Commit Graph

2255 Commits

Author SHA1 Message Date
Bernhard Redl 76d8e11703 +toggle option in message view to change message display theme (dark,light) permanently (Issue 1674) 2012-09-14 03:16:36 +02:00
cketti 2ee3378eef Use executeSimpleCommand() for UID COPY so the response type is checked
The previous code never failed e.g. on a "NO" response. That lead to
messages being deleted for a move action.
2012-09-14 02:08:39 +02:00
cketti 93be25bf37 Make sure ActivityListener.getOperation() never returns null 2012-09-14 01:28:52 +02:00
cketti 0878de5936 Go back to the old behavior for batch mark as (un)read, (un)flag
If there is at least one unread message among the selected messages the
action is "mark as read". Otherwise, "mark as unread".
If there is at least one unstarred message among the selected messages
the action is "add star". Otherwise, "remove star".
2012-09-14 00:34:25 +02:00
cketti 95c748c183 Removed hack that is no longer necessary after fixing the activity stack 2012-09-13 23:22:14 +02:00
Andrew Chen 1ef930090e IMAP Search: log exceptions on remote search, properly dispatch MessageList changes. 2012-09-13 09:10:39 -07:00
ashley willis df75a9fbfa modified loadMessageForView() to dowload message if neither X_DOWNLOADED_FULL nor X_DOWNLOADED_PARTIAL. 2012-09-13 09:10:38 -07:00
Rob Bayer fdb1267cb1 Add remote IMAP search support.
* rbayer/IMAPsearch: (21 commits)
  More cleanup
  Code Cleanup getRemoteSearchFullText -> isRemoteSearchFullText line wraps for preference items
  Refactor to allow fetching of extra search results beyond original request.  Most code moved out of ImapStore and ImapFolder and into MessagingController.searchRemoteMessagesSynchronous.  Should make it easier to add remoteSearch for other server types.
  Prevent delete of search results while search results open
  remove duplicated code block
  Don't hide Crypto when IMAPsearch disabled
  Code Style Cleanup: Tabs -> 4 spaces Remove trailing whitespace from blank lines
  tabs -> spaces (my bad...)
  Fix opening of folders to be Read-Write when necessary, even if they were previously opened Read-Only.
  add missing file
  Working IMAP search, with passable UI.
  UI improvements
  Simple help info when enabling Remote Search
  Dependency for preferences
  Basic IMAP search working
2012-09-13 09:10:37 -07:00
Jesse Vincent 3a68360e30 remove lots of duplicate menu ui, particularly cutting down on context menu stuff. 2012-09-12 23:30:27 -07:00
Jesse Vincent 5d4a2132d8 Remove "mark all as read" from the UI. (leaving the backend support for now)
User-facing "select all, mark as read" is slightly different but less confusing and cluttered than the duplicated option
2012-09-12 23:30:27 -07:00
cketti 5a29c8a415 Get rid of incomplete code to toggle a message's selection state 2012-09-13 06:46:32 +02:00
cketti 997943a521 Update action mode title when necessary 2012-09-13 06:46:32 +02:00
cketti d9fad383eb Added "select all" to action mode menu 2012-09-13 06:46:32 +02:00
Andrew Chen ea04339ca6 Add Android-PullToRefresh to about screen. 2012-09-12 21:31:26 -07:00
Jesse Vincent 3799ecfb21 Check message uids first when comparing messages. message uids are less likely to be the same than folders, so it's a slight optimization 2012-09-12 21:56:17 -05:00
Jesse Vincent 1b7af9270e Make the message item popup menu work 2012-09-12 20:58:44 -04:00
Jesse Vincent 7b40e5b14a remove single message items from the Action bar 2012-09-12 20:47:24 -04:00
Jesse Vincent d876a16893 Add a helper helper so we can get click events on message list menu items 2012-09-12 20:44:57 -04:00
Jesse Vincent 593569f4ad Bullet-proof an NPE I ran into on a 2.2 test emulator while on an airplane 2012-09-12 18:54:06 -04:00
cketti 2a05bc0caa Use ActionBarSherlock's MenuBuilder for the "more" menu 2012-09-12 18:26:51 -04:00
Andrew Chen c574088f57 Add basic pull to refresh support to MessageList. 2012-09-12 01:59:55 -07:00
Jesse Vincent 4eff1a25e9 Temporarily disable our messagelist item backgrounds so we can see list item selection.
They'll return as a preference
2012-09-12 00:54:20 -04:00
Jesse Vincent ff52affed9 Make the menu button trigger the existing single-select action mode (until we can make the proper context menu go.) 2012-09-12 00:52:39 -04:00
Jesse Vincent b5d887728a Cleanups to our MessageList item select/deselect code.
Fixes bugs where the action mode wouldn't trigger if the first item was checked with the checkbox
2012-09-11 18:47:32 -04:00
cketti 3060fd063e Don't display "0" in the action bar if there are no unread messages 2012-09-11 04:38:03 +02:00
cketti ac8d1aa162 Cleanup 2012-09-11 04:33:20 +02:00
Jesse Vincent cd98875729 remove our swipe to select/deselect code now that we have long-press to select and check box to select 2012-09-10 18:32:24 -04:00
Jesse Vincent d5f739030a Always save all headers. Not doing so is kind of a crazy space microoptimization and can get a little messy 2012-09-10 12:07:35 -04:00
cketti 20a608e1a0 Removed "Manage back button" setting 2012-09-10 17:54:27 +02:00
Jesse Vincent 8d928d20fa get rid of the non-touchable version of the message list items. (The real difference was the capability to show previews) 2012-09-10 11:52:00 -04:00
cketti f9630a3826 Don't display "up" arrow in action bar of Accounts activity 2012-09-10 17:24:35 +02:00
cketti d8e9c48177 Changed the way we use the activity stack
- removed launchMode attributes for all activities
- only use one activity task
- got rid of "managed back button" behavior
2012-09-10 17:24:34 +02:00
Jesse Vincent 8daea241af Cache the read and unread color chip variants per account. 2012-09-10 11:11:40 -04:00
Jesse Vincent 86c9aab7a8 default touchable views and checkboxes to on 2012-09-10 11:06:45 -04:00
Jesse Vincent c9897a5c84 Indicate read state in chips 2012-09-10 11:01:51 -04:00
cketti 185d6b8538 Changed scrollbar style in message list 2012-09-10 16:48:54 +02:00
cketti 0b977c9e9b Tweaked background colors for (un)read messages in the message list 2012-09-10 16:48:54 +02:00
Jesse Vincent 78cf804aca first pass of converting chips to colored circles 2012-09-10 10:40:20 -04:00
Jesse Vincent 46edd8f793 Revert "Context actionbar for the account screen."
We're not ready for this sort of living in the futre yet.

This reverts commit 0f51eb54c1.

Conflicts:
	res/drawable-hdpi/ic_action_settings_light.png
	res/drawable-ldpi/ic_action_settings_light.png
	res/drawable-mdpi/ic_action_settings_light.png
	res/drawable-xhdpi/ic_action_settings_light.png
	res/menu/accounts_context.xml
	res/values/strings.xml
	src/com/fsck/k9/activity/Accounts.java
2012-09-10 07:56:35 -04:00
Jesse Vincent 297e859b90 Revert "Add context action bar on FolderList activity." - We are not ready for this
sort of future yet ;)

This reverts commit a5b8ce8064.

Conflicts:
	res/drawable-hdpi/ic_action_read_light.png
	res/drawable-ldpi/ic_action_read_light.png
	res/drawable-mdpi/ic_action_read_light.png
	res/drawable-xhdpi/ic_action_read_light.png
	res/menu/folder_context.xml
2012-09-10 07:41:37 -04:00
ashley willis 7d4152fdd4 re Bernhard's Issue 4543 fix: only set as read if account.isMarkMessageAsReadOnView() 2012-09-09 21:15:37 -05:00
Bernhard Redl 7c9b42091a Fixes 4517: Junk special folder not autoconfigured (rfc6154 implementation was incomplete) 2012-09-09 21:11:08 -05:00
Bernhard Redl ee0e558f4d Fixed Issue 4543: Msg UnRead after "Download Complete" pressed 2012-09-09 21:11:08 -05:00
Bernhard Redl 611cf2e192 fixed download complete message button 2012-09-09 21:11:08 -05:00
Andrew Chen 891dde2baf Set (un)read toggle title based on current message state. 2012-09-09 15:11:54 -07:00
Andrew Chen e4d2830ec7 Rename some one-letter variables. 2012-09-09 15:11:13 -07:00
Andrew Chen 3e261568ae Fix whitespace; no functional changes. 2012-09-09 14:46:34 -07:00
Andrew Chen 38c4f24111 Move message selection functionality into the MessageAdapter. 2012-09-09 14:09:35 -07:00
Jesse Vincent 3ef22ca094 When we're at the end of the message list, dim the next or prev button instead of making it vanish 2012-09-09 13:45:35 -07:00
Jesse Vincent 20e3335bc1 Remove "flag" as a meessage view menu option (duplicates tapping on the star) 2012-09-09 13:45:34 -07:00
Jesse Vincent 87e437b388 Move "move" and "copy" out of a submenu 2012-09-09 13:45:33 -07:00
Andrew Chen 9fbb2b4836 Show the subject line in the MessageHeader if the ActionBar title was truncated. 2012-09-09 13:45:33 -07:00
Andrew Chen 31461bc657 Set abs title to (no subject) if the message has no subject. 2012-09-09 13:45:31 -07:00
Andrew Chen ed693fc01a Hide the unread message count in the actionbar when doing an explicit search. 2012-09-09 13:45:30 -07:00
Andrew Chen 4a416f7acd Hide subject line in MessageView since it's now displayed in the actionbar.
Now that the subject line is gone, the right side of the header is now the tallest part of the header.
Put date and time on the same line to keep the header compact.
2012-09-09 13:41:49 -07:00
Sander Bogaert cbfe353378 Remove fading edges. 2012-09-09 13:39:12 -07:00
Sander Bogaert a5b8ce8064 Add context action bar on FolderList activity. 2012-09-09 13:39:11 -07:00
Sander Bogaert c0e483d2b9 Have a dynamic subtitle for the MessageList action bar too. 2012-09-09 13:39:10 -07:00
Sander Bogaert 1036fe531d Split folder action bar and use the same top view as we use for Accounts and MessageList. 2012-09-09 13:37:15 -07:00
Sander Bogaert 277669711c Correctly close the context action mode when deleting an account. 2012-09-09 13:37:14 -07:00
Sander Bogaert 416ac8b646 Formatting of Accounts.java 2012-09-09 13:37:14 -07:00
Sander Bogaert 0f51eb54c1 Context actionbar for the account screen. 2012-09-09 13:37:13 -07:00
Sander Bogaert ed03f19ea5 Accounts actionbar split. Now contains unread number for consistency and shows status as subtitle if available. Allowed separate method to get the current operation in ActivityListener. 2012-09-09 13:37:12 -07:00
Sander Bogaert bc9bc29097 Show unread count on special accounts too. 2012-09-09 13:37:11 -07:00
cketti 1cdb1c4fc5 Changed look of action bar in MessageList
* (Temporarily) removed spinner because it wasn't doing anything useful
* Created custom view that also displays the unread count
2012-09-09 13:24:27 -07:00
cketti cec2f4cdee Use "display name" of folder in action bar 2012-09-09 13:21:15 -07:00
cketti 9301e94e73 Show as much of the folder name as possible in the navigation spinner 2012-09-09 13:18:10 -07:00
cketti 2b49338112 Removed trailing spaces (no functional changes) 2012-09-09 13:16:07 -07:00
Sander Bogaert 24d5d3208a Use SupportProgressBar methods. 2012-09-09 13:13:44 -07:00
Sander Bogaert 13dc96eca9 Have the cc/bbc and attachment action on top with nice icons. 2012-09-09 13:13:43 -07:00
Sander Bogaert 29b6d046d3 Separate the welcome message in it's own activity. Cleaner solution and it prevents it from having the same actionbar as the Accounts activity. 2012-09-09 13:13:42 -07:00
Sander Bogaert e172e398ce Add ActionBarSherlock to the used libraries in the about dialog. 2012-09-09 13:13:41 -07:00
Sander Bogaert c31c8923c2 Add an actionbar to the MessageView activity. 2012-09-09 13:13:40 -07:00
Sander Bogaert 592aeb0b03 Add forward, reply, reply all, same sender back in the MessageList context actionbar. 2012-09-09 13:13:39 -07:00
Sander Bogaert 10c733606e Disable actionbar home button on Accounts activity and removed indeterminate progress window feature from it. 2012-09-09 13:13:38 -07:00
Sander Bogaert f530af7f8b Make the icon up navigation work in messagelist when displaying a query, tapping it takes you back to the account screen. 2012-09-09 13:13:38 -07:00
Sander Bogaert 6daa8a3c0c Add refresh to actionbar for Accounts activity. 2012-09-08 22:26:31 -07:00
Sander Bogaert 65505c8145 Remove customview from top bar and make bottom refresh function in MessageList. 2012-09-08 22:26:30 -07:00
Sander Bogaert b2289783a4 Make inbox item in navigation list more general. 2012-09-08 22:23:39 -07:00
Sander Bogaert 9c9763154e Abbriviate long foldernames. 2012-09-08 22:23:38 -07:00
Sander Bogaert 9f568e3e08 Hide move & copy options for mixed messagelists. Also use hide and show the new grouped icon for them correctly. 2012-09-08 22:21:13 -07:00
Sander Bogaert 85fc76c10b Have the icon function as 'up' instead of 'home'. 2012-09-08 22:21:10 -07:00
Sander Bogaert 4a7a61bd08 Made the selectAll working again. This also got rid of the 2 settings options in the actionbar. 2012-09-08 22:21:06 -07:00
cketti c7003ab028 Cleaned up ActionBarNavigationSpinner 2012-09-08 22:21:05 -07:00
cketti f46f733bce Moved ActionBarNavigationSpinner to another package 2012-09-08 22:21:05 -07:00
cketti 933a8fdcd5 Made actionbar_selected a format string 2012-09-08 22:21:04 -07:00
cketti 763e2853d7 Whitespace fixes 2012-09-08 22:19:56 -07:00
Sander Bogaert 33cae2fdab Fixed actionbar context mode bug when rotating the screen. 2012-09-08 22:16:03 -07:00
Sander Bogaert f11e3d5059 Have a nice title for messagelist displaying a query. 2012-09-08 22:16:03 -07:00
Sander Bogaert a730e67514 Have a dynamic context actionbar filled with options that are supported by the current selection of mails. Also works for unified inbox. 2012-09-08 22:13:07 -07:00
Sander Bogaert 35e8937b8a Remove send alternate option from messagelist activity. 2012-09-08 22:13:06 -07:00
Sander Bogaert 24d7416e61 Implemented the (Un)start and (Un)read toggles. 2012-09-08 22:13:06 -07:00
Sander Bogaert 6bea2dddac Major cleanup of the MessageList activity and layout. Removed dead code. 2012-09-08 22:10:21 -07:00
Sander Bogaert 876bd52e8d Exiting context mode after batch actions. 2012-09-08 22:07:18 -07:00
Sander Bogaert e01232a500 Selection with context actionbar working. 2012-09-08 22:05:41 -07:00
cketti f8bd9e481c Converted MessageList to a K9ListActivity 2012-09-08 21:47:52 -07:00
Sander Bogaert 830442b690 Show email subject in actionbar. 2012-09-08 21:43:09 -07:00
Sander Bogaert ee6bd2dc22 Pressing the actionbar icon will take you back to the accountsscreen. 2012-09-08 21:43:08 -07:00
Sander Bogaert 67b4cd9c8e Add unread count to MessageList title 2012-09-08 21:43:08 -07:00
Sander Bogaert b90386ecd3 Fix progressindicator on folderscreen. 2012-09-08 21:40:57 -07:00
Sander Bogaert 6c27d3e7ef Fix the upper refresh button in MessageList 2012-09-08 21:40:56 -07:00
Sander Bogaert 1b9abb2b9b Set a title for the folderlist activity. 2012-09-08 21:39:44 -07:00
Sander Bogaert 67ab08383f Created new string resource for folderacitvity title. 2012-09-08 21:39:43 -07:00
Sander Bogaert 18748499af Generalize ActionBarNavigationSpinner creation. 2012-09-08 21:39:42 -07:00
Sander Bogaert 4de06915ea Make title changeable. Have email adress and foldername in there. 2012-09-08 21:36:47 -07:00
Sander Bogaert c19367eb18 Fix swap back bug. 2012-09-08 21:34:34 -07:00
Sander Bogaert 03cec1ef56 Separated the navigationspinner and the messagelist class. 2012-09-08 21:34:33 -07:00
Sander Bogaert c2af640891 Messagelist special cases bug fix. 2012-09-08 21:32:54 -07:00
Sander Bogaert 2ec97235ec Split bar on Messagelist activity and some code styling. 2012-09-08 21:32:54 -07:00
Sander Bogaert 4293914855 Initial actionbar integration. On top of every activity, no real integration yet. 2012-09-08 21:14:55 -07:00
cketti 3253466f14 More magic to work around BinaryTempFileBodyInputStream 2012-09-09 01:15:26 +02:00
cketti 734e0d1920 Merge branch 'MessageListAdapter_cleanup' 2012-09-09 00:55:18 +02:00
Andrew Chen 2ef8cda13c Remove the try-finally stream close. Add comment as to why this pattern doesn't work here. 2012-09-07 23:49:24 -07:00
Andrew Chen c44b19cda6 Close input stream after reading to fix strict mode warning. 2012-09-07 20:34:40 -07:00
Andrew Chen 2b0b929aa2 Add references and in-reply-to for forwarded messages. 2012-09-07 11:03:46 -07:00
Andrew Chen 3f4bc28363 Add null check before attempting to do math on the date. 2012-09-06 16:38:45 -07:00
cketti f42943f30c Optimized searching for a message in the message list 2012-09-06 22:33:22 +02:00
cketti 5678786c97 Properly closing InputStreams to avoid StrictMode warnings 2012-09-05 05:57:52 +02:00
cketti 9c335127e2 Code cleanup 2012-09-05 03:50:02 +02:00
cketti 16ab1b67bc Made sure the message list is only modified from the UI thread 2012-09-05 03:02:22 +02:00
cketti d97da517fa Rewrote code accessing mAdapter.messages from outside MessageListAdapter 2012-09-05 01:31:09 +02:00
cketti fb6d004692 Don't use MessageListHandler when calling from the UI thread 2012-09-05 01:02:05 +02:00
cketti bd9b6aea2d Moved methods modifying the message list to MessageListAdapter 2012-09-05 00:51:04 +02:00
cketti 75a97a82c0 Make MessageListHandler a real Handler that uses Android's message queue 2012-09-05 00:35:43 +02:00
Andrew Chen 536046809d Merge pull request #170 from roee88/master
Issue 4461: MessageProvider enhancements and fixes
2012-09-03 12:47:45 -07:00
Roee Shlomo f6e30a0642 Removed unreachable searchStats overrides
Removed unreachable searchStats overrides.
Replaced with folderStatusChanged in MessageProvider.

Further review confirmed searchStats is only called for listeners passed
directly to MessagingController.searchLocalMessages* and never called
for any
MessagingController registered listener.
folderStatusChanged  is more appropriate for this purpose.
2012-08-31 04:35:56 +03:00
Bernhard Redl 474f32ad02 changed parseFlags to directly manimpulate member 2012-08-30 18:15:19 +02:00
Bernhard Redl 7c007d19fb added improvements suggested by achen 2012-08-30 17:47:58 +02:00
Bernhard Redl 56105bcfe3 + add support for $Forwarded IMAP flag 2012-08-29 02:26:38 +02:00
cketti c0153a1636 Display decrypted/verified messages like text/plain messages
Nicely format the text instead of wrapping it in <pre> tags.
2012-08-27 17:38:10 +02:00
Roee Shlomo a4b8bbdb72 Removed trailing spaces 2012-08-18 20:52:32 +03:00
Roee Shlomo ef082f0260 Fixed indentation 2012-08-17 17:29:35 +03:00
Roee Shlomo 7419259407 Allow more fields in the external provider 2012-08-17 17:19:26 +03:00
Roee Shlomo a4d1f78dbd Fixed ACTION_REFRESH_OBSERVER broadcast sending
searchStats seems unreachable so broadcast is now sent from
folderStatusChanged and also contains the account and folder name as
extra parameters.
2012-08-17 17:18:00 +03:00
Andrew Chen a274a3717a Merge pull request #168 from aatdark/aatdark_mime4j072
upgraded Mime4J from 0.7-SNAPSHOT to 0.7.2.  Fixes MimeMultipart parser bug (Issue 4455).
2012-08-15 15:34:25 -07:00
cketti 66911a0624 Use grey background for read messages in the message list 2012-08-15 04:14:12 +02:00
Bernhard Redl 89f6c2f6d0 upgraded Mime4J 0.7-SNAPSHOT -> 0.7.2 (fixes MimeMultipart parser bug) 2012-08-15 01:47:57 +02:00
cketti 2e454f0af7 Removed "System zoom controls" setting
We always allow zooming but hide (provided the Android version supports
it) the on-screen zoom controls if the device supports multi-touch,
hence pinch-to-zoom.
2012-08-15 00:21:22 +02:00
cketti d9f1690741 Added option to always show the CC/BCC text input fields 2012-08-10 03:38:10 +02:00
cketti 1ff3b6b88f Disable the 'Add Cc/Bcc' menu option when both fields are visible 2012-08-10 02:31:55 +02:00
Andrew Chen 6f8c60763d Use Calendar to get current year when formatting copyright. 2012-08-08 11:03:10 -07:00
Andrew Chen 4f122ca094 Merge pull request #160 from dzan/fix_messagelist_whitespace
No more white space at the right hand side of the MessageList
2012-08-06 16:53:55 -07:00
Sander Bogaert ee283c0c77 Give star a bit more room so there is no cut-off. Don't force the scrollbar on the outside so the listitems can take the whole width. 2012-08-03 12:18:12 -04:00
Jesse Vincent 74f04e75e3 A first spike of integrating http://code.google.com/p/android-titlebar-webview
on my nexus 7, the webview and titlebar are overlapping each other, still
2012-08-02 16:49:21 -07:00
Jesse Vincent 17a6f79365 Better solution coming up!
Revert "Added fallback for when WebView.setEmbeddedTitleBar() is not available"

This reverts commit 6073b9d3fa.
2012-08-02 16:11:10 -07:00
cketti 592ed3ef38 Upgrade from "keyguardPrivacy" to "notificationHideSubject"
Make sure existing installations aren't reset to the default value when
the new setting can't be found.
2012-08-02 03:09:26 +02:00
cketti 3e6d161c18 Show current value for the 'notification_hide_subject' ListPreference 2012-08-02 02:43:10 +02:00
cketti 8c11ec18a9 Code style/documentation cleanup (no functional changes) 2012-08-02 02:31:54 +02:00
cketti cd37ae16e1 Fixed setting names in SettingsUpgrader for version 12 2012-08-02 02:20:33 +02:00
Bernhard Redl 4028505d69 Extended setting to hide subject in notification area (never, when locked, always)
Fixed issue 2595
2012-08-02 01:47:20 +02:00