35f19abc9f
Improve the "Do what I mean" nature of "Empty trash" - it now syncs the
...
trash folder after deletions to clear out local records of deleted
messages and does a compact operation on the local store.
2010-12-01 06:04:22 +00:00
75ec749ed4
Remove an unused "context" from a private function
2010-12-01 06:04:16 +00:00
02acea3bbf
replying to a message you sent shouldn't end up sending mail only to you
2010-12-01 06:04:12 +00:00
1898ceee71
Remove two retundant variables
2010-12-01 03:08:36 +00:00
f4a54b9ecb
fix a numeric equality bug spotted by intellij
2010-12-01 03:08:09 +00:00
78c900b5fe
remove redundant ;s
2010-12-01 03:07:28 +00:00
75aa644a23
Remove a bunch of stringification inside of string appends (per intellij)
2010-12-01 03:06:50 +00:00
0677bd9e77
Get rid of some redundant casts (Per IntelliJ)
2010-12-01 03:06:12 +00:00
fde438fbfb
Get rid of some unnecessary stringification (Per IntelliJ)
2010-12-01 03:05:40 +00:00
cead5c7060
flip some loops to using java internals instead (per intellij)
2010-12-01 03:04:57 +00:00
5485d0faf1
switch over some for loops to enhanced for loop syntax per intellij
2010-12-01 03:04:07 +00:00
58e6bd388b
finalize some declarations per IntelliJ
2010-12-01 03:03:22 +00:00
c79ea226a5
Remove "throws" declarations that didn't actually get thrown. Remove a
...
couple of try blocks that only caught throws we didn't throw. IntelliJ
optimization.
2010-12-01 03:02:13 +00:00
81f12f0e05
clean up a couple null checks
2010-12-01 03:01:20 +00:00
43d9c0a6d4
Eliminate some redundant assignments
2010-12-01 03:00:36 +00:00
2ecdc22111
simplify static final methods to just be static. (IntelliJ inspection)
2010-12-01 02:59:50 +00:00
1ce9021ecd
Fix pinch-to-zoom. Patch by achen.code. Fixes isue 2720
2010-11-30 01:42:00 +00:00
174a62536e
Resolves Issue 2719: Message List Previews: Read message senders are shown in bold patch from achen.code
2010-11-30 01:04:24 +00:00
f98a2db2ab
stop fading the chip if a message is read. we already change text
...
weight
2010-11-29 03:24:57 +00:00
dbc07d14ee
Revert " http://code.google.com/p/k9mail/issues/detail?id=2682 " until we
...
can make it configurable, per discussion with Marcus
This reverts commit 1436eeefa292f64c8c9aa6ec9fa2daaeafeb93fd.
2010-11-29 02:21:27 +00:00
15bf83bbe4
preliminary implementation of 'quiet time'
2010-11-29 02:21:16 +00:00
fb6dfb3bde
removed a commented-out method to show notifications on changes to
...
system connectivity
2010-11-28 21:48:29 +00:00
2b8f7c0bbc
unify all our beeping, buzzing and flashing codepaths
2010-11-28 21:48:25 +00:00
70922989d3
genericize configureNotification in preparation for code reuse
2010-11-28 21:48:21 +00:00
64667d03dc
extract vibration pattern metadata out ouf MessagingController into
...
notificationsetting
2010-11-28 20:29:14 +00:00
b7f52a834f
isVibrate -> shouldVibrate to match shouldRing
2010-11-28 20:29:09 +00:00
28c126b8a5
extract notification code from actual "action" code
2010-11-28 20:29:05 +00:00
99d5704b82
extract "sending messages" notification into methods
2010-11-28 20:29:02 +00:00
9784d0e943
remove 100loc by replacing a pattern with a method.
2010-11-28 20:28:58 +00:00
fa64f4c3a8
Minor refactoring for readability
2010-11-28 20:28:53 +00:00
b7617a3497
extract "determine what to do with a new message" out of
...
downloadMessages Probably wants a better name
2010-11-28 20:28:50 +00:00
3404edca28
extract the "synchronize one folder" method
2010-11-28 20:28:46 +00:00
36bb10fb2c
extract out "sync one account"
2010-11-28 20:28:42 +00:00
4f376e8332
astyle
2010-11-28 20:28:37 +00:00
a75098013a
add a new quiet time preference
2010-11-28 20:28:32 +00:00
d3c86a39dd
initial import of a timepicker preference widget
2010-11-28 20:28:19 +00:00
621f87fcbc
Revert "refactor getHeaders and removeHeaders to use a common method and an"
...
Subtly flawed. Returned the wrong headers
This reverts commit 657b3961f86b1b694fb7587216ecefeb0b20f5d2.
2010-11-27 04:03:15 +00:00
75108f4078
move toMe and ccMe into LocalMessage from MessageInfoHolder
2010-11-27 04:03:10 +00:00
580f47998d
Remove subject from messageinfoholder
2010-11-27 04:03:06 +00:00
60a538e071
Remove "preview" form messageinfoholder
2010-11-27 04:03:02 +00:00
f9981dcf7c
lift hasAttachments to LocalMessage
2010-11-27 04:02:56 +00:00
1149f2d916
refactor getHeaders and removeHeaders to use a common method and an
...
iterator to address a Market FC:
java.util.ConcurrentModificationException
at java.util.ArrayList$ArrayListIterator.next(ArrayList.java:573)
at com.fsck.k9.mail.internet.MimeHeader.getHeader(MimeHeader.java:87)
at
com.fsck.k9.mail.internet.MimeHeader.getFirstHeader(MimeHeader.java:51)
at
com.fsck.k9.mail.internet.MimeMessage.getFirstHeader(MimeMessage.java:437)
at
com.fsck.k9.mail.internet.MimeMessage.getContentType(MimeMessage.java:130)
at
com.fsck.k9.mail.internet.MimeMessage.getMimeType(MimeMessage.java:159)
at
com.fsck.k9.mail.internet.MimeUtility.findFirstPartByMimeType(MimeUtility.java:971)
at com.fsck.k9.crypto.Apg.isEncrypted(Apg.java:464)
at
com.fsck.k9.activity.MessageView.updateDecryptLayout(MessageView.java:2702)
at
com.fsck.k9.activity.MessageView$Listener$6.run(MessageView.java:2466)
at android.os.Handler.handleCallback(Handler.java:587)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:144)
at android.app.ActivityThread.main(ActivityThread.java:4937)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:521)
at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626)
2010-11-26 03:53:15 +00:00
23254e8998
BatchButton area toggling should't happen from anything other than the
...
UiThread:
Fixes a common error from the market:
android.view.ViewRoot$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
at android.view.ViewRoot.checkThread(ViewRoot.java:2802)
at android.view.ViewRoot.invalidateChild(ViewRoot.java:607)
at android.view.ViewRoot.invalidateChildInParent(ViewRoot.java:633)
at android.view.ViewGroup.invalidateChild(ViewGroup.java:2505)
at android.view.View.invalidate(View.java:5139)
at android.view.View.setFlags(View.java:4502)
at android.view.View.setVisibility(View.java:3030)
at
com.fsck.k9.activity.MessageList.hideBatchButtons(MessageList.java:2883)
at
com.fsck.k9.activity.MessageList.toggleBatchButtons(MessageList.java:2906)
at com.fsck.k9.activity.MessageList.access$500(MessageList.java:77)
at
com.fsck.k9.activity.MessageList$MessageListAdapter.pruneDirtyMessages(MessageList.java:2302)
at com.fsck.k9.activity.MessageList$1.run(MessageList.java:811)
2010-11-26 03:53:10 +00:00
4f08820683
http://code.google.com/p/k9mail/issues/detail?id=2682
...
mark multiple mails as SPAM
2010-11-22 08:12:48 +00:00
0206ebf809
Fixed issue 2680
...
Should not set empty string in auto-expand folder list.
2010-11-21 13:25:21 +00:00
5d33bc044b
when a message is seen _decrement_ the unread count, don't increment it
2010-11-21 05:31:42 +00:00
14152a8585
Don't compare whether we're setting the delete flag with whether the
...
message is seen or not. (logic error)
2010-11-21 05:31:38 +00:00
0e5b5de409
update our counts on destroy before actually destroying the message, so
...
we have something to call isSet on
2010-11-21 05:31:34 +00:00
43cef54ad6
We don't cache positive DNS lokups. We shouldn't cache negative DNS lookups either
2010-11-21 02:10:59 +00:00
389502da55
Fixed account shortcuts
...
- Fixed NullPointerException
- Removed unnecessary stuff (originally copied from Accounts activity)
2010-11-18 09:09:57 +00:00
0560dc28d9
Don't use the application context to start the Accounts activity (because then we'd have to create a new task)
...
Fixes issue 2653
2010-11-18 09:08:40 +00:00
a67a2022d3
Added method name logging on transaction logging, when debug is enabled
2010-11-17 21:11:07 +00:00
dc16657480
Made LocalStore.destroy() transactional
2010-11-17 21:10:45 +00:00
46300ac421
Move our "pick a folder" preferences out of the account setup wizard,
...
where you're unlikely to even have access to them the first time you
walk through into the "Folders" preferences.
At the same time, move toward using a list preference widget, rather
than a custom activity.
2010-11-17 03:43:02 +00:00
b6ccba9c7d
When getting a list of folders out of the database, ask for it in
...
asciibetical order, rather than random order
2010-11-17 03:42:14 +00:00
7291486ca0
No longer delete the Outbox every time it's empty - it makes it somewhat
...
more difficult to work with. If we want to hide it when it's empty,
that's fine. but it's not necessary to delete it.
2010-11-17 03:41:37 +00:00
80e4de6db4
fix a deleted message count logic error
2010-11-15 01:31:20 +00:00
4f4fe87d5f
Minor refactoring of flag setting code
2010-11-15 01:31:16 +00:00
36714d3b4a
astyle
2010-11-15 01:31:11 +00:00
f9d828a62c
Improved some comments
2010-11-14 23:21:48 +00:00
58ca9fe740
Changed external intent (e.g. Intent.ACTION_SEND_TO) handling code in MessageCompose
...
- extracted handling of external intents to a new method
- only allow mailto URI for ACTION_VIEW and ACTION_SENDTO (as documented by AOSP)
- allow additional recipients via "to" parameter in mailto URI
- removed check for allowed MIME type when adding attachments since we're accepting all MIME types anyway
- show CC and BCC text fields when one of those recipient types was set by the intent
- use MIME type specified in intent for attachments (if present and doesn't contain a "*")
2010-11-14 02:27:42 +00:00
675651286b
Added the ability to completely wipe the localy cached messages of a syncced folder.
2010-11-14 00:49:25 +00:00
32ea04a5b3
kill a temporary variable
2010-11-14 00:49:21 +00:00
6a6c86d117
Kill a once-used temporary variable
2010-11-14 00:49:18 +00:00
945d4d7c32
a slight cleanup for message deletioon policy logic.
2010-11-14 00:49:15 +00:00
0eee80f08b
renamed deleteMessagesOlderThan to clearMessagesOlderThan to better
...
reflect that it just nukes local copies rather than the synced copies
2010-11-14 00:49:08 +00:00
7d40596aa1
split apart "delete messages older than" for later reuse
2010-11-14 00:49:04 +00:00
14055691a3
Merge branch 'mail-on-sd'
...
* mail-on-sd: (40 commits)
Added more comments to explain how the locking mecanism works for LocalStore
Fixed wrong method being called during experimental provider initialization (since provider isn't enabled, that didn't harm)
Add more comments about how the various StorageProviders work and how they're enabled
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
French localization for storage related settings
Remove unused SD card strings (replaced with storage indirection)
Merge mail-on-sd branch from trunk
Reset mail service on storage mount (even if no account uses the storage, to be improved)
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
Migraion -> Migration
move the Storage location preference into preferences rather than the wizard.
Made LocalStore log less verbose Added @Override compile checks
Added ACTION_SHUTDOWN broadcast receiver to properly initiate shutdown sequence (not yet implemented) and cancel any scheduled Intent
Be more consistent about which SQLiteDatabase variable is used (from instance variable to argument variable) to make code more refactoring-friendly (class is already big, code extraction should be easier if not referencing the instance variable).
Added transaction timing logging
Factorised storage lock/transaction handling code for regular operations.
Use DB transactions to batch modifications (makes code more robust / could improve performances)
Merge mail-on-sd branch from trunk
Update issue 888 Added DB close on unmount / DB open on mount
Update issue 888 Back to account list when underlying storage not available/unmounting in MessageView / MessageList
...
2010-11-13 21:40:56 +00:00
76e26607b8
Added a first pass implementation of being able to resend a message.
2010-11-13 03:09:32 +00:00
3779237eb8
remove a special flag in FolderInfoHolder that we only use twice and
...
appear to initialize unreliably in favor of some simple checks.
2010-11-13 03:09:27 +00:00
27d3e6312b
Refactor FolderInfoHolder to remove copy-paste code
2010-11-13 03:09:23 +00:00
a8de2d0000
astyle
2010-11-13 01:47:08 +00:00
a551dc8dff
Replace the old "record a message in K9 Errors and give up"
...
failed-message scheme with an actual android notification that opens the
outbox
2010-11-13 01:47:02 +00:00
e964c7ba84
Tell the user about a failed delivery the first (any) time it fails
2010-11-13 01:46:59 +00:00
4fb338d8a9
Disable "don't send messages in the outbox if they're flagged" - users
...
really don't like their mail just getting stuck
2010-11-13 01:46:55 +00:00
ecf793ea26
remove an unused constant
2010-11-13 01:46:46 +00:00
24b018a812
replace a trivial one-line method that was called twice with its body
2010-11-13 01:46:41 +00:00
f874f0f9d3
replace a single-use single-line private method with its body in the one place it was used
2010-11-13 01:46:36 +00:00
0f4366aa77
in the account list, when trying to check mail, also try to send mail
2010-11-13 01:46:31 +00:00
af5f78928c
Add a "fetch all messages" visible limit
2010-11-12 23:41:43 +00:00
a130f56bf4
when changing an account's visible limits, try to reset folder visible
...
limits as soon as we save the setting
2010-11-12 23:41:38 +00:00
9f695eb4ed
extract the per-account "reset visible limits" method
2010-11-12 23:41:33 +00:00
478bd876ee
There's no reason the getSubject accessor should throw a
...
MessagingException on LocalMessage
2010-11-12 22:27:32 +00:00
b2e5d7afc5
extract our our folder-count updating code from the flag setting code
2010-11-12 21:38:11 +00:00
eb908b67a3
try to clean up our message count update logic in flagging
2010-11-12 21:38:06 +00:00
2d8a8998b0
factor out a "destroy" method for local messages
2010-11-12 21:38:02 +00:00
1292a10ac2
When a message has been deleted on the server and we want to sync remote
...
deletions, we don't care whether it was flagged as deleted ocally - we definitely
want to destroy it.
2010-11-12 21:37:58 +00:00
33fd42e766
If we DELETE a message from the database, don't then try to UPDATE it
2010-11-12 21:37:54 +00:00
52e2a437fb
Imported a variant of http://code.google.com/p/android-color-picker/ into k-9
...
- Ported to the ColorPickerDialog API
- Translated the API and Internals from Indonesian to English
- Moved to use K-9 strings rather than custom strings.
In an ideal world, we should use ambilwarna as an android library
project, like it was intended.
2010-11-08 02:21:32 +00:00
d45081abaa
Animate the batch-operations toolbar (Imported from AOSP)
2010-11-07 19:40:42 +00:00
6528b2d775
lift up font setting code to be with the rest of the initial messagelist item setting code
2010-11-07 00:30:17 +00:00
69675bc935
Now that we can show bigger previews, actually generate a bigger preview
2010-11-05 04:23:09 +00:00
a78776a9ee
Only look at the first 8k of a message when calculating message previews
2010-11-05 04:23:04 +00:00
bfc24a58a0
Improvements to message preview heuristics
2010-11-05 03:55:24 +00:00
9d69875246
Add a new preference to let users select how many lines of message
...
preview show in message-preview mode.
2010-11-05 02:59:26 +00:00
d0e85ce43a
astyle
2010-11-05 02:59:21 +00:00
602099cfd3
Be more careful about deleting messages from the MessageListAdapter -
...
don't do it from something that's not the UI thread
2010-11-05 01:16:35 +00:00
4aba667a4e
fix for "http:/"-links in plaintext -emails. (add http:// is a link has no schema)
2010-11-04 13:35:39 +00:00
5b88a99de0
Got rid of some compiler warnings.
2010-11-04 03:11:34 +00:00
fb55aa5bfb
Fix an extra paren
2010-11-03 00:48:18 +00:00
b9999878df
We care about eclair MR1, not eclair
2010-11-03 00:44:07 +00:00
9c7e3bcc26
Guard against null content from html parts on reply/forward, which was
...
causing a bunch of NPEs on the market.
2010-10-31 17:42:03 +00:00
7f396e29a0
Match beginning of words when searching for contacts in Android 1.5/1.6 (e.g. "Doe" will find "Doe, John" and "John Doe")
...
Fixes issue 1354
2010-10-30 20:53:56 +00:00
0add1f97c0
Mark contacts as contacted when a mail is sent to them.
...
Fixes issue 2522
2010-10-30 20:35:49 +00:00
7db384fc08
Use a more backward compatible os version check, since the "current"
...
best practice is incompatible with 1.5
2010-10-29 22:35:27 +00:00
e0d6a55d06
SINGLE_COLUMN layouts cause Android 1.0-2.1 to segfault.
2010-10-29 22:35:19 +00:00
b749a198a7
get to: contacts working right.
2010-10-29 22:35:11 +00:00
c5cf9e5c8c
message_to_label and message_to_fmt were used from places that weren't
...
their original sources. rename them to lie less.
2010-10-29 22:34:59 +00:00
d28a85de5b
Update issue 2270
...
Status: Fixed
Gracefully ignore RejectedExecutionException on service shutdown (there's little we can do about being shut down)
2010-10-29 19:55:04 +00:00
be6ab18091
Update issue 2537
...
Try to gracefully handle account DB corruption by deleting file on open exception
2010-10-28 19:16:55 +00:00
50c3751421
Display "Account settings" title instead of "General settings" when opening account settings (doesn't seem to be affected by user chosen language though)
2010-10-28 19:07:30 +00:00
b723769e65
translated "unable to connect".
2010-10-28 14:37:48 +00:00
6704279042
redo our messagelist sigil code to not break sender colorization
2010-10-25 03:21:08 +00:00
724169e982
astyle
2010-10-25 03:20:03 +00:00
ddccd11ef7
Try to send pending messages whenever we refresh pushers. should help
...
with "stuck" unsent messages on push-only accounts
2010-10-25 03:19:43 +00:00
f6f9d35430
unify two codepaths that sent unsent messages, one of them without a notification
2010-10-25 03:19:19 +00:00
968fb8c508
add a variant of sendPendingMessages that will send pending messages in all accounts
2010-10-25 03:18:51 +00:00
1d6caa5c0a
Never show an undismissable "new email" notification for a null account (like used to happen during setup)
2010-10-24 02:01:13 +00:00
c216f42eb3
Exchange authenticaton and setup overhaul from Kris Wong
2010-10-24 01:03:29 +00:00
07adaaee4d
Applied WebDavStore_cleanup.diff to remove dead code in the WebDav store from Kris Wong <wongk@seapine.com>
2010-10-24 01:02:46 +00:00
62caa5ce76
Experimental change - ask android to try to make columns no wider than
...
the viewport. This change should NOT be backported to 3.2, but I'd like
folks to try it with real email.
2010-10-23 18:50:54 +00:00
43cb54594b
Push the webview's renderpriority from NORMAL to HIGH - it's cargo-cult
...
performance improvement, but it certainly doesn't hurt
2010-10-23 18:50:24 +00:00
983d7ad48f
The "viewport" hinting we used to try to better fit messages by default
...
made android zooming incredibly unreliable. Now it's only somewhat
unreliable.
2010-10-23 18:50:10 +00:00
4ea6c1603b
We've been seeing a lot of FCs on htmlifcation of large messages due to
...
running out of memory during our heavy HTMLification. Try to be a bit
lighter on the poor RAM if a plain text message is big.
2010-10-23 17:33:08 +00:00
524dfb348a
Updated MIME Type list with http://www.stdicon.com/mimetypes
2010-10-23 16:28:18 +00:00
105df4c61a
It turns out that not every android release has a good extension to
...
mimetype mapping. restore our previous hardcoded mime database as a
fallback
2010-10-23 16:28:07 +00:00
fb059a8138
Fix for NPE when changing the identity
...
Fixes issue 2506. Patch from jca02266
2010-10-23 15:26:50 +00:00
96f1d9eadf
Fix phantom messages in unified inbox.
2010-10-23 15:19:56 +00:00
bc2127c84a
added a synchronous variant of searchLocalMessages
2010-10-23 15:19:47 +00:00
64c102dd14
notification that the dataset changed needs to happen on the UI thread.
2010-10-21 20:49:48 +00:00
48f2885cfc
When returning from a messageview to a messagelist do our listview
...
updates on a thread rather than on the main ui thread. it results
in the list blinking with old data, but that's still a better user
experience than "frozen"
2010-10-21 20:49:36 +00:00
e8756af4f1
astyle
2010-10-21 20:49:20 +00:00
2a4792eb60
update a comment about an uncommon code path
2010-10-21 20:49:05 +00:00
8d9c074a27
Add gmail-style "to me" and "cc me" indicators in messagelist
2010-10-21 20:48:45 +00:00
d02ddda19b
When doing a message search, break it into "first 10" and "more" -
...
because a long SQL query takes more time before starting to return
results, K-9 was increasingly slow on large folders.
Doing two searches may take marginally more time but starts getting
results back to the UI much faster.
2010-10-21 20:48:28 +00:00
e05784d41d
Running heavy operations on the UI thread makes K-9's UI slow and
...
freezy. addOrUpdateMessages is very heavy. and very common.
2010-10-21 20:48:12 +00:00
0933fad9b3
Update issue 7031
...
http://code.google.com/p/android/issues/detail?id=7031
added removeDialog() for every dismissDialog()
2010-10-18 09:53:22 +00:00
b2a08d969b
Revert "For the common case of "getMessage" where we actually have the object in"
...
This doesn't work on initial sync, since the comparisons fail and you're
left with duplicates in the displayed mailbox
This reverts commit fa1c88bec348d0132acc60a320626bf0ca1170ec.
2010-10-16 08:27:58 +00:00
496677dad4
Calculate preview for html-only messages
...
Fixes 2465
2010-10-16 08:27:47 +00:00
742db2ac62
Cosmetic code changes
2010-10-13 20:56:44 +00:00
4be781a749
Fix NullPointerException when saving account settings for non-IMAP accounts.
...
Fixes issue 2454
2010-10-13 20:49:34 +00:00
28c9dfdcce
Delay formatting of dates in messagelist until we actually need them
...
-- it turns out they're very expensive.
2010-10-13 10:53:08 +00:00
4e53ee12b6
For the common case of "getMessage" where we actually have the object in
...
the list, use a less painful equality check than iteration.
This works because messageInfoHolders compare to each other using the
same key as message they contain.
2010-10-13 10:52:53 +00:00
9db44bf4a9
MessageProvider: making sure exposed cursor gets dereferenced on close (and closed on finalization) to prevent memory leak
2010-10-11 20:41:59 +00:00
e8fd9683e6
Optimize the new return-to-listview code. (Avoid a bug where we do far
...
too much work on first open of a message list)
2010-10-11 19:47:41 +00:00
d07aca3008
"Preferences" -> "Settings" for consistency
2010-10-11 14:54:23 +00:00
c5d68fb49d
Add preferences to enable pinch-to-zoom and single-column layout for
...
messages
2010-10-11 14:54:15 +00:00
5fc78b4219
astyle
2010-10-11 00:08:54 +00:00
a683186f6e
move 3 IMAP preferences out of the "wizard" flow to an advanced page
...
where they belong
2010-10-11 00:08:47 +00:00
28388b235e
move "saveAllHeaders" to the account preferences screen.
2010-10-11 00:08:39 +00:00
777c3e28b5
Disable theme in preferences to work around an android bug
2010-10-10 19:29:15 +00:00
296ab4f2be
Update issue 1623
...
Message retrieval:
- Use the given projection for the cursor result instead of always using a predefined projection. Extraction logic is now in dedicated classes for easy extension.
- Added BaseColumns._ID & BaseColumns._COUNT columns.
- Deprecated "id" column since it's not a reliable identifier (it's an incremential value generated at query() time)
2010-10-09 09:19:24 +00:00
3503355b2e
"Reply after quote" preference wasn't persisted.
2010-10-09 03:17:59 +00:00
385c34e190
Refactoring
...
- Moved ListPreference helper functions from FontSizeSettings to K9PreferenceActivity
- Used helper functions in Prefs
- Reordered preferences in Prefs to match the order in global_preferences.xml (display order)
2010-10-09 01:05:29 +00:00
96f18734f4
Minor rename
2010-10-09 00:48:46 +00:00
da7210d1db
Refactoring: Some variable, method, and id renaming.
2010-10-09 00:38:52 +00:00
7028a4c167
Fixes issue 2144
...
- Removed the contact names cache (memory leak)
- Changed Contacts.searchByAddress() to Contacts.getNameForAddress(). Cursor is now immediately closed.
- Only try to resolve contact names when "Global settings" -> "Show contact name" is checked
- Never resolve contact names if number of recipients exceeds a threshold
2010-10-09 00:24:43 +00:00
4f429ec3bc
Update issue 2144
...
Forgot to actually save the value when leaving global settings.
2010-10-09 00:13:46 +00:00
23b53bd660
Update issue 2144
...
Added option to show names from contacts to global preferences (value isn't used yet).
2010-10-08 23:50:33 +00:00
72cb0bf7ec
remove debugging statement
2010-10-08 06:56:50 +00:00
8c1eda3149
An attempt at cleaning up after the 3.00x and earlier bug that caused
...
K-9 to leave old headers hanging around in the database
2010-10-08 06:33:04 +00:00
ccc9a99d94
make batch buttons behave correctly if the last selected item is deleted
...
while in a messageview
2010-10-08 06:18:45 +00:00
b0de9913e0
more correct list updates after restore
2010-10-08 06:18:30 +00:00
7881039cbf
astyle
2010-10-08 05:34:46 +00:00
945bccd633
First pass at a sane "restore list state" behavior when going back to a
...
messagelist from a message view
2010-10-08 05:34:33 +00:00
78f797dda8
A previous refactoring broke notification for messages from the user by
...
replacing a localized string with substitutions with a concatenation
in one of two places the string was used.
2010-10-08 05:09:38 +00:00
6feb483f36
Update issue 1623
...
Restored accidently dropped content resolver notification code (dropped during r2397 refactoring)
First pass at documenting exposed fields
2010-10-06 20:14:33 +00:00
f858c72482
Added @Override compile check
2010-10-06 17:51:35 +00:00
9b5436d23b
Removed (redundant) debug logging from the IMAP parser code.
2010-10-06 01:50:02 +00:00
548e6e7c77
Update issue 1623
...
Don't export the formatted date through the content provider: now exported as the raw Epoch value - date formatting is a UI concern. That makes MessageInfoHolder lighter.
2010-10-05 22:33:20 +00:00
58c80ad096
Update issue 1623
...
Added semaphore to prevent third party content resolver from exhausting K-9 resources: it won't allow more than 1 cursor to be active at the same time. Concurrent threads (other content resolver invocations) will be suspended until the previous cursor gets released.
2010-10-05 20:23:07 +00:00
6061c42ea9
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
2010-10-05 06:04:28 +00:00
58bb54a588
when quoting an html body part for forwarding, downrez it to plain text.
...
In the glorious future, we should be forwarding as an attachment. but
this is better than the previous behaviour
2010-10-05 06:04:16 +00:00
ae53a0c5ff
broke addAttachmentView into its own sub
2010-10-05 06:03:51 +00:00
524350a960
Replace our (incomplete) custom MIME type list with a call to webkit.
2010-10-05 06:03:24 +00:00
4d24101e13
MessageProvider:
...
- Prevented from handling queries while K-9 isn't ready
- Added more log output
2010-10-05 05:09:17 +00:00
00ffc4f7fe
Reverted "shortcut" to global settings in menu for search results (message list) as this led to display problems with Android 2.2.
...
Fixes issue 2347
2010-10-04 00:01:59 +00:00
a3f4429963
Switch to UNIX EOL style
2010-10-03 11:08:42 +00:00
f1d413ce77
Optimization: extracted populate() outside MessageInfoHolder in order to properly cache DateFormat (avoid useless DateFormat costly lookup at each population)
2010-10-03 10:56:16 +00:00
9347409e14
Changed case of CheckboxListPreference class to match the Android framework naming pattern
2010-10-03 09:26:30 +00:00
8bb6eb146b
Optimizations:
...
- Don't instantiate an empty Address array just to throw it away (less gabarge collection)
- Use a StringBuilder rather than a StringBuffer (faster as it isn't synchronized)
2010-10-03 08:28:56 +00:00
ef1d958092
Optimization: don't invoke Cursor.getXXX(int) more than necessary
2010-10-02 18:45:51 +00:00
75984939d1
Don't embed helper instance inside a data transfer object (ideally, the populate() method should be moved outside that DTO to an external service/helper) as this might lead future development to introduce unwanted dependency graphs (= memory leaks)
2010-10-02 09:07:14 +00:00
bb64a0ab01
Update issue 2379
...
Status: Fixed
Extracted Intent.ACTION_SENDTO handling in a separate block to extract data from URI (as opposed to ACTION_SEND which uses Intent extras to pass data)
2010-10-02 08:14:12 +00:00
f6064ff19f
Use a thread pool to optimize resource usage instead of always firing up new threads (less garbage collection).
...
Note: this is not a complete revert of r2153 since the pool is now automatically expanded as needed (different implementation).
2010-10-02 07:45:11 +00:00
71dbdf3417
Update issue 1623
...
Removed dependency from K9 to MessageProvider (and added ability for components to register themselve for being notified when K9 instance is ready)
Moved Intent broadcast code from MessageProvider to K9
Made query() easily extensible using strategy pattern, the discriminant still being the Uri path
2010-10-01 19:41:39 +00:00
01f961c058
Update issue 1623
...
Fixed severe design flaw where the message provider would accumulate messages, causing an OutOfMemoryError even when the message provider isn't explicitely invoked.
query() is now synchronized with message retrieval
2010-09-26 16:01:41 +00:00
2a39cd5206
Fixes issue 2282
...
Added an option whether the registered name color is change or not
Avoid "Connection error" when MessageView is opened. The contacts.getName() might return null.
2010-09-26 14:39:52 +00:00
a2fe3bda34
When a new mail alert is alerting about a specific mailbox rather than
...
inbox, default to having it open that mailbox. Patch from thardie
2010-09-22 15:43:43 +00:00
b6124fb397
deleteHeaders deleted message headers by id when it should have been
...
deleting by message_id. I believe this was our last serious leak in
our flash storage
deleting message headers was....just wrong. we've fixed other similar
bugs inherited from android 1.0 before.
2010-09-22 02:46:20 +00:00
4cb2d52c9c
Refactored message sorting code by extracting the sort code from the sorted object (this was a bad design, worsened by the MessageProvider patch). Ideally, new Comparator classes should get promoted to top-level classes and not be enclosed in MessageList.
...
Subject stripper backported from issue258 branch (Utility.java)
The result is a cleaner MessageInfoHolder class.
2010-09-21 22:12:45 +00:00
9ef306413b
MessagingController not propagating provided listener
2010-09-20 11:47:02 +00:00
0990609727
Don't forget to remove some Preference entires when deleting Account
2010-09-19 21:10:56 +00:00
e28e6d8817
Added ability to disable LED notification for new messages (new account setting)
...
Extracted notification related settings in separate class (see Issue 2268)
Update issue 371
Status: Fixed
Added ability to disable LED notification for new messages
2010-09-19 20:54:43 +00:00
e16a79d08c
Javadoc comment
2010-09-12 06:11:08 +00:00
c8a5de7abd
Intent.ACTION_SENDTO.equals(action) was tested twice in the same if/else if statement causing the last one to never match, removed the first one in order to properly enable intent-based activity population
...
Fixes issue 2110
"Intent.ACTION_SENDTO.equals(action)" removed from first condition
See r1712
2010-09-12 05:26:13 +00:00
bbd664ad3c
Optimization: don't use bytes and related byte/char conversion when we're actually working on string only
2010-09-11 11:20:50 +00:00
8cf2655dd8
Reverted r2332 and r2333 because the cause of the problem reported in issue 2078 seems to be different than initially thought.
2010-09-09 23:52:06 +00:00
5aa56e1569
Code cleaning: remove unused imports/variables
2010-09-04 06:57:25 +00:00
3291c585e8
Improve Volume navigation settings, fix a bug when a list view is in
...
touch mode.
Patch by fiouzy.
2010-09-03 21:41:32 +00:00
de31886f44
Fixes issue 2230
...
Owner: fiouzy
Synchronize access to designated list to prevent concurrency issue
2010-09-03 20:32:12 +00:00
a85ea2ee53
- Reworked the previous patch with suggestions by jessev to be as runtime/memory efficient as possible without being useless.
...
- Output debug message when invalid responses are encountered.
2010-09-03 15:32:25 +00:00
b9b15295cd
Added yet another work-around for an IMAP server implementation with a creative interpretation of the specification. Sanity check results returned for a SEARCH command.
...
Fixes issue 2078
2010-09-03 13:58:09 +00:00
9d9e669d65
Code cleanup
2010-09-03 02:15:57 +00:00
b44bed2596
Fix NullPointerException
...
Fixes issue 2261
2010-09-03 01:16:41 +00:00
0c27a1ab0e
Avoid division by zero.
...
Fixes issue 2259
2010-09-03 00:56:19 +00:00
525d9a2ef9
Don't choke on malformed UIDL responses (POP3).
...
Fixes issue 2252
2010-09-02 23:59:20 +00:00
6573f27cec
do our messagelist updates from sync on the ui thread rather than the
...
sync thread. copy the incoming message list to deal with concurrent
access issues. Patch by cketti++
2010-09-02 03:45:16 +00:00
08f10f1fe5
Issue 1711 (don't display subject when phone locked)
...
Modified code so that subject is still visible after unlock when notification bar is expanded
2010-09-01 22:37:11 +00:00
f43db5235c
Fixes issue 1711
...
Owner: fiouzy
Don't display message subject in notification bar when keyguard is active (system locked)
2010-09-01 22:26:36 +00:00
f21d86d8ce
Fixes issue 1945. Toast debug location when enabling debug logging.
2010-09-01 21:27:11 +00:00
9b285ae3fc
Fixes issue 939
...
Heavily inspired from Gmail implementation. Currently implemented only for MessageView delete operation.
2010-09-01 20:59:09 +00:00
842a5ee123
Update issue 2144
...
Use setSpan() instead of Html.fromHtml()
Should clear cached name of contacts at MessageView#onClickSender().
2010-09-01 01:35:20 +00:00
a83fd2d548
Kill an insanely chatty log message
2010-08-31 05:01:26 +00:00
a1496bd839
Revert the clever runonuithread hack from the previous commit, as it
...
leads to concurrent modification exceptions. "oops" :/
2010-08-31 04:29:56 +00:00
7030967fa7
astyle
2010-08-31 03:58:33 +00:00
7bd8fc3599
When we sync messages and are displaying a messagelist, do the listview
...
updates on the UI thread rather than the sync thread. This is a huge
performance boost (based on simple empirical testing) for initial syncs
as we now do more work as we add messages to message lists
2010-08-31 03:57:02 +00:00
db1b86a296
Better visibility toggling as k-9 switches between messages in
...
MessageView
2010-08-31 03:55:30 +00:00
7f72da93e0
Added missing bit of achen.code's patch for issue 2211 (reply below quote)
2010-08-30 21:27:07 +00:00
b1074329e4
On the MessageList and the MessageView, prefer to use the display name registered in the Contacts rather than raw addresses.
...
Update issue 2144
2010-08-30 14:37:34 +00:00
e5c4f35737
Correct loading the alternated font size preferences.
2010-08-30 14:14:43 +00:00
4bf233fba5
next and previous were reversed from K-9's standard interpretation of
...
them in the previous patch to add volume button navigation
2010-08-30 03:05:41 +00:00
12eb866370
Remove a temporary variable
2010-08-30 02:16:38 +00:00
65f0d22355
Add Volume button navigation in MessageView, MessageList and all
...
K9ListActivity subclasses.
The MessageView code is a patch from paulkilroy@gmail.com .
Fixes Issue 2112
2010-08-30 02:16:20 +00:00
0f1a1baa89
Add a preference to use volume up / volume down to navigate items.
...
From a patch by paul.kilroy@gmail.com . Partial resolution of Issue 2112
2010-08-30 02:15:59 +00:00
be8ac83198
A first pass at letting users choose not to top-post their message
...
replies. Code By achen.code@gmail.com
Fixes Issue 2262
2010-08-30 00:00:34 +00:00
6e2c5be84c
simplify a boolean in isMoveCapable
2010-08-29 23:40:14 +00:00
1f399f5904
Simplify a boolean conditional
2010-08-29 23:40:00 +00:00
7d2804549e
Remove redundant "return" statements from the end of void methods (with
...
help from intellij)
2010-08-29 23:39:45 +00:00
4f0bce1569
Simplify many, many boolean conditions with help from IntelliJ
2010-08-29 23:39:26 +00:00
3d27cf220a
Removed some code/string duplication.
2010-08-29 18:46:51 +00:00
89dcc3646b
Database version bump to clear bogus cached attachments
2010-08-29 16:58:04 +00:00
6031862bad
Before we delete messages earlier than the earliest acceptable date, make sure we also delete their attachments.
2010-08-29 16:57:57 +00:00
fe62812ff2
Delete the attachments from disk before we delete them from the database, so we know what to delete.
2010-08-29 16:57:49 +00:00
994ed6653c
simplify some of our flagging logic and remove duplication using ternary operators
2010-08-29 16:57:40 +00:00
6d38c1c71a
Comments to better explain what's really going on on delete of messages
2010-08-29 16:57:31 +00:00
a5b7aa97dd
typo fix
2010-08-29 16:57:24 +00:00
e0447e32cc
astyle
2010-08-29 16:57:13 +00:00
7300aca2b8
Remove a call to deleteHeaders since headers are deleted implicitly by
...
an SQLite trigger.
Call our new variant of deleteAttachments() to avoid an extra lookup
2010-08-29 16:57:02 +00:00
31613e15c7
extract the method for "delete a message" from the "Set flags" method
2010-08-29 16:56:54 +00:00
54a4c84afa
Split out deleteAttachment to avoid an extra SQL call if we can.
2010-08-29 16:56:45 +00:00
38c31db8f6
Don't open a connection to the server if the protocol doesn't support flags and the flag to be changed isn't the deleted flag. This avoids unnecessary connections to POP3 servers.
...
Fixes issue 2046
2010-08-28 21:15:23 +00:00
015666b657
Fixed issue 2174
...
When selecting one of the five vibrate patterns or the number of repetitions, we should demonstrate to the user what the vibrate pattern feels like. (Thanks to achen.code)
use the ListPreference instead of the EditTextPreference to set vibrate times.
2010-08-28 14:00:34 +00:00
41ebeb3498
Don't show K9mail-errors as move/copy destination folder.
...
Fixes issue 2219
2010-08-27 01:02:29 +00:00
a93da0ed80
decoupled PgpData from CryptoProvider, moved the crypto provider into Account
2010-08-22 09:51:17 +00:00
df0ae4e4bf
Update Issue 2168
...
Respect "Return to list after delete" after pressing on "Archive", "Move", or "Spam" button.
TODO: Change strings to reflect this change (e.g. "Return to list after move/delete")
2010-08-19 03:14:27 +00:00
90ee194d0f
Fixes issue 387
...
Applied patch by achen.code (thanks!) to word wrap the quoted text on replies.
2010-08-19 02:49:13 +00:00
00d30f1b8a
NullPointerException and TODO-Marker on a strange code-line
2010-08-18 14:27:39 +00:00
726b472330
set context before using it
2010-08-18 14:13:37 +00:00
0b62640eac
Provisional initial commit of MessagingProvider code by
...
stephane.lajeunesse and koxx33
We're going to try it out in the 3.1 dev series. if it ends up looking
good, it'll be in 3.2
2010-08-18 02:49:13 +00:00
Jesse Vincent