Thialfihar
b839866e17
removed some unused APG constants, added an APG Intent API version to be sent along with all Intents
2010-08-12 17:39:50 +00:00
Fiouz
1e67fc4cde
Update issue 1290
...
Update issue 1916
Added support for country/region specific locales
2010-08-12 11:03:19 +00:00
Jesse Vincent
a0238904b6
Update our emoji implementation to support docomo, softbank and kddi
...
(with the exception of 3 kddi glyphs that overlap with softbank).
As of this commit, emoji sent by iPhone users are visible in K-9
2010-08-12 02:22:35 +00:00
Jesse Vincent
d123aa2a39
Add a hook for hinting charset conversions to Java, since Android's java
...
doesn't know about all conversions.
2010-08-12 02:22:25 +00:00
Jesse Vincent
54633a4e16
Improvements to "more from this sender" - hopefully this should search
...
only on actual addresses, not their local parts.
2010-08-12 02:22:08 +00:00
Jesse Vincent
ece68bae5d
Off-by-one error in the recent IMAP fetch work :/
2010-08-12 02:21:56 +00:00
Jesse Vincent
de16b21124
Add debug logging when K-9 doesn't enable push because the user has
...
configured push to be off.
2010-08-11 03:36:49 +00:00
Jesse Vincent
0229d8a1fe
Implement windowing for IMAP UID FETCH
...
Our previous implementation of UID FETCH didn't ever take into account
maximum command line lengths. When fetching, say 800 messages from a
GMail IMAP server, we could easily overflow the max line length leading
to a fetch that didn't get all the messages we wanted to and was
truncated before the description of which fields we want. That caused
K-9 to fetch complete messages, exhaust memory and ultimately fail,
even when we were just trying to get message lengths.
An equivalent fix needs to be made to seach by UID.
2010-08-11 03:36:40 +00:00
Jesse Vincent
9ebf16e3d9
Finish removing the ThreadPool / ExecutorService Left over from when the
...
code was actually in the view class
2010-08-10 04:29:18 +00:00
Jesse Vincent
490ab6b8c0
Try harder to make message loading feel responsive and scroll correctly.
...
We're still not there.
2010-08-09 03:16:40 +00:00
Jesse Vincent
a724df79d4
To date, "loadMessageForView" competed for threads in a thread pool with
...
all of our mail syncing code. This led to very choppy UI experience.
This change doesn't entirely fix message load lag, but the _worst case_
I see is now better than the best case I saw last week.
2010-08-08 23:49:27 +00:00
cketti
2e6a67c2a7
Better text filter for ChooseFolder (folder is displayed if search term is found anywhere in the folder name, not just at the beginning)
...
Heavily based on a patch provided by Marcus.Wolschon
Fixes issue 2098
2010-08-08 20:27:39 +00:00
Jesse Vincent
1f725a2d5c
increment the new message count if the message is in a notifiable folder
...
and the account wants notifications. (even if we don't
notify for a message from ourselves, we DO increase the notification
count.)
2010-08-08 19:43:01 +00:00
Jesse Vincent
ce9a84e8fd
Quick updates from a code review pass by cketti
2010-08-08 19:35:18 +00:00
Jesse Vincent
d2e3061f20
Lift our initial unread counter up higher so that it happens before
...
called code starts resetting the unread count again.
2010-08-08 19:14:52 +00:00
Jesse Vincent
06a3d5985b
Avoid allocating two temp variables on sync
2010-08-08 19:14:47 +00:00
Jesse Vincent
f5a399f6c6
extract out "should we notify" from "notify";
...
rather than calculating the number of pre-existing new messages for this
sync twice, do it once, a bit earlier.
2010-08-08 18:50:31 +00:00
cketti
43fb202d43
Fixes issue 1522
...
Added option to automatically show images in message view (always, if sender is in contacts, never).
Patch by paulkilroy (thanks!)
Includes bugfix for the "Show pictures" on orientation change code introduced earlier.
2010-08-07 22:38:08 +00:00
cketti
9d45470b40
Fixes issue 1076
...
Remember "Show pictures" button state when changing orientation.
2010-08-07 21:37:57 +00:00
cketti
5c588992a0
Fixes Issue 2076
...
Remove german version of the "Re:" prefix when replying to messages. So instead of "Re: AW: subject" we get "Re: subject".
2010-08-07 19:25:47 +00:00
Fiouz
dfb8f9e0f2
Memory management optimisation: help garbage collection by avoiding repeated instantiations of immutable arrays (empty arrays of String, Message, Flag, Address)
2010-08-07 15:10:07 +00:00
Thialfihar
54e0ad5ce0
added some comments to explain some cryptography-related classes and to-dos
2010-08-05 10:55:59 +00:00
Thialfihar
11e28698e1
hide the decrypt signature layout in MessageView if no signature exists, fixes the wrong display of signatures from another message
2010-08-05 10:45:58 +00:00
Fiouz
380452355c
MessageListAdapter:
...
- Use of a single View.OnClickListener for all messages.
- Extracted method to bind message item views (from MessageInfoHolder to MessageViewHolder).
2010-08-03 07:46:31 +00:00
Fiouz
ad9c315cf4
No longer need to extend Handler since r1126: we're using Activity.runOnUiThread()
2010-08-03 06:09:39 +00:00
Fiouz
2a476dc92c
Additional @Override compile check
2010-08-03 05:46:35 +00:00
Jesse Vincent
f15101420e
Revert "I like this idea, but it's not ready for 3.000"
...
This reverts commit f812a3485445c7db4024f84865aaa5d8e6b7b3a0.
(Now that 3.0 is branched, this can be on trunk again for further work)
2010-08-02 22:34:21 +00:00
Jesse Vincent
58c5afc77b
I like this idea, but it's not ready for 3.000
...
Revert "It turns out that a big part of our perceptible message switching time"
This reverts commit 06f9bb5b7f3064e646b43148d188cec06cd14d11.
2010-08-02 22:32:57 +00:00
Fiouz
44cef83e0b
Use of constants for immutable empty arrays (prevent useless memory allocation)
2010-08-02 11:55:31 +00:00
Jesse Vincent
d4695636f3
It turns out that a big part of our perceptible message switching time
...
was loading the "loading..." file into the WebView. Since it doesn't
take that long to load the real content, replacing the "Loading..." file
with "blank the view" seems to actually feel a heck of a lot faster.
2010-08-02 03:03:58 +00:00
Jesse Vincent
f2729fc58b
Don't show "To: " if the only recipients were ccs and bccs.
2010-08-02 03:03:53 +00:00
Jesse Vincent
cd6b64d88f
Experimental changes to tell WebView that the HTML versions of messages
...
we generate from ascii are "mobile-optimized"
2010-08-02 01:27:50 +00:00
Jesse Vincent
d78e7a0d69
Switch from the incomplete (but compatible with java 1.3) mime4j charset
...
alias resolver to the core java nio version with a better charset
database;
rather than falling back to not showing the user a failing message, fall
back to showing the user the message as ascii -- it makes it possible
to get _something_ out of an unknown-charset message, rather than just a
"ha ha. no." error.
2010-08-02 01:27:46 +00:00
Jesse Vincent
7fc921c0b7
astyle
2010-08-02 01:27:40 +00:00
Jesse Vincent
a4381696f9
Support Emoji for DoCoMo.
...
Emoji icons are derived from http://start.typepad.jp/typecast/
2010-08-02 01:24:40 +00:00
Fiouz
3bbb6ae050
Don't display Archive/Spam batch operations when corresponding folders are unset
2010-07-30 09:58:26 +00:00
Jesse Vincent
d8a73b195d
Factor out the decision about whether a part is "viewable" for purposes
...
of fetching ; remove broken "inline" check from the same.
2010-07-30 00:58:33 +00:00
cketti
0c67f1f4cf
Only ask for POP3 capabilities before authorization if TLS should be used. Always ask after authorization.
2010-07-30 00:58:22 +00:00
cketti
91e55f6fa1
Don't log POP3 passwords by default.
2010-07-30 00:53:46 +00:00
Jesse Vincent
d8a757faaf
Try to avoid a bunch of reallocations as we grow the temporary output stream by defining its size if we can get it
2010-07-29 22:17:35 +00:00
Jesse Vincent
134c0b23dd
Backport a bit of memory efficiency I'm not sure I believe from AOSP
2010-07-29 22:17:32 +00:00
Jesse Vincent
0bb115ca42
Actually catch an OOM in getTextFromPart
...
Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages
2010-07-29 22:17:29 +00:00
Jesse Vincent
c6aa505ffe
improve the method docs on getTextFromPart
...
Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages
2010-07-29 22:17:26 +00:00
cketti
4c1060ecae
Only show "save or discard" dialog before leaving the message compose activity if the message needs saving.
2010-07-28 23:17:46 +00:00
Thialfihar
3d5fb524ef
set account setting crypto app to "APG" by default
2010-07-28 21:28:51 +00:00
Thialfihar
5e30c3dab1
removed two extra lines from the merge in r2055
2010-07-28 12:10:08 +00:00
Jesse Vincent
2ca76e3db0
Fix for Issue 1956
...
A race condition made the outgoing certificate being compared to the old
incoming mHost,
throwing an exception with an untrusted certificate dialogue to accept
or decline.
2010-07-27 18:59:41 +00:00
Jesse Vincent
7a4d12b53b
Merge from apg-integration
2010-07-27 12:10:09 +00:00
Jesse Vincent
bae8a9736d
Clean up some inverted logic
2010-07-27 01:28:03 +00:00
Jesse Vincent
b1fb92034a
clean up some weird inverted logic (as recommended by intellij)
2010-07-27 01:27:54 +00:00
Jesse Vincent
c541a07ed2
Don't fire off a notification about new mail before we finish
...
initializing an account.
2010-07-27 01:27:45 +00:00
Jesse Vincent
766a115155
Remove URLs from message previews. Suggested by Kevin Falcone
2010-07-24 02:09:12 +00:00
Jesse Vincent
19a06d39a1
With all the other performance work we've been doing, getting a message
...
into the messagelist is now much, much faster. Intentionally loading the
whole mailbox before we let the user interact with the list is
increasingly painful. A 250 message mailbox takes 2+ seconds to "unlock"
on a modern phone.
Consequently, this commit switches us _back_ to progressive loading of
mailboxes from the synchronous version.
Based on user feedback, we may or may not keep this for the production
release.
2010-07-22 04:17:13 +00:00
Jesse Vincent
80e134c03c
astyle
2010-07-22 03:40:30 +00:00
Jesse Vincent
eb21807384
Moving sendMessage and saveMessage into AsyncTasks to make the send/save
...
buttons much less janky
2010-07-22 03:40:22 +00:00
Jesse Vincent
8182b8a8ee
Split out sendmessage and savemessage - the sendorsavemessage method
...
didn't actually have them sharing code.
2010-07-22 03:40:14 +00:00
Jesse Vincent
338919a9a0
Merge remote branch 'remotes/issue814'
...
* remotes/issue814:
Changed the appearance of the ChooseAccount activity to better match the look of the account list.
svn:eol-style set to LF (UNIX style)
Update issue 814 Status: Started Cc: +fiouzy Reuse of res/layout/accounts_item.xml to match account list Automatically expand/scroll to Intent-presented account
- Patch provided by fiouzy (ability to choose identity from other accounts) - Modifications in MessageCompose by cketti (use MessageReference to replace mFolder and mSourceMessageUid)
Created branch for issue 814 (Feature to select account to send from in compose screen)
2010-07-22 03:15:28 +00:00
Jesse Vincent
75b8487024
First bits of infrastructure for not showing HTML-mail inline images as
...
downloadable attachments
2010-07-19 06:13:41 +00:00
Jesse Vincent
65e318a80e
mark thumbnails as .tmp files that should be explicitly gced on start.
2010-07-19 05:32:45 +00:00
Jesse Vincent
7de3aeb740
Actually, clearing the tempdir from attachmentprovider stomps on our
...
binary download usage of the temp directory. Reverted!
2010-07-19 05:32:37 +00:00
Jesse Vincent
f9a24cb123
astyle
2010-07-19 01:57:49 +00:00
Jesse Vincent
a75bf8668e
K-9 wasn't properly clearing the thumbnail/tmpfile cache. We now
...
properly clear it up on start, which causes K-9 to leak less flash
memory AND
fixes the "Wrong thumbnail" bug.
2010-07-19 01:55:23 +00:00
Jesse Vincent
f7032c4161
Android is growing up a bit. artificially limiting the user to
...
attachments of only 5MB is counter-productive, bump the artificial limit
to 128M
2010-07-19 01:55:09 +00:00
Jesse Vincent
6ef923be91
After we download attachments, get rid of the "old" attachment views
2010-07-19 01:54:55 +00:00
Jesse Vincent
2ee5b49cf2
When marking a message as read as we're opening it from the message
...
list, don't "bother" sorting the messagelist again before opening the
message, it adds a _bit_ of slowness when we don't need it and
we'll sort again when we get back to the message list.
2010-07-19 01:54:38 +00:00
Jesse Vincent
0fcae025b2
per a bunch of complaints, it looks like my new notification counting
...
code was off-by-one
2010-07-19 01:54:23 +00:00
Jesse Vincent
819692e025
refactor one of the versions of 'getAttachmentUri' in terms of one of
...
the others. less code == fewer chances to screw up
2010-07-19 01:54:09 +00:00
Jesse Vincent
6d20c65778
remove the old "isdownloading" notification for the current message.
2010-07-19 01:53:49 +00:00
Jesse Vincent
ad7839e46e
remove debugging statement
2010-07-19 01:53:30 +00:00
Jesse Vincent
a63beda64b
Finish backing out the "sort by received date" patch until we get the
...
recieved-date support sorted out
2010-07-19 01:53:14 +00:00
Jesse Vincent
111e6f5109
First pass at a "download the rest of this message" button
2010-07-19 01:52:59 +00:00
Jesse Vincent
d0c24e23c7
simplify account loading code by caching Preferences.getPreferences()
2010-07-19 01:52:43 +00:00
Jesse Vincent
7464a1527a
Convert for loops to "enhanced" syntax per SDK performance guidelines
...
(Automatic with Eclipse)
2010-07-19 01:52:18 +00:00
Jesse Vincent
8f1d535630
make it possible to get to global settings from the folder list
2010-07-16 01:24:01 +00:00
Jesse Vincent
b21120405e
Use a simple HashSet for our listener set since we don't need the
...
overhead of the CoWASet
2010-07-16 00:38:32 +00:00
Thialfihar
19ca87a2d5
removed the initiation of "select text" via long press again
...
Update issue 662
We tried out the long press for a bit and deemed it too sensitive for general usage. It can cause problems with gestures and such, so I removed it again. I hope using the option menu is not too much overhead.
If you want to include it in your custom build or anything, then r 1976 and r1977 should be enough.
2010-07-15 21:35:57 +00:00
Jesse Vincent
f492ee9d0b
back out the rest of my localDate changes for now due to user
...
complaints.
2010-07-15 03:47:45 +00:00
Jesse Vincent
b8e82085f9
At the end of header sync reset the counts.
2010-07-15 03:42:20 +00:00
Jesse Vincent
a58d91f7c7
astyle
2010-07-15 03:42:17 +00:00
Jesse Vincent
d3cc1fdfdc
Rather than doing a full count of all the unread messages in each and
...
every folder for each message downloaded in a session, factor the
"unread messages" count out into the calling code. It's slightly less
clean, but a pretty huge performance gain.
Fixes issue 1443
2010-07-15 03:42:13 +00:00
Jesse Vincent
1bea931ed0
since we're checking seen status within the notify method, (first thing,
...
even), we don't need to do it in the caller code.
2010-07-15 03:42:09 +00:00
Jesse Vincent
ff62ae5c23
Don't construct a listenerset clone if we don't need to.
...
danapple++ suggested the optimization
2010-07-15 03:42:05 +00:00
Jesse Vincent
08581f6538
isRing -> shouldRing so that the code reads sanely
2010-07-15 03:42:01 +00:00
Thialfihar
cc71273c4b
remember which message was selected in MessageList in case the list changes while the dialog is up
...
Fixes issue 906
2010-07-14 18:39:57 +00:00
Thialfihar
91599ae963
ignore gestures during text selection
...
Fixes issue 662
2010-07-14 18:20:10 +00:00
Thialfihar
510e9acc83
added text selection via "long press" in MessageView, also giving a notification for when text selection starts
...
Update issue 662
Added the long press initiation of text selection. I also noticed we'll have to make sure text selection is not recognized as a gesture (or at least ignored as gesture).
2010-07-14 18:12:40 +00:00
Jesse Vincent
ed86fc8371
First pass at better end-user visibility into what K-9 is doing when we
...
appear to "sit" while syncing headers.
2010-07-13 23:59:14 +00:00
Jesse Vincent
49c0601390
cketti points out that I was cloning improperly.
...
(Also, reading the docs for add, I don't need to check existence first)
2010-07-13 21:54:11 +00:00
Thialfihar
014b6c19c3
svn:eol-style=LF for src and XML resources
...
Fixes issue 1982
2010-07-13 21:49:28 +00:00
Jesse Vincent
e17707330f
reduce lots and lots of code duplication when calling out to listeners.
2010-07-13 21:17:10 +00:00
Jesse Vincent
986237d31f
factor common code out of downloadLargeMessages and
...
downloadSmallMessages (catching a missing condition in one)
2010-07-13 21:17:04 +00:00
Jesse Vincent
70a1eef943
astyle
2010-07-13 21:16:56 +00:00
Jesse Vincent
a85c83f696
Revert "When deciding whether a message is older than a certain date, we should"
...
This reverts commit 98cab91631692b55ba72231126f612d6b4d4d662.
As Dan rightly suspected, it made pop3 sad :/
2010-07-13 21:16:49 +00:00
Jesse Vincent
8ab165ef31
Allow per-protocol configuration of which wire protocols are
...
debug-logged
2010-07-13 21:16:42 +00:00
Thialfihar
eda64bf1e7
display the language choices in their native names, added a larger set of native language names, which will be reduced to the supported languages at runtime
...
Fixes issue 1290
This may be a bit much, but I hope it can make it a little bit easier to add a new language later on and have consistent ordering.
2010-07-13 14:24:21 +00:00
cketti
665efc1448
Work-around to be able to read messages with "charset=0". QUALCOMM Windows Eudora seems to send headers like this.
...
Fixes issue 1952
2010-07-12 19:45:59 +00:00
Koji Arai
eb7289f97b
Reverted a part of r1872.
...
Should save draft when the home button is pressed.
2010-07-12 14:57:42 +00:00
cketti
49e5ad4963
More cosmetic changes (again no change in functionality)
2010-07-12 02:17:48 +00:00
cketti
173b36d04e
Removed unnecessary null pointer check.
2010-07-12 01:39:29 +00:00
cketti
f40a01b0d2
"Optimized" computeBatchDirection() to exit the loop once newState is set to true because it can never be changed to false again.
2010-07-12 01:09:47 +00:00