mirror of
https://github.com/moparisthebest/k-9
synced 2024-11-24 02:12:15 -05:00
isRing -> shouldRing so that the code reads sanely
This commit is contained in:
parent
cc71273c4b
commit
08581f6538
@ -1049,7 +1049,7 @@ public class Account implements BaseAccount
|
||||
return oldMaxPushFolders != maxPushFolders;
|
||||
}
|
||||
|
||||
public synchronized boolean isRing()
|
||||
public synchronized boolean shouldRing()
|
||||
{
|
||||
return mRing;
|
||||
}
|
||||
|
@ -386,7 +386,7 @@ public class AccountSettings extends K9PreferenceActivity
|
||||
// XXX: The following two lines act as a workaround for the RingtonePreference
|
||||
// which does not let us set/get the value programmatically
|
||||
SharedPreferences prefs = mAccountRingtone.getPreferenceManager().getSharedPreferences();
|
||||
String currentRingtone = (!mAccount.isRing() ? null : mAccount.getRingtone());
|
||||
String currentRingtone = (!mAccount.shouldRing() ? null : mAccount.getRingtone());
|
||||
prefs.edit().putString(PREFERENCE_RINGTONE, currentRingtone).commit();
|
||||
|
||||
mAccountVibrate = (CheckBoxPreference) findPreference(PREFERENCE_VIBRATE);
|
||||
@ -565,7 +565,7 @@ public class AccountSettings extends K9PreferenceActivity
|
||||
}
|
||||
else
|
||||
{
|
||||
if (mAccount.isRing())
|
||||
if (mAccount.shouldRing())
|
||||
{
|
||||
mAccount.setRingtone(null);
|
||||
}
|
||||
|
@ -4621,7 +4621,7 @@ public class MessagingController implements Runnable
|
||||
if (!account.isRingNotified())
|
||||
{
|
||||
account.setRingNotified(true);
|
||||
if (account.isRing())
|
||||
if (account.shouldRing())
|
||||
{
|
||||
String ringtone = account.getRingtone();
|
||||
notif.sound = TextUtils.isEmpty(ringtone) ? null : Uri.parse(ringtone);
|
||||
|
Loading…
Reference in New Issue
Block a user