moparisthebest
/
k-9
mirror of https://github.com/moparisthebest/k-9
1
0
Fork 0
Code Issues Releases Wiki Activity
1,499 Commits 36 Branches 329 Tags 887 MiB
Commit Graph

60 Commits

Author SHA1 Message Date
Fiouz e28e6d8817 Added ability to disable LED notification for new messages (new account setting) 
Extracted notification related settings in separate class (see Issue 2268)

Update issue 371
Status: Fixed
Added ability to disable LED notification for new messages
 2010-09-19 20:54:43 +00:00
Fiouz bbd664ad3c Optimization: don't use bytes and related byte/char conversion when we're actually working on string only 2010-09-11 11:20:50 +00:00
Fiouz 08f10f1fe5 Issue 1711 (don't display subject when phone locked) 
Modified code so that subject is still visible after unlock when notification bar is expanded
 2010-09-01 22:37:11 +00:00
Fiouz f43db5235c Fixes issue 1711 
Owner: fiouzy
Don't display message subject in notification bar when keyguard is active (system locked)
 2010-09-01 22:26:36 +00:00
Koji Arai b1074329e4 On the MessageList and the MessageView, prefer to use the display name registered in the Contacts rather than raw addresses. 
Update issue 2144
 2010-08-30 14:37:34 +00:00
Jesse Vincent 6e2c5be84c simplify a boolean in isMoveCapable 2010-08-29 23:40:14 +00:00
Jesse Vincent 1f399f5904 Simplify a boolean conditional 2010-08-29 23:40:00 +00:00
Jesse Vincent 4f0bce1569 Simplify many, many boolean conditions with help from IntelliJ 2010-08-29 23:39:26 +00:00
Jesse Vincent e0447e32cc astyle 2010-08-29 16:57:13 +00:00
cketti 38c31db8f6 Don't open a connection to the server if the protocol doesn't support flags and the flag to be changed isn't the deleted flag. This avoids unnecessary connections to POP3 servers. 
Fixes issue 2046
 2010-08-28 21:15:23 +00:00
Koji Arai 015666b657 Fixed issue 2174 
When selecting one of the five vibrate patterns or the number of repetitions, we should demonstrate to the user what the vibrate pattern feels like. (Thanks to achen.code)

use the ListPreference instead of the EditTextPreference to set vibrate times.
 2010-08-28 14:00:34 +00:00
Jesse Vincent ff5024eaec astyle 2010-08-18 02:48:55 +00:00
Jesse Vincent 9ebf16e3d9 Finish removing the ThreadPool / ExecutorService Left over from when the 
code was actually in the view class
 2010-08-10 04:29:18 +00:00
Jesse Vincent a724df79d4 To date, "loadMessageForView" competed for threads in a thread pool with 
all of our mail syncing code. This led to very choppy UI experience.

This change doesn't entirely fix message load lag, but the _worst case_
I see is now better than the best case I saw last week.
 2010-08-08 23:49:27 +00:00
Jesse Vincent 1f725a2d5c increment the new message count if the message is in a notifiable folder 
and the account wants notifications. (even if we don't
notify for a message from ourselves, we DO increase the notification
count.)
 2010-08-08 19:43:01 +00:00
Jesse Vincent ce9a84e8fd Quick updates from a code review pass by cketti 2010-08-08 19:35:18 +00:00
Jesse Vincent d2e3061f20 Lift our initial unread counter up higher so that it happens before 
called code starts resetting the unread count again.
 2010-08-08 19:14:52 +00:00
Jesse Vincent 06a3d5985b Avoid allocating two temp variables on sync 2010-08-08 19:14:47 +00:00
Jesse Vincent f5a399f6c6 extract out "should we notify" from "notify"; 
rather than calculating the number of pre-existing new messages for this
sync twice, do it once, a bit earlier.
 2010-08-08 18:50:31 +00:00
Fiouz 44cef83e0b Use of constants for immutable empty arrays (prevent useless memory allocation) 2010-08-02 11:55:31 +00:00
Jesse Vincent 7fc921c0b7 astyle 2010-08-02 01:27:40 +00:00
Jesse Vincent b1fb92034a clean up some weird inverted logic (as recommended by intellij) 2010-07-27 01:27:54 +00:00
Jesse Vincent c541a07ed2 Don't fire off a notification about new mail before we finish 
initializing an account.
 2010-07-27 01:27:45 +00:00
Jesse Vincent f9a24cb123 astyle 2010-07-19 01:57:49 +00:00
Jesse Vincent 0fcae025b2 per a bunch of complaints, it looks like my new notification counting 
code was off-by-one
 2010-07-19 01:54:23 +00:00
Jesse Vincent 111e6f5109 First pass at a "download the rest of this message" button 2010-07-19 01:52:59 +00:00
Jesse Vincent 7464a1527a Convert for loops to "enhanced" syntax per SDK performance guidelines 
(Automatic with Eclipse)
 2010-07-19 01:52:18 +00:00
Jesse Vincent b21120405e Use a simple HashSet for our listener set since we don't need the 
overhead of the CoWASet
 2010-07-16 00:38:32 +00:00
Jesse Vincent d3cc1fdfdc Rather than doing a full count of all the unread messages in each and 
every folder for each message downloaded in a session, factor the
"unread messages" count out into the calling code.  It's slightly less
clean, but a pretty huge performance gain.

Fixes issue 1443
 2010-07-15 03:42:13 +00:00
Jesse Vincent 1bea931ed0 since we're checking seen status within the notify method, (first thing, 
even), we don't need to do it in the caller code.
 2010-07-15 03:42:09 +00:00
Jesse Vincent ff62ae5c23 Don't construct a listenerset clone if we don't need to. 
danapple++ suggested the optimization
 2010-07-15 03:42:05 +00:00
Jesse Vincent 08581f6538 isRing -> shouldRing so that the code reads sanely 2010-07-15 03:42:01 +00:00
Jesse Vincent ed86fc8371 First pass at better end-user visibility into what K-9 is doing when we 
appear to "sit" while syncing headers.
 2010-07-13 23:59:14 +00:00
Jesse Vincent 49c0601390 cketti points out that I was cloning improperly. 
(Also, reading the docs for add, I don't need to check existence first)
 2010-07-13 21:54:11 +00:00
Jesse Vincent e17707330f reduce lots and lots of code duplication when calling out to listeners. 2010-07-13 21:17:10 +00:00
Jesse Vincent 986237d31f factor common code out of downloadLargeMessages and 
downloadSmallMessages (catching a missing condition in one)
 2010-07-13 21:17:04 +00:00
Jesse Vincent ae339f1ac8 Add a per-account setting to choose how much of each message to download automatically. 2010-07-11 11:59:14 +00:00
Jesse Vincent 44f161fc7f extract "fetch unsyncced messages" from downloadMessages 2010-07-10 17:10:24 +00:00
Jesse Vincent c2d9d0e15d extract "sync local message flags" from downloadMessages 2010-07-10 16:42:54 +00:00
Jesse Vincent 35b7fce087 factor out downloadSmallMessages from downloadMessages 2010-07-10 16:42:39 +00:00
Jesse Vincent 9dc3f09068 factor "downloadLargeMessages" out of "downloadMessages" 2010-07-10 16:42:12 +00:00
Jesse Vincent ab8cdb3522 minor astyling 2010-07-10 16:41:48 +00:00
Jesse Vincent 0f17fc4a83 Factor a bit of code out of a 400 line method. Still needs a lot more 
outfactoring
 2010-07-10 16:41:34 +00:00
Jesse Vincent 5aea9e7d9b Remove duplicate code from error message generation 2010-07-10 16:41:07 +00:00
Jesse Vincent 56217e8ad6 Debug message clarity fixes 2010-07-10 16:40:55 +00:00
Jesse Vincent fd234c2701 If we hit a race condition and download a message after it's already 
been marked as suppressed, then don't actually save it locally
 2010-07-08 15:49:26 +00:00
Jesse Vincent a826f33eb3 find src/com/fsck/ -name \*.java|xargs astyle --style=ansi 
--mode=java --indent-switches --indent=spaces=4 --convert-tabs
--unpad=paren
 2010-07-06 10:29:26 +00:00
Daniel Applebaum 318099082f Fixes Issue 794 
Implements new setting "Sync remote deletions" which is checked by
default.  When unchecked, K-9 Mail will no longer remove messages from
local storage just because the message was removed from the server.
This functionality works for all account types.  Messages will still
be removed from the local store in order to stay within the limit
imposed by the "Number of messages to display" setting.
 2010-07-03 13:10:38 +00:00
Koji Arai 3ee3fad3d6 Fixes Issue 1915 
Added the vibrate pattern preference.
 2010-07-02 14:47:01 +00:00
Daniel Applebaum 3c146c5a7f Fixes Issue 1832 
If the message isn't worth showing immediately, it is not worth
saving!

(Don't save a message unless we get at least a non-null subject and
non-null sender during first pass sync.)
 2010-06-30 00:16:59 +00:00