cketti
0560dc28d9
Don't use the application context to start the Accounts activity (because then we'd have to create a new task)
...
Fixes issue 2653
2010-11-18 09:08:40 +00:00
Fiouz
a67a2022d3
Added method name logging on transaction logging, when debug is enabled
2010-11-17 21:11:07 +00:00
Fiouz
dc16657480
Made LocalStore.destroy() transactional
2010-11-17 21:10:45 +00:00
Jesse Vincent
46300ac421
Move our "pick a folder" preferences out of the account setup wizard,
...
where you're unlikely to even have access to them the first time you
walk through into the "Folders" preferences.
At the same time, move toward using a list preference widget, rather
than a custom activity.
2010-11-17 03:43:02 +00:00
Jesse Vincent
b6ccba9c7d
When getting a list of folders out of the database, ask for it in
...
asciibetical order, rather than random order
2010-11-17 03:42:14 +00:00
Jesse Vincent
7291486ca0
No longer delete the Outbox every time it's empty - it makes it somewhat
...
more difficult to work with. If we want to hide it when it's empty,
that's fine. but it's not necessary to delete it.
2010-11-17 03:41:37 +00:00
Jesse Vincent
80e4de6db4
fix a deleted message count logic error
2010-11-15 01:31:20 +00:00
Jesse Vincent
4f4fe87d5f
Minor refactoring of flag setting code
2010-11-15 01:31:16 +00:00
Jesse Vincent
36714d3b4a
astyle
2010-11-15 01:31:11 +00:00
Fiouz
f9d828a62c
Improved some comments
2010-11-14 23:21:48 +00:00
cketti
58ca9fe740
Changed external intent (e.g. Intent.ACTION_SEND_TO) handling code in MessageCompose
...
- extracted handling of external intents to a new method
- only allow mailto URI for ACTION_VIEW and ACTION_SENDTO (as documented by AOSP)
- allow additional recipients via "to" parameter in mailto URI
- removed check for allowed MIME type when adding attachments since we're accepting all MIME types anyway
- show CC and BCC text fields when one of those recipient types was set by the intent
- use MIME type specified in intent for attachments (if present and doesn't contain a "*")
2010-11-14 02:27:42 +00:00
Jesse Vincent
675651286b
Added the ability to completely wipe the localy cached messages of a syncced folder.
2010-11-14 00:49:25 +00:00
Jesse Vincent
32ea04a5b3
kill a temporary variable
2010-11-14 00:49:21 +00:00
Jesse Vincent
6a6c86d117
Kill a once-used temporary variable
2010-11-14 00:49:18 +00:00
Jesse Vincent
945d4d7c32
a slight cleanup for message deletioon policy logic.
2010-11-14 00:49:15 +00:00
Jesse Vincent
0eee80f08b
renamed deleteMessagesOlderThan to clearMessagesOlderThan to better
...
reflect that it just nukes local copies rather than the synced copies
2010-11-14 00:49:08 +00:00
Jesse Vincent
7d40596aa1
split apart "delete messages older than" for later reuse
2010-11-14 00:49:04 +00:00
Jesse Vincent
14055691a3
Merge branch 'mail-on-sd'
...
* mail-on-sd: (40 commits)
Added more comments to explain how the locking mecanism works for LocalStore
Fixed wrong method being called during experimental provider initialization (since provider isn't enabled, that didn't harm)
Add more comments about how the various StorageProviders work and how they're enabled
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
French localization for storage related settings
Remove unused SD card strings (replaced with storage indirection)
Merge mail-on-sd branch from trunk
Reset mail service on storage mount (even if no account uses the storage, to be improved)
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
Migraion -> Migration
move the Storage location preference into preferences rather than the wizard.
Made LocalStore log less verbose Added @Override compile checks
Added ACTION_SHUTDOWN broadcast receiver to properly initiate shutdown sequence (not yet implemented) and cancel any scheduled Intent
Be more consistent about which SQLiteDatabase variable is used (from instance variable to argument variable) to make code more refactoring-friendly (class is already big, code extraction should be easier if not referencing the instance variable).
Added transaction timing logging
Factorised storage lock/transaction handling code for regular operations.
Use DB transactions to batch modifications (makes code more robust / could improve performances)
Merge mail-on-sd branch from trunk
Update issue 888 Added DB close on unmount / DB open on mount
Update issue 888 Back to account list when underlying storage not available/unmounting in MessageView / MessageList
...
2010-11-13 21:40:56 +00:00
Jesse Vincent
76e26607b8
Added a first pass implementation of being able to resend a message.
2010-11-13 03:09:32 +00:00
Jesse Vincent
3779237eb8
remove a special flag in FolderInfoHolder that we only use twice and
...
appear to initialize unreliably in favor of some simple checks.
2010-11-13 03:09:27 +00:00
Jesse Vincent
27d3e6312b
Refactor FolderInfoHolder to remove copy-paste code
2010-11-13 03:09:23 +00:00
Jesse Vincent
a8de2d0000
astyle
2010-11-13 01:47:08 +00:00
Jesse Vincent
a551dc8dff
Replace the old "record a message in K9 Errors and give up"
...
failed-message scheme with an actual android notification that opens the
outbox
2010-11-13 01:47:02 +00:00
Jesse Vincent
e964c7ba84
Tell the user about a failed delivery the first (any) time it fails
2010-11-13 01:46:59 +00:00
Jesse Vincent
4fb338d8a9
Disable "don't send messages in the outbox if they're flagged" - users
...
really don't like their mail just getting stuck
2010-11-13 01:46:55 +00:00
Jesse Vincent
ecf793ea26
remove an unused constant
2010-11-13 01:46:46 +00:00
Jesse Vincent
24b018a812
replace a trivial one-line method that was called twice with its body
2010-11-13 01:46:41 +00:00
Jesse Vincent
f874f0f9d3
replace a single-use single-line private method with its body in the one place it was used
2010-11-13 01:46:36 +00:00
Jesse Vincent
0f4366aa77
in the account list, when trying to check mail, also try to send mail
2010-11-13 01:46:31 +00:00
Jesse Vincent
af5f78928c
Add a "fetch all messages" visible limit
2010-11-12 23:41:43 +00:00
Jesse Vincent
a130f56bf4
when changing an account's visible limits, try to reset folder visible
...
limits as soon as we save the setting
2010-11-12 23:41:38 +00:00
Jesse Vincent
9f695eb4ed
extract the per-account "reset visible limits" method
2010-11-12 23:41:33 +00:00
Jesse Vincent
478bd876ee
There's no reason the getSubject accessor should throw a
...
MessagingException on LocalMessage
2010-11-12 22:27:32 +00:00
Jesse Vincent
b2e5d7afc5
extract our our folder-count updating code from the flag setting code
2010-11-12 21:38:11 +00:00
Jesse Vincent
eb908b67a3
try to clean up our message count update logic in flagging
2010-11-12 21:38:06 +00:00
Jesse Vincent
2d8a8998b0
factor out a "destroy" method for local messages
2010-11-12 21:38:02 +00:00
Jesse Vincent
1292a10ac2
When a message has been deleted on the server and we want to sync remote
...
deletions, we don't care whether it was flagged as deleted ocally - we definitely
want to destroy it.
2010-11-12 21:37:58 +00:00
Jesse Vincent
33fd42e766
If we DELETE a message from the database, don't then try to UPDATE it
2010-11-12 21:37:54 +00:00
Jesse Vincent
52e2a437fb
Imported a variant of http://code.google.com/p/android-color-picker/ into k-9
...
- Ported to the ColorPickerDialog API
- Translated the API and Internals from Indonesian to English
- Moved to use K-9 strings rather than custom strings.
In an ideal world, we should use ambilwarna as an android library
project, like it was intended.
2010-11-08 02:21:32 +00:00
Jesse Vincent
d45081abaa
Animate the batch-operations toolbar (Imported from AOSP)
2010-11-07 19:40:42 +00:00
Jesse Vincent
6528b2d775
lift up font setting code to be with the rest of the initial messagelist item setting code
2010-11-07 00:30:17 +00:00
Jesse Vincent
69675bc935
Now that we can show bigger previews, actually generate a bigger preview
2010-11-05 04:23:09 +00:00
Jesse Vincent
a78776a9ee
Only look at the first 8k of a message when calculating message previews
2010-11-05 04:23:04 +00:00
Jesse Vincent
bfc24a58a0
Improvements to message preview heuristics
2010-11-05 03:55:24 +00:00
Jesse Vincent
9d69875246
Add a new preference to let users select how many lines of message
...
preview show in message-preview mode.
2010-11-05 02:59:26 +00:00
Jesse Vincent
d0e85ce43a
astyle
2010-11-05 02:59:21 +00:00
Jesse Vincent
602099cfd3
Be more careful about deleting messages from the MessageListAdapter -
...
don't do it from something that's not the UI thread
2010-11-05 01:16:35 +00:00
Marcus Wolschon
4aba667a4e
fix for "http:/"-links in plaintext -emails. (add http:// is a link has no schema)
2010-11-04 13:35:39 +00:00
cketti
5b88a99de0
Got rid of some compiler warnings.
2010-11-04 03:11:34 +00:00
Jesse Vincent
fb55aa5bfb
Fix an extra paren
2010-11-03 00:48:18 +00:00
Jesse Vincent
b9999878df
We care about eclair MR1, not eclair
2010-11-03 00:44:07 +00:00
Jesse Vincent
9c7e3bcc26
Guard against null content from html parts on reply/forward, which was
...
causing a bunch of NPEs on the market.
2010-10-31 17:42:03 +00:00
cketti
7f396e29a0
Match beginning of words when searching for contacts in Android 1.5/1.6 (e.g. "Doe" will find "Doe, John" and "John Doe")
...
Fixes issue 1354
2010-10-30 20:53:56 +00:00
cketti
0add1f97c0
Mark contacts as contacted when a mail is sent to them.
...
Fixes issue 2522
2010-10-30 20:35:49 +00:00
Jesse Vincent
7db384fc08
Use a more backward compatible os version check, since the "current"
...
best practice is incompatible with 1.5
2010-10-29 22:35:27 +00:00
Jesse Vincent
e0d6a55d06
SINGLE_COLUMN layouts cause Android 1.0-2.1 to segfault.
2010-10-29 22:35:19 +00:00
Jesse Vincent
b749a198a7
get to: contacts working right.
2010-10-29 22:35:11 +00:00
Jesse Vincent
c5cf9e5c8c
message_to_label and message_to_fmt were used from places that weren't
...
their original sources. rename them to lie less.
2010-10-29 22:34:59 +00:00
Fiouz
d28a85de5b
Update issue 2270
...
Status: Fixed
Gracefully ignore RejectedExecutionException on service shutdown (there's little we can do about being shut down)
2010-10-29 19:55:04 +00:00
Fiouz
be6ab18091
Update issue 2537
...
Try to gracefully handle account DB corruption by deleting file on open exception
2010-10-28 19:16:55 +00:00
Fiouz
50c3751421
Display "Account settings" title instead of "General settings" when opening account settings (doesn't seem to be affected by user chosen language though)
2010-10-28 19:07:30 +00:00
Marcus Wolschon
b723769e65
translated "unable to connect".
2010-10-28 14:37:48 +00:00
Jesse Vincent
6704279042
redo our messagelist sigil code to not break sender colorization
2010-10-25 03:21:08 +00:00
Jesse Vincent
724169e982
astyle
2010-10-25 03:20:03 +00:00
Jesse Vincent
ddccd11ef7
Try to send pending messages whenever we refresh pushers. should help
...
with "stuck" unsent messages on push-only accounts
2010-10-25 03:19:43 +00:00
Jesse Vincent
f6f9d35430
unify two codepaths that sent unsent messages, one of them without a notification
2010-10-25 03:19:19 +00:00
Jesse Vincent
968fb8c508
add a variant of sendPendingMessages that will send pending messages in all accounts
2010-10-25 03:18:51 +00:00
Jesse Vincent
1d6caa5c0a
Never show an undismissable "new email" notification for a null account (like used to happen during setup)
2010-10-24 02:01:13 +00:00
Jesse Vincent
c216f42eb3
Exchange authenticaton and setup overhaul from Kris Wong
2010-10-24 01:03:29 +00:00
Jesse Vincent
07adaaee4d
Applied WebDavStore_cleanup.diff to remove dead code in the WebDav store from Kris Wong <wongk@seapine.com>
2010-10-24 01:02:46 +00:00
Jesse Vincent
62caa5ce76
Experimental change - ask android to try to make columns no wider than
...
the viewport. This change should NOT be backported to 3.2, but I'd like
folks to try it with real email.
2010-10-23 18:50:54 +00:00
Jesse Vincent
43cb54594b
Push the webview's renderpriority from NORMAL to HIGH - it's cargo-cult
...
performance improvement, but it certainly doesn't hurt
2010-10-23 18:50:24 +00:00
Jesse Vincent
983d7ad48f
The "viewport" hinting we used to try to better fit messages by default
...
made android zooming incredibly unreliable. Now it's only somewhat
unreliable.
2010-10-23 18:50:10 +00:00
Jesse Vincent
4ea6c1603b
We've been seeing a lot of FCs on htmlifcation of large messages due to
...
running out of memory during our heavy HTMLification. Try to be a bit
lighter on the poor RAM if a plain text message is big.
2010-10-23 17:33:08 +00:00
Jesse Vincent
524dfb348a
Updated MIME Type list with http://www.stdicon.com/mimetypes
2010-10-23 16:28:18 +00:00
Jesse Vincent
105df4c61a
It turns out that not every android release has a good extension to
...
mimetype mapping. restore our previous hardcoded mime database as a
fallback
2010-10-23 16:28:07 +00:00
Jesse Vincent
fb059a8138
Fix for NPE when changing the identity
...
Fixes issue 2506. Patch from jca02266
2010-10-23 15:26:50 +00:00
Jesse Vincent
96f1d9eadf
Fix phantom messages in unified inbox.
2010-10-23 15:19:56 +00:00
Jesse Vincent
bc2127c84a
added a synchronous variant of searchLocalMessages
2010-10-23 15:19:47 +00:00
Jesse Vincent
64c102dd14
notification that the dataset changed needs to happen on the UI thread.
2010-10-21 20:49:48 +00:00
Jesse Vincent
48f2885cfc
When returning from a messageview to a messagelist do our listview
...
updates on a thread rather than on the main ui thread. it results
in the list blinking with old data, but that's still a better user
experience than "frozen"
2010-10-21 20:49:36 +00:00
Jesse Vincent
e8756af4f1
astyle
2010-10-21 20:49:20 +00:00
Jesse Vincent
2a4792eb60
update a comment about an uncommon code path
2010-10-21 20:49:05 +00:00
Jesse Vincent
8d9c074a27
Add gmail-style "to me" and "cc me" indicators in messagelist
2010-10-21 20:48:45 +00:00
Jesse Vincent
d02ddda19b
When doing a message search, break it into "first 10" and "more" -
...
because a long SQL query takes more time before starting to return
results, K-9 was increasingly slow on large folders.
Doing two searches may take marginally more time but starts getting
results back to the UI much faster.
2010-10-21 20:48:28 +00:00
Jesse Vincent
e05784d41d
Running heavy operations on the UI thread makes K-9's UI slow and
...
freezy. addOrUpdateMessages is very heavy. and very common.
2010-10-21 20:48:12 +00:00
Marcus Wolschon
0933fad9b3
Update issue 7031
...
http://code.google.com/p/android/issues/detail?id=7031
added removeDialog() for every dismissDialog()
2010-10-18 09:53:22 +00:00
Jesse Vincent
b2a08d969b
Revert "For the common case of "getMessage" where we actually have the object in"
...
This doesn't work on initial sync, since the comparisons fail and you're
left with duplicates in the displayed mailbox
This reverts commit fa1c88bec348d0132acc60a320626bf0ca1170ec.
2010-10-16 08:27:58 +00:00
Jesse Vincent
496677dad4
Calculate preview for html-only messages
...
Fixes 2465
2010-10-16 08:27:47 +00:00
cketti
742db2ac62
Cosmetic code changes
2010-10-13 20:56:44 +00:00
cketti
4be781a749
Fix NullPointerException when saving account settings for non-IMAP accounts.
...
Fixes issue 2454
2010-10-13 20:49:34 +00:00
Jesse Vincent
28c9dfdcce
Delay formatting of dates in messagelist until we actually need them
...
-- it turns out they're very expensive.
2010-10-13 10:53:08 +00:00
Jesse Vincent
4e53ee12b6
For the common case of "getMessage" where we actually have the object in
...
the list, use a less painful equality check than iteration.
This works because messageInfoHolders compare to each other using the
same key as message they contain.
2010-10-13 10:52:53 +00:00
Fiouz
9db44bf4a9
MessageProvider: making sure exposed cursor gets dereferenced on close (and closed on finalization) to prevent memory leak
2010-10-11 20:41:59 +00:00
Jesse Vincent
e8fd9683e6
Optimize the new return-to-listview code. (Avoid a bug where we do far
...
too much work on first open of a message list)
2010-10-11 19:47:41 +00:00
Jesse Vincent
d07aca3008
"Preferences" -> "Settings" for consistency
2010-10-11 14:54:23 +00:00
Jesse Vincent
c5d68fb49d
Add preferences to enable pinch-to-zoom and single-column layout for
...
messages
2010-10-11 14:54:15 +00:00
Jesse Vincent
5fc78b4219
astyle
2010-10-11 00:08:54 +00:00
Jesse Vincent
a683186f6e
move 3 IMAP preferences out of the "wizard" flow to an advanced page
...
where they belong
2010-10-11 00:08:47 +00:00
Jesse Vincent
28388b235e
move "saveAllHeaders" to the account preferences screen.
2010-10-11 00:08:39 +00:00