moparisthebest
/
k-9
mirror of https://github.com/moparisthebest/k-9
1
0
Fork 0
Code Issues Releases Wiki Activity
5,728 Commits 36 Branches 329 Tags 887 MiB
Commit Graph

302 Commits

Author SHA1 Message Date
Valentin CAULIER 3e84c20c9b Updating other classes to use new constructor and getters of 
MessageReference
 2015-03-21 11:12:13 +01:00
Dominik Schürmann 16f09611fe PGP: Introduce key preference per account for OpenPGP APIv7 2015-03-20 15:14:48 +01:00
Valentin CAULIER bf0333ba31 Beginning MessageReference update to immutable object 2015-03-16 16:29:42 +01:00
cketti ab964cf8af Merge branch 'pgp_mime_preparations' 2015-03-16 16:14:45 +01:00
cketti 54831fba73 Remove test for openpgp-api-library code 2015-03-16 16:05:25 +01:00
Dominik Schürmann e4cfd3c886 Update openpgp-api-library for APIv7 2015-03-16 14:29:12 +01:00
cketti f0e1b14b58 Merge pull request #567 
Move NetworkType to k9mail-library, use on StoreConfig
 2015-03-16 13:39:59 +01:00
cketti 494b16196d Rename AccountCreator.calculateDefaultDeletePolicy() 2015-03-16 13:28:11 +01:00
cketti 5f14e3b4e1 Use switch statement inside calculateDefaultDeletePolicy() 
With this - at least in theory  - the JIT compiler can produce better code
than is possible with the static HashMap.
 2015-03-16 13:26:44 +01:00
cketti f733cc38ba Merge pull request #566 
Rationalize default ports
 2015-03-16 13:15:43 +01:00
cketti 00528f5d24 Move throw statement outside of switch body 
This way static analysis can detect when we're missing a switch case.
 2015-03-16 13:11:01 +01:00
cketti 855da35f3a Code style fixes 2015-03-16 13:06:40 +01:00
cketti d528864a25 Merge branch '5.103_with_bugfixes' 
Make sure 5.105 can be found in master branch
 2015-03-14 12:28:20 +01:00
cketti 08beb212c2 Fix crashes when selecting messages in the message list 
Throughout the code we make the assumption that onPrepareActionMode() is
called right after starting the action mode. However, this is not the case on
Android 5.1.
With this change we call ActionMode.invalidate() right after starting the
action mode which causes onPrepareActionMode() to be invoked.
 2015-03-13 21:12:21 +01:00
cketti 42419fc4e5 Bump version to 5.104 2015-03-13 13:10:11 +01:00
cketti 20a1fa384c Prepare changelog for 5.104 2015-03-13 12:53:17 +01:00
cketti 9f2bbe9ae4 Add Serbian translation 2015-03-13 12:48:50 +01:00
cketti e0a249098b Update translations 2015-03-13 12:42:16 +01:00
Art O Cathain 110400a85b move NetworkType to k9mail-library, use on StoreConfig 2015-03-08 12:59:15 +00:00
Art O Cathain 520e327775 remove duplication 2015-03-08 11:26:54 +00:00
Art O Cathain 810d0cf6b4 Move default port and default TLS port to a single location 2015-03-08 11:05:53 +00:00
cketti 147db8cc5e Configure 'developer mode' via BuildConfig 2015-03-07 00:30:50 +01:00
cketti 2f832e5fa4 Merge pull request #562 from artbristol/art/tidy-check-settings-async-task 
Refactor to make code more readable
 2015-03-06 23:52:22 +01:00
cketti 46bac187d5 Merge pull request #557 from artbristol/art/account-creation-refactor-2 
Remove duplication, enum-ify String
 2015-03-06 23:47:46 +01:00
cketti 67404b1883 Merge pull request #553 
Remove redundant variable assignments
Minimize scope of local variables
 2015-03-06 23:13:54 +01:00
cketti abd2b20850 Minimize scope of local variables 2015-03-06 23:12:28 +01:00
cketti 29f7552c3a Merge pull request #548 
Rename Searchfield to SearchField
 2015-03-06 23:00:18 +01:00
cketti b826d4e98d Use imports for inner classes 2015-03-06 21:19:27 +01:00
cketti bf344dee5d Merge branch 'master' into pgp_mime_preparations 2015-03-03 00:33:45 +01:00
cketti 2a404b30d2 Small refactoring of MessageBuilder 2015-03-03 00:26:43 +01:00
cketti cb0a99281a Refactor IdentityHeaderBuilder to make it a bit more readable 2015-03-03 00:11:59 +01:00
cketti bc284584d1 Move code to build messages outside of MessageCompose 2015-03-02 23:52:35 +01:00
cketti 5330fe5b27 Extract code to parse a message header to its own class 2015-02-25 03:36:48 +01:00
Art O Cathain d0fa82269f review comments 2015-02-23 17:28:42 +00:00
cketti dd20ff5aa3 Merge pull request #561 
Reduce code duplication in AccountSetupAccountType
 2015-02-23 03:39:07 +01:00
cketti 737e0d2ac8 Minor code style fixes 2015-02-23 03:36:34 +01:00
cketti d443a6d4eb Add more tests 2015-02-23 02:58:16 +01:00
cketti a979accb54 Add helper methods to get more readable tests 2015-02-23 02:58:16 +01:00
cketti af491fdb41 Remove comments 2015-02-23 02:23:00 +01:00
cketti 084e7a1687 Change names of test methods 2015-02-23 02:22:10 +01:00
cketti 8fbb3edd1c Fix code style 2015-02-23 01:45:30 +01:00
Art O Cathain 5035e7e3d1 review comments, also use == in preference to equals for enums 2015-02-22 21:30:26 +00:00
Valentin CAULIER 23c01b0390 MessageReference class, method equals() unit tests 2015-02-22 21:11:13 +01:00
Art O Cathain a656a61c65 tidy method 2015-02-22 17:01:14 +00:00
Art O Cathain d5d42469b0 Avoid confusing reuse of local variables 2015-02-22 16:03:58 +00:00
Art O Cathain 492d65feed reduce duplication 2015-02-22 15:52:16 +00:00
cketti e7f706b78d Show new decrypt/verify error conditions in crypto header 2015-02-21 04:31:44 +01:00
cketti bcb668300f Refactor OpenPgpHeaderView for readability 2015-02-21 03:24:41 +01:00
cketti 6def0be158 Add helper methods to shorten code 2015-02-21 02:57:02 +01:00
cketti fd99c279e5 Remove "m" prefix of field names 2015-02-21 02:52:55 +01:00
cketti ab877453d9 Use enum instead of int constants 2015-02-21 02:50:47 +01:00
cketti d61ac959a9 Limit method/field accessibility 2015-02-21 02:39:34 +01:00
cketti ae258f5761 Remove unused method 2015-02-21 02:39:34 +01:00
cketti b40749547c Don't show parts we can't (yet) decrypt as attachments 2015-02-21 02:39:34 +01:00
cketti e5e4c29736 Save type of crypto part for later use 2015-02-21 02:39:34 +01:00
cketti 6f3f555986 Add support for new decrypt/verify error conditions 
We can decrypt or verify a message if it was only partly downloaded.
 2015-02-21 02:39:33 +01:00
cketti c6abb50d10 Refactor code to get smaller methods 2015-02-20 18:31:42 +01:00
Art O Cathain 1a706c3113 formatting 2015-02-18 19:48:17 +00:00
Art O Cathain 583a637d79 Remove duplication, enum-ify String 2015-02-18 19:42:33 +00:00
cketti d8448c3510 Only make http or https URIs trigger the "Show pictures" button 2015-02-17 23:42:26 +01:00
cketti ab8746ffe9 Hide side bar when not showing the crypto header view 2015-02-17 23:18:46 +01:00
cketti 132ede425b Make it easier to check if a crypto provider is configured 2015-02-17 20:17:34 +01:00
cketti cac1f1ca0d Do MessageTopView initialization in onFinishInflate() 2015-02-17 18:04:52 +01:00
cketti 160b9eb354 Do MessageContainerView initialization in onFinishInflate() 2015-02-17 17:42:28 +01:00
cketti f887348953 Set background color of message view in one place 2015-02-17 04:15:10 +01:00
cketti e15cda8504 Fix "Show pictures" button functionality 2015-02-17 03:54:13 +01:00
cketti 68147880ce Move "Show pictures" button into MessageTopView 
We can also get rid of the "Show message" and "Show attachments" buttons.
 2015-02-17 02:32:20 +01:00
cketti c64ae008c1 Code cleanup 2015-02-17 01:54:40 +01:00
cketti 6b52f41e2c Better name for method argument 2015-02-17 01:43:53 +01:00
cketti e16f8af667 Don't pass Fragment reference to MessageContainerView 2015-02-17 01:30:41 +01:00
cketti 15cb58fe42 Add placeholder for application ID to K9FileProvider 2015-02-17 00:58:03 +01:00
cketti 9659bee8c5 Merge branch 'master' into pgp_mime_preparations 2015-02-17 00:56:42 +01:00
cketti ebef8eccb9 Add missing placeholder for application ID 2015-02-17 00:45:36 +01:00
Art O Cathain ffb4507776 Enums instead of int/String constants (#547) 
simplify and add logging

simplify

use == for enum comparison to avoid type mistakes

enum name needs to match previous constant

simplify

Address review comments - formatting, and remove superfluous comment

Shorten DeletePolicy values since not used in settings strings; import enums to reduce clutter

fix whitespace

remove comment per review

address review comment

review comments

remove another superfluous qualification

Last changes
 2015-02-16 22:22:05 +00:00
cketti 24e6b39dc0 Stop using Intent.setClassName() 
Use the type-safe Intent constructor to reference internal classes.
 2015-02-16 22:44:55 +01:00
cketti 461778ed11 Merge branch 'configurable_application_id' 2015-02-16 21:53:44 +01:00
cketti 1301645387 Use different application ID for debug builds 
This way debug builds can be installed next to the release version.
 2015-02-16 21:45:04 +01:00
cketti ebeed31705 Fix search for non-default application ID 2015-02-16 21:38:16 +01:00
cketti d703ac9148 Revert substitution of "com.fsck.k9" in implementation details 
We don't need to change strings that are not exposed to the system/users.
 2015-02-16 21:02:52 +01:00
cketti 9f1ecf7220 Merge pull request #555 from BombTeam/UnusedImportsRemoval 
Remove unused import
 2015-02-16 19:47:38 +01:00
cketti b4900cc6af Merge pull request #551 from BombTeam/remove-redundant-cast 
Remove redundant casts
 2015-02-16 18:46:15 +01:00
cketti 62c2894fce Merge pull request #544 from BombTeam/StringGlitchCorrection 
Fix height of buttons in wizard screens
 2015-02-16 18:30:51 +01:00
Valentin CAULIER 80f8e4a81d Removing java.util.Arrays import 2015-02-16 17:37:15 +01:00
Levrifon 0d0b80f142 Added placeholder for application ID 2015-02-16 16:53:38 +01:00
Marine c4e202ecd9 remove redundant assignment to FolderSettings 
removed null affectation because it’s done automatically
 2015-02-16 15:31:03 +01:00
Marine 9bf546b33b removed redundant assignment to AccountSetupBasics 
removed null affectation because it’s done automatically
 2015-02-16 15:25:36 +01:00
Marine f5cac2c71f remove redundant cast Button to WelcomeMessage 
findViewById(R.id.next) and
findViewById(R.id.import_settings)
are Button so it’s redundant to cast it to Button
 2015-02-16 15:10:34 +01:00
Marine 63047e0ac6 remove redundant cast (Button) 
findViewById(R.id.pop) ,
findViewById(R.id.imap) and
findViewById(R.id.webdav)
are Button so it’s redundant to cast it to Button
 2015-02-16 15:03:11 +01:00
Marine 980d799087 Rename from Searchfield to SearchField 2015-02-16 14:07:41 +01:00
qvandekadsye 9b1a0b3614 Applying "match-parent" value to "next" buttons. 2015-02-16 13:48:31 +01:00
cketti aae71125c6 Merge pull request #523 
Make sure to keep font meta info on view recycling
 2015-02-15 17:43:11 +01:00
cketti 9df1a3ee80 Potentially avoid creating new Typeface instances 2015-02-15 17:38:10 +01:00
cketti ba1fc1305f Merge branch 'master' into pgp_mime_preparations 2015-02-14 05:10:15 +01:00
cketti 9c3cab2354 Don't show changelog dialog during UI tests 
This will hopefully make the UI tests more stable.
 2015-02-14 04:23:54 +01:00
qvandekadsye 5013f36ba4 re-correcting String glitch by changing layout-height attribute 2015-02-13 15:21:09 +01:00
Gabriel Burca 9ba2725ab1 Fixes issue 6703 
- onPrepareActionMode must be called before computeBatchDirection
  because computeBatchDirection ends up referencing mMarkAsRead /
  mMarkAsUnread and mFlag / mUnflag which could be null otherwise.
 2015-02-12 21:27:44 -06:00
cketti e0abcc3f67 Decouple MessageCryptoHelper from MessageList 2015-02-09 20:02:16 +01:00
cketti 5d3cdc2724 Remove unused variable 2015-02-09 19:44:33 +01:00
cketti bb3f84fda6 Move MessageCryptoAnnotations to upper level 2015-02-09 19:43:23 +01:00
cketti d301efea58 Move MessageCryptoHelper 2015-02-09 19:37:46 +01:00