71dbdf3417
Update issue 1623
...
Removed dependency from K9 to MessageProvider (and added ability for components to register themselve for being notified when K9 instance is ready)
Moved Intent broadcast code from MessageProvider to K9
Made query() easily extensible using strategy pattern, the discriminant still being the Uri path
2010-10-01 19:41:39 +00:00
01f961c058
Update issue 1623
...
Fixed severe design flaw where the message provider would accumulate messages, causing an OutOfMemoryError even when the message provider isn't explicitely invoked.
query() is now synchronized with message retrieval
2010-09-26 16:01:41 +00:00
2a39cd5206
Fixes issue 2282
...
Added an option whether the registered name color is change or not
Avoid "Connection error" when MessageView is opened. The contacts.getName() might return null.
2010-09-26 14:39:52 +00:00
a2fe3bda34
When a new mail alert is alerting about a specific mailbox rather than
...
inbox, default to having it open that mailbox. Patch from thardie
2010-09-22 15:43:43 +00:00
b6124fb397
deleteHeaders deleted message headers by id when it should have been
...
deleting by message_id. I believe this was our last serious leak in
our flash storage
deleting message headers was....just wrong. we've fixed other similar
bugs inherited from android 1.0 before.
2010-09-22 02:46:20 +00:00
4cb2d52c9c
Refactored message sorting code by extracting the sort code from the sorted object (this was a bad design, worsened by the MessageProvider patch). Ideally, new Comparator classes should get promoted to top-level classes and not be enclosed in MessageList.
...
Subject stripper backported from issue258 branch (Utility.java)
The result is a cleaner MessageInfoHolder class.
2010-09-21 22:12:45 +00:00
9ef306413b
MessagingController not propagating provided listener
2010-09-20 11:47:02 +00:00
0990609727
Don't forget to remove some Preference entires when deleting Account
2010-09-19 21:10:56 +00:00
e28e6d8817
Added ability to disable LED notification for new messages (new account setting)
...
Extracted notification related settings in separate class (see Issue 2268)
Update issue 371
Status: Fixed
Added ability to disable LED notification for new messages
2010-09-19 20:54:43 +00:00
e16a79d08c
Javadoc comment
2010-09-12 06:11:08 +00:00
c8a5de7abd
Intent.ACTION_SENDTO.equals(action) was tested twice in the same if/else if statement causing the last one to never match, removed the first one in order to properly enable intent-based activity population
...
Fixes issue 2110
"Intent.ACTION_SENDTO.equals(action)" removed from first condition
See r1712
2010-09-12 05:26:13 +00:00
bbd664ad3c
Optimization: don't use bytes and related byte/char conversion when we're actually working on string only
2010-09-11 11:20:50 +00:00
8cf2655dd8
Reverted r2332 and r2333 because the cause of the problem reported in issue 2078 seems to be different than initially thought.
2010-09-09 23:52:06 +00:00
5aa56e1569
Code cleaning: remove unused imports/variables
2010-09-04 06:57:25 +00:00
3291c585e8
Improve Volume navigation settings, fix a bug when a list view is in
...
touch mode.
Patch by fiouzy.
2010-09-03 21:41:32 +00:00
de31886f44
Fixes issue 2230
...
Owner: fiouzy
Synchronize access to designated list to prevent concurrency issue
2010-09-03 20:32:12 +00:00
a85ea2ee53
- Reworked the previous patch with suggestions by jessev to be as runtime/memory efficient as possible without being useless.
...
- Output debug message when invalid responses are encountered.
2010-09-03 15:32:25 +00:00
b9b15295cd
Added yet another work-around for an IMAP server implementation with a creative interpretation of the specification. Sanity check results returned for a SEARCH command.
...
Fixes issue 2078
2010-09-03 13:58:09 +00:00
9d9e669d65
Code cleanup
2010-09-03 02:15:57 +00:00
b44bed2596
Fix NullPointerException
...
Fixes issue 2261
2010-09-03 01:16:41 +00:00
0c27a1ab0e
Avoid division by zero.
...
Fixes issue 2259
2010-09-03 00:56:19 +00:00
525d9a2ef9
Don't choke on malformed UIDL responses (POP3).
...
Fixes issue 2252
2010-09-02 23:59:20 +00:00
6573f27cec
do our messagelist updates from sync on the ui thread rather than the
...
sync thread. copy the incoming message list to deal with concurrent
access issues. Patch by cketti++
2010-09-02 03:45:16 +00:00
08f10f1fe5
Issue 1711 (don't display subject when phone locked)
...
Modified code so that subject is still visible after unlock when notification bar is expanded
2010-09-01 22:37:11 +00:00
f43db5235c
Fixes issue 1711
...
Owner: fiouzy
Don't display message subject in notification bar when keyguard is active (system locked)
2010-09-01 22:26:36 +00:00
f21d86d8ce
Fixes issue 1945. Toast debug location when enabling debug logging.
2010-09-01 21:27:11 +00:00
9b285ae3fc
Fixes issue 939
...
Heavily inspired from Gmail implementation. Currently implemented only for MessageView delete operation.
2010-09-01 20:59:09 +00:00
842a5ee123
Update issue 2144
...
Use setSpan() instead of Html.fromHtml()
Should clear cached name of contacts at MessageView#onClickSender().
2010-09-01 01:35:20 +00:00
a83fd2d548
Kill an insanely chatty log message
2010-08-31 05:01:26 +00:00
a1496bd839
Revert the clever runonuithread hack from the previous commit, as it
...
leads to concurrent modification exceptions. "oops" :/
2010-08-31 04:29:56 +00:00
7030967fa7
astyle
2010-08-31 03:58:33 +00:00
7bd8fc3599
When we sync messages and are displaying a messagelist, do the listview
...
updates on the UI thread rather than the sync thread. This is a huge
performance boost (based on simple empirical testing) for initial syncs
as we now do more work as we add messages to message lists
2010-08-31 03:57:02 +00:00
db1b86a296
Better visibility toggling as k-9 switches between messages in
...
MessageView
2010-08-31 03:55:30 +00:00
7f72da93e0
Added missing bit of achen.code's patch for issue 2211 (reply below quote)
2010-08-30 21:27:07 +00:00
b1074329e4
On the MessageList and the MessageView, prefer to use the display name registered in the Contacts rather than raw addresses.
...
Update issue 2144
2010-08-30 14:37:34 +00:00
e5c4f35737
Correct loading the alternated font size preferences.
2010-08-30 14:14:43 +00:00
4bf233fba5
next and previous were reversed from K-9's standard interpretation of
...
them in the previous patch to add volume button navigation
2010-08-30 03:05:41 +00:00
12eb866370
Remove a temporary variable
2010-08-30 02:16:38 +00:00
65f0d22355
Add Volume button navigation in MessageView, MessageList and all
...
K9ListActivity subclasses.
The MessageView code is a patch from paulkilroy@gmail.com .
Fixes Issue 2112
2010-08-30 02:16:20 +00:00
0f1a1baa89
Add a preference to use volume up / volume down to navigate items.
...
From a patch by paul.kilroy@gmail.com . Partial resolution of Issue 2112
2010-08-30 02:15:59 +00:00
be8ac83198
A first pass at letting users choose not to top-post their message
...
replies. Code By achen.code@gmail.com
Fixes Issue 2262
2010-08-30 00:00:34 +00:00
6e2c5be84c
simplify a boolean in isMoveCapable
2010-08-29 23:40:14 +00:00
1f399f5904
Simplify a boolean conditional
2010-08-29 23:40:00 +00:00
7d2804549e
Remove redundant "return" statements from the end of void methods (with
...
help from intellij)
2010-08-29 23:39:45 +00:00
4f0bce1569
Simplify many, many boolean conditions with help from IntelliJ
2010-08-29 23:39:26 +00:00
3d27cf220a
Removed some code/string duplication.
2010-08-29 18:46:51 +00:00
89dcc3646b
Database version bump to clear bogus cached attachments
2010-08-29 16:58:04 +00:00
6031862bad
Before we delete messages earlier than the earliest acceptable date, make sure we also delete their attachments.
2010-08-29 16:57:57 +00:00
fe62812ff2
Delete the attachments from disk before we delete them from the database, so we know what to delete.
2010-08-29 16:57:49 +00:00
994ed6653c
simplify some of our flagging logic and remove duplication using ternary operators
2010-08-29 16:57:40 +00:00
6d38c1c71a
Comments to better explain what's really going on on delete of messages
2010-08-29 16:57:31 +00:00
a5b7aa97dd
typo fix
2010-08-29 16:57:24 +00:00
e0447e32cc
astyle
2010-08-29 16:57:13 +00:00
7300aca2b8
Remove a call to deleteHeaders since headers are deleted implicitly by
...
an SQLite trigger.
Call our new variant of deleteAttachments() to avoid an extra lookup
2010-08-29 16:57:02 +00:00
31613e15c7
extract the method for "delete a message" from the "Set flags" method
2010-08-29 16:56:54 +00:00
54a4c84afa
Split out deleteAttachment to avoid an extra SQL call if we can.
2010-08-29 16:56:45 +00:00
38c31db8f6
Don't open a connection to the server if the protocol doesn't support flags and the flag to be changed isn't the deleted flag. This avoids unnecessary connections to POP3 servers.
...
Fixes issue 2046
2010-08-28 21:15:23 +00:00
015666b657
Fixed issue 2174
...
When selecting one of the five vibrate patterns or the number of repetitions, we should demonstrate to the user what the vibrate pattern feels like. (Thanks to achen.code)
use the ListPreference instead of the EditTextPreference to set vibrate times.
2010-08-28 14:00:34 +00:00
41ebeb3498
Don't show K9mail-errors as move/copy destination folder.
...
Fixes issue 2219
2010-08-27 01:02:29 +00:00
a93da0ed80
decoupled PgpData from CryptoProvider, moved the crypto provider into Account
2010-08-22 09:51:17 +00:00
df0ae4e4bf
Update Issue 2168
...
Respect "Return to list after delete" after pressing on "Archive", "Move", or "Spam" button.
TODO: Change strings to reflect this change (e.g. "Return to list after move/delete")
2010-08-19 03:14:27 +00:00
90ee194d0f
Fixes issue 387
...
Applied patch by achen.code (thanks!) to word wrap the quoted text on replies.
2010-08-19 02:49:13 +00:00
00d30f1b8a
NullPointerException and TODO-Marker on a strange code-line
2010-08-18 14:27:39 +00:00
726b472330
set context before using it
2010-08-18 14:13:37 +00:00
0b62640eac
Provisional initial commit of MessagingProvider code by
...
stephane.lajeunesse and koxx33
We're going to try it out in the 3.1 dev series. if it ends up looking
good, it'll be in 3.2
2010-08-18 02:49:13 +00:00
ff5024eaec
astyle
2010-08-18 02:48:55 +00:00
86dc82f916
Merge branch 'ideal-screenreader'
...
* ideal-screenreader:
The IDEAL Group have joined the K-9 dogwalkers and submitted their code to be part of K-9!
Initial import of the Ideal K-9 branch which adds support for screenreaders.
2010-08-18 02:01:10 +00:00
8832933a60
It turns out that if you're only fetching the bodystructure, the mime4j
...
parser can't parse the message.
2010-08-17 04:21:22 +00:00
02aad5945a
Added null pointer check.
...
See issue 2154
2010-08-16 19:34:48 +00:00
ba95150a31
Use IP address for SMTP EHLO if hostname contains invalid characters, e.g. underscore.
...
Fixes issue 2143
2010-08-15 19:26:44 +00:00
7964c34dbd
Fixes issue 2145
...
Cannot show the emoji icon on Android 1.6 at least. Replaced all "< img" to "<img".
2010-08-15 14:52:59 +00:00
da90792fa7
Don't call MimeUtility.unfoldAndDecode() on the message body when scanning for external image references. Also cleaned up the code a bit.
2010-08-15 04:05:39 +00:00
73c3872dd0
Improve our display of inline images in HTML mail to not also offer
...
themselves up for download.
To do so, we need to start storing the original content-id and
content-disposition for attachments - this includes a database upgrade.
Based on a patch from @achen.code
2010-08-15 02:37:06 +00:00
95fd605b0e
default account setting cryptoApp to APG
2010-08-14 19:30:37 +00:00
0e4c1dfacb
Added helper class to access contacts. Uses the old contacts API for SDK/API 3+4 devices and the new API for SDK/API 5+ devices.
...
All places that accessed the contacts have been updated to use this helper class.
2010-08-14 13:59:33 +00:00
0eb342ef5a
Code cleanup (Removed unused imports, added @Override annotations)
2010-08-13 14:06:13 +00:00
97001b6edb
filter on folder-selection
2010-08-13 06:37:00 +00:00
b839866e17
removed some unused APG constants, added an APG Intent API version to be sent along with all Intents
2010-08-12 17:39:50 +00:00
1e67fc4cde
Update issue 1290
...
Update issue 1916
Added support for country/region specific locales
2010-08-12 11:03:19 +00:00
a0238904b6
Update our emoji implementation to support docomo, softbank and kddi
...
(with the exception of 3 kddi glyphs that overlap with softbank).
As of this commit, emoji sent by iPhone users are visible in K-9
2010-08-12 02:22:35 +00:00
d123aa2a39
Add a hook for hinting charset conversions to Java, since Android's java
...
doesn't know about all conversions.
2010-08-12 02:22:25 +00:00
54633a4e16
Improvements to "more from this sender" - hopefully this should search
...
only on actual addresses, not their local parts.
2010-08-12 02:22:08 +00:00
ece68bae5d
Off-by-one error in the recent IMAP fetch work :/
2010-08-12 02:21:56 +00:00
de16b21124
Add debug logging when K-9 doesn't enable push because the user has
...
configured push to be off.
2010-08-11 03:36:49 +00:00
0229d8a1fe
Implement windowing for IMAP UID FETCH
...
Our previous implementation of UID FETCH didn't ever take into account
maximum command line lengths. When fetching, say 800 messages from a
GMail IMAP server, we could easily overflow the max line length leading
to a fetch that didn't get all the messages we wanted to and was
truncated before the description of which fields we want. That caused
K-9 to fetch complete messages, exhaust memory and ultimately fail,
even when we were just trying to get message lengths.
An equivalent fix needs to be made to seach by UID.
2010-08-11 03:36:40 +00:00
9ebf16e3d9
Finish removing the ThreadPool / ExecutorService Left over from when the
...
code was actually in the view class
2010-08-10 04:29:18 +00:00
490ab6b8c0
Try harder to make message loading feel responsive and scroll correctly.
...
We're still not there.
2010-08-09 03:16:40 +00:00
a724df79d4
To date, "loadMessageForView" competed for threads in a thread pool with
...
all of our mail syncing code. This led to very choppy UI experience.
This change doesn't entirely fix message load lag, but the _worst case_
I see is now better than the best case I saw last week.
2010-08-08 23:49:27 +00:00
2e6a67c2a7
Better text filter for ChooseFolder (folder is displayed if search term is found anywhere in the folder name, not just at the beginning)
...
Heavily based on a patch provided by Marcus.Wolschon
Fixes issue 2098
2010-08-08 20:27:39 +00:00
1f725a2d5c
increment the new message count if the message is in a notifiable folder
...
and the account wants notifications. (even if we don't
notify for a message from ourselves, we DO increase the notification
count.)
2010-08-08 19:43:01 +00:00
ce9a84e8fd
Quick updates from a code review pass by cketti
2010-08-08 19:35:18 +00:00
d2e3061f20
Lift our initial unread counter up higher so that it happens before
...
called code starts resetting the unread count again.
2010-08-08 19:14:52 +00:00
06a3d5985b
Avoid allocating two temp variables on sync
2010-08-08 19:14:47 +00:00
f5a399f6c6
extract out "should we notify" from "notify";
...
rather than calculating the number of pre-existing new messages for this
sync twice, do it once, a bit earlier.
2010-08-08 18:50:31 +00:00
43fb202d43
Fixes issue 1522
...
Added option to automatically show images in message view (always, if sender is in contacts, never).
Patch by paulkilroy (thanks!)
Includes bugfix for the "Show pictures" on orientation change code introduced earlier.
2010-08-07 22:38:08 +00:00
9d45470b40
Fixes issue 1076
...
Remember "Show pictures" button state when changing orientation.
2010-08-07 21:37:57 +00:00
5c588992a0
Fixes Issue 2076
...
Remove german version of the "Re:" prefix when replying to messages. So instead of "Re: AW: subject" we get "Re: subject".
2010-08-07 19:25:47 +00:00
dfb8f9e0f2
Memory management optimisation: help garbage collection by avoiding repeated instantiations of immutable arrays (empty arrays of String, Message, Flag, Address)
2010-08-07 15:10:07 +00:00
54e0ad5ce0
added some comments to explain some cryptography-related classes and to-dos
2010-08-05 10:55:59 +00:00
11e28698e1
hide the decrypt signature layout in MessageView if no signature exists, fixes the wrong display of signatures from another message
2010-08-05 10:45:58 +00:00
380452355c
MessageListAdapter:
...
- Use of a single View.OnClickListener for all messages.
- Extracted method to bind message item views (from MessageInfoHolder to MessageViewHolder).
2010-08-03 07:46:31 +00:00
ad9c315cf4
No longer need to extend Handler since r1126: we're using Activity.runOnUiThread()
2010-08-03 06:09:39 +00:00
2a476dc92c
Additional @Override compile check
2010-08-03 05:46:35 +00:00
f15101420e
Revert "I like this idea, but it's not ready for 3.000"
...
This reverts commit f812a3485445c7db4024f84865aaa5d8e6b7b3a0.
(Now that 3.0 is branched, this can be on trunk again for further work)
2010-08-02 22:34:21 +00:00
58c5afc77b
I like this idea, but it's not ready for 3.000
...
Revert "It turns out that a big part of our perceptible message switching time"
This reverts commit 06f9bb5b7f3064e646b43148d188cec06cd14d11.
2010-08-02 22:32:57 +00:00
44cef83e0b
Use of constants for immutable empty arrays (prevent useless memory allocation)
2010-08-02 11:55:31 +00:00
d4695636f3
It turns out that a big part of our perceptible message switching time
...
was loading the "loading..." file into the WebView. Since it doesn't
take that long to load the real content, replacing the "Loading..." file
with "blank the view" seems to actually feel a heck of a lot faster.
2010-08-02 03:03:58 +00:00
f2729fc58b
Don't show "To: " if the only recipients were ccs and bccs.
2010-08-02 03:03:53 +00:00
cd6b64d88f
Experimental changes to tell WebView that the HTML versions of messages
...
we generate from ascii are "mobile-optimized"
2010-08-02 01:27:50 +00:00
d78e7a0d69
Switch from the incomplete (but compatible with java 1.3) mime4j charset
...
alias resolver to the core java nio version with a better charset
database;
rather than falling back to not showing the user a failing message, fall
back to showing the user the message as ascii -- it makes it possible
to get _something_ out of an unknown-charset message, rather than just a
"ha ha. no." error.
2010-08-02 01:27:46 +00:00
7fc921c0b7
astyle
2010-08-02 01:27:40 +00:00
a4381696f9
Support Emoji for DoCoMo.
...
Emoji icons are derived from http://start.typepad.jp/typecast/
2010-08-02 01:24:40 +00:00
3bbb6ae050
Don't display Archive/Spam batch operations when corresponding folders are unset
2010-07-30 09:58:26 +00:00
d8a73b195d
Factor out the decision about whether a part is "viewable" for purposes
...
of fetching ; remove broken "inline" check from the same.
2010-07-30 00:58:33 +00:00
0c67f1f4cf
Only ask for POP3 capabilities before authorization if TLS should be used. Always ask after authorization.
2010-07-30 00:58:22 +00:00
91e55f6fa1
Don't log POP3 passwords by default.
2010-07-30 00:53:46 +00:00
d8a757faaf
Try to avoid a bunch of reallocations as we grow the temporary output stream by defining its size if we can get it
2010-07-29 22:17:35 +00:00
134c0b23dd
Backport a bit of memory efficiency I'm not sure I believe from AOSP
2010-07-29 22:17:32 +00:00
0bb115ca42
Actually catch an OOM in getTextFromPart
...
Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages
2010-07-29 22:17:29 +00:00
c6aa505ffe
improve the method docs on getTextFromPart
...
Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages
2010-07-29 22:17:26 +00:00
4c1060ecae
Only show "save or discard" dialog before leaving the message compose activity if the message needs saving.
2010-07-28 23:17:46 +00:00
3d5fb524ef
set account setting crypto app to "APG" by default
2010-07-28 21:28:51 +00:00
5e30c3dab1
removed two extra lines from the merge in r2055
2010-07-28 12:10:08 +00:00
2ca76e3db0
Fix for Issue 1956
...
A race condition made the outgoing certificate being compared to the old
incoming mHost,
throwing an exception with an untrusted certificate dialogue to accept
or decline.
2010-07-27 18:59:41 +00:00
7a4d12b53b
Merge from apg-integration
2010-07-27 12:10:09 +00:00
bae8a9736d
Clean up some inverted logic
2010-07-27 01:28:03 +00:00
b1fb92034a
clean up some weird inverted logic (as recommended by intellij)
2010-07-27 01:27:54 +00:00
c541a07ed2
Don't fire off a notification about new mail before we finish
...
initializing an account.
2010-07-27 01:27:45 +00:00
766a115155
Remove URLs from message previews. Suggested by Kevin Falcone
2010-07-24 02:09:12 +00:00
19a06d39a1
With all the other performance work we've been doing, getting a message
...
into the messagelist is now much, much faster. Intentionally loading the
whole mailbox before we let the user interact with the list is
increasingly painful. A 250 message mailbox takes 2+ seconds to "unlock"
on a modern phone.
Consequently, this commit switches us _back_ to progressive loading of
mailboxes from the synchronous version.
Based on user feedback, we may or may not keep this for the production
release.
2010-07-22 04:17:13 +00:00
80e134c03c
astyle
2010-07-22 03:40:30 +00:00
eb21807384
Moving sendMessage and saveMessage into AsyncTasks to make the send/save
...
buttons much less janky
2010-07-22 03:40:22 +00:00
8182b8a8ee
Split out sendmessage and savemessage - the sendorsavemessage method
...
didn't actually have them sharing code.
2010-07-22 03:40:14 +00:00
338919a9a0
Merge remote branch 'remotes/issue814'
...
* remotes/issue814:
Changed the appearance of the ChooseAccount activity to better match the look of the account list.
svn:eol-style set to LF (UNIX style)
Update issue 814 Status: Started Cc: +fiouzy Reuse of res/layout/accounts_item.xml to match account list Automatically expand/scroll to Intent-presented account
- Patch provided by fiouzy (ability to choose identity from other accounts) - Modifications in MessageCompose by cketti (use MessageReference to replace mFolder and mSourceMessageUid)
Created branch for issue 814 (Feature to select account to send from in compose screen)
2010-07-22 03:15:28 +00:00
75b8487024
First bits of infrastructure for not showing HTML-mail inline images as
...
downloadable attachments
2010-07-19 06:13:41 +00:00
65e318a80e
mark thumbnails as .tmp files that should be explicitly gced on start.
2010-07-19 05:32:45 +00:00
7de3aeb740
Actually, clearing the tempdir from attachmentprovider stomps on our
...
binary download usage of the temp directory. Reverted!
2010-07-19 05:32:37 +00:00
f9a24cb123
astyle
2010-07-19 01:57:49 +00:00
a75bf8668e
K-9 wasn't properly clearing the thumbnail/tmpfile cache. We now
...
properly clear it up on start, which causes K-9 to leak less flash
memory AND
fixes the "Wrong thumbnail" bug.
2010-07-19 01:55:23 +00:00
f7032c4161
Android is growing up a bit. artificially limiting the user to
...
attachments of only 5MB is counter-productive, bump the artificial limit
to 128M
2010-07-19 01:55:09 +00:00
6ef923be91
After we download attachments, get rid of the "old" attachment views
2010-07-19 01:54:55 +00:00
2ee5b49cf2
When marking a message as read as we're opening it from the message
...
list, don't "bother" sorting the messagelist again before opening the
message, it adds a _bit_ of slowness when we don't need it and
we'll sort again when we get back to the message list.
2010-07-19 01:54:38 +00:00
0fcae025b2
per a bunch of complaints, it looks like my new notification counting
...
code was off-by-one
2010-07-19 01:54:23 +00:00
819692e025
refactor one of the versions of 'getAttachmentUri' in terms of one of
...
the others. less code == fewer chances to screw up
2010-07-19 01:54:09 +00:00
6d20c65778
remove the old "isdownloading" notification for the current message.
2010-07-19 01:53:49 +00:00
ad7839e46e
remove debugging statement
2010-07-19 01:53:30 +00:00
a63beda64b
Finish backing out the "sort by received date" patch until we get the
...
recieved-date support sorted out
2010-07-19 01:53:14 +00:00
111e6f5109
First pass at a "download the rest of this message" button
2010-07-19 01:52:59 +00:00
d0c24e23c7
simplify account loading code by caching Preferences.getPreferences()
2010-07-19 01:52:43 +00:00
7464a1527a
Convert for loops to "enhanced" syntax per SDK performance guidelines
...
(Automatic with Eclipse)
2010-07-19 01:52:18 +00:00
8f1d535630
make it possible to get to global settings from the folder list
2010-07-16 01:24:01 +00:00
b21120405e
Use a simple HashSet for our listener set since we don't need the
...
overhead of the CoWASet
2010-07-16 00:38:32 +00:00
19ca87a2d5
removed the initiation of "select text" via long press again
...
Update issue 662
We tried out the long press for a bit and deemed it too sensitive for general usage. It can cause problems with gestures and such, so I removed it again. I hope using the option menu is not too much overhead.
If you want to include it in your custom build or anything, then r 1976 and r1977 should be enough.
2010-07-15 21:35:57 +00:00
f492ee9d0b
back out the rest of my localDate changes for now due to user
...
complaints.
2010-07-15 03:47:45 +00:00
b8e82085f9
At the end of header sync reset the counts.
2010-07-15 03:42:20 +00:00
a58d91f7c7
astyle
2010-07-15 03:42:17 +00:00
d3cc1fdfdc
Rather than doing a full count of all the unread messages in each and
...
every folder for each message downloaded in a session, factor the
"unread messages" count out into the calling code. It's slightly less
clean, but a pretty huge performance gain.
Fixes issue 1443
2010-07-15 03:42:13 +00:00
1bea931ed0
since we're checking seen status within the notify method, (first thing,
...
even), we don't need to do it in the caller code.
2010-07-15 03:42:09 +00:00
ff62ae5c23
Don't construct a listenerset clone if we don't need to.
...
danapple++ suggested the optimization
2010-07-15 03:42:05 +00:00
08581f6538
isRing -> shouldRing so that the code reads sanely
2010-07-15 03:42:01 +00:00
cc71273c4b
remember which message was selected in MessageList in case the list changes while the dialog is up
...
Fixes issue 906
2010-07-14 18:39:57 +00:00
91599ae963
ignore gestures during text selection
...
Fixes issue 662
2010-07-14 18:20:10 +00:00
510e9acc83
added text selection via "long press" in MessageView, also giving a notification for when text selection starts
...
Update issue 662
Added the long press initiation of text selection. I also noticed we'll have to make sure text selection is not recognized as a gesture (or at least ignored as gesture).
2010-07-14 18:12:40 +00:00
ed86fc8371
First pass at better end-user visibility into what K-9 is doing when we
...
appear to "sit" while syncing headers.
2010-07-13 23:59:14 +00:00
49c0601390
cketti points out that I was cloning improperly.
...
(Also, reading the docs for add, I don't need to check existence first)
2010-07-13 21:54:11 +00:00
014b6c19c3
svn:eol-style=LF for src and XML resources
...
Fixes issue 1982
2010-07-13 21:49:28 +00:00
e17707330f
reduce lots and lots of code duplication when calling out to listeners.
2010-07-13 21:17:10 +00:00
986237d31f
factor common code out of downloadLargeMessages and
...
downloadSmallMessages (catching a missing condition in one)
2010-07-13 21:17:04 +00:00
70a1eef943
astyle
2010-07-13 21:16:56 +00:00
a85c83f696
Revert "When deciding whether a message is older than a certain date, we should"
...
This reverts commit 98cab91631692b55ba72231126f612d6b4d4d662.
As Dan rightly suspected, it made pop3 sad :/
2010-07-13 21:16:49 +00:00
8ab165ef31
Allow per-protocol configuration of which wire protocols are
...
debug-logged
2010-07-13 21:16:42 +00:00
eda64bf1e7
display the language choices in their native names, added a larger set of native language names, which will be reduced to the supported languages at runtime
...
Fixes issue 1290
This may be a bit much, but I hope it can make it a little bit easier to add a new language later on and have consistent ordering.
2010-07-13 14:24:21 +00:00
665efc1448
Work-around to be able to read messages with "charset=0". QUALCOMM Windows Eudora seems to send headers like this.
...
Fixes issue 1952
2010-07-12 19:45:59 +00:00
eb7289f97b
Reverted a part of r1872.
...
Should save draft when the home button is pressed.
2010-07-12 14:57:42 +00:00
49e5ad4963
More cosmetic changes (again no change in functionality)
2010-07-12 02:17:48 +00:00
173b36d04e
Removed unnecessary null pointer check.
2010-07-12 01:39:29 +00:00
f40a01b0d2
"Optimized" computeBatchDirection() to exit the loop once newState is set to true because it can never be changed to false again.
2010-07-12 01:09:47 +00:00
6fc14b9e07
Cosmetic changes to the code (no change in functionality)
2010-07-12 01:06:33 +00:00
e3cb9f4603
Synchronize iterator accesses to mHandler.messages to avoid ConcurrentModificationException in MessageList. Original analysis and patch was provided by fiouzy.
...
Fixes issue 1598
2010-07-11 22:01:11 +00:00
1485502d47
Add a comment about the reason for a recent commit
2010-07-11 19:40:48 +00:00
5a43acff2a
Rather than accidentally reusing a public API function name with a
...
different signature, give the private command to pull a count
from the remote imap store its own name
2010-07-11 15:41:20 +00:00
227ee95532
Disable the delete button after it's tapped (to try to prevent
...
accidental clicks)
2010-07-11 15:39:52 +00:00
5d514c2ace
extract out "setup message buttons on message display.
2010-07-11 15:39:41 +00:00
20e47991c3
astyle
2010-07-11 15:39:26 +00:00
73da009409
Hide the message header while flipping messages, rather than displaying
...
the "wrong" thing during load.
2010-07-11 15:31:31 +00:00
00199de3bb
Extract "disable buttons" on messageview and disable buttons before
...
shifting to the next message
2010-07-11 15:31:11 +00:00
0a848d6526
Make the "header" section addressable in messageView (for later hiding)
2010-07-11 15:30:53 +00:00
b3e6844e44
make the 'should we show animations' boolena actually 'showAnimations'
...
instead of isAnimations.
2010-07-11 15:30:40 +00:00
0c7d4825cc
Avoid NullPointerException when trying to move a message before it is fully loaded (in message view).
...
Fixes issue 1957
2010-07-11 14:57:00 +00:00
28d3967d0f
Fixes issue 305
...
Support Content-Id header to show inline images.
2010-07-11 13:44:16 +00:00
c359b2c6bf
Comment out redundant logging of IMAP commands
...
Each IMAP command was logged 3 times in normal operation. It seriously
clouds the logs and makes it much harder to read and debug ongoing
connections
2010-07-11 12:31:47 +00:00
7a543b45b1
Remove duplicate code between two message counting routines in ImapStore
2010-07-11 12:31:34 +00:00
9321a045d9
When counting remote unseen/flagged messages, don't window to only the
...
most recent 300 messages - Since we display this # to the user, the
"last 300" heuristic ends up confusing and _wrong_ on a regular basis.
2010-07-11 12:31:22 +00:00
ae339f1ac8
Add a per-account setting to choose how much of each message to download automatically.
2010-07-11 11:59:14 +00:00
e59987fdcb
Display an error message (instead of "null") if a message couldn't be decoded because of a missing charset.
...
See issue 1480 for a test case.
2010-07-11 01:28:08 +00:00
44f161fc7f
extract "fetch unsyncced messages" from downloadMessages
2010-07-10 17:10:24 +00:00
c2d9d0e15d
extract "sync local message flags" from downloadMessages
2010-07-10 16:42:54 +00:00
35b7fce087
factor out downloadSmallMessages from downloadMessages
2010-07-10 16:42:39 +00:00
9dc3f09068
factor "downloadLargeMessages" out of "downloadMessages"
2010-07-10 16:42:12 +00:00
ab8cdb3522
minor astyling
2010-07-10 16:41:48 +00:00
0f17fc4a83
Factor a bit of code out of a 400 line method. Still needs a lot more
...
outfactoring
2010-07-10 16:41:34 +00:00
4024cca2aa
Add a comment about the custom IMAP command Yahoo! needs to work right.
2010-07-10 16:41:22 +00:00
5aea9e7d9b
Remove duplicate code from error message generation
2010-07-10 16:41:07 +00:00
56217e8ad6
Debug message clarity fixes
2010-07-10 16:40:55 +00:00
61b25c8760
only store an internalDate if we actually get it from the server; If we
...
don't have an internaldate, use the sentdate for sorting comparisons.
2010-07-10 16:40:34 +00:00
52ff331771
When deciding whether a message is older than a certain date, we should
...
be prefering the date we can ~trust "Internal" to the date asserted by
the sender.
2010-07-10 16:40:13 +00:00
ee63564138
"ReceivedDate" was an unused concept. Its value was never set.
2010-07-10 16:40:00 +00:00
f2fe826fb3
make MessageList remember the last selected item
2010-07-09 11:12:32 +00:00
67b23fc797
added a setting for language, overriding the system locale settings
...
Update issue 1290
2010-07-09 00:27:47 +00:00
dbb4d6e21c
Now that we have internal_date on all messages, we should be using it
...
for sorting. This will prevent spam with ...less true dates from pushing
messages to the top of your list. Additionally, when downloading
messages from the server, they'll actually appear in the order they were
received - the existing behaviour really screwed up users who were
trying to triage mail as it came in.
2010-07-08 16:33:19 +00:00
fd234c2701
If we hit a race condition and download a message after it's already
...
been marked as suppressed, then don't actually save it locally
2010-07-08 15:49:26 +00:00
190b597a45
add Archive keyboard shortcut to MessageList, refs issue 3
2010-07-08 15:27:22 +00:00
365d82407a
Make "Settings" work in search folders.
...
Fixes issue 1844
2010-07-08 13:30:30 +00:00
8bc42639c4
Fix market-reported NullPointerException
...
Fixes issue 1660
2010-07-08 01:09:43 +00:00
1eb37c2031
Added menu option to select & copy text in the message view.
...
The standard ScrollView causes problems when selecting text (and the message is long enough so scrolling is possible). The newly introduced ToggleScrollView can be set to disable scrolling via touch gestures thus making copying multi-line text sections possible.
Fixes issue 662
2010-07-07 22:14:45 +00:00
76df04e949
make shortcuts honour the account setting for the startup folder even if changed after shortcut creation, based on cketti's patch, refs issue 1025
2010-07-07 18:31:16 +00:00
00a8f948eb
added launcher shortcuts to accounts, refs issue 1025
2010-07-07 16:17:13 +00:00
5d4073072f
use "http://" as baseUrl in WebView instead of "email://", refs issue 267
2010-07-07 10:54:50 +00:00
a826f33eb3
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi
...
--mode=java --indent-switches --indent=spaces=4 --convert-tabs
--unpad=paren
2010-07-06 10:29:26 +00:00
96b93f7327
minor coding style fixes
2010-07-05 18:06:30 +00:00
8752347b5f
merged archive-move-spam-buttons into trunk
2010-07-05 13:41:52 +00:00
42b0845522
Remember last selected folder for copy and move operations and scroll this folder into view on subsequent folder selections (for move and copy operations).
...
Fixes issue 1538
2010-07-04 23:29:57 +00:00
a5a1ae7d28
Fixes Issue 41
...
Should query whether saving the draft message or discarding when back button was pressed.
Suppress to save the draft message automatically when attaching any file.
2010-07-04 17:46:55 +00:00
24079b673d
some old code removed
2010-07-04 14:52:32 +00:00
03b28c8b68
Added account settings for "archive" and "spam" folders. See issue 3.
2010-07-04 13:48:06 +00:00
cdbcb188ec
Fixes Issue 1664
...
Correct thread safety on some member variables when doing null checks.
Explicitly check for mMessageCount == -1 and stop=true in idling loop.
However, the original error message "Message count = -1 for folder"
will still arise in some circumstances and is a valid error to
report.
2010-07-03 15:22:54 +00:00
318099082f
Fixes Issue 794
...
Implements new setting "Sync remote deletions" which is checked by
default. When unchecked, K-9 Mail will no longer remove messages from
local storage just because the message was removed from the server.
This functionality works for all account types. Messages will still
be removed from the local store in order to stay within the limit
imposed by the "Number of messages to display" setting.
2010-07-03 13:10:38 +00:00
45339457f8
Added preference to go to Integrated Inbox on application startup.
...
Fixes issue 1797
2010-07-03 00:26:35 +00:00
e8cb293e03
Fixes Issue 1887
...
Save/restore In-Reply-To/References headers on configuration change
2010-07-02 21:17:06 +00:00
dab0c9a97f
Fixes Issue 1914
...
Show To, Cc and From headers on the part of additional headers without fetching all headers.
2010-07-02 14:57:55 +00:00
3ee3fad3d6
Fixes Issue 1915
...
Added the vibrate pattern preference.
2010-07-02 14:47:01 +00:00
9d2276aa0a
Fixes Issue 1790
...
Refresh dialog "message" each time the dialog is raised.
2010-06-30 00:41:27 +00:00
3c146c5a7f
Fixes Issue 1832
...
If the message isn't worth showing immediately, it is not worth
saving!
(Don't save a message unless we get at least a non-null subject and
non-null sender during first pass sync.)
2010-06-30 00:16:59 +00:00
fc55c54db0
Fixes Issue 1875
...
Change initial value for maximum message age to -1 (unlimited) instead
of erroneous 10.
2010-06-28 02:51:47 +00:00
7adc168471
Added a null pointer check to protect from NullPointerExceptions.
...
See issue 1749
2010-06-21 18:17:10 +00:00
e485aa83c6
Fix for the abiltiy to hit "Back" out of global preferences after
...
switching away from K-9 and back again.
Fixes issue 1791
Patch by fiouzy@gmail.com
2010-06-21 14:39:22 +00:00
4a6b99b647
Fixed some warnings
2010-06-20 14:19:01 +00:00
d5f53a99e6
Removed comment
2010-06-20 14:11:16 +00:00
648e3bd829
Added option to specify the message quote prefix character/string (default ">"). Applied patch provided by fiouzy (Thanks!) with some small modifications.
...
Fixes issue 1830
2010-06-20 14:07:03 +00:00
7f625b5ef4
Added option to specify Reply-to address for an identity. Patch provided by fiouzy (Thanks!).
...
Fixes issue 1762
2010-06-20 12:48:22 +00:00
e529bed259
Added option to return to the message list after deleting a message in the message view activity. Patch provided by fiouzy (Thanks!)
...
Fixes issue 1634
2010-06-20 12:15:29 +00:00
a5c5aaa054
Better handling of cases where a special folder is set to INBOX (e.g. Sent folder = INBOX). Make sure we count unread messages and don't exclude the Inbox from notifications in this case.
...
Fixes issue 1817
2010-06-17 12:42:22 +00:00
6b5e9949d7
Show "From", "To", "Cc" headers in "raw" form when displaying all message headers.
...
Fixes issue 1805
2010-06-16 19:58:09 +00:00
4f7ab92985
Move to next/previous message in message view if a message was moved.
...
Fixes issue 1621.
2010-06-14 13:46:08 +00:00
8cb7f8f317
Fixes Issue 1763
...
Patch from jca02266 to use locale independent date formatter.
2010-06-11 12:56:01 +00:00
dcd83f243b
For post-2.8 - start at replacing text buttons with image buttons.
...
better images are desperately needed.
2010-06-10 03:37:23 +00:00
2aac012282
Folder.fetchPart() is called when it shouldn't be. Disabled the exception for now. See issue 1733
2010-06-09 19:44:35 +00:00
504f1b7e17
Fixed 1597
...
Switching "Touch-friendly view" option from message list view no longer causes NullPointerException / Force close
2010-06-09 02:45:28 +00:00
c3739bb43b
Fixes Issue 1755
...
r1789 has incorrect Issue (1411) mentioned.
2010-06-09 00:16:55 +00:00
6476281379
Fixes Issue 1411
...
Only automatically finish the FolderList Activity when actively
managing the back button.
2010-06-08 23:26:48 +00:00
Fiouz