Fixes from audit

git-svn-id: http://svn.code.sf.net/p/davmail/code/trunk@1472 3d1905a2-6b24-0410-a738-b14d5a86fcbd

src/java/davmail/AbstractServer.java

@@ -36,7 +36,7 @@ import java.security.KeyStore;
  * Generic abstract server common to SMTP and POP3 implementations
  */
 public abstract class AbstractServer extends Thread {
-	protected boolean nosslFlag = false; // will cause same behavior as before with unchanged config files
+	protected boolean nosslFlag; // will cause same behavior as before with unchanged config files
     private final int port;
     private ServerSocket serverSocket;
 

src/java/davmail/exchange/ews/BaseShape.java

@@ -21,6 +21,7 @@ package davmail.exchange.ews;
 /**
  * Item or folder base shape.
  */
+@SuppressWarnings({"UnusedDeclaration"})
 public final class BaseShape extends ElementOption {
     private BaseShape(String value) {
         super("t:BaseShape", value);

src/java/davmail/exchange/ews/ConflictResolution.java

@@ -21,6 +21,7 @@ package davmail.exchange.ews;
 /**
  * Item update conflict resolution
  */
+@SuppressWarnings({"JavaDoc"})
 public class ConflictResolution extends AttributeOption {
     private ConflictResolution(String value) {
         super("ConflictResolution", value);

src/java/davmail/exchange/ews/ContainmentComparison.java

@@ -21,7 +21,7 @@ package davmail.exchange.ews;
 /**
  * Contains comparison mode.
  */
-@SuppressWarnings({"UnusedDeclaration"})
+@SuppressWarnings({"UnusedDeclaration", "JavaDoc"})
 public class ContainmentComparison extends AttributeOption {
     private ContainmentComparison(String value) {
         super("ContainmentComparison", value);

src/java/davmail/exchange/ews/ContainmentMode.java

@@ -21,7 +21,7 @@ package davmail.exchange.ews;
 /**
  * Contains search mode.
  */
-@SuppressWarnings({"UnusedDeclaration"})
+@SuppressWarnings({"UnusedDeclaration", "JavaDoc"})
 public class ContainmentMode extends AttributeOption {
     private ContainmentMode(String value) {
         super("ContainmentMode", value);

src/java/davmail/exchange/ews/DeleteType.java

@@ -21,6 +21,7 @@ package davmail.exchange.ews;
 /**
  * DeleteItem disposal type.
  */
+@SuppressWarnings({"JavaDoc"})
 public class DeleteType extends AttributeOption {
     private DeleteType(String value) {
         super("DeleteType", value);

src/java/davmail/exchange/ews/Disposal.java

@@ -21,6 +21,7 @@ package davmail.exchange.ews;
 /**
  * Disposal.
  */
+@SuppressWarnings({"JavaDoc"})
 public class Disposal extends AttributeOption {
     private Disposal(String value) {
         super("DeleteType", value);

src/java/davmail/exchange/ews/EWSMethod.java

@@ -431,7 +431,7 @@ public abstract class EWSMethod extends PostMethod {
         protected List<FieldUpdate> fieldUpdates;
         protected List<FileAttachment> attachments;
         protected List<Attendee> attendees;
-        protected List<String> fieldNames = new ArrayList<String>();
+        protected final List<String> fieldNames = new ArrayList<String>();
 
         @Override
         public String toString() {

src/java/davmail/exchange/ews/GetUserAvailabilityMethod.java

@@ -29,11 +29,11 @@ import java.io.Writer;
  * GetUserAvailability method.
  */
 public class GetUserAvailabilityMethod extends EWSMethod {
-    protected String attendee;
-    protected String start;
-    protected String end;
+    protected final String attendee;
+    protected final String start;
+    protected final String end;
     protected String mergedFreeBusy;
-    protected int interval;
+    protected final int interval;
 
     /**
      * Build EWS method
@@ -92,7 +92,7 @@ public class GetUserAvailabilityMethod extends EWSMethod {
         writer.write(end);
         writer.write("</t:EndTime>" +
                 "</t:TimeWindow>" +
-                "<t:MergedFreeBusyIntervalInMinutes>60</t:MergedFreeBusyIntervalInMinutes>" +
+                "<t:MergedFreeBusyIntervalInMinutes>"+interval+"</t:MergedFreeBusyIntervalInMinutes>" +
                 "<t:RequestedView>MergedOnly</t:RequestedView>" +
                 "</t:FreeBusyViewOptions>");
     }

src/java/davmail/exchange/ews/IndexedFieldUpdate.java

@@ -27,8 +27,8 @@ import java.util.Set;
  * Field update with multiple values.
  */
 public class IndexedFieldUpdate extends FieldUpdate {
-    Set<FieldUpdate> updates = new HashSet<FieldUpdate>();
-    protected String collectionName;
+    final Set<FieldUpdate> updates = new HashSet<FieldUpdate>();
+    protected final String collectionName;
 
     public IndexedFieldUpdate(String collectionName) {
         this.collectionName = collectionName;

src/java/davmail/exchange/ews/MessageDisposition.java

@@ -21,7 +21,7 @@ package davmail.exchange.ews;
 /**
  * MessageDisposition flag.
  */
-@SuppressWarnings({"JavaDoc"})
+@SuppressWarnings({"JavaDoc", "UnusedDeclaration"})
 public class MessageDisposition extends AttributeOption {
 
     private MessageDisposition(String value) {

src/java/davmail/exchange/ews/ResolveNamesMethod.java

@@ -113,6 +113,7 @@ public class ResolveNamesMethod extends EWSMethod {
         }
     }
 
+    @Override
     protected void handleEmailAddresses(XMLStreamReader reader, Item responseItem) throws XMLStreamException {
         while (reader.hasNext() && !XMLStreamUtil.isEndTag(reader, "EmailAddresses")) {
             reader.next();

src/java/davmail/http/DavMailCookieSpec.java

@@ -26,6 +26,7 @@ import org.apache.commons.httpclient.cookie.RFC2109Spec;
  * Custom CookieSpec to allow extended domain names.
  */
 public class DavMailCookieSpec extends RFC2109Spec {
+    @Override
     public void validate(String host, int port, String path,
         boolean secure, final Cookie cookie) throws MalformedCookieException {
         String hostWithoutDomain = host.substring(0, host.length()