diff --git a/src/java/davmail/AbstractServer.java b/src/java/davmail/AbstractServer.java index 0e6b32cd..a99e1fb5 100644 --- a/src/java/davmail/AbstractServer.java +++ b/src/java/davmail/AbstractServer.java @@ -36,7 +36,7 @@ import java.security.KeyStore; * Generic abstract server common to SMTP and POP3 implementations */ public abstract class AbstractServer extends Thread { - protected boolean nosslFlag = false; // will cause same behavior as before with unchanged config files + protected boolean nosslFlag; // will cause same behavior as before with unchanged config files private final int port; private ServerSocket serverSocket; diff --git a/src/java/davmail/exchange/ews/BaseShape.java b/src/java/davmail/exchange/ews/BaseShape.java index fd608287..8e5757ca 100644 --- a/src/java/davmail/exchange/ews/BaseShape.java +++ b/src/java/davmail/exchange/ews/BaseShape.java @@ -21,6 +21,7 @@ package davmail.exchange.ews; /** * Item or folder base shape. */ +@SuppressWarnings({"UnusedDeclaration"}) public final class BaseShape extends ElementOption { private BaseShape(String value) { super("t:BaseShape", value); diff --git a/src/java/davmail/exchange/ews/ConflictResolution.java b/src/java/davmail/exchange/ews/ConflictResolution.java index 23bd92f5..d249d43b 100644 --- a/src/java/davmail/exchange/ews/ConflictResolution.java +++ b/src/java/davmail/exchange/ews/ConflictResolution.java @@ -21,6 +21,7 @@ package davmail.exchange.ews; /** * Item update conflict resolution */ +@SuppressWarnings({"JavaDoc"}) public class ConflictResolution extends AttributeOption { private ConflictResolution(String value) { super("ConflictResolution", value); diff --git a/src/java/davmail/exchange/ews/ContainmentComparison.java b/src/java/davmail/exchange/ews/ContainmentComparison.java index 3ebf8deb..12729bca 100644 --- a/src/java/davmail/exchange/ews/ContainmentComparison.java +++ b/src/java/davmail/exchange/ews/ContainmentComparison.java @@ -21,7 +21,7 @@ package davmail.exchange.ews; /** * Contains comparison mode. */ -@SuppressWarnings({"UnusedDeclaration"}) +@SuppressWarnings({"UnusedDeclaration", "JavaDoc"}) public class ContainmentComparison extends AttributeOption { private ContainmentComparison(String value) { super("ContainmentComparison", value); diff --git a/src/java/davmail/exchange/ews/ContainmentMode.java b/src/java/davmail/exchange/ews/ContainmentMode.java index ed7ec368..93ecb809 100644 --- a/src/java/davmail/exchange/ews/ContainmentMode.java +++ b/src/java/davmail/exchange/ews/ContainmentMode.java @@ -21,7 +21,7 @@ package davmail.exchange.ews; /** * Contains search mode. */ -@SuppressWarnings({"UnusedDeclaration"}) +@SuppressWarnings({"UnusedDeclaration", "JavaDoc"}) public class ContainmentMode extends AttributeOption { private ContainmentMode(String value) { super("ContainmentMode", value); diff --git a/src/java/davmail/exchange/ews/DeleteType.java b/src/java/davmail/exchange/ews/DeleteType.java index 7f9ef007..3f63cb20 100644 --- a/src/java/davmail/exchange/ews/DeleteType.java +++ b/src/java/davmail/exchange/ews/DeleteType.java @@ -21,6 +21,7 @@ package davmail.exchange.ews; /** * DeleteItem disposal type. */ +@SuppressWarnings({"JavaDoc"}) public class DeleteType extends AttributeOption { private DeleteType(String value) { super("DeleteType", value); diff --git a/src/java/davmail/exchange/ews/Disposal.java b/src/java/davmail/exchange/ews/Disposal.java index 943b17c0..299ec4b5 100644 --- a/src/java/davmail/exchange/ews/Disposal.java +++ b/src/java/davmail/exchange/ews/Disposal.java @@ -21,6 +21,7 @@ package davmail.exchange.ews; /** * Disposal. */ +@SuppressWarnings({"JavaDoc"}) public class Disposal extends AttributeOption { private Disposal(String value) { super("DeleteType", value); diff --git a/src/java/davmail/exchange/ews/EWSMethod.java b/src/java/davmail/exchange/ews/EWSMethod.java index 22931cac..ee3bf0fa 100644 --- a/src/java/davmail/exchange/ews/EWSMethod.java +++ b/src/java/davmail/exchange/ews/EWSMethod.java @@ -431,7 +431,7 @@ public abstract class EWSMethod extends PostMethod { protected List fieldUpdates; protected List attachments; protected List attendees; - protected List fieldNames = new ArrayList(); + protected final List fieldNames = new ArrayList(); @Override public String toString() { diff --git a/src/java/davmail/exchange/ews/GetUserAvailabilityMethod.java b/src/java/davmail/exchange/ews/GetUserAvailabilityMethod.java index d21b3ee6..dc23fa4c 100644 --- a/src/java/davmail/exchange/ews/GetUserAvailabilityMethod.java +++ b/src/java/davmail/exchange/ews/GetUserAvailabilityMethod.java @@ -29,11 +29,11 @@ import java.io.Writer; * GetUserAvailability method. */ public class GetUserAvailabilityMethod extends EWSMethod { - protected String attendee; - protected String start; - protected String end; + protected final String attendee; + protected final String start; + protected final String end; protected String mergedFreeBusy; - protected int interval; + protected final int interval; /** * Build EWS method @@ -92,7 +92,7 @@ public class GetUserAvailabilityMethod extends EWSMethod { writer.write(end); writer.write("" + "" + - "60" + + ""+interval+"" + "MergedOnly" + ""); } diff --git a/src/java/davmail/exchange/ews/IndexedFieldUpdate.java b/src/java/davmail/exchange/ews/IndexedFieldUpdate.java index 896c025c..a2a3a4bd 100644 --- a/src/java/davmail/exchange/ews/IndexedFieldUpdate.java +++ b/src/java/davmail/exchange/ews/IndexedFieldUpdate.java @@ -27,8 +27,8 @@ import java.util.Set; * Field update with multiple values. */ public class IndexedFieldUpdate extends FieldUpdate { - Set updates = new HashSet(); - protected String collectionName; + final Set updates = new HashSet(); + protected final String collectionName; public IndexedFieldUpdate(String collectionName) { this.collectionName = collectionName; diff --git a/src/java/davmail/exchange/ews/MessageDisposition.java b/src/java/davmail/exchange/ews/MessageDisposition.java index 9a2e33ae..20e27a92 100644 --- a/src/java/davmail/exchange/ews/MessageDisposition.java +++ b/src/java/davmail/exchange/ews/MessageDisposition.java @@ -21,7 +21,7 @@ package davmail.exchange.ews; /** * MessageDisposition flag. */ -@SuppressWarnings({"JavaDoc"}) +@SuppressWarnings({"JavaDoc", "UnusedDeclaration"}) public class MessageDisposition extends AttributeOption { private MessageDisposition(String value) { diff --git a/src/java/davmail/exchange/ews/ResolveNamesMethod.java b/src/java/davmail/exchange/ews/ResolveNamesMethod.java index a0fe9bd7..52f5c4a6 100644 --- a/src/java/davmail/exchange/ews/ResolveNamesMethod.java +++ b/src/java/davmail/exchange/ews/ResolveNamesMethod.java @@ -113,6 +113,7 @@ public class ResolveNamesMethod extends EWSMethod { } } + @Override protected void handleEmailAddresses(XMLStreamReader reader, Item responseItem) throws XMLStreamException { while (reader.hasNext() && !XMLStreamUtil.isEndTag(reader, "EmailAddresses")) { reader.next(); diff --git a/src/java/davmail/http/DavMailCookieSpec.java b/src/java/davmail/http/DavMailCookieSpec.java index 0c07365e..e8949847 100644 --- a/src/java/davmail/http/DavMailCookieSpec.java +++ b/src/java/davmail/http/DavMailCookieSpec.java @@ -26,6 +26,7 @@ import org.apache.commons.httpclient.cookie.RFC2109Spec; * Custom CookieSpec to allow extended domain names. */ public class DavMailCookieSpec extends RFC2109Spec { + @Override public void validate(String host, int port, String path, boolean secure, final Cookie cookie) throws MalformedCookieException { String hostWithoutDomain = host.substring(0, host.length()