70c4fad734
gitattributes: Set batch files to CRLF line endings on checkout
...
If a batch file is run without CRLF line endings (ie LF-only) then
arbitrary behavior may occur. I consider that a bug in Windows, however
the effects can be serious enough (eg unintended code executed) that
we're fixing it in the repo by requiring CRLF line endings for batch
files on checkout.
Prior to this change the checked-out line endings of batch files were
dependent on a user's git preferences. On Windows it is common for git
users to have automatic CRLF conversion enabled (core.autocrlf true),
but those users that don't would run into this behavior.
For example a user has reported running the Visual Studio project
generator batch file (projects/generate.bat) and it looped forever.
Output showed that the Windows OS interpreter was occasionally jumping
to arbitrary points in the batch file and executing commands. This
resulted in unintended files being removed (a removal sequence called)
and looping forever.
Ref: https://serverfault.com/q/429594
Ref: https://stackoverflow.com/q/232651
Ref: https://www.dostips.com/forum/viewtopic.php?t=8988
Ref: https://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
Ref: https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_core_autocrlf
Bug: https://github.com/curl/curl/discussions/6427
Reported-by: Ganesh Kamath
Closes https://github.com/curl/curl/pull/6442
2021-01-14 15:59:56 -05:00
8f32ead8bf
tool_operate: spellfix a comment
2021-01-14 13:40:12 +01:00
ac1f1b77a8
ROADMAP: refreshed
...
o removed HSTS - already implemented
o added HTTPS RR records
o mention HTTP/3 completion
2021-01-14 09:49:17 +01:00
ab6eb2ec07
http_chunks: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
e38f4b7e80
transfer: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
8072a882b3
tftp: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
78af707caf
multi: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
a7591fbb73
ldap: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
476e1339ef
doh: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
afb150499f
asyn-ares: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
c2c9e44a4d
vtls: remove Curl_ prefix from static functions
2021-01-14 08:09:09 +01:00
7e72b9b547
bearssl: remove Curl_ prefix from static functions
2021-01-14 08:09:08 +01:00
4b55d0468a
mbedtls: remove Curl_ prefix from static functions
2021-01-14 08:09:08 +01:00
5beed3e742
wolfssl: remove Curl_ prefix from static functions
2021-01-14 08:09:08 +01:00
39df93a875
nss: remove Curl_ prefix from static functions
2021-01-14 08:09:08 +01:00
a3e1e6b3b4
gnutls: remove Curl_ prefix from static functions
2021-01-14 08:09:08 +01:00
3112ede57c
openssl: remove Curl_ prefix from static functions
...
... as we reserve this prefix to library-wide functions.
Closes #6443
2021-01-14 08:08:54 +01:00
a79555291e
nss: get the run-time version instead of build-time
...
Closes #6445
2021-01-13 23:22:07 +01:00
3831043eff
tool_doswin: Restore original console settings on CTRL signal
...
- Move Windows terminal init code from tool_main to tool_doswin.
- Restore the original console settings on CTRL+C and CTRL+BREAK.
Background: On Windows the curl tool changes the console settings to
enable virtual terminal processing (eg color output) if supported
(ie Win 10). The original settings are restored on exit but prior to
this change were not restored in the case of the CTRL signals.
Windows VT behavior varies depending on console/powershell/terminal;
refer to the discussion in #6226 .
Assisted-by: Rich Turner
Closes https://github.com/curl/curl/pull/6226
2021-01-12 03:44:48 -05:00
33993d45fe
gen.pl: fix perl syntax
...
Follow-up to 324cf1d2e
2021-01-12 08:12:41 +01:00
3d78301106
help: update to current codebase
...
This commit bumps the help to the current state of the project.
Closes #6437
2021-01-12 08:09:22 +01:00
324cf1d2ee
docs: fix line length bug in gen.pl
...
The script warns if the length of $opt and $desc is > 78. However, these
two variables are on totally separate lines so the check makes no sense.
Also the $bitmask field is totally forgotten. Currently this leads to
two warnings within `--resolve` and `--aws-sigv4`.
Closes #6438
2021-01-12 08:06:54 +01:00
efa5b16d38
docs: fix wrong documentation in help.d
...
curl does not list all categories when you invoke "--help" without any
parameters.
Closes #6436
2021-01-12 00:08:55 +01:00
90aad9cb1f
aws-sigv4.d: polish the wording
...
Make it shorter and imperative form
Closes #6439
2021-01-12 00:07:52 +01:00
4f61fd87b2
misc: fix typos
...
Bug: https://curl.se/mail/lib-2021-01/0063.html
Closes #6434
2021-01-11 15:12:25 +01:00
06f1db57ca
multi_runsingle: bail out early on data->conn == NULL
...
As that's a significant error condition and scan-build warns for NULL
pointer dereferences if we don't.
Closes #6433
2021-01-11 12:33:23 +01:00
48220f7e3d
multi: skip DONE state if there's no connection left for ftp wildcard
...
... to avoid running in that state with data->conn being NULL.
2021-01-11 12:33:11 +01:00
057cb05b4b
libssh2: fix "Value stored to 'readdir_len' is never read"
...
Detected by scan-build
2021-01-11 12:32:58 +01:00
6cb803ecb1
connect: mark intentional ignores of setsockopt return values
...
Pointed out by Coverity
Closes #6431
2021-01-11 10:21:51 +01:00
70af179118
http_proxy: Fix CONNECT chunked encoding race condition
...
- During the end-of-headers response phase do not mark the tunnel
complete unless the response body was completely parsed/ignored.
Prior to this change if the entirety of a CONNECT response with chunked
encoding was not received by the time the final header was parsed then
the connection would be marked done prematurely, before all the chunked
data could be read in and ignored (since this is what we do with any
CONNECT response body) and the connection could not be used.
Bug: https://curl.se/mail/lib-2021-01/0033.html
Reported-by: Fabian Keil
Closes https://github.com/curl/curl/pull/6432
2021-01-11 03:28:01 -05:00
3375584a02
RELEASE-NOTES: synced
2021-01-11 00:27:46 +01:00
229930762f
url: if IDNA conversion fails, fallback to Transitional
...
This improves IDNA2003 compatiblity.
Reported-by: Bubu on github
Fixes #6423
Closes #6428
2021-01-11 00:21:28 +01:00
16b27e06bd
travis: make the Hyper build from its master branch
...
Closes #6430
2021-01-11 00:17:52 +01:00
8b2dec6ab7
http: make 'authneg' also work for Hyper
...
When doing a request with a request body expecting a 401/407 back, that
initial request is sent with a zero content-length. Test 177 and more.
Closes #6424
2021-01-10 14:51:33 +01:00
83f1ca6929
cmake: Add an option to disable libidn2
...
New option USE_LIBIDN2 defaults to ON for libidn2 detection. Prior to
this change libidn2 detection could not be turned off in cmake builds.
Reported-by: William A Rowe Jr
Fixes https://github.com/curl/curl/issues/6361
Closes https://github.com/curl/curl/pull/6362
2021-01-08 22:36:43 -05:00
d336ac33c1
HYPER: no longer needs the special branch
2021-01-08 23:54:22 +01:00
060658f634
test179: use consistent header line endings
...
... to make "Hyper mode" work better.
2021-01-08 10:57:48 +01:00
1e5cec3297
file: don't provide content-length for directories
...
... as it is misleading.
Ref #6379
Closes #6421
2021-01-07 23:31:28 +01:00
a56f263cdc
TODO: Directory listing for FILE:
...
Ref #6379
2021-01-07 16:17:13 +01:00
f52c6981c5
curl.h: add CURLPROTO_GOPHERS as own protocol identifier
...
Follow-up to a1f06f32b8Closes #6418
2021-01-06 15:23:41 +01:00
ab525c059e
http: have CURLOPT_FAILONERROR fail after all headers
...
... so that Retry-After and other meta-content can still be used.
Added 1634 to verify. Adjusted test 194 and 281 since --fail now also
includes the header-terminating CRLF in the output before it exits.
Fixes #6408
Closes #6409
2021-01-06 15:14:40 +01:00
9d7281ff17
global_init: debug builds allocates a byte in init
...
... to make build tools/valgrind warn if no curl_global_cleanup is
called.
This is conditionally only done for debug builds with the env variable
CURL_GLOBAL_INIT set.
Closes #6410
2021-01-06 15:13:45 +01:00
75f7ab28d2
lib/unit tests: add missing curl_global_cleanup() calls
2021-01-06 15:13:45 +01:00
5808144f3c
travis: adapt to Hyper build change
...
Closes #6419
2021-01-06 15:09:20 +01:00
0936ecd0ee
pretransfer: setup the User-Agent header here
...
... and not in the connection setup, as for multiplexed transfers the
connection setup might be skipped and then the transfer would end up
without the set user-agent!
Reported-by: Flameborn on github
Assisted-by: Andrey Gursky
Assisted-by: Jay Satiro
Assisted-by: Mike Gelfand
Fixes #6312
Closes #6417
2021-01-05 23:46:32 +01:00
80c5a838ce
test66: disable with Hyper
...
...as Hyper doesn't support HTTP/0.9
2021-01-05 17:27:05 +01:00
25c1d5e6a8
c-hyper: poll the tasks until end correctly
...
... makes test 36 work.
Closes #6412
2021-01-05 15:33:47 +01:00
56b32b5d75
mk-ca-bundle.pl: deterministic output when using -t
...
Printing trust purposes are now sorted, making the output deterministic
when running on the same input certdata.txt.
Closes #6413
2021-01-05 13:03:41 +01:00
eacfe36991
KNOWN_BUGS: fixed "wolfSSL lacks support for renegotiation"
...
Fixed by #6411
2021-01-05 10:08:06 +01:00
f927f38f1e
wolfssl: add SECURE_RENEGOTIATION support
...
Closes #6411
2021-01-05 10:05:46 +01:00
Jay Satiro