mirror of https://github.com/moparisthebest/curl
Dinar in bug report #1086121, found a file handle leak when a multipart
formpost (including a file upload part) was aborted before the whole file was sent.
This commit is contained in:
parent
38181fbc74
commit
d3b414724b
5
CHANGES
5
CHANGES
|
@ -7,6 +7,11 @@
|
||||||
Changelog
|
Changelog
|
||||||
|
|
||||||
|
|
||||||
|
Daniel (16 December 2004)
|
||||||
|
- Dinar in bug report #1086121, found a file handle leak when a multipart
|
||||||
|
formpost (including a file upload part) was aborted before the whole file
|
||||||
|
was sent.
|
||||||
|
|
||||||
Daniel (15 December 2004)
|
Daniel (15 December 2004)
|
||||||
- Tom Lee found out that globbing of strings with backslashes didn't work as
|
- Tom Lee found out that globbing of strings with backslashes didn't work as
|
||||||
you'd expect. Backslashes are such a central part of windows file names that
|
you'd expect. Backslashes are such a central part of windows file names that
|
||||||
|
|
|
@ -26,6 +26,7 @@ This release includes the following changes:
|
||||||
|
|
||||||
This release includes the following bugfixes:
|
This release includes the following bugfixes:
|
||||||
|
|
||||||
|
o file handle leak in aborted multipart formpost file upload
|
||||||
o -T upload multiple files with backslashes in file names
|
o -T upload multiple files with backslashes in file names
|
||||||
o modified credentials between two requests on a persistent http connection
|
o modified credentials between two requests on a persistent http connection
|
||||||
o large file file:// resumes on Windows
|
o large file file:// resumes on Windows
|
||||||
|
@ -71,6 +72,6 @@ advice from friends like these:
|
||||||
Tim Sneddon, Ian Gulliver, Jean-Philippe Barrette-LaPierre, Jeff Phillips,
|
Tim Sneddon, Ian Gulliver, Jean-Philippe Barrette-LaPierre, Jeff Phillips,
|
||||||
Wojciech Zwiefka, David Phillips, Reinout van Schouwen, Maurice Barnum,
|
Wojciech Zwiefka, David Phillips, Reinout van Schouwen, Maurice Barnum,
|
||||||
Richard Atterer, Rene Bernhardt, Matt Veenstra, Bryan Henderson, Ton Voon,
|
Richard Atterer, Rene Bernhardt, Matt Veenstra, Bryan Henderson, Ton Voon,
|
||||||
Kai Sommerfeld, David Byron, Harshal Pradhan, Tom Lee
|
Kai Sommerfeld, David Byron, Harshal Pradhan, Tom Lee, Dinar
|
||||||
|
|
||||||
Thanks! (and sorry if I forgot to mention someone)
|
Thanks! (and sorry if I forgot to mention someone)
|
||||||
|
|
|
@ -1299,6 +1299,9 @@ CURLcode Curl_http_done(struct connectdata *conn,
|
||||||
conn->bytecount = http->readbytecount + http->writebytecount;
|
conn->bytecount = http->readbytecount + http->writebytecount;
|
||||||
|
|
||||||
Curl_formclean(http->sendit); /* Now free that whole lot */
|
Curl_formclean(http->sendit); /* Now free that whole lot */
|
||||||
|
if(http->form.fp)
|
||||||
|
/* a file being uploaded was left opened, close it! */
|
||||||
|
fclose(http->form.fp);
|
||||||
}
|
}
|
||||||
else if(HTTPREQ_PUT == data->set.httpreq)
|
else if(HTTPREQ_PUT == data->set.httpreq)
|
||||||
conn->bytecount = http->readbytecount + http->writebytecount;
|
conn->bytecount = http->readbytecount + http->writebytecount;
|
||||||
|
|
|
@ -357,10 +357,15 @@ sub runhttpserver {
|
||||||
my $data;
|
my $data;
|
||||||
|
|
||||||
if($res && $verbose) {
|
if($res && $verbose) {
|
||||||
print "RUN: curl command returned $res\nRUN: ";
|
|
||||||
open(ERR, "<log/verifystderr");
|
open(ERR, "<log/verifystderr");
|
||||||
print <ERR>;
|
my @e = <ERR>;
|
||||||
close(ERR);
|
close(ERR);
|
||||||
|
print "RUN: curl command returned $res\n";
|
||||||
|
for(@e) {
|
||||||
|
if($_ !~ /^([ \t]*)$/) {
|
||||||
|
print "RUN: $_";
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
open(FILE, "<log/verifiedserver");
|
open(FILE, "<log/verifiedserver");
|
||||||
my @file=<FILE>;
|
my @file=<FILE>;
|
||||||
|
|
Loading…
Reference in New Issue