moparisthebest
/
curl
mirror of https://github.com/moparisthebest/curl
1
0
Fork 0
Code Issues Releases Wiki Activity

Removed the use of AI_CANONNAME in the IPv6-enabled resolver functions since 

we really have no use for reverse lookups of the address.

I truly hope these are the last reverse lookups we had lingering in the
code!
This commit is contained in:
Daniel Stenberg 2005-11-08 14:45:58 +00:00
parent 931eff89f5
commit cab59b4c32
4 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES
View File

@ -9,6 +9,12 @@
Daniel (8 November 2005) Daniel (8 November 2005)
- Removed the use of AI_CANONNAME in the IPv6-enabled resolver functions since
we really have no use for reverse lookups of the address.
I truly hope these are the last reverse lookups we had lingering in the
code!
- Dmitry Bartsevich discovered some issues in compatibilty of SSPI-enabled - Dmitry Bartsevich discovered some issues in compatibilty of SSPI-enabled
version of libcurl with different Windows versions. Current version of version of libcurl with different Windows versions. Current version of
libcurl imports SSPI functions from secur32.dll. However, under Windows NT libcurl imports SSPI functions from secur32.dll. However, under Windows NT

1
RELEASE-NOTES
View File

@ -17,6 +17,7 @@ This release includes the following changes:
This release includes the following bugfixes: This release includes the following bugfixes:
o no reverse lookups on IP addresses when ipv6-enabled
o SSPI compatibility fix: using the proper DLLs o SSPI compatibility fix: using the proper DLLs
o binary LDAP properties are now shown base64 encoded o binary LDAP properties are now shown base64 encoded
o Windows uploads from stdin using curl can now contain ctrl-Z bytes o Windows uploads from stdin using curl can now contain ctrl-Z bytes

17
lib/hostip6.c
View File

@ -228,7 +228,6 @@ Curl_addrinfo *Curl_getaddrinfo(struct connectdata *conn,
curl_socket_t s; curl_socket_t s;
int pf; int pf;
struct SessionHandle *data = conn->data; struct SessionHandle *data = conn->data;
int ai_flags;
*waitp=0; /* don't wait, we have the response now */ *waitp=0; /* don't wait, we have the response now */
@ -263,20 +262,20 @@ Curl_addrinfo *Curl_getaddrinfo(struct connectdata *conn,
} }
} }
memset(&hints, 0, sizeof(hints));
hints.ai_family = pf;
hints.ai_socktype = conn->socktype;
if((1 == Curl_inet_pton(AF_INET, hostname, addrbuf)) || if((1 == Curl_inet_pton(AF_INET, hostname, addrbuf)) ||
(1 == Curl_inet_pton(AF_INET6, hostname, addrbuf))) { (1 == Curl_inet_pton(AF_INET6, hostname, addrbuf))) {
/* the given address is numerical only, prevent a reverse lookup */ /* the given address is numerical only, prevent a reverse lookup */
ai_flags = AI_NUMERICHOST; hints.ai_flags = AI_NUMERICHOST;
} }
#if 0 /* removed nov 8 2005 before 7.15.1 */
else else
ai_flags = AI_CANONNAME; hints.ai_flags = AI_CANONNAME;
#endif
memset(&hints, 0, sizeof(hints));
hints.ai_family = pf;
hints.ai_socktype = conn->socktype;
hints.ai_flags = ai_flags;
if(port) { if(port) {
snprintf(sbuf, sizeof(sbuf), "%d", port); snprintf(sbuf, sizeof(sbuf), "%d", port);
sbufptr=sbuf; sbufptr=sbuf;

2
lib/hostthre.c
View File

@ -819,7 +819,9 @@ Curl_addrinfo *Curl_getaddrinfo(struct connectdata *conn,
memset(&hints, 0, sizeof(hints)); memset(&hints, 0, sizeof(hints));
hints.ai_family = pf; hints.ai_family = pf;
hints.ai_socktype = conn->socktype; hints.ai_socktype = conn->socktype;
#if 0 /* removed nov 8 2005 before 7.15.1 */
hints.ai_flags = AI_CANONNAME; hints.ai_flags = AI_CANONNAME;
#endif
itoa(port, sbuf, 10); itoa(port, sbuf, 10);
/* fire up a new resolver thread! */ /* fire up a new resolver thread! */