mirror of https://github.com/moparisthebest/curl
- Added CURLFORM_STREAM as a supported option to curl_formadd() to allow an
application to provide data for a multipart with the read callback. Note that the size needs to be provided with CURLFORM_CONTENTSLENGTH when the stream option is used. This feature is verified by the new test case 554. This feature was sponsored by Xponaut.
This commit is contained in:
parent
1e482fe6a8
commit
a2314225e0
7
CHANGES
7
CHANGES
|
@ -6,6 +6,13 @@
|
||||||
|
|
||||||
Changelog
|
Changelog
|
||||||
|
|
||||||
|
Daniel Stenberg (31 Mar 2008)
|
||||||
|
- Added CURLFORM_STREAM as a supported option to curl_formadd() to allow an
|
||||||
|
application to provide data for a multipart with the read callback. Note
|
||||||
|
that the size needs to be provided with CURLFORM_CONTENTSLENGTH when the
|
||||||
|
stream option is used. This feature is verified by the new test case
|
||||||
|
554. This feature was sponsored by Xponaut.
|
||||||
|
|
||||||
Daniel Fandrich (30 Mar 2008)
|
Daniel Fandrich (30 Mar 2008)
|
||||||
- Changed the makefile so the doc/examples/ programs are never built in a
|
- Changed the makefile so the doc/examples/ programs are never built in a
|
||||||
normal build/install (only with the 'make check' target), so that a
|
normal build/install (only with the 'make check' target), so that a
|
||||||
|
|
|
@ -6,11 +6,11 @@ Curl and libcurl 7.18.2
|
||||||
Public functions in libcurl: 56
|
Public functions in libcurl: 56
|
||||||
Public web site mirrors: 39
|
Public web site mirrors: 39
|
||||||
Known libcurl bindings: 36
|
Known libcurl bindings: 36
|
||||||
Contributors: 621
|
Contributors: 636
|
||||||
|
|
||||||
This release includes the following changes:
|
This release includes the following changes:
|
||||||
|
|
||||||
o
|
o CURLFORM_STREAM was added
|
||||||
|
|
||||||
This release includes the following bugfixes:
|
This release includes the following bugfixes:
|
||||||
|
|
||||||
|
|
|
@ -38,9 +38,7 @@ parts you want to add to your post.
|
||||||
The options listed first are for making normal parts. The options from
|
The options listed first are for making normal parts. The options from
|
||||||
\fICURLFORM_FILE\fP through \fICURLFORM_BUFFERLENGTH\fP are for file upload
|
\fICURLFORM_FILE\fP through \fICURLFORM_BUFFERLENGTH\fP are for file upload
|
||||||
parts.
|
parts.
|
||||||
|
|
||||||
.SH OPTIONS
|
.SH OPTIONS
|
||||||
|
|
||||||
.IP CURLFORM_COPYNAME
|
.IP CURLFORM_COPYNAME
|
||||||
followed by a string which provides the \fIname\fP of this part. libcurl
|
followed by a string which provides the \fIname\fP of this part. libcurl
|
||||||
copies the string so your application doesn't need to keep it around after
|
copies the string so your application doesn't need to keep it around after
|
||||||
|
@ -48,14 +46,12 @@ this function call. If the name isn't NUL-terminated, or if you'd
|
||||||
like it to contain zero bytes, you must set its length with
|
like it to contain zero bytes, you must set its length with
|
||||||
\fBCURLFORM_NAMELENGTH\fP. The copied data will be freed by
|
\fBCURLFORM_NAMELENGTH\fP. The copied data will be freed by
|
||||||
\fIcurl_formfree(3)\fP.
|
\fIcurl_formfree(3)\fP.
|
||||||
|
|
||||||
.IP CURLFORM_PTRNAME
|
.IP CURLFORM_PTRNAME
|
||||||
followed by a string which provides the \fIname\fP of this part. libcurl
|
followed by a string which provides the \fIname\fP of this part. libcurl
|
||||||
will use the pointer and refer to the data in your application, so you
|
will use the pointer and refer to the data in your application, so you
|
||||||
must make sure it remains until curl no longer needs it. If the name
|
must make sure it remains until curl no longer needs it. If the name
|
||||||
isn't NUL-terminated, or if you'd like it to contain zero
|
isn't NUL-terminated, or if you'd like it to contain zero
|
||||||
bytes, you must set its length with \fBCURLFORM_NAMELENGTH\fP.
|
bytes, you must set its length with \fBCURLFORM_NAMELENGTH\fP.
|
||||||
|
|
||||||
.IP CURLFORM_COPYCONTENTS
|
.IP CURLFORM_COPYCONTENTS
|
||||||
followed by a pointer to the contents of this part, the actual data
|
followed by a pointer to the contents of this part, the actual data
|
||||||
to send away. libcurl copies the provided data, so your application doesn't
|
to send away. libcurl copies the provided data, so your application doesn't
|
||||||
|
@ -63,57 +59,55 @@ need to keep it around after this function call. If the data isn't null
|
||||||
terminated, or if you'd like it to contain zero bytes, you must
|
terminated, or if you'd like it to contain zero bytes, you must
|
||||||
set the length of the name with \fBCURLFORM_CONTENTSLENGTH\fP. The copied
|
set the length of the name with \fBCURLFORM_CONTENTSLENGTH\fP. The copied
|
||||||
data will be freed by \fIcurl_formfree(3)\fP.
|
data will be freed by \fIcurl_formfree(3)\fP.
|
||||||
|
|
||||||
.IP CURLFORM_PTRCONTENTS
|
.IP CURLFORM_PTRCONTENTS
|
||||||
followed by a pointer to the contents of this part, the actual data
|
followed by a pointer to the contents of this part, the actual data
|
||||||
to send away. libcurl will use the pointer and refer to the data in your
|
to send away. libcurl will use the pointer and refer to the data in your
|
||||||
application, so you must make sure it remains until curl no longer needs it.
|
application, so you must make sure it remains until curl no longer needs it.
|
||||||
If the data isn't NUL-terminated, or if you'd like it to contain zero bytes,
|
If the data isn't NUL-terminated, or if you'd like it to contain zero bytes,
|
||||||
you must set its length with \fBCURLFORM_CONTENTSLENGTH\fP.
|
you must set its length with \fBCURLFORM_CONTENTSLENGTH\fP.
|
||||||
|
|
||||||
.IP CURLFORM_CONTENTSLENGTH
|
.IP CURLFORM_CONTENTSLENGTH
|
||||||
followed by a long giving the length of the contents.
|
followed by a long giving the length of the contents. Note that for
|
||||||
|
\fICURLFORM_STREAM\fP contents, this option is mandatory.
|
||||||
.IP CURLFORM_FILECONTENT
|
.IP CURLFORM_FILECONTENT
|
||||||
followed by a filename, causes that file to be read and its contents used
|
followed by a filename, causes that file to be read and its contents used
|
||||||
as data in this part. This part does \fInot\fP automatically become a file
|
as data in this part. This part does \fInot\fP automatically become a file
|
||||||
upload part simply because its data was read from a file.
|
upload part simply because its data was read from a file.
|
||||||
|
|
||||||
.IP CURLFORM_FILE
|
.IP CURLFORM_FILE
|
||||||
followed by a filename, makes this part a file upload part. It sets the
|
followed by a filename, makes this part a file upload part. It sets the
|
||||||
\fIfilename\fP field to the basename of the provided filename, it reads the
|
\fIfilename\fP field to the basename of the provided filename, it reads the
|
||||||
contents of the file and passes them as data and sets the content-type if the
|
contents of the file and passes them as data and sets the content-type if the
|
||||||
given file match one of the internally known file extensions. For
|
given file match one of the internally known file extensions. For
|
||||||
\fBCURLFORM_FILE\fP the user may send one or more files in one part by
|
\fBCURLFORM_FILE\fP the user may send one or more files in one part by
|
||||||
providing multiple \fBCURLFORM_FILE\fP arguments each followed by the
|
providing multiple \fBCURLFORM_FILE\fP arguments each followed by the filename
|
||||||
filename (and each CURLFORM_FILE is allowed to have a CURLFORM_CONTENTTYPE).
|
(and each \fICURLFORM_FILE\fP is allowed to have a
|
||||||
|
\fICURLFORM_CONTENTTYPE\fP).
|
||||||
.IP CURLFORM_CONTENTTYPE
|
.IP CURLFORM_CONTENTTYPE
|
||||||
is used in combination with \fICURLFORM_FILE\fP. Followed by a pointer to a
|
is used in combination with \fICURLFORM_FILE\fP. Followed by a pointer to a
|
||||||
string which provides the content-type for this part, possibly instead of an
|
string which provides the content-type for this part, possibly instead of an
|
||||||
internally chosen one.
|
internally chosen one.
|
||||||
|
|
||||||
.IP CURLFORM_FILENAME
|
.IP CURLFORM_FILENAME
|
||||||
is used in combination with \fICURLFORM_FILE\fP. Followed by a pointer to a
|
is used in combination with \fICURLFORM_FILE\fP. Followed by a pointer to a
|
||||||
string, it tells libcurl to use the given string as the \fIfilename\fP in the
|
string, it tells libcurl to use the given string as the \fIfilename\fP in the
|
||||||
file upload part instead of the actual file name.
|
file upload part instead of the actual file name.
|
||||||
|
|
||||||
.IP CURLFORM_BUFFER
|
.IP CURLFORM_BUFFER
|
||||||
is used for custom file upload parts without use of \fICURLFORM_FILE\fP. It
|
is used for custom file upload parts without use of \fICURLFORM_FILE\fP. It
|
||||||
tells libcurl that the file contents are already present in a buffer. The
|
tells libcurl that the file contents are already present in a buffer. The
|
||||||
parameter is a string which provides the \fIfilename\fP field in the content
|
parameter is a string which provides the \fIfilename\fP field in the content
|
||||||
header.
|
header.
|
||||||
|
|
||||||
.IP CURLFORM_BUFFERPTR
|
.IP CURLFORM_BUFFERPTR
|
||||||
is used in combination with \fICURLFORM_BUFFER\fP. The parameter is a pointer
|
is used in combination with \fICURLFORM_BUFFER\fP. The parameter is a pointer
|
||||||
to the buffer to be uploaded. This buffer must not be freed until after
|
to the buffer to be uploaded. This buffer must not be freed until after
|
||||||
\fIcurl_easy_cleanup(3)\fP is called. You must also use
|
\fIcurl_easy_cleanup(3)\fP is called. You must also use
|
||||||
\fICURLFORM_BUFFERLENGTH\fP to set the number of bytes in the buffer.
|
\fICURLFORM_BUFFERLENGTH\fP to set the number of bytes in the buffer.
|
||||||
|
|
||||||
.IP CURLFORM_BUFFERLENGTH
|
.IP CURLFORM_BUFFERLENGTH
|
||||||
is used in combination with \fICURLFORM_BUFFER\fP. The parameter is a
|
is used in combination with \fICURLFORM_BUFFER\fP. The parameter is a
|
||||||
long which gives the length of the buffer.
|
long which gives the length of the buffer.
|
||||||
|
.IP CURLFORM_STREAM
|
||||||
|
Tells libcurl to use the \fICURLOPT_READFUNCTION\fP callback to get data. The
|
||||||
|
parameter you pass to \fICURLFORM_STREAM\fP is the pointer passed on to the
|
||||||
|
read callback's fourth argument. If you want the part to look like a file
|
||||||
|
upload one, set the \fICURLFORM_FILENAME\fP parameter as well. (Option added
|
||||||
|
in libcurl 7.18.2)
|
||||||
.IP CURLFORM_ARRAY
|
.IP CURLFORM_ARRAY
|
||||||
Another possibility to send options to curl_formadd() is the
|
Another possibility to send options to curl_formadd() is the
|
||||||
\fBCURLFORM_ARRAY\fP option, that passes a struct curl_forms array pointer as
|
\fBCURLFORM_ARRAY\fP option, that passes a struct curl_forms array pointer as
|
||||||
|
@ -121,7 +115,6 @@ its value. Each curl_forms structure element has a CURLformoption and a char
|
||||||
pointer. The final element in the array must be a CURLFORM_END. All available
|
pointer. The final element in the array must be a CURLFORM_END. All available
|
||||||
options can be used in an array, except the CURLFORM_ARRAY option itself! The
|
options can be used in an array, except the CURLFORM_ARRAY option itself! The
|
||||||
last argument in such an array must always be \fBCURLFORM_END\fP.
|
last argument in such an array must always be \fBCURLFORM_END\fP.
|
||||||
|
|
||||||
.IP CURLFORM_CONTENTHEADER
|
.IP CURLFORM_CONTENTHEADER
|
||||||
specifies extra headers for the form POST section. This takes a curl_slist
|
specifies extra headers for the form POST section. This takes a curl_slist
|
||||||
prepared in the usual way using \fBcurl_slist_append\fP and appends the list
|
prepared in the usual way using \fBcurl_slist_append\fP and appends the list
|
||||||
|
|
|
@ -211,10 +211,16 @@ struct curl_httppost {
|
||||||
do not free in formfree */
|
do not free in formfree */
|
||||||
#define HTTPPOST_BUFFER (1<<4) /* upload file from buffer */
|
#define HTTPPOST_BUFFER (1<<4) /* upload file from buffer */
|
||||||
#define HTTPPOST_PTRBUFFER (1<<5) /* upload file from pointer contents */
|
#define HTTPPOST_PTRBUFFER (1<<5) /* upload file from pointer contents */
|
||||||
|
#define HTTPPOST_CALLBACK (1<<6) /* upload fiel contents by using the
|
||||||
|
regular read callback to get the data
|
||||||
|
and pass the given pointer as custom
|
||||||
|
pointer */
|
||||||
|
|
||||||
char *showfilename; /* The file name to show. If not set, the
|
char *showfilename; /* The file name to show. If not set, the
|
||||||
actual file name will be used (if this
|
actual file name will be used (if this
|
||||||
is a file part) */
|
is a file part) */
|
||||||
|
void *userp; /* custom pointer used for
|
||||||
|
HTTPPOST_CALLBACK posts */
|
||||||
};
|
};
|
||||||
|
|
||||||
typedef int (*curl_progress_callback)(void *clientp,
|
typedef int (*curl_progress_callback)(void *clientp,
|
||||||
|
@ -246,7 +252,7 @@ typedef size_t (*curl_write_callback)(char *buffer,
|
||||||
#define CURL_READFUNC_PAUSE 0x10000001
|
#define CURL_READFUNC_PAUSE 0x10000001
|
||||||
typedef int (*curl_seek_callback)(void *instream,
|
typedef int (*curl_seek_callback)(void *instream,
|
||||||
curl_off_t offset,
|
curl_off_t offset,
|
||||||
int origin); /* 'whence' */
|
int origin); /* 'whence' */
|
||||||
|
|
||||||
typedef size_t (*curl_read_callback)(char *buffer,
|
typedef size_t (*curl_read_callback)(char *buffer,
|
||||||
size_t size,
|
size_t size,
|
||||||
|
@ -1313,6 +1319,8 @@ typedef enum {
|
||||||
CFINIT(END),
|
CFINIT(END),
|
||||||
CFINIT(OBSOLETE2),
|
CFINIT(OBSOLETE2),
|
||||||
|
|
||||||
|
CFINIT(STREAM),
|
||||||
|
|
||||||
CURLFORM_LASTENTRY /* the last unusued */
|
CURLFORM_LASTENTRY /* the last unusued */
|
||||||
} CURLformoption;
|
} CURLformoption;
|
||||||
|
|
||||||
|
@ -1796,7 +1804,7 @@ CURL_EXTERN CURLcode curl_easy_pause(CURL *handle, int bitmask);
|
||||||
!defined(__cplusplus)
|
!defined(__cplusplus)
|
||||||
#include "typecheck-gcc.h"
|
#include "typecheck-gcc.h"
|
||||||
#else
|
#else
|
||||||
#if defined(__STDC__) && (__STDC__ >= 1)
|
#if defined(__STDC__) && (__STDC__ >= 1)
|
||||||
/* This preprocessor magic that replaces a call with the exact same call is
|
/* This preprocessor magic that replaces a call with the exact same call is
|
||||||
only done to make sure application authors pass exactly three arguments
|
only done to make sure application authors pass exactly three arguments
|
||||||
to these functions. */
|
to these functions. */
|
||||||
|
|
152
lib/formdata.c
152
lib/formdata.c
|
@ -5,7 +5,7 @@
|
||||||
* | (__| |_| | _ <| |___
|
* | (__| |_| | _ <| |___
|
||||||
* \___|\___/|_| \_\_____|
|
* \___|\___/|_| \_\_____|
|
||||||
*
|
*
|
||||||
* Copyright (C) 1998 - 2007, Daniel Stenberg, <daniel@haxx.se>, et al.
|
* Copyright (C) 1998 - 2008, Daniel Stenberg, <daniel@haxx.se>, et al.
|
||||||
*
|
*
|
||||||
* This software is licensed as described in the file COPYING, which
|
* This software is licensed as described in the file COPYING, which
|
||||||
* you should have received as part of this distribution. The terms
|
* you should have received as part of this distribution. The terms
|
||||||
|
@ -159,13 +159,13 @@ static size_t readfromfile(struct Form *form, char *buffer, size_t size);
|
||||||
*
|
*
|
||||||
***************************************************************************/
|
***************************************************************************/
|
||||||
static struct curl_httppost *
|
static struct curl_httppost *
|
||||||
AddHttpPost(char * name, size_t namelength,
|
AddHttpPost(char *name, size_t namelength,
|
||||||
char * value, size_t contentslength,
|
char *value, size_t contentslength,
|
||||||
char * buffer, size_t bufferlength,
|
char *buffer, size_t bufferlength,
|
||||||
char *contenttype,
|
char *contenttype,
|
||||||
long flags,
|
long flags,
|
||||||
struct curl_slist* contentHeader,
|
struct curl_slist* contentHeader,
|
||||||
char *showfilename,
|
char *showfilename, char *userp,
|
||||||
struct curl_httppost *parent_post,
|
struct curl_httppost *parent_post,
|
||||||
struct curl_httppost **httppost,
|
struct curl_httppost **httppost,
|
||||||
struct curl_httppost **last_post)
|
struct curl_httppost **last_post)
|
||||||
|
@ -182,6 +182,7 @@ AddHttpPost(char * name, size_t namelength,
|
||||||
post->contenttype = contenttype;
|
post->contenttype = contenttype;
|
||||||
post->contentheader = contentHeader;
|
post->contentheader = contentHeader;
|
||||||
post->showfilename = showfilename;
|
post->showfilename = showfilename;
|
||||||
|
post->userp = userp,
|
||||||
post->flags = flags;
|
post->flags = flags;
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
|
@ -597,7 +598,7 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
|
||||||
}
|
}
|
||||||
|
|
||||||
case CURLFORM_BUFFERPTR:
|
case CURLFORM_BUFFERPTR:
|
||||||
current_form->flags |= HTTPPOST_PTRBUFFER;
|
current_form->flags |= HTTPPOST_PTRBUFFER;
|
||||||
if(current_form->buffer)
|
if(current_form->buffer)
|
||||||
return_value = CURL_FORMADD_OPTION_TWICE;
|
return_value = CURL_FORMADD_OPTION_TWICE;
|
||||||
else {
|
else {
|
||||||
|
@ -618,6 +619,25 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
|
||||||
array_state?(size_t)array_value:(size_t)va_arg(params, long);
|
array_state?(size_t)array_value:(size_t)va_arg(params, long);
|
||||||
break;
|
break;
|
||||||
|
|
||||||
|
case CURLFORM_STREAM:
|
||||||
|
current_form->flags |= HTTPPOST_CALLBACK;
|
||||||
|
if(current_form->userp)
|
||||||
|
return_value = CURL_FORMADD_OPTION_TWICE;
|
||||||
|
else {
|
||||||
|
char *userp =
|
||||||
|
array_state?array_value:va_arg(params, char *);
|
||||||
|
if(userp) {
|
||||||
|
current_form->userp = userp;
|
||||||
|
current_form->value = userp; /* this isn't strictly true but we
|
||||||
|
derive a value from this later on
|
||||||
|
and we need this non-NULL to be
|
||||||
|
accepted as a fine form part */
|
||||||
|
}
|
||||||
|
else
|
||||||
|
return_value = CURL_FORMADD_NULL;
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
case CURLFORM_CONTENTTYPE:
|
case CURLFORM_CONTENTTYPE:
|
||||||
{
|
{
|
||||||
const char *contenttype =
|
const char *contenttype =
|
||||||
|
@ -693,18 +713,18 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
|
||||||
form != NULL;
|
form != NULL;
|
||||||
form = form->more) {
|
form = form->more) {
|
||||||
if( ((!form->name || !form->value) && !post) ||
|
if( ((!form->name || !form->value) && !post) ||
|
||||||
( (form->contentslength) &&
|
( (form->contentslength) &&
|
||||||
(form->flags & HTTPPOST_FILENAME) ) ||
|
(form->flags & HTTPPOST_FILENAME) ) ||
|
||||||
( (form->flags & HTTPPOST_FILENAME) &&
|
( (form->flags & HTTPPOST_FILENAME) &&
|
||||||
(form->flags & HTTPPOST_PTRCONTENTS) ) ||
|
(form->flags & HTTPPOST_PTRCONTENTS) ) ||
|
||||||
|
|
||||||
( (!form->buffer) &&
|
( (!form->buffer) &&
|
||||||
(form->flags & HTTPPOST_BUFFER) &&
|
(form->flags & HTTPPOST_BUFFER) &&
|
||||||
(form->flags & HTTPPOST_PTRBUFFER) ) ||
|
(form->flags & HTTPPOST_PTRBUFFER) ) ||
|
||||||
|
|
||||||
( (form->flags & HTTPPOST_READFILE) &&
|
( (form->flags & HTTPPOST_READFILE) &&
|
||||||
(form->flags & HTTPPOST_PTRCONTENTS) )
|
(form->flags & HTTPPOST_PTRCONTENTS) )
|
||||||
) {
|
) {
|
||||||
return_value = CURL_FORMADD_INCOMPLETE;
|
return_value = CURL_FORMADD_INCOMPLETE;
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
@ -731,10 +751,9 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
|
||||||
}
|
}
|
||||||
form->name_alloc = TRUE;
|
form->name_alloc = TRUE;
|
||||||
}
|
}
|
||||||
if( !(form->flags & HTTPPOST_FILENAME) &&
|
if( !(form->flags & (HTTPPOST_FILENAME | HTTPPOST_READFILE |
|
||||||
!(form->flags & HTTPPOST_READFILE) &&
|
HTTPPOST_PTRCONTENTS | HTTPPOST_PTRBUFFER |
|
||||||
!(form->flags & HTTPPOST_PTRCONTENTS) &&
|
HTTPPOST_CALLBACK)) ) {
|
||||||
!(form->flags & HTTPPOST_PTRBUFFER) ) {
|
|
||||||
/* copy value (without strdup; possibly contains null characters) */
|
/* copy value (without strdup; possibly contains null characters) */
|
||||||
form->value = memdup(form->value, form->contentslength);
|
form->value = memdup(form->value, form->contentslength);
|
||||||
if(!form->value) {
|
if(!form->value) {
|
||||||
|
@ -748,6 +767,7 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
|
||||||
form->buffer, form->bufferlength,
|
form->buffer, form->bufferlength,
|
||||||
form->contenttype, form->flags,
|
form->contenttype, form->flags,
|
||||||
form->contentheader, form->showfilename,
|
form->contentheader, form->showfilename,
|
||||||
|
form->userp,
|
||||||
post, httppost,
|
post, httppost,
|
||||||
last_post);
|
last_post);
|
||||||
|
|
||||||
|
@ -824,18 +844,25 @@ static CURLcode AddFormData(struct FormData **formp,
|
||||||
return CURLE_OUT_OF_MEMORY;
|
return CURLE_OUT_OF_MEMORY;
|
||||||
newform->next = NULL;
|
newform->next = NULL;
|
||||||
|
|
||||||
/* we make it easier for plain strings: */
|
if(type <= FORM_CONTENT) {
|
||||||
if(!length)
|
/* we make it easier for plain strings: */
|
||||||
length = strlen((char *)line);
|
if(!length)
|
||||||
|
length = strlen((char *)line);
|
||||||
|
|
||||||
newform->line = (char *)malloc(length+1);
|
newform->line = (char *)malloc(length+1);
|
||||||
if(!newform->line) {
|
if(!newform->line) {
|
||||||
free(newform);
|
free(newform);
|
||||||
return CURLE_OUT_OF_MEMORY;
|
return CURLE_OUT_OF_MEMORY;
|
||||||
|
}
|
||||||
|
memcpy(newform->line, line, length);
|
||||||
|
newform->length = length;
|
||||||
|
newform->line[length]=0; /* zero terminate for easier debugging */
|
||||||
}
|
}
|
||||||
memcpy(newform->line, line, length);
|
else
|
||||||
newform->length = length;
|
/* For callbacks and files we don't have any actual data so we just keep a
|
||||||
newform->line[length]=0; /* zero terminate for easier debugging */
|
pointer to whatever this points to */
|
||||||
|
newform->line = (char *)line;
|
||||||
|
|
||||||
newform->type = type;
|
newform->type = type;
|
||||||
|
|
||||||
if(*formp) {
|
if(*formp) {
|
||||||
|
@ -846,7 +873,9 @@ static CURLcode AddFormData(struct FormData **formp,
|
||||||
*formp = newform;
|
*formp = newform;
|
||||||
|
|
||||||
if(size) {
|
if(size) {
|
||||||
if((type == FORM_DATA) || (type == FORM_CONTENT))
|
if(type != FORM_FILE)
|
||||||
|
/* for static content as well as callback data we add the size given
|
||||||
|
as input argument */
|
||||||
*size += length;
|
*size += length;
|
||||||
else {
|
else {
|
||||||
/* Since this is a file to be uploaded here, add the size of the actual
|
/* Since this is a file to be uploaded here, add the size of the actual
|
||||||
|
@ -893,7 +922,8 @@ void Curl_formclean(struct FormData **form_ptr)
|
||||||
|
|
||||||
do {
|
do {
|
||||||
next=form->next; /* the following form line */
|
next=form->next; /* the following form line */
|
||||||
free(form->line); /* free the line */
|
if(form->type <= FORM_CONTENT)
|
||||||
|
free(form->line); /* free the line */
|
||||||
free(form); /* free the struct */
|
free(form); /* free the struct */
|
||||||
|
|
||||||
} while((form = next) != NULL); /* continue */
|
} while((form = next) != NULL); /* continue */
|
||||||
|
@ -997,7 +1027,8 @@ void curl_formfree(struct curl_httppost *form)
|
||||||
|
|
||||||
if( !(form->flags & HTTPPOST_PTRNAME) && form->name)
|
if( !(form->flags & HTTPPOST_PTRNAME) && form->name)
|
||||||
free(form->name); /* free the name */
|
free(form->name); /* free the name */
|
||||||
if( !(form->flags & HTTPPOST_PTRCONTENTS) && form->contents)
|
if( !(form->flags & (HTTPPOST_PTRCONTENTS|HTTPPOST_CALLBACK)) &&
|
||||||
|
form->contents)
|
||||||
free(form->contents); /* free the contents */
|
free(form->contents); /* free the contents */
|
||||||
if(form->contenttype)
|
if(form->contenttype)
|
||||||
free(form->contenttype); /* free the content type */
|
free(form->contenttype); /* free the content type */
|
||||||
|
@ -1188,9 +1219,11 @@ CURLcode Curl_getFormData(struct FormData **finalform,
|
||||||
if(result)
|
if(result)
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
else if((post->flags & HTTPPOST_FILENAME) ||
|
else if(post->flags & (HTTPPOST_FILENAME|HTTPPOST_BUFFER|
|
||||||
(post->flags & HTTPPOST_BUFFER)) {
|
HTTPPOST_CALLBACK)) {
|
||||||
|
/* it should be noted that for the HTTPPOST_FILENAME and
|
||||||
|
HTTPPOST_CALLBACK cases the ->showfilename struct member is always
|
||||||
|
assigned at this point */
|
||||||
char *filebasename=
|
char *filebasename=
|
||||||
(!post->showfilename)?strippath(post->contents):NULL;
|
(!post->showfilename)?strippath(post->contents):NULL;
|
||||||
|
|
||||||
|
@ -1312,7 +1345,14 @@ CURLcode Curl_getFormData(struct FormData **finalform,
|
||||||
if(result)
|
if(result)
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
else if(post->flags & HTTPPOST_CALLBACK) {
|
||||||
|
/* the contents should be read with the callback and the size
|
||||||
|
is set with the contentslength */
|
||||||
|
result = AddFormData(&form, FORM_CALLBACK, post->userp,
|
||||||
|
post->contentslength, &size);
|
||||||
|
if(result)
|
||||||
|
break;
|
||||||
|
}
|
||||||
else {
|
else {
|
||||||
/* include the contents we got */
|
/* include the contents we got */
|
||||||
result = AddFormData(&form, FORM_CONTENT, post->contents,
|
result = AddFormData(&form, FORM_CONTENT, post->contents,
|
||||||
|
@ -1380,21 +1420,29 @@ int Curl_FormInit(struct Form *form, struct FormData *formdata )
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static size_t readfromfile(struct Form *form, char *buffer, size_t size)
|
static size_t readfromfile(struct Form *form, char *buffer,
|
||||||
|
size_t size)
|
||||||
{
|
{
|
||||||
size_t nread;
|
size_t nread;
|
||||||
if(!form->fp) {
|
bool callback = (bool)(form->data->type == FORM_CALLBACK);
|
||||||
/* this file hasn't yet been opened */
|
|
||||||
form->fp = fopen(form->data->line, "rb"); /* b is for binary */
|
|
||||||
if(!form->fp)
|
|
||||||
return (size_t)-1; /* failure */
|
|
||||||
}
|
|
||||||
nread = fread(buffer, 1, size, form->fp);
|
|
||||||
|
|
||||||
if(nread != size) {
|
if(callback)
|
||||||
|
nread = form->fread_func(buffer, 1, size, form->data->line);
|
||||||
|
else {
|
||||||
|
if(!form->fp) {
|
||||||
|
/* this file hasn't yet been opened */
|
||||||
|
form->fp = fopen(form->data->line, "rb"); /* b is for binary */
|
||||||
|
if(!form->fp)
|
||||||
|
return (size_t)-1; /* failure */
|
||||||
|
}
|
||||||
|
nread = fread(buffer, 1, size, form->fp);
|
||||||
|
}
|
||||||
|
if(!nread || nread > size) {
|
||||||
/* this is the last chunk from the file, move on */
|
/* this is the last chunk from the file, move on */
|
||||||
fclose(form->fp);
|
if(!callback) {
|
||||||
form->fp = NULL;
|
fclose(form->fp);
|
||||||
|
form->fp = NULL;
|
||||||
|
}
|
||||||
form->data = form->data->next;
|
form->data = form->data->next;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1421,7 +1469,8 @@ size_t Curl_FormReader(char *buffer,
|
||||||
if(!form->data)
|
if(!form->data)
|
||||||
return 0; /* nothing, error, empty */
|
return 0; /* nothing, error, empty */
|
||||||
|
|
||||||
if(form->data->type == FORM_FILE) {
|
if((form->data->type == FORM_FILE) ||
|
||||||
|
(form->data->type == FORM_CALLBACK)) {
|
||||||
gotsize = readfromfile(form, buffer, wantedsize);
|
gotsize = readfromfile(form, buffer, wantedsize);
|
||||||
|
|
||||||
if(gotsize)
|
if(gotsize)
|
||||||
|
@ -1449,10 +1498,9 @@ size_t Curl_FormReader(char *buffer,
|
||||||
|
|
||||||
form->data = form->data->next; /* advance */
|
form->data = form->data->next; /* advance */
|
||||||
|
|
||||||
} while(form->data && (form->data->type != FORM_FILE));
|
} while(form->data && (form->data->type < FORM_CALLBACK));
|
||||||
/* If we got an empty line and we have more data, we proceed to the next
|
/* If we got an empty line and we have more data, we proceed to the next
|
||||||
line immediately to avoid returning zero before we've reached the end.
|
line immediately to avoid returning zero before we've reached the end. */
|
||||||
This is the bug reported November 22 1999 on curl 6.3. (Daniel) */
|
|
||||||
|
|
||||||
return gotsize;
|
return gotsize;
|
||||||
}
|
}
|
||||||
|
|
|
@ -8,7 +8,7 @@
|
||||||
* | (__| |_| | _ <| |___
|
* | (__| |_| | _ <| |___
|
||||||
* \___|\___/|_| \_\_____|
|
* \___|\___/|_| \_\_____|
|
||||||
*
|
*
|
||||||
* Copyright (C) 1998 - 2007, Daniel Stenberg, <daniel@haxx.se>, et al.
|
* Copyright (C) 1998 - 2008, Daniel Stenberg, <daniel@haxx.se>, et al.
|
||||||
*
|
*
|
||||||
* This software is licensed as described in the file COPYING, which
|
* This software is licensed as described in the file COPYING, which
|
||||||
* you should have received as part of this distribution. The terms
|
* you should have received as part of this distribution. The terms
|
||||||
|
@ -27,8 +27,10 @@
|
||||||
enum formtype {
|
enum formtype {
|
||||||
FORM_DATA, /* form metadata (convert to network encoding if necessary) */
|
FORM_DATA, /* form metadata (convert to network encoding if necessary) */
|
||||||
FORM_CONTENT, /* form content (never convert) */
|
FORM_CONTENT, /* form content (never convert) */
|
||||||
FORM_FILE /* 'line' points to a file name we should read from
|
FORM_CALLBACK, /* 'line' points to the custom pointer we pass to the callback
|
||||||
to create the form data (never convert) */
|
*/
|
||||||
|
FORM_FILE /* 'line' points to a file name we should read from
|
||||||
|
to create the form data (never convert) */
|
||||||
};
|
};
|
||||||
|
|
||||||
/* plain and simple linked list with lines to send */
|
/* plain and simple linked list with lines to send */
|
||||||
|
@ -44,6 +46,7 @@ struct Form {
|
||||||
size_t sent; /* number of bytes of the current line that has
|
size_t sent; /* number of bytes of the current line that has
|
||||||
already been sent in a previous invoke */
|
already been sent in a previous invoke */
|
||||||
FILE *fp; /* file to read from */
|
FILE *fp; /* file to read from */
|
||||||
|
curl_read_callback fread_func; /* fread callback pointer */
|
||||||
};
|
};
|
||||||
|
|
||||||
/* used by FormAdd for temporary storage */
|
/* used by FormAdd for temporary storage */
|
||||||
|
@ -62,6 +65,7 @@ typedef struct FormInfo {
|
||||||
char *showfilename; /* The file name to show. If not set, the actual
|
char *showfilename; /* The file name to show. If not set, the actual
|
||||||
file name will be used */
|
file name will be used */
|
||||||
bool showfilename_alloc;
|
bool showfilename_alloc;
|
||||||
|
char *userp; /* pointer for the read callback */
|
||||||
struct curl_slist* contentheader;
|
struct curl_slist* contentheader;
|
||||||
struct FormInfo *more;
|
struct FormInfo *more;
|
||||||
} FormInfo;
|
} FormInfo;
|
||||||
|
|
|
@ -2507,6 +2507,8 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
|
||||||
}
|
}
|
||||||
|
|
||||||
/* set the read function to read from the generated form data */
|
/* set the read function to read from the generated form data */
|
||||||
|
http->form.fread_func = conn->fread_func; /* get the previously set callback
|
||||||
|
function pointer */
|
||||||
conn->fread_func = (curl_read_callback)Curl_FormReader;
|
conn->fread_func = (curl_read_callback)Curl_FormReader;
|
||||||
conn->fread_in = &http->form;
|
conn->fread_in = &http->form;
|
||||||
|
|
||||||
|
|
|
@ -0,0 +1,68 @@
|
||||||
|
<testcase>
|
||||||
|
#
|
||||||
|
# Server-side
|
||||||
|
<reply>
|
||||||
|
<data mode="text">
|
||||||
|
HTTP/1.1 200 OK
|
||||||
|
Date: Thu, 09 Nov 2010 14:49:00 GMT
|
||||||
|
Server: test-server/fake swsclose
|
||||||
|
Connection: close
|
||||||
|
Content-Type: text/html
|
||||||
|
|
||||||
|
hello
|
||||||
|
</data>
|
||||||
|
</reply>
|
||||||
|
|
||||||
|
# Client-side
|
||||||
|
<client>
|
||||||
|
<server>
|
||||||
|
http
|
||||||
|
</server>
|
||||||
|
# tool is what to use instead of 'curl'
|
||||||
|
<tool>
|
||||||
|
lib554
|
||||||
|
</tool>
|
||||||
|
|
||||||
|
<name>
|
||||||
|
HTTP multi-part formpost using read callback for the file part
|
||||||
|
</name>
|
||||||
|
<command>
|
||||||
|
http://%HOSTIP:%HTTPPORT/554
|
||||||
|
</command>
|
||||||
|
</client>
|
||||||
|
|
||||||
|
#
|
||||||
|
# Verify data after the test has been "shot"
|
||||||
|
<verify>
|
||||||
|
<strippart>
|
||||||
|
s/^------------------------------[a-z0-9]*/------------------------------/
|
||||||
|
s/boundary=----------------------------[a-z0-9]*/boundary=----------------------------/
|
||||||
|
</strippart>
|
||||||
|
# Note that the stripping above removes 12 bytes from every occurance of the
|
||||||
|
# boundary string and since 4 of them are in the body contents, we see
|
||||||
|
# 415 - (4*12) here == 367 bytes.
|
||||||
|
<protocol>
|
||||||
|
POST /554 HTTP/1.1
|
||||||
|
Host: %HOSTIP:%HTTPPORT
|
||||||
|
Accept: */*
|
||||||
|
Content-Length: 415
|
||||||
|
Expect: 100-continue
|
||||||
|
Content-Type: multipart/form-data; boundary=----------------------------
|
||||||
|
|
||||||
|
------------------------------
|
||||||
|
Content-Disposition: form-data; name="sendfile"; filename="postit2.c"
|
||||||
|
|
||||||
|
this is what we post to the silly web server
|
||||||
|
|
||||||
|
------------------------------
|
||||||
|
Content-Disposition: form-data; name="filename"
|
||||||
|
|
||||||
|
postit2.c
|
||||||
|
------------------------------
|
||||||
|
Content-Disposition: form-data; name="submit"
|
||||||
|
|
||||||
|
send
|
||||||
|
--------------------------------
|
||||||
|
</protocol>
|
||||||
|
</verify>
|
||||||
|
</testcase>
|
|
@ -48,7 +48,7 @@ noinst_PROGRAMS = lib500 lib501 lib502 lib503 lib504 lib505 lib506 \
|
||||||
lib507 lib508 lib510 lib511 lib512 lib513 lib514 lib515 lib516 \
|
lib507 lib508 lib510 lib511 lib512 lib513 lib514 lib515 lib516 \
|
||||||
lib517 lib518 lib519 lib520 lib521 lib523 lib524 lib525 lib526 lib527 \
|
lib517 lib518 lib519 lib520 lib521 lib523 lib524 lib525 lib526 lib527 \
|
||||||
lib529 lib530 lib532 lib533 lib536 lib537 lib540 lib541 lib542 lib543 \
|
lib529 lib530 lib532 lib533 lib536 lib537 lib540 lib541 lib542 lib543 \
|
||||||
lib544 lib545 lib547 lib548 lib549 lib552 lib553
|
lib544 lib545 lib547 lib548 lib549 lib552 lib553 lib554
|
||||||
|
|
||||||
# Dependencies (may need to be overriden)
|
# Dependencies (may need to be overriden)
|
||||||
LDADD = $(LIBDIR)/libcurl.la
|
LDADD = $(LIBDIR)/libcurl.la
|
||||||
|
@ -147,3 +147,5 @@ lib549_SOURCES = lib549.c $(SUPPORTFILES)
|
||||||
lib552_SOURCES = lib552.c $(SUPPORTFILES)
|
lib552_SOURCES = lib552.c $(SUPPORTFILES)
|
||||||
|
|
||||||
lib553_SOURCES = lib553.c $(SUPPORTFILES)
|
lib553_SOURCES = lib553.c $(SUPPORTFILES)
|
||||||
|
|
||||||
|
lib554_SOURCES = lib554.c $(SUPPORTFILES)
|
||||||
|
|
|
@ -0,0 +1,130 @@
|
||||||
|
/*****************************************************************************
|
||||||
|
* _ _ ____ _
|
||||||
|
* Project ___| | | | _ \| |
|
||||||
|
* / __| | | | |_) | |
|
||||||
|
* | (__| |_| | _ <| |___
|
||||||
|
* \___|\___/|_| \_\_____|
|
||||||
|
*
|
||||||
|
* $Id$
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include "test.h"
|
||||||
|
|
||||||
|
static char data[]="this is what we post to the silly web server\n";
|
||||||
|
|
||||||
|
struct WriteThis {
|
||||||
|
char *readptr;
|
||||||
|
size_t sizeleft;
|
||||||
|
};
|
||||||
|
|
||||||
|
static size_t read_callback(void *ptr, size_t size, size_t nmemb, void *userp)
|
||||||
|
{
|
||||||
|
struct WriteThis *pooh = (struct WriteThis *)userp;
|
||||||
|
|
||||||
|
if(size*nmemb < 1)
|
||||||
|
return 0;
|
||||||
|
|
||||||
|
if(pooh->sizeleft) {
|
||||||
|
*(char *)ptr = pooh->readptr[0]; /* copy one single byte */
|
||||||
|
pooh->readptr++; /* advance pointer */
|
||||||
|
pooh->sizeleft--; /* less data left */
|
||||||
|
return 1; /* we return 1 byte at a time! */
|
||||||
|
}
|
||||||
|
|
||||||
|
return 0; /* no more data left to deliver */
|
||||||
|
}
|
||||||
|
|
||||||
|
int test(char *URL)
|
||||||
|
{
|
||||||
|
CURL *curl;
|
||||||
|
CURLcode res=CURLE_OK;
|
||||||
|
CURLFORMcode formrc;
|
||||||
|
|
||||||
|
struct curl_httppost *formpost=NULL;
|
||||||
|
struct curl_httppost *lastptr=NULL;
|
||||||
|
struct WriteThis pooh;
|
||||||
|
|
||||||
|
pooh.readptr = data;
|
||||||
|
pooh.sizeleft = strlen(data);
|
||||||
|
|
||||||
|
curl_global_init(CURL_GLOBAL_ALL);
|
||||||
|
|
||||||
|
/* Fill in the file upload field */
|
||||||
|
formrc = curl_formadd(&formpost,
|
||||||
|
&lastptr,
|
||||||
|
CURLFORM_COPYNAME, "sendfile",
|
||||||
|
CURLFORM_STREAM, &pooh,
|
||||||
|
CURLFORM_CONTENTSLENGTH, pooh.sizeleft,
|
||||||
|
CURLFORM_FILENAME, "postit2.c",
|
||||||
|
CURLFORM_END);
|
||||||
|
|
||||||
|
if(formrc)
|
||||||
|
printf("curl_formadd(1) = %d\n", formrc);
|
||||||
|
|
||||||
|
/* Fill in the filename field */
|
||||||
|
formrc = curl_formadd(&formpost,
|
||||||
|
&lastptr,
|
||||||
|
CURLFORM_COPYNAME, "filename",
|
||||||
|
CURLFORM_COPYCONTENTS, "postit2.c",
|
||||||
|
CURLFORM_END);
|
||||||
|
|
||||||
|
if(formrc)
|
||||||
|
printf("curl_formadd(2) = %d\n", formrc);
|
||||||
|
|
||||||
|
/* Fill in a submit field too */
|
||||||
|
formrc = curl_formadd(&formpost,
|
||||||
|
&lastptr,
|
||||||
|
CURLFORM_COPYNAME, "submit",
|
||||||
|
CURLFORM_COPYCONTENTS, "send",
|
||||||
|
CURLFORM_END);
|
||||||
|
|
||||||
|
if(formrc)
|
||||||
|
printf("curl_formadd(3) = %d\n", formrc);
|
||||||
|
|
||||||
|
if (curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
||||||
|
fprintf(stderr, "curl_global_init() failed\n");
|
||||||
|
return TEST_ERR_MAJOR_BAD;
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((curl = curl_easy_init()) == NULL) {
|
||||||
|
fprintf(stderr, "curl_easy_init() failed\n");
|
||||||
|
curl_global_cleanup();
|
||||||
|
return TEST_ERR_MAJOR_BAD;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* First set the URL that is about to receive our POST. */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_URL, URL);
|
||||||
|
|
||||||
|
/* Now specify we want to POST data */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_POST, TRUE);
|
||||||
|
|
||||||
|
/* Set the expected POST size */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_POSTFIELDSIZE, (long)pooh.sizeleft);
|
||||||
|
|
||||||
|
/* we want to use our own read function */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_READFUNCTION, read_callback);
|
||||||
|
|
||||||
|
/* pointer to pass to our read function */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_READDATA, &pooh);
|
||||||
|
|
||||||
|
/* send a multi-part formpost */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_HTTPPOST, formpost);
|
||||||
|
|
||||||
|
/* get verbose debug output please */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_VERBOSE, 1);
|
||||||
|
|
||||||
|
/* include headers in the output */
|
||||||
|
curl_easy_setopt(curl, CURLOPT_HEADER, TRUE);
|
||||||
|
|
||||||
|
/* Perform the request, res will get the return code */
|
||||||
|
res = curl_easy_perform(curl);
|
||||||
|
|
||||||
|
/* always cleanup */
|
||||||
|
curl_easy_cleanup(curl);
|
||||||
|
curl_global_cleanup();
|
||||||
|
|
||||||
|
/* now cleanup the formpost chain */
|
||||||
|
curl_formfree(formpost);
|
||||||
|
|
||||||
|
return res;
|
||||||
|
}
|
Loading…
Reference in New Issue