moparisthebest
/
curl
mirror of https://github.com/moparisthebest/curl
1
0
Fork 0
Code Issues Releases Wiki Activity

operate_do: skip superfluous check for NULL pointer 

Coverity CID 1243583. get_url_file_name() cannot fail and return a NULL
file name pointer so skip the check for that - it tricks coverity into
believing it can happen and it then warns later on when we use 'outfile'
without checking for NULL.
This commit is contained in:
Daniel Stenberg 2014-10-08 12:21:39 +02:00
parent e0d269c0d8
commit 987a4a7367
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tool_operate.c
View File

@ -543,7 +543,7 @@ static CURLcode operate_do(struct GlobalConfig *global,
res = get_url_file_name(&outfile, this_url);
if(res)
goto show_error;
if((!outfile || !*outfile) && !config->content_disposition) {
if(!*outfile && !config->content_disposition) {
helpf(global->errors, "Remote file name has no length!\n");
res = CURLE_WRITE_ERROR;
goto quit_urls;