From 987a4a7367ac8df32628ba738342e2206582f1e7 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Wed, 8 Oct 2014 12:21:39 +0200 Subject: [PATCH] operate_do: skip superfluous check for NULL pointer Coverity CID 1243583. get_url_file_name() cannot fail and return a NULL file name pointer so skip the check for that - it tricks coverity into believing it can happen and it then warns later on when we use 'outfile' without checking for NULL. --- src/tool_operate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tool_operate.c b/src/tool_operate.c index 488fb08c4..7448cad9c 100644 --- a/src/tool_operate.c +++ b/src/tool_operate.c @@ -543,7 +543,7 @@ static CURLcode operate_do(struct GlobalConfig *global, res = get_url_file_name(&outfile, this_url); if(res) goto show_error; - if((!outfile || !*outfile) && !config->content_disposition) { + if(!*outfile && !config->content_disposition) { helpf(global->errors, "Remote file name has no length!\n"); res = CURLE_WRITE_ERROR; goto quit_urls;