* fix .xpi packaging

* move ctypes related modules to modules/ctypes/

TODO

@@ -1,6 +1,8 @@
 TODO
 ----
 
+* use for (var i = 0; myArray[i++];) instead of i<myArray.length
+
 * add entry to popup menu when registering
 
 WONTFIX

src/Makefile

@@ -84,7 +84,10 @@ chrome_sources := $(chrome_sources_js) \
 modules_dir := modules
 
 # The sources for the module files.
-modules_sources := $(wildcard $(modules_dir)/*.js) $(wildcard $(modules_dir)/*.jsm)
+modules_sources := $(wildcard $(modules_dir)/*.js) \
+		$(wildcard $(modules_dir)/*.jsm) \
+		$(wildcard $(modules_dir)/ctypes/*.jsm) \
+		$(wildcard $(modules_dir)/gtk2/*.jsm)
 
 # The sources for the XPI file. Uses variables defined in the included
 # Makefiles.

src/chrome/content/options.js

@@ -382,7 +382,6 @@ var firetrayUIOptions = {
       let accountOrServerTypeOrder = parseInt(
         tree.view.getCellText(
           i, tree.columns.getNamedColumn("account_or_server_type_order")));
-
       LOG("account: "+accountOrServerTypeName+", "+accountOrServerTypeExcluded);
 
       if (tree.view.getLevel(i) === TREELEVEL_SERVER_TYPES) {

src/modules/FiretrayHandler.jsm

@@ -8,8 +8,8 @@ const Cu = Components.utils;
 
 Cu.import("resource://gre/modules/Services.jsm");
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/gobject.jsm");
-Cu.import("resource://firetray/gtk.jsm");
+Cu.import("resource://firetray/ctypes/gobject.jsm");
+Cu.import("resource://firetray/ctypes/gtk.jsm");
 Cu.import("resource://firetray/commons.js");
 
 /**

src/modules/FiretrayMessaging.jsm

@@ -8,7 +8,6 @@ const Cu = Components.utils;
 
 Cu.import("resource:///modules/mailServices.js");
 Cu.import("resource://gre/modules/PluralForm.jsm");
-// Cu.import("resource://firetray/FiretrayHandler.jsm");
 Cu.import("resource://firetray/commons.js");
 
 const FLDRS_UNINTERESTING = {
@@ -35,7 +34,7 @@ firetray.Messaging = {
 
   init: function() {
     if (this.initialized) {
-      LOG("Messaging already initialized");
+      WARN("Messaging already initialized");
       return;
     }
     LOG("Enabling Messaging");

src/modules/commons.js

@@ -68,11 +68,10 @@ firetray.Utils = {
   },
 
   QueryInterfaces: function(obj) {
-    for each (i in Components.interfaces) {
+    for each (i in Components.interfaces)
       try {
-        if (obj instanceof i) { LOG(i); }
-      } catch (x) {}
-    }
+        if (obj instanceof i) LOG (i);
+      } catch(x) {}
   },
 
   // adapted from http://forums.mozillazine.org/viewtopic.php?p=921150#921150

src/modules/ctypes/cairo.jsm

@@ -10,7 +10,7 @@ const Cc = Components.classes;
 const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
 
 function cairo_defines(lib) {
   this.cairo_t = ctypes.StructType("cairo_t");

src/modules/ctypes/gdk.jsm

@@ -47,11 +47,11 @@ const Cc = Components.classes;
 const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
-Cu.import("resource://firetray/cairo.jsm");
-Cu.import("resource://firetray/glib.jsm");
-Cu.import("resource://firetray/gobject.jsm");
-Cu.import("resource://firetray/x11.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/cairo.jsm");
+Cu.import("resource://firetray/ctypes/glib.jsm");
+Cu.import("resource://firetray/ctypes/gobject.jsm");
+Cu.import("resource://firetray/ctypes/x11.jsm");
 
 function gdk_defines(lib) {
   this.GdkInterpType = ctypes.int; // enum

src/modules/ctypes/glib.jsm

@@ -10,7 +10,7 @@ const Cc = Components.classes;
 const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
 
 function glib_defines(lib) {
   /* mutual inclusion not possible */

src/modules/ctypes/gobject.jsm

@@ -47,8 +47,8 @@ const Cc = Components.classes;
 const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
-Cu.import("resource://firetray/glib.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/glib.jsm");
 
 function gobject_defines(lib) {
 

src/modules/ctypes/gtk.jsm

@@ -10,10 +10,10 @@ const Cc = Components.classes;
 const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
-Cu.import("resource://firetray/gdk.jsm");
-Cu.import("resource://firetray/gobject.jsm");
-Cu.import("resource://firetray/pango.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/gdk.jsm");
+Cu.import("resource://firetray/ctypes/gobject.jsm");
+Cu.import("resource://firetray/ctypes/pango.jsm");
 
 function gtk_defines(lib) {
   this.GTK_ICON_SIZE_MENU = 1; // enum GtkIconSize

src/modules/ctypes/libc.jsm

@@ -10,7 +10,7 @@ const Cc = Components.classes;
 const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
 
 function libc_defines(lib) {
   this.FILE = ctypes.StructType("FILE");

src/modules/ctypes/pango.jsm

@@ -12,9 +12,9 @@ const Cc = Components.classes;
 const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
-Cu.import("resource://firetray/cairo.jsm");
-Cu.import("resource://firetray/gobject.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/cairo.jsm");
+Cu.import("resource://firetray/ctypes/gobject.jsm");
 
 function pango_defines(lib) {
   this.PANGO_WEIGHT_THIN       = 100;

src/modules/ctypes/x11.jsm

@@ -15,7 +15,7 @@ const Ci = Components.interfaces;
 
 Cu.import("resource://gre/modules/Services.jsm");
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypes-utils.jsm");
+Cu.import("resource://firetray/ctypes/ctypes-utils.jsm");
 Cu.import("resource://firetray/logging.jsm");
 
 const XATOMS_ICCCM = [ "WM_DELETE_WINDOW", "WM_STATE", "WM_CHANGE_STATE" ];

src/modules/gtk2/FiretrayStatusIcon.jsm

@@ -9,12 +9,12 @@ const Cu = Components.utils;
 Cu.import("resource://gre/modules/Services.jsm");
 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/cairo.jsm");
-Cu.import("resource://firetray/gobject.jsm");
-Cu.import("resource://firetray/gdk.jsm");
-Cu.import("resource://firetray/gtk.jsm");
-Cu.import("resource://firetray/libc.jsm");
-Cu.import("resource://firetray/pango.jsm");
+Cu.import("resource://firetray/ctypes/cairo.jsm");
+Cu.import("resource://firetray/ctypes/gobject.jsm");
+Cu.import("resource://firetray/ctypes/gdk.jsm");
+Cu.import("resource://firetray/ctypes/gtk.jsm");
+Cu.import("resource://firetray/ctypes/libc.jsm");
+Cu.import("resource://firetray/ctypes/pango.jsm");
 Cu.import("resource://firetray/commons.js");
 
 if ("undefined" == typeof(firetray.Handler))

src/modules/gtk2/FiretrayWindow.jsm

@@ -16,12 +16,12 @@ const Cu = Components.utils;
 Cu.import("resource://gre/modules/Services.jsm");
 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
 Cu.import("resource://gre/modules/ctypes.jsm");
-Cu.import("resource://firetray/ctypesMap.jsm");
-Cu.import("resource://firetray/gobject.jsm");
-Cu.import("resource://firetray/gdk.jsm");
-Cu.import("resource://firetray/gtk.jsm");
-Cu.import("resource://firetray/libc.jsm");
-Cu.import("resource://firetray/x11.jsm");
+Cu.import("resource://firetray/ctypes/ctypesMap.jsm");
+Cu.import("resource://firetray/ctypes/gobject.jsm");
+Cu.import("resource://firetray/ctypes/gdk.jsm");
+Cu.import("resource://firetray/ctypes/gtk.jsm");
+Cu.import("resource://firetray/ctypes/libc.jsm");
+Cu.import("resource://firetray/ctypes/x11.jsm");
 Cu.import("resource://firetray/commons.js");
 
 const Services2 = {};
@@ -98,11 +98,8 @@ firetray.Window = {
    * @param userData: _find_data_t
    */
   _findGtkWindowByTitle: function(gtkWidget, userData) {
-    // LOG("GTK Window: "+gtkWidget+", "+userData);
-
     let data = ctypes.cast(userData, _find_data_t.ptr);
     let inTitle = data.contents.inTitle;
-    // LOG("inTitle="+inTitle.readString());
 
     let gtkWin = ctypes.cast(gtkWidget, gtk.GtkWindow.ptr);
     let winTitle = gtk.gtk_window_get_title(gtkWin);
@@ -332,8 +329,7 @@ firetray.Handler.gdkWindows = new ctypesMap(gdk.GdkWindow.ptr),
 /** debug facility */
 firetray.Handler.dumpWindows = function() {
   LOG(firetray.Handler.windowsCount);
-  for (let winId in firetray.Handler.windows)
-    LOG(winId+"="+firetray.Handler.gtkWindows.get(winId));
+  for (let winId in firetray.Handler.windows) LOG(winId+"="+firetray.Handler.gtkWindows.get(winId));
 };
 
 firetray.Handler.registerWindow = function(win) {