moparisthebest/FireTray
1
0
Fork 0
mirror of https://github.com/moparisthebest/FireTray synced 2025-01-07 19:48:03 -05:00
Code Issues Releases Wiki Activity

Cleaning.

Browse Source 
...trying to less alter "oncommand" attributes, following AMO review.
addEventListener() won't help here (see
http://forums.mozillazine.org/viewtopic.php?f=19&t=2696969).

Note: There seem to be some cases where we would want to keep "oncommand" or
"command" attributes (setting them to "void(0);"), for ex. for <key> elements
(see http://stackoverflow.com/q/16779316/421846).
This commit is contained in:
foudfou 2014-10-12 23:23:05 +02:00
parent 0cfe58e410
commit 2cf236bf14
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/chrome/content/options.js
View File

@ -78,7 +78,7 @@ var firetrayUIOptions = {
'ui_radiogroup_scroll'].forEach(function(id){ 'ui_radiogroup_scroll'].forEach(function(id){
document.getElementById(id).hidden = true; document.getElementById(id).hidden = true;
}); });
document.getElementById("ui_scroll_hides").setAttribute("oncommand", void(0)); document.getElementById("ui_scroll_hides").removeAttribute("oncommand");
// mail prefs // mail prefs
document.getElementById("newmail_icon_names").hidden = true; document.getElementById("newmail_icon_names").hidden = true;

4
src/chrome/content/overlay.js
View File

@ -79,8 +79,8 @@ var firetrayChrome = { // each new window gets a new firetrayChrome !
let fInfo = firetrayChrome.replaceCommand(id, button.new); let fInfo = firetrayChrome.replaceCommand(id, button.new);
if (fInfo) { if (fInfo) {
button.old = fInfo[0]; button.old = fInfo[0];
firetray_log.debug('replaced command='+button.id+' type='+fInfo[1]+' func='+fInfo[0]);
button.type = fInfo[1]; button.type = fInfo[1];
firetray_log.debug('replaced command='+id+' type='+fInfo[1]+' func='+fInfo[0]);
} }
}, this); }, this);
}, },
@ -120,7 +120,7 @@ var firetrayChrome = { // each new window gets a new firetrayChrome !
type = FIRETRAY_XUL_ATTRIBUTE_ONCOMMAND; type = FIRETRAY_XUL_ATTRIBUTE_ONCOMMAND;
let prev = elt.getAttribute("oncommand"); let prev = elt.getAttribute("oncommand");
old = new Function(prev); old = new Function(prev);
elt.setAttribute("oncommand", void(0)); elt.removeAttribute("oncommand");
elt.addEventListener('command', func, false); elt.addEventListener('command', func, false);
} else { } else {
firetray_log.warn('Could not replace oncommand on '+eltId); firetray_log.warn('Could not replace oncommand on '+eltId);