mirror/Shipwright
1
0
Fork 0
mirror of https://github.com/HarbourMasters/Shipwright.git synced 2024-11-29 12:52:18 -05:00
Code Issues Projects Releases Wiki Activity

ComboBox Simplification

Browse Source
This commit is contained in:
Baoulettes 2022-05-19 19:48:49 +02:00 committed by GitHub
parent 076887e71f
commit bc6def77a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
libultraship/libultraship/SohImGuiImpl.cpp
View File

@ -390,6 +390,32 @@ namespace SohImGui {
} }
} }
void EnhancementCombobox(const char* cvarname, const char* ComboArray[], s16 FirstTimeValue = -1){
//The -1 do not force the make to add a default value
if (FirstTimeValue < 0){
//If there is no default value it will pass this condition
FirstTimeValue = 0;
}
//And now we set the default value to the CVar fallback
//This way we ensure to show the number we want the user to see the first time
s16 selected=CVar_GetS32(cvarname, FirstTimeValue);
//Now we set the fetched value to the drop box.
//This way if a player set something else than the default it will show their selection.
s16 DefaultValue=selected;
if (ImGui::BeginCombo("##cvarname", ComboArray[DefaultValue])) {
s16 ComboxSize = sizeof(&ComboArray) / sizeof(ComboArray[0]);
//Seem like it does not count entry 0 so it end up doing 0, 1, 2 and count 2 not 3
for (uint8_t i = 0; i <= ComboxSize+1; i++) {
if (ImGui::Selectable(ComboArray[i], i==selected)) {
CVar_SetS32(cvarname, i);
selected=i;
needs_save = true;
}
}
ImGui::EndCombo();
}
}
void EnhancementRadioButton(std::string text, std::string cvarName, int id) { void EnhancementRadioButton(std::string text, std::string cvarName, int id) {
/*Usage : /*Usage :
EnhancementRadioButton("My Visible Name","gMyCVarName", MyID); EnhancementRadioButton("My Visible Name","gMyCVarName", MyID);
@ -634,20 +660,9 @@ namespace SohImGui {
EXPERIMENTAL(); EXPERIMENTAL();
ImGui::Text("Texture Filter (Needs reload)"); ImGui::Text("Texture Filter (Needs reload)");
EnhancementCombobox("gTextureFilter", filters);
GfxRenderingAPI* gapi = gfx_get_current_rendering_api(); GfxRenderingAPI* gapi = gfx_get_current_rendering_api();
if (ImGui::BeginCombo("##filters", filters[gapi->get_texture_filter()])) { gapi->set_texture_filter((FilteringMode)CVar_GetS32("gTextureFilter", 0));
for (int fId = 0; fId <= FilteringMode::NONE; fId++) {
if (ImGui::Selectable(filters[fId], fId == gapi->get_texture_filter())) {
INFO("New Filter: %s", filters[fId]);
gapi->set_texture_filter((FilteringMode)fId);
CVar_SetS32("gTextureFilter", (int)fId);
needs_save = true;
}
}
ImGui::EndCombo();
}
overlay->DrawSettings(); overlay->DrawSettings();
ImGui::EndMenu(); ImGui::EndMenu();
} }