From 8496245e85a92176af6466f31d3553bf1c0b7af4 Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot Date: Mon, 3 Oct 2016 23:32:43 +0100 Subject: [PATCH] checkdeadlinks: Move the main functionality into a separate function. --- checkdeadlinks.py | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/checkdeadlinks.py b/checkdeadlinks.py index e58ed1d3..bae091b4 100755 --- a/checkdeadlinks.py +++ b/checkdeadlinks.py @@ -70,28 +70,31 @@ def is_dead(url): else: return False +def get_deadlinks(xep, is_verbose=False): + global xepnum + xepnum = '%04d' % xep + + global verbose + verbose = is_verbose + + xepfile = 'xep-' + xepnum + '.xml' + thexep = parse(xepfile) + + urls = [link.getAttribute("url") for link in thexep.getElementsByTagName("link")] + urls += [image.getAttribute("src") for image in thexep.getElementsByTagName("img")] + + if verbose: + print('Checking XEP-%s (%d links):' % (xepnum, len(urls))) + + return [url for url in set(urls) if is_dead(url)] + def main(): parser = ArgumentParser(description=__doc__) parser.add_argument('-v', '--verbose', action='store_true', help='Enables more verbosity') parser.add_argument('-x', '--xep', type=int, help='Defines the number of the XEP to check') args = parser.parse_args() - global xepnum - xepnum = '%04d' % args.xep - - global verbose - verbose = args.verbose - - xepfile = 'xep-' + xepnum + '.xml' - thexep = parse(xepfile) - - if verbose: - print('Checking XEP-' + xepnum + ':') - - urls = [link.getAttribute("url") for link in thexep.getElementsByTagName("link")] - urls += [image.getAttribute("src") for image in thexep.getElementsByTagName("img")] - - deadlinks = [url for url in set(urls) if is_dead(url)] + deadlinks = get_deadlinks(args.xep, args.verbose) if deadlinks: for url in deadlinks: