moparisthebest/xeps
1
0
Fork 0
mirror of https://github.com/moparisthebest/xeps synced 2024-11-21 08:45:04 -05:00
Code Issues Releases Wiki Activity

for #1235: Remove redundant braces in if-expression

Browse Source 
As per @horazont's feedback:
> You do not need () around the command in an if. I think that causes a subshell to spawn, the effects of which I'm not certain about.

Further Googling suggests that the exit status of a pipeline is that of the most recently executed foreground pipeline, meaning that the exit code can be used directly in conditional statements.
This commit is contained in:
Guus der Kinderen 2022-11-06 09:33:59 +01:00
parent d65a5b4c2f
commit 7389c8a3e9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/validate-xep0001-conformance.sh
View File

@ -18,7 +18,7 @@ VALIDATION_RESULT=0
# 1. Check DTD conformance against xep.dtd
XEP_DTD="xep.dtd"
if (xmllint --noout --dtdvalid "$XEP_DTD" "$1")
if xmllint --noout --dtdvalid "$XEP_DTD" "$1"
then
echo "[PASS] DTD conformance against xep.dtd"
else
@ -32,7 +32,7 @@ HEADER_STATUS=$(xmllint --xpath '/xep/header/status/text()' --nowarning --dtdval
HEADER_TYPE=$(xmllint --xpath '/xep/header/type/text()' --nowarning --dtdvalid "$XEP_DTD" $1)
HEADER_APPROVER=$(xmllint --xpath '/xep/header/approver/text()' --nowarning --dtdvalid "$XEP_DTD" $1)
if (echo "$FILE_NAME" | grep -Eq "^xep-[0-9]{4}.xml$")
if echo "$FILE_NAME" | grep -Eq "^xep-[0-9]{4}.xml$"
then
echo "[INFO] The filename ('$FILE_NAME') matches 'xep-[0-9]{4}.xml'."
# 2. If the filename matches xep-[0-9]{4}.xml, check:
@ -66,7 +66,7 @@ else
fi
# 3.3 That the name does not start with xep-[0-9]
if (echo "$FILE_NAME" | grep -Eq "^xep-[0-9].*$")
if echo "$FILE_NAME" | grep -Eq "^xep-[0-9].*$"
then
echo "[FAIL] The filename ('$FILE_NAME') starts with 'xep-[0-9]' (but should not)."
VALIDATION_RESULT=1;