checkdeadlinks: Move the checking code into its own is_dead() function.

checkdeadlinks.py

@@ -50,25 +50,7 @@ import urllib2
 
 from xml.dom.minidom import parse,parseString,Document
 
-def main():
-    parser = ArgumentParser(description=__doc__)
-    parser.add_argument('-v', '--verbose', action='store_true', help='Enables more verbosity')
-    parser.add_argument('-x', '--xep', type=int, help='Defines the number of the XEP to check')
-    args = parser.parse_args()
-
-    xepnum = '%04d' % args.xep
-    verbose = args.verbose
-
-    xepfile = 'xep-' + xepnum + '.xml'
-    thexep = parse(xepfile)
-
-    links = thexep.getElementsByTagName("link")
-    deadlinks = 0
-    if verbose:
-        print 'Checking XEP-' + xepnum + ':'
-
-    for link in links:
-        url = link.getAttribute("url")
+def is_dead(url):
     if re.match("^(http|https)", url):
         if verbose:
             print url + ' :',
@@ -82,10 +64,38 @@ def main():
             reason = str(e)
             if verbose:
                 print "XEP-" + xepnum + " - DEAD: " + url + " [" + reason + "]"
-                deadlinks = deadlinks + 1
+            return True
         else:
             if verbose:
                 print 'OK'
+            return False
+    else:
+        return False
+
+def main():
+    parser = ArgumentParser(description=__doc__)
+    parser.add_argument('-v', '--verbose', action='store_true', help='Enables more verbosity')
+    parser.add_argument('-x', '--xep', type=int, help='Defines the number of the XEP to check')
+    args = parser.parse_args()
+
+    global xepnum
+    xepnum = '%04d' % args.xep
+
+    global verbose
+    verbose = args.verbose
+
+    xepfile = 'xep-' + xepnum + '.xml'
+    thexep = parse(xepfile)
+
+    links = thexep.getElementsByTagName("link")
+    deadlinks = 0
+    if verbose:
+        print 'Checking XEP-' + xepnum + ':'
+
+    for link in links:
+        url = link.getAttribute("url")
+        if is_dead(url):
+            deadlinks += 1
 
     if deadlinks > 0:
         sys.exit(1)