1
0
mirror of https://github.com/moparisthebest/xeps synced 2024-11-21 08:45:04 -05:00

Add script for aiding triage

This commit is contained in:
Kevin Smith 2023-02-28 17:51:30 +00:00
parent 058ee26930
commit 55b5372038
2 changed files with 84 additions and 8 deletions

77
tools/local-triage.py Executable file
View File

@ -0,0 +1,77 @@
#!/usr/bin/env python3
# Run this on its own (in the root of the xeps repo checkout) to iterate
# over open PRs triaging them. It's a wrapper around the `gh` github command
# and the triage.sh script, checking out each PR (as requested) in
# a distinct worktree, and binning it afterwards.
#
# Supply a single parameter of a GitHub PR number to only look at that PR.
#
# I make no claim about the quality of the Python involved, this was a quick
# hack for my (Kev's) benefit.
import subprocess
import sys
class PR:
def __init__(self, line):
s = line.split('\t')
self.number = s[0]
self.title = s[1]
self.branch = s[2]
self.state = s[3]
def __str__(self):
return f'PR#{self.number}({self.branch}): {self.title}'
def exec(command) -> str:
process = subprocess.Popen(command, stdout=subprocess.PIPE, shell=True)
(stdout, stderr) = process.communicate()
exit_code = process.wait()
if exit_code == 0:
return stdout.decode()
return ""
def exec_with_err(command, cwd=None) -> str:
process = subprocess.Popen(
command, stdout=subprocess.PIPE, shell=True, cwd=cwd)
(stdout, stderr) = process.communicate()
exit_code = process.wait()
return stdout.decode() + ('\n' + stderr.decode() if stderr else "")
def open_prs() -> list[str]:
lines = exec("gh pr list -R xsf/xeps --limit=100").splitlines()
prs = []
for line in lines:
prs.append(PR(line))
return prs
exec("git fetch")
prs = open_prs()
print(f'{len(prs)} PRs')
for pr in prs:
if len(sys.argv) > 1 and pr.number != sys.argv[1]:
continue
if pr.state != 'OPEN':
print(f"Skipping PR in state {pr.state}:\n{pr}")
continue
print(pr)
choice = 'invalid'
while choice != 'c' and choice != '':
choice = input("Check labels (c), Open on GitHub (o) or skip (enter):")
if choice == 'o':
exec(f'gh pr view -w -R xsf/xeps {pr.number}')
if choice == '':
continue
worktree_path = f'pr-worktree/{pr.number}'
exec(f'git fetch origin +refs/pull/{pr.number}/merge')
exec(f'git worktree add {worktree_path} FETCH_HEAD')
triage = exec_with_err(f'../../tools/triage.sh "{pr.title}"', worktree_path)
print(triage)
print(f'Worktree checked out in {worktree_path}')
input('Enter to remove worktree and continue')
exec(f'git worktree remove {worktree_path}')

View File

@ -107,11 +107,10 @@ do
xep_num="XEP-$(echo "$xep" | grep -Eo '[0-9]{4}')"
if ! echo "$pr_title" | grep "$xep_num" &>/dev/null
then
echo "error: title did not include '$xep_num'"
exit 1
echo "warning: title did not include '$xep_num'"
fi
status="$(xpath "$xep" '/xep/header/status/text()')"
status="$(xpath "$xep" '/xep/header/status/text()')"
approvers=""
if echo "$status" | grep -E '^(Experimental|Deferred)$' &>/dev/null
then
@ -121,15 +120,15 @@ do
echo "tag: needs-editor-action"
echo "manual: move $xep_num status to Experimental before or with merge"
fi
approvers="$(xpath "$xep" '/xep/header/author/email/text()' | sort -u)"
else
# *not* Experimental or Deferred
approvers="$(xpath "$xep" '/xep/header/approver/text()' 2>/dev/null || echo 'Unknown')"
fi
echo "info: $xep_num status '$status' needs approvers: '$(echo "$approvers" | tr '\n' ' ' | xargs)'"
new_all_approvers="$(echo -e "$all_approvers\n$approvers" | sort -u)"
if [ "$all_approvers" != "$new_all_approvers" ]
then
@ -143,7 +142,7 @@ do
fi
all_approvers="$new_all_approvers"
fi
# check revision block added and minor version bump
versions="$(xpath "$xep" '/xep/header/revision/version/text()')"
latest_num_versions="$(echo "$versions" | wc -l)"