From 569717abdc90c5f4cca81d9785b143a8d2b6a67b Mon Sep 17 00:00:00 2001 From: Frederic Hemberger Date: Mon, 26 Sep 2011 14:37:01 +0200 Subject: [PATCH 1/3] jsHint'ed github.js --- .themes/classic/source/javascripts/github.js | 70 +++++++++----------- 1 file changed, 33 insertions(+), 37 deletions(-) diff --git a/.themes/classic/source/javascripts/github.js b/.themes/classic/source/javascripts/github.js index 623d493..0187743 100644 --- a/.themes/classic/source/javascripts/github.js +++ b/.themes/classic/source/javascripts/github.js @@ -1,43 +1,39 @@ -github = (function(){ - function render(target, repos){ - var i = 0, fragment = '', t = $(target)[0]; +var github = (function(){ + function render(target, repos){ + var i = 0, fragment = '', t = $(target)[0]; - for(i = 0; i < repos.length; i++) - fragment += '
  • '+repos[i].name+'

    '+repos[i].description+'

  • '; - - t.innerHTML = fragment; + for(i = 0; i < repos.length; i++) { + fragment += '
  • '+repos[i].name+'

    '+repos[i].description+'

  • '; } - return { - showRepos: function(options){ - var feed = new jXHR(); - feed.onerror = function (msg,url) { - $(options.target + ' li.loading').addClass('error').text("Error loading feed"); - } - feed.onreadystatechange = function(data){ - if (feed.readyState === 4) { - var repos = []; - var i; - for (i = 0; i < data.repositories.length; i++){ - if (options.skip_forks && data.repositories[i].fork) - continue; - repos.push(data.repositories[i]); - } - repos.sort(function(a, b){ - var a = new Date(a.pushed_at), - b = new Date(b.pushed_at); + t.innerHTML = fragment; + } + return { + showRepos: function(options){ + var feed = new jXHR(); + feed.onerror = function (msg,url) { + $(options.target + ' li.loading').addClass('error').text("Error loading feed"); + }; + feed.onreadystatechange = function(data) { + if (feed.readyState === 4) { + var repos = []; + for (var i = 0; i < data.repositories.length; i++){ + if (options.skip_forks && data.repositories[i].fork) { continue; } + repos.push(data.repositories[i]); + } + repos.sort(function(a, b) { + var aDate = new Date(a.pushed_at).valueOf(), + bDate = new Date(b.pushed_at).valueOf(); - if (a.valueOf() == b.valueOf()) return 0; - return a.valueOf() > b.valueOf() ? -1 : 1; - }); + if (aDate === bDate) { return 0; } + return aDate > bDate ? -1 : 1; + }); - if (options.count) - repos.splice(options.count); - - render(options.target, repos) - } - }; - feed.open("GET","http://github.com/api/v2/json/repos/show/"+options.user+"?callback=?"); - feed.send(); + if (options.count) { repos.splice(options.count); } + render(options.target, repos); } - }; + }; + feed.open("GET","http://github.com/api/v2/json/repos/show/"+options.user+"?callback=?"); + feed.send(); + } + }; })(); \ No newline at end of file From ab62bb93558db7a422ee9c1b87e1b524b57dc5a4 Mon Sep 17 00:00:00 2001 From: Frederic Hemberger Date: Mon, 26 Sep 2011 14:41:39 +0200 Subject: [PATCH 2/3] jsHint'ed octopress.js --- .themes/classic/source/javascripts/octopress.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.themes/classic/source/javascripts/octopress.js b/.themes/classic/source/javascripts/octopress.js index 35174fd..c369625 100644 --- a/.themes/classic/source/javascripts/octopress.js +++ b/.themes/classic/source/javascripts/octopress.js @@ -6,7 +6,7 @@ function getNav() { mobileNav.children('select').append(''); }); mobileNav.children('select').bind('change', function(event) { - if (event.target.value) window.location.href = event.target.value; + if (event.target.value) { window.location.href = event.target.value; } }); } @@ -52,7 +52,7 @@ function testFeatures() { } function addCodeLineNumbers() { - if (navigator.appName == 'Microsoft Internet Explorer') { return; } + if (navigator.appName === 'Microsoft Internet Explorer') { return; } $('div.gist-highlight').each(function(code) { var tableStart = '
    ', lineNumbers = '
    ',
    @@ -72,7 +72,7 @@ function flashVideoFallback(){
           flashplayerskin = "/assets/jwplayer/glow/glow.xml";
       $('video').each(function(video){
         video = $(video);
    -    if (!Modernizr.video.h264 && swfobject.getFlashPlayerVersion() || window.location.hash.indexOf("flash-test") != -1){
    +    if (!Modernizr.video.h264 && swfobject.getFlashPlayerVersion() || window.location.hash.indexOf("flash-test") !== -1){
           video.children('source[src$=mp4]').first().map(function(source){
             var src = $(source).attr('src'),
                 id = 'video_'+Math.round(1 + Math.random()*(100000)),
    
    From fdf6af1d25ddc991c96dc3b4df5f7e913adcd7ef Mon Sep 17 00:00:00 2001
    From: Frederic Hemberger 
    Date: Mon, 26 Sep 2011 15:58:14 +0200
    Subject: [PATCH 3/3] Fixes img tag properties
    
    ---
     plugins/image_tag.rb | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    
    diff --git a/plugins/image_tag.rb b/plugins/image_tag.rb
    index 20595cb..4567000 100644
    --- a/plugins/image_tag.rb
    +++ b/plugins/image_tag.rb
    @@ -30,9 +30,9 @@ module Jekyll
               @img['title']  = title
               @img['alt']    = alt
             else
    -          @img['alt']    = @img['title'].gsub!(/"/, '"')
    +          @img['alt']    = @img['title'].gsub!(/"/, '"') if @img['title']
             end
    -        @img['class'].gsub!(/"/, '')
    +        @img['class'].gsub!(/"/, '') if @img['class']
           end
           super
         end