From a9a901c1362f6a4d6004f445629077e7633abb28 Mon Sep 17 00:00:00 2001 From: Frederic Hemberger Date: Wed, 21 Sep 2011 14:48:38 +0200 Subject: [PATCH] Fixed misuse of ARIA roles (see http://dev.opera.com/articles/view/introduction-to-wai-aria/) --- .themes/classic/sass/base/_layout.scss | 12 ++++++------ .themes/classic/sass/base/_theme.scss | 2 +- .themes/classic/sass/partials/_blog.scss | 2 +- .themes/classic/sass/partials/_navigation.scss | 8 ++++---- .themes/classic/sass/partials/sidebar/_base.scss | 2 +- .../classic/source/_includes/custom/navigation.html | 2 +- .themes/classic/source/_includes/navigation.html | 4 ++-- .themes/classic/source/_layouts/default.html | 6 +++--- .themes/classic/source/_layouts/page.html | 4 ++-- .themes/classic/source/_layouts/post.html | 4 ++-- .themes/classic/source/index.html | 4 ++-- .themes/classic/source/javascripts/octopress.js | 8 ++++---- 12 files changed, 29 insertions(+), 29 deletions(-) diff --git a/.themes/classic/sass/base/_layout.scss b/.themes/classic/sass/base/_layout.scss index 4a3c780..c347af1 100644 --- a/.themes/classic/sass/base/_layout.scss +++ b/.themes/classic/sass/base/_layout.scss @@ -41,7 +41,7 @@ body { max-width: $max-width; position: relative; margin: 0 auto; - > header, > nav, > footer, #content > article, #content > div > article, #content > div > section, nav[role=pagination] { + > header, > nav, > footer, #content > article, #content > div > article, #content > div > section, nav.pagination { @extend .group; padding-left: $pad-min; padding-right: $pad-min; @@ -67,7 +67,7 @@ body { #content { > div, > article { width: 100%; }} -aside[role=sidebar] { +aside.sidebar { float: none; padding: 0 $pad-min 1px; background-color: lighten($sidebar-bg, 2); @@ -88,7 +88,7 @@ aside[role=sidebar] { body.sidebar-footer { @media only screen and (min-width: 750px) { - aside[role=sidebar]{ @include collapse-sidebar; } + aside.sidebar{ @include collapse-sidebar; } } #content { margin-right: 0px; } .toggle-sidebar { display: none; } @@ -98,7 +98,7 @@ body.sidebar-footer { body > header { font-size: 1em; } } @media only screen and (min-width: 750px) { - aside[role=sidebar] { @include collapse-sidebar; } + aside.sidebar { @include collapse-sidebar; } } @media only screen and (min-width: 768px) { body { -webkit-text-size-adjust: auto; } @@ -120,7 +120,7 @@ body.sidebar-footer { float: left; } } - aside[role=sidebar] { + aside.sidebar { @extend .group; width: $sidebar-width-medium - $sidebar-pad-medium*2; padding: 0 $sidebar-pad-medium $sidebar-pad-medium; @@ -147,7 +147,7 @@ body.sidebar-footer { padding-bottom: $pad-wide/2; } } - aside[role=sidebar] { + aside.sidebar { width: $sidebar-width-wide - $sidebar-pad-wide*2; padding: 1.2em $sidebar-pad-wide $sidebar-pad-wide; .collapse-sidebar & { diff --git a/.themes/classic/sass/base/_theme.scss b/.themes/classic/sass/base/_theme.scss index fce47e5..e5539b1 100644 --- a/.themes/classic/sass/base/_theme.scss +++ b/.themes/classic/sass/base/_theme.scss @@ -60,7 +60,7 @@ $page-border-bottom: darken($footer-bg, 5) !default; a { @include link-colors($link-color, $hover: $link-color-hover, $focus: $link-color-hover, $visited: $link-color-visited, $active: $link-color-active); } -aside[role=sidebar] a { +aside.sidebar a { @include link-colors($sidebar-link-color, $hover: $sidebar-link-color-hover, $focus: $sidebar-link-color-hover, $active: $sidebar-link-color-active); } a { diff --git a/.themes/classic/sass/partials/_blog.scss b/.themes/classic/sass/partials/_blog.scss index 558f0a2..88c71e9 100644 --- a/.themes/classic/sass/partials/_blog.scss +++ b/.themes/classic/sass/partials/_blog.scss @@ -121,7 +121,7 @@ article + article { display: inline-block; } -#content nav[role=pagination] { +#content nav.pagination { text-align: center; font-size: .95em; div { diff --git a/.themes/classic/sass/partials/_navigation.scss b/.themes/classic/sass/partials/_navigation.scss index 7af9f9f..43ae469 100644 --- a/.themes/classic/sass/partials/_navigation.scss +++ b/.themes/classic/sass/partials/_navigation.scss @@ -31,8 +31,8 @@ body > nav { } } } - fieldset[role=site-search]{ float: right; width: 48%; } - fieldset[role=mobile-nav]{ float: left; width: 48%; + fieldset[role=search]{ float: right; width: 48%; } + fieldset.mobile-nav{ float: left; width: 48%; select{ width: 100%; font-size: .8em; border: 1px solid #888;} } ul { display: none; } @@ -85,8 +85,8 @@ body > nav { width: $sidebar-width-medium - $pad-medium*2 - $sidebar-pad-medium - 58px; .search { width: 91%; } } - fieldset[role=mobile-nav] { display: none; } - fieldset[role=site-search]{ width: 99%; } + fieldset.mobile-nav { display: none; } + fieldset[role=search]{ width: 99%; } } @media only screen and (min-width: 992px) { form { diff --git a/.themes/classic/sass/partials/sidebar/_base.scss b/.themes/classic/sass/partials/sidebar/_base.scss index a0d1c09..afda01c 100644 --- a/.themes/classic/sass/partials/sidebar/_base.scss +++ b/.themes/classic/sass/partials/sidebar/_base.scss @@ -1,7 +1,7 @@ .side-shadow-border { @include box-shadow(lighten($sidebar-bg, 5) 0 1px); } -aside[role=sidebar] { +aside.sidebar { color: $sidebar-color; text-shadow: lighten($sidebar-bg, 8) 0 1px; a { @extend .force-wrap; } diff --git a/.themes/classic/source/_includes/custom/navigation.html b/.themes/classic/source/_includes/custom/navigation.html index 8f091e1..d6bd424 100644 --- a/.themes/classic/source/_includes/custom/navigation.html +++ b/.themes/classic/source/_includes/custom/navigation.html @@ -1,4 +1,4 @@ -