A call to assert(1) will always fail and cause Wget to crash. If such a
situation does arise, Wget should invoke abort() and provide a useful
error message to the user prior to exiting.
MIN and MAx are macros that a developer will universally expect
throughout the source. Yet, they were being defined in multiple places
across the source. Instead, define them in a single location in the
common wget.h header file and use them consistently everywhere.
The use of TLSv1_client_method() means that the protocol used will be
limited to TLSv1.0. This is not desirable for --secure-protocol values
of "auto" (default) and "pfs". Fix by using SSLv23_client_method() and
disabling SSLv[23].
Issue reported by Mikolaj Kucharski.
This patch also adds support for multiple challenges per
WWW-Authenticate header line.
The test Test-auth-both.py now succeeds and thus is taken away
from XFAIL_TESTS (expected to fail tests).
Fixes a reported crash and prevents multiple downloads of the
same file in case the URL is escaped in different ways.
Reported-by: Frédéric <vfrederix@gmail.com>
In test.c, this patch changes the type of program_argstring to char *
from a const char *. This is because, we use a char * string in the rest
of the program and declare an extern accordingly. Removing the const
type helps in keeping the code cleaner at no extra cost.
This reverts commit 1553c70961d05ffeb15780d0d1d58f991d9a6c66.
Some architectures like arm64 and ppc64 have unsigned chars where this
commit will cause problems.
After the Spring Cleaning on warnings in early 2014, GCC and Clang emit
only about two warnings when compiling Wget with -Wall -Wextra.
Enable both these flags by default so that new warnings in these areas
are more prominent.
