Fix issues reported by static code analysis tool 'parfait'

Closes: #41235
Reported-by: Jiri Kukacka

src/ChangeLog

@@ -1,3 +1,11 @@
+2014-12-01  Tim Ruehsen <tim.ruehsen@gmx.de>
+
+	* connect.c, iri.c, url.c, warc.c: Fix issues reported
+	by static code analysis tool 'parfait'.
+
+	Closes: #41235
+	Reported-by: Jiri Kukacka
+
 2014-11-29  Tim Ruehsen <tim.ruehsen@gmx.de>
 
 	* utils.h: xfree() sets argument to NULL after freeing,

src/connect.c

@@ -844,7 +844,7 @@ void *
 fd_transport_context (int fd)
 {
   struct transport_info *info = hash_table_get (transport_map, (void *)(intptr_t) fd);
-  return info->ctx;
+  return info ? info->ctx : NULL;
 }
 
 /* When fd_read/fd_write are called multiple times in a loop, they should

src/iri.c

@@ -328,12 +328,15 @@ struct iri *iri_dup (const struct iri *src)
 /* Completely free an iri structure. */
 void
 iri_free (struct iri *i)
+{
+  if (i)
     {
       xfree (i->uri_encoding);
       xfree (i->content_encoding);
       xfree (i->orig_url);
       xfree (i);
     }
+}
 
 /* Set uri_encoding of struct iri i. If a remote encoding was specified, use
    it unless force is true. */

src/url.c

@@ -575,7 +575,7 @@ rewrite_shorthand_url (const char *url)
         goto http;
 
       /* Turn "foo.bar.com:path" to "ftp://foo.bar.com/path". */
-      ret = aprintf ("ftp://%s", url);
+      if ((ret = aprintf ("ftp://%s", url)) != NULL)
         ret[6 + (p - url)] = '/';
     }
   else
@@ -1172,6 +1172,8 @@ url_set_file (struct url *url, const char *newfile)
 
 void
 url_free (struct url *url)
+{
+  if (url)
     {
       xfree (url->host);
       xfree (url->path);
@@ -1188,6 +1190,7 @@ url_free (struct url *url)
 
       xfree (url);
     }
+}
 
 /* Create all the necessary directories for PATH (a file).  Calls
    make_directory internally.  */

src/warc.c

@@ -1201,7 +1201,10 @@ warc_tempfile (void)
 
 #if !O_TEMPORARY
   if (unlink (filename) < 0)
+    {
+      close(fd);
       return NULL;
+    }
 #endif
 
   return fdopen (fd, "wb+");