[svn] Fix potential memory leak in request_set_header.

This commit is contained in:
hniksic 2005-04-17 09:59:35 -07:00
parent 7c363df6b5
commit d406908e94
2 changed files with 12 additions and 1 deletions

View File

@ -1,3 +1,8 @@
2005-04-17 Hrvoje Niksic <hniksic@xemacs.org>
* http.c (request_set_header): Free NAME when VALUE is NULL and
freeing the header name is requested.
2005-04-17 Hrvoje Niksic <hniksic@xemacs.org>
* snprintf.c (fmtstr): Declare VALUE as const char *.

View File

@ -234,7 +234,13 @@ request_set_header (struct request *req, char *name, char *value,
struct request_header *hdr;
int i;
if (!value)
return;
{
/* A NULL value is a no-op; if freeing the name is requested,
free it now to avoid leaks. */
if (release_policy == rel_name || release_policy == rel_both)
xfree (name);
return;
}
for (i = 0; i < req->hcount; i++)
{
hdr = &req->headers[i];