moparisthebest/wget
1
0
Fork 0
mirror of https://github.com/moparisthebest/wget synced 2024-07-03 16:38:41 -04:00
Code Issues Releases Wiki Activity

[svn] Hrvoje's response to my "wondering" comment in write_backup_file() read

Browse Source 
extremely strangely without adding tags to show who was saying what.  Also, one
of his phrases was very misleading.
This commit is contained in:
dan 2001-01-09 18:10:16 -08:00
parent 2204604381
commit a77dc45c4d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/url.c
View File

@ -1561,6 +1561,7 @@ write_backup_file (const char *file, downloaded_file_t downloaded_file_return)
thought I could just add a field to the urlpos structure saying thought I could just add a field to the urlpos structure saying
that we'd written a .orig file for this URL, but that didn't work, that we'd written a .orig file for this URL, but that didn't work,
so I had to make this separate list. so I had to make this separate list.
-- Dan Harkless <wget@harkless.org>
This [adding a field to the urlpos structure] didn't work This [adding a field to the urlpos structure] didn't work
because convert_file() is called twice: once after all its because convert_file() is called twice: once after all its
@ -1569,10 +1570,11 @@ write_backup_file (const char *file, downloaded_file_t downloaded_file_return)
original linked list collected in recursive_retrieve() is original linked list collected in recursive_retrieve() is
lost after the first invocation of convert_links(), and lost after the first invocation of convert_links(), and
convert_all_links() makes a new one (it calls get_urls_html() convert_all_links() makes a new one (it calls get_urls_html()
for each file it covers.) That's why your approach didn't for each file it covers.) That's why your first approach didn't
work. The way to make it work is perhaps to make this flag a work. The way to make it work is perhaps to make this flag a
field in the `urls_html' list. */ field in the `urls_html' list.
-- Hrvoje Niksic <hniksic@arsdigita.com>
*/
converted_file_ptr = xmalloc(sizeof(*converted_file_ptr)); converted_file_ptr = xmalloc(sizeof(*converted_file_ptr));
converted_file_ptr->string = xstrdup(file); /* die on out-of-mem. */ converted_file_ptr->string = xstrdup(file); /* die on out-of-mem. */
converted_file_ptr->next = converted_files; converted_file_ptr->next = converted_files;