moparisthebest/wget
1
0
Fork 0
mirror of https://github.com/moparisthebest/wget synced 2024-07-03 16:38:41 -04:00
Code Issues Releases Wiki Activity

Fix leaks found by Coverity

Browse Source 
* src/http.c (parse_strict_transport_security): Free c_max_age
             (open_output_stream): Fix indentation
* src/iri.c (locale_to_utf8): Free new
This commit is contained in:
Tim Rühsen 2015-08-30 13:13:05 +02:00
parent 398699c438
commit 88a1a79bc1
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/http.c
View File

@ -1274,7 +1274,10 @@ parse_strict_transport_security (const char *header, time_t *max_age, bool *incl
for (; extract_param (&header, &name, &value, ';', &is_url_encoded); is_url_encoded = false) for (; extract_param (&header, &name, &value, ';', &is_url_encoded); is_url_encoded = false)
{ {
if (BOUNDED_EQUAL_NO_CASE (name.b, name.e, "max-age")) if (BOUNDED_EQUAL_NO_CASE (name.b, name.e, "max-age"))
c_max_age = strdupdelim (value.b, value.e); {
xfree(c_max_age);
c_max_age = strdupdelim (value.b, value.e);
}
else if (BOUNDED_EQUAL_NO_CASE (name.b, name.e, "includeSubDomains")) else if (BOUNDED_EQUAL_NO_CASE (name.b, name.e, "includeSubDomains"))
is = true; is = true;
} }
@ -2486,9 +2489,10 @@ open_output_stream (struct http_stat *hs, int count, FILE **fp)
*fp = output_stream; *fp = output_stream;
/* Print fetch message, if opt.verbose. */ /* Print fetch message, if opt.verbose. */
logprintf (LOG_VERBOSE, _("Saving to: %s\n"), logprintf (LOG_VERBOSE, _("Saving to: %s\n"),
HYPHENP (hs->local_file) ? quote ("STDOUT") : quote (hs->local_file)); HYPHENP (hs->local_file) ? quote ("STDOUT") : quote (hs->local_file));
return RETROK;
return RETROK;
} }
/* Set proper type flags based on type string. */ /* Set proper type flags based on type string. */
@ -2625,6 +2629,7 @@ metalink_from_http (const struct response *resp, const struct http_stat *hs,
logprintf (LOG_NOTQUIET, _("When downloading signature:\n" logprintf (LOG_NOTQUIET, _("When downloading signature:\n"
"%s: %s.\n"), urlstr, error); "%s: %s.\n"), urlstr, error);
xfree (error); xfree (error);
iri_free (iri);
} }
else else
{ {

1
src/iri.c
View File

@ -231,6 +231,7 @@ locale_to_utf8 (const char *str)
if (do_conversion ("UTF-8", opt.locale, (char *) str, strlen ((char *) str), &new)) if (do_conversion ("UTF-8", opt.locale, (char *) str, strlen ((char *) str), &new))
return (const char *) new; return (const char *) new;
xfree (new);
return str; return str;
} }