moparisthebest
/
wget
mirror of https://github.com/moparisthebest/wget
1
0
Fork 0
Code Issues Releases Wiki Activity

Don't create a logfile for --background if we're --quiet.

This commit is contained in:
Micah Cowan 2008-04-12 22:45:45 -07:00
parent aed143ea0c
commit 7783870db1
3 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ChangeLog
View File

@ -1,3 +1,13 @@
2008-04-12 Micah Cowan <micah@cowan.name>
* mswindows.c (fake_fork_child): Don't create a logfile for
--background when --quiet is used, but not --server-response.
Don't mention that we're backgrounding if --quiet is used. Based
on a patch submitted by Rabin Vincent <rabin@rab.in>. Fixes bug
#20917.
* utils.c (fork_to_background): Likewise.
2008-04-11 Micah Cowan <micah@cowan.name>
* ftp.c (getftp, ftp_loop_internal): Don't append to an existing

7
src/mswindows.c
View File

@ -157,6 +157,10 @@ fake_fork_child (void)
event = info->event;
info->logfile_changed = false;
if (opt.quiet && !opt.server_response)
{
log_close ();
}
if (!opt.lfilename)
{
/* See utils:fork_to_background for explanation. */
@ -289,7 +293,8 @@ fake_fork (void)
goto cleanup;
}
printf (_("Continuing in background, pid %lu.\n"), pi.dwProcessId);
if (!opt.quiet)
printf (_("Continuing in background, pid %lu.\n"), pi.dwProcessId);
if (info->logfile_changed)
printf (_("Output will be written to `%s'.\n"), info->lfilename);

10
src/utils.c
View File

@ -301,6 +301,13 @@ fork_to_background (void)
/* Whether we arrange our own version of opt.lfilename here. */
bool logfile_changed = false;
if (opt.quiet && !opt.server_response)
{
/* Don't bother with a logfile, there are virtually no logs we
issue in quiet mode. (Server responses in FTP are the
exception, when enabled.) */
log_close ();
}
if (!opt.lfilename)
{
/* We must create the file immediately to avoid either a race
@ -325,7 +332,8 @@ fork_to_background (void)
else if (pid != 0)
{
/* parent, no error */
printf (_("Continuing in background, pid %d.\n"), (int) pid);
if (!quiet)
printf (_("Continuing in background, pid %d.\n"), (int) pid);
if (logfile_changed)
printf (_("Output will be written to `%s'.\n"), opt.lfilename);
exit (0); /* #### should we use _exit()? */