[svn] When did the bug get fixed where recursive FTP would fail if logging in put

you in a directory other than "/"?  I don't see a src/ChangeLog entry for
it.  In any case, my testing shows that it's fixed in 1.7-dev, but TODO and
a comment in src/ftp.c were not changed to reflect this.
This commit is contained in:
dan 2001-01-09 20:17:06 -08:00
parent 86ee0537d5
commit 7140f393b2
4 changed files with 8 additions and 6 deletions

View File

@ -1,6 +1,9 @@
2001-01-09 Dan Harkless <wget@harkless.org>
* TODO: If -c is on, don't re-download a 100%-downloaded file.
Also, the bug where you couldn't recurse into ftp directories if
logging in put you somewhere else besides the server's "/"
directory got fixed without the TODO entry for it being removed.
2001-01-06 Dan Harkless <wget@harkless.org>

3
TODO
View File

@ -51,9 +51,6 @@ changes.
* Make -K compare X.orig to X and move the former on top of the latter if
they're the same, rather than leaving identical .orig files laying around.
* Allow mirroring of FTP URLs where logging in puts you somewhere else besides
'/'.
* If CGI output is saved to a file, e.g. cow.cgi?param, -k needs to change the
'?' to a "%3F" in links to that file to avoid passing part of the filename as
a parameter.

View File

@ -6,6 +6,11 @@
* url.c (write_backup_file): Clarified a comment.
* ftp.c (ftp_retrieve_dirs): I don't see a ChangeLog entry for
this, but the bug where recursion into FTP directories didn't work
if logging in put you in a directory other than "/" is apparently
fixed now. Removed the comment here warning of the bug.
2001-01-06 Dan Harkless <wget@harkless.org>
* ChangeLog: The '[Not in 1.6 branch.]'s were decided not to be

View File

@ -1442,9 +1442,6 @@ ftp_retrieve_dirs (struct urlinfo *u, struct fileinfo *f, ccon *con)
if (len > current_length)
current_container = (char *)alloca (len);
u->dir = current_container;
/* When retrieving recursively, all directories must be
absolute. This restriction will (hopefully!) be lifted in
the future. */
sprintf (u->dir, "/%s%s%s", odir + (*odir == '/'),
(!*odir || (*odir == '/' && !* (odir + 1))) ? "" : "/", f->name);
if (!accdir (u->dir, ALLABS))