moparisthebest/wget
1
0
Fork 0
mirror of https://github.com/moparisthebest/wget synced 2024-07-03 16:38:41 -04:00
Code Issues Releases Wiki Activity

[svn] Dan Berger responded to my email. Added his explanation of what his patch was

Browse Source 
coded for (downloading StarOffice from Sun's website).  He says he doesn't use
wget any more, so he won't be writing a patch that allows downloading that
without breaking anything (such a patch would apparently involve stopping
certain characters in the URL from being escaped).
This commit is contained in:
dan 2000-03-02 15:49:37 -08:00
parent 3a8c75cac4
commit 66ced51104
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/ChangeLog
View File

@ -4,16 +4,17 @@
braces to avoid ambiguous `else'" warnings. Eliminated them. braces to avoid ambiguous `else'" warnings. Eliminated them.
* http.c (gethttp): Dan Berger's query string patch is totally * http.c (gethttp): Dan Berger's query string patch is totally
bogus. If you have two different URLs, gen_page.cgi?page1 and bogus. If you have two different URLs, gen_page.cgi?page1 and
get_page.cgi?page2, they'll both be saved as get_page.cgi and the get_page.cgi?page2, they'll both be saved as get_page.cgi and the
second will overwrite the first. Also, parameters to implicit second will overwrite the first. Also, parameters to implicit
CGIs, like "http://www.host.com/db/?2000-03-02" cause the URLs to CGIs, like "http://www.host.com/db/?2000-03-02" cause the URLs to
be printed with trailing garbage characters, and could seg fault. be printed with trailing garbage characters, and could seg fault.
I'm not sure what Dan had in mind with this patch (no explanatory Backing out the patch, which Dan B. informed me by email was just
comments), but I'm removing it for now. If he can rewrite it so a kludge to download StarOffice from Sun made necessary due to
it doesn't break stuff, okay. wget's unconditional escaping of certain characters (room for an
(http_loop): Heiko introduced "suggest explicit option there?).
braces to avoid ambiguous `else'" warnings. Eliminated them. (http_loop): Heiko introduced "suggest explicit braces to avoid
ambiguous `else'" warnings. Eliminated them.
* main.c: Heiko's --wait / --waitretry backwards compatibility * main.c: Heiko's --wait / --waitretry backwards compatibility
code looks to have been totally untested -- automatic variable code looks to have been totally untested -- automatic variable