moparisthebest/wallabag
1
0
Fork 0
mirror of https://github.com/moparisthebest/wallabag synced 2024-08-13 16:54:00 -04:00
Code Issues Releases Wiki Activity

Use fetchAll directly on the connection and bind parameters using ?

Browse Source
This commit is contained in:
Vincent Jousse 2013-12-13 18:44:43 +01:00
parent 56071a0c81
commit 8c2d368cbf
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Poche/Repository/EntryRepository.php
View File

@ -12,11 +12,9 @@ class EntryRepository
//TODO don't hardcode the user ;)
public function getEntries($userId = 1) {
$sql = "SELECT * FROM entries where user_id = :userId";
$stmt = $this->db->prepare($sql);
$stmt->bindValue('userId', $userId);
$entries = $stmt->fetchAll();
return $entries;
$sql = "SELECT * FROM entries where user_id = ?";
$entries = $this->db->fetchAll($sql, array($userId));
return $entries ? $entries : array();
}
//TODO don't hardcode the user ;)

4
tests/functionals/ApiTest.php
View File

@ -19,7 +19,7 @@ class ApiTest extends PocheWebTestCase
)
);
$this->assertEquals($client->getResponse()->getContent(), '[]');
$this->assertEquals('[]', $client->getResponse()->getContent());
}
@ -42,7 +42,7 @@ class ApiTest extends PocheWebTestCase
)
);
$this->assertEquals($client->getResponse()->getContent(),'{"id":"1","url":"http:\/\/deboutlesgens.com\/blog\/le-courage-de-vivre-consciemment\/","title":"Le courage de vivre consciemment","content":"Test content","updated":null,"status":null,"bookmark":"0","fetched":"1","user_id":"1"}');
$this->assertEquals('[{"id":"1","url":"http:\/\/deboutlesgens.com\/blog\/le-courage-de-vivre-consciemment\/","title":"Le courage de vivre consciemment","content":"Test content","updated":null,"status":null,"bookmark":"0","fetched":"1","user_id":"1"}]', $client->getResponse()->getContent());
}