From 5c4ef2dad5b69af335fab8ca0673354ec0eaba85 Mon Sep 17 00:00:00 2001
From: Andreas Boehler <andy@klasseonline.dyndns.org>
Date: Mon, 15 Apr 2013 08:35:27 +0200
Subject: [PATCH 1/3] Create branch for OC5 Added DisplayName support in OC5

---
 appinfo/info.xml       |  2 +-
 appinfo/version        |  2 +-
 settings.php           |  3 +-
 templates/settings.php |  1 +
 user_sql.php           | 67 +++++++++++++++++++++++++++++++++++++++++-
 5 files changed, 71 insertions(+), 4 deletions(-)

diff --git a/appinfo/info.xml b/appinfo/info.xml
index 021ef38..8bf8439 100644
--- a/appinfo/info.xml
+++ b/appinfo/info.xml
@@ -6,7 +6,7 @@
        <licence>AGPL</licence>
        <author>Andreas Boehler &lt;andreas (at) aboehler 
 (dot) at &gt;</author>
-       <require>4.9</require>
+       <require>5.0</require>
        <shipped>false</shipped>
        <types>
        		<authentication/>
diff --git a/appinfo/version b/appinfo/version
index 39e898a..ac39a10 100644
--- a/appinfo/version
+++ b/appinfo/version
@@ -1 +1 @@
-0.7.1
+0.9.0
diff --git a/settings.php b/settings.php
index f6f1ff3..9c500ab 100644
--- a/settings.php
+++ b/settings.php
@@ -20,7 +20,7 @@
  * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
  *
  */
-$params = array('sql_host', 'sql_user', 'sql_database', 'sql_password', 'sql_table', 'sql_column_username', 'sql_column_password', 'sql_type', 'sql_column_active', 'strip_domain', 'default_domain', 'crypt_type');
+$params = array('sql_host', 'sql_user', 'sql_database', 'sql_password', 'sql_table', 'sql_column_username', 'sql_column_password', 'sql_type', 'sql_column_active', 'strip_domain', 'default_domain', 'crypt_type', 'sql_column_displayname');
 
 OCP\Util::addscript('user_sql', 'settings');
 OCP\User::checkAdminUser();
@@ -59,5 +59,6 @@ $tmpl->assign( 'sql_column_active', OCP\Config::getAppValue( 'user_sql', 'sql_co
 $tmpl->assign( 'strip_domain', OCP\Config::getAppValue( 'user_sql', 'strip_domain', 0));
 $tmpl->assign( 'default_domain', OCP\Config::getAppValue( 'user_sql', 'default_domain', ''));
 $tmpl->assign( 'crypt_type', OCP\Config::getAppValue( 'user_sql', 'crypt_type', 'mysql_encrypt'));
+$tmpl->assign( 'sql_column_displayname', OCP\Config::getAppValue( 'user_sql', 'sql_column_displayname', ''));
 
 return $tmpl->fetchPage();
diff --git a/templates/settings.php b/templates/settings.php
index 05529d9..b0e6790 100644
--- a/templates/settings.php
+++ b/templates/settings.php
@@ -23,6 +23,7 @@
             <p><label for="sql_table"><?php echo $l->t('Table');?></label><input type="text" id="sql_table" name="sql_table" value="<?php echo $_['sql_table']; ?>" /></p>
             <p><label for="sql_column_username"><?php echo $l->t('Username Column');?></label><input type="text" id="sql_column_username" name="sql_column_username" value="<?php echo $_['sql_column_username']; ?>" /></p>
             <p><label for="sql_column_password"><?php echo $l->t('Password Column');?></label><input type="text" id="sql_column_password" name="sql_column_password" value="<?php echo $_['sql_column_password']; ?>" /></p>
+            <p><label for="sql_column_displayname"><?php echo $l->t('Real Name Column');?></label><input type="text" id="sql_column_displayname" name="sql_column_displayname" value="<?php echo $_['sql_column_displayname']; ?>" /></p>
             <p><label for="crypt_type"><?php echo $l->t('Encryption Type');?></label>
                 <?php $crypt_types = array('md5' => 'MD5', 'md5crypt' => 'MD5 Crypt', 'cleartext' => 'Cleartext', 'mysql_encrypt' => 'mySQL ENCRYPT()', 'system' => 'System (crypt)', 'mysql_password' => 'mySQL PASSWORD()', 'joomla' => 'Joomla MD5 Encryption');?>
                 <select id="crypt_type" name="crypt_type">
diff --git a/user_sql.php b/user_sql.php
index 77cee98..6636af5 100644
--- a/user_sql.php
+++ b/user_sql.php
@@ -36,6 +36,7 @@ class OC_USER_SQL extends OC_User_Backend implements OC_User_Interface {
     protected $sql_column_username;
     protected $sql_column_password;
     protected $sql_column_active;
+    protected $sql_column_displayname;
     protected $sql_type;
     protected $db_conn;
     protected $db;
@@ -53,6 +54,7 @@ class OC_USER_SQL extends OC_User_Backend implements OC_User_Interface {
         $this->sql_table = OCP\Config::getAppValue('user_sql', 'sql_table', '');
         $this->sql_column_username = OCP\Config::getAppValue('user_sql', 'sql_column_username', '');
         $this->sql_column_password = OCP\Config::getAppValue('user_sql', 'sql_column_password', '');
+        $this->sql_column_displayname = OCP\Config::getAppValue('user_sql', 'sql_column_displayname', '');
         $this->sql_column_active = OCP\Config::getAppValue('user_sql', 'sql_column_active', '');
         $this->sql_type = OCP\Config::getAppValue('user_sql', 'sql_type', '');
         $this->default_domain = OCP\Config::getAppValue('user_sql', 'default_domain', '');
@@ -73,7 +75,11 @@ class OC_USER_SQL extends OC_User_Backend implements OC_User_Interface {
 
     public function implementsAction($actions) 
     {
-        return (bool)((OC_USER_BACKEND_CHECK_PASSWORD) & $actions);
+        return (bool)((OC_USER_BACKEND_CHECK_PASSWORD | OC_USER_BAKCNED_GET_DISPLAYNAME) & $actions);
+    }
+
+    public function hasUserListings() {
+        return true;
     }
 
     public function createUser() {
@@ -313,6 +319,65 @@ class OC_USER_SQL extends OC_User_Backend implements OC_User_Interface {
             return true;
         }
 
+    }
+
+    public function getDisplayName($uid)
+    {
+        OC_Log::write('OC_USER_SQL', "Entering getDisplayName() for UID: $uid", OC_Log::DEBUG);
+        if(!$this->db_conn)
+        {
+            return false;
+        }
+        $uid = trim($uid);
+        if($this->default_domain && (strpos($uid, '@') === false))
+        {
+            $uid .= "@".$this->default_domain;
+        }
+        $uid = strtolower($uid);
+
+        if(!$this->userExists($uid))
+        {
+            return false;
+        }
+
+        $query = "SELECT $this->sql_column_displayname FROM $this->sql_table WHERE $this->sql_column_username = :uid";
+        if($this->sql_column_active != '')
+            $query .= " AND $this->sql_column_active = 1";
+        OC_Log::write('OC_USER_SQL', "Preparing query: $query", OC_Log::DEBUG);
+        $result = $this->db->prepare($query);
+        $result->bindParam(":uid", $uid);
+        OC_Log::write('OC_USER_SQL', "Executing query...", OC_Log::DEBUG);
+        if(!$result->execute())
+        {
+            $err = $result->errorInfo();
+            OC_Log::write('OC_USER_SQL', "Query failed: ".$err[2], OC_Log::DEBUG);
+            return false;
+        }
+        OC_Log::write('OC_USER_SQL', "Fetching results...", OC_Log::DEBUG);
+        $row = $result->fetch();
+        if(!$row)
+        {
+            OC_Log::write('OC_USER_SQL', "Empty row, user has no display name or does not exist, return false", OC_Log::DEBUG);
+            return false;
+        }
+        else
+        {
+            OC_Log::write('OC_USER_SQL', "User exists, return true", OC_Log::DEBUG);
+            $displayName = utf8_encode($row[$this->sql_column_displayname]);
+            return $displayName;;
+        }
+        return false;
+    }
+
+    public function getDisplayNames($search = '', $limit = null, $offset = null)
+    {
+        $uids = $this->getUsers($search, $limit, $offset);
+        $displayNames = array();
+        foreach($uids as $uid)
+        {
+            $displayNames[$uid] = $this->getDisplayName($uid);
+        }
+        return $displayNames;
     }
        
      /**

From ddc166e6625f2f728acec6a61ec52c4607b5964b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20B=C3=B6hler?= <andreas@aboehler.at>
Date: Sun, 24 Aug 2014 18:36:21 +0200
Subject: [PATCH 2/3] Fix a typo

---
 user_sql.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/user_sql.php b/user_sql.php
index 6636af5..f01ec60 100644
--- a/user_sql.php
+++ b/user_sql.php
@@ -75,7 +75,7 @@ class OC_USER_SQL extends OC_User_Backend implements OC_User_Interface {
 
     public function implementsAction($actions) 
     {
-        return (bool)((OC_USER_BACKEND_CHECK_PASSWORD | OC_USER_BAKCNED_GET_DISPLAYNAME) & $actions);
+        return (bool)((OC_USER_BACKEND_CHECK_PASSWORD | OC_USER_BACKEND_GET_DISPLAYNAME) & $actions);
     }
 
     public function hasUserListings() {

From d3397146a3e3cc189c77e11079a720587f48b2d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20B=C3=B6hler?= <andreas@aboehler.at>
Date: Mon, 27 Oct 2014 20:23:32 +0100
Subject: [PATCH 3/3] Update Settings for ownCloud 7 and fix a long-pending
 "checkbox" bug

---
 ajax/settings.php      | 39 ++++++++++++++++++++++
 css/settings.css       | 14 ++++++++
 js/settings.js         | 46 +++++++++++++++++++++++++-
 settings.php           | 15 +++++++--
 templates/settings.php | 73 ++++++++++++++++++++++++++++--------------
 5 files changed, 160 insertions(+), 27 deletions(-)
 create mode 100644 ajax/settings.php
 create mode 100644 css/settings.css

diff --git a/ajax/settings.php b/ajax/settings.php
new file mode 100644
index 0000000..08adf92
--- /dev/null
+++ b/ajax/settings.php
@@ -0,0 +1,39 @@
+<?php
+
+// Init owncloud
+
+// Check if we are a user
+OCP\User::checkAdminUser();
+OCP\JSON::checkAppEnabled('user_sql');
+
+// CSRF checks
+OCP\JSON::callCheck();
+
+$l = new OC_L10N('use_sql');
+
+$params = array('sql_host', 'sql_user', 'sql_database', 'sql_password',
+                'sql_table', 'sql_column_username', 'sql_column_password',
+                'sql_type', 'sql_column_active', 'strip_domain', 'default_domain',
+                'crypt_type', 'sql_column_displayname');
+
+if (isset($_POST['appname']) && $_POST['appname'] == "user_sql") {
+  foreach ($params as $param) {
+    if (isset($_POST[$param])) {
+      if ($param === 'strip_domain') {
+        OCP\Config::setAppValue('user_sql', 'strip_domain', true);
+      } else {
+          OCP\Config::setAppValue('user_sql', $param, $_POST[$param]);
+      }
+    } else {
+      if ($param === 'strip_domain') {
+        OCP\Config::setAppValue('user_sql', 'strip_domain', false);
+      }
+    }
+  }
+} else {
+  OC_JSON::error(array("data" => array( "message" => $l->t("Not submitted for us.") )));
+  return false;
+}
+
+OCP\JSON::success(array('data' => array( 'message' => $l->t('Application settings successfully stored.') )));
+return true;
diff --git a/css/settings.css b/css/settings.css
new file mode 100644
index 0000000..9c45085
--- /dev/null
+++ b/css/settings.css
@@ -0,0 +1,14 @@
+.statusmessage {
+        background-color: #DDDDFF;
+}
+.errormessage {
+        background-color: #FFDDDD;
+}
+.successmessage {
+        background-color: #DDFFDD;
+}
+.statusmessage,.errormessage,.successmessage{
+        display:none;
+        padding: 1;
+}
+
diff --git a/js/settings.js b/js/settings.js
index 8337712..ad8d982 100644
--- a/js/settings.js
+++ b/js/settings.js
@@ -1 +1,45 @@
-//
+// declare namespace
+var user_sql = user_sql || {};
+
+/**
+ * init admin settings view
+ */
+user_sql.adminSettingsUI = function() {
+
+  if ($('#sql').length > 0) {
+    // enable tabs on settings page
+    $('#sql').tabs();
+
+    $('#sqlSubmit').click(function(event) {
+      event.preventDefault();
+
+      var self = $(this);
+      var post = $('#sqlForm').serialize();
+      $('#sql_update_message').show();
+      $('#sql_success_message').hide();
+      $('#sql_error_message').hide();
+      // Ajax foobar
+      $.post(OC.filePath('user_sql', 'ajax', 'settings.php'), post, function(data) {
+        $('#sql_update_message').hide();
+        if (data.status == 'success') {
+          $('#sql_success_message').html(data.data.message);
+          $('#sql_success_message').show();
+          window.setTimeout(function() {
+              $('#sql_success_message').hide();
+          }, 10000);
+        } else {
+          $('#sql_error_message').html(data.data.message);
+          $('#sql_error_message').show();
+        }
+      }, 'json');
+      return false;
+    });
+  }
+}
+
+$(document).ready(function() {
+  if ($('#sql')) {
+    user_sql.adminSettingsUI();
+  }
+});
+
diff --git a/settings.php b/settings.php
index 9c500ab..c140ad9 100644
--- a/settings.php
+++ b/settings.php
@@ -20,11 +20,16 @@
  * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
  *
  */
-$params = array('sql_host', 'sql_user', 'sql_database', 'sql_password', 'sql_table', 'sql_column_username', 'sql_column_password', 'sql_type', 'sql_column_active', 'strip_domain', 'default_domain', 'crypt_type', 'sql_column_displayname');
+$params = array('sql_host', 'sql_user', 'sql_database', 'sql_password',
+                'sql_table', 'sql_column_username', 'sql_column_password',
+                'sql_type', 'sql_column_active', 'strip_domain', 'default_domain',
+                'crypt_type', 'sql_column_displayname');
 
-OCP\Util::addscript('user_sql', 'settings');
+OCP\Util::addStyle('user_sql', 'settings');
+OCP\Util::addScript('user_sql', 'settings');
 OCP\User::checkAdminUser();
 
+/*
 if ($_POST) {
     OCP\JSON::callCheck();
     foreach($params as $param){
@@ -38,6 +43,7 @@ if ($_POST) {
         }
     }
 }
+*/
 
 // fill template
 $tmpl = new OCP\Template( 'user_sql', 'settings');
@@ -61,4 +67,9 @@ $tmpl->assign( 'default_domain', OCP\Config::getAppValue( 'user_sql', 'default_d
 $tmpl->assign( 'crypt_type', OCP\Config::getAppValue( 'user_sql', 'crypt_type', 'mysql_encrypt'));
 $tmpl->assign( 'sql_column_displayname', OCP\Config::getAppValue( 'user_sql', 'sql_column_displayname', ''));
 
+// workaround to detect OC version
+$ocVersion = @reset(OCP\Util::getVersion());
+$tmpl->assign('ocVersion', $ocVersion);
+
+
 return $tmpl->fetchPage();
diff --git a/templates/settings.php b/templates/settings.php
index b0e6790..9e0c1d1 100644
--- a/templates/settings.php
+++ b/templates/settings.php
@@ -1,9 +1,24 @@
-<form id="sql" action="#" method="post">
-    <fieldset class="personalblock">
-        <legend><?php echo $l->t('SQL'); ?></legend>
-            <p><label for="sql_type"><?php echo $l->t('SQL Driver');?></label>
+<?php
+$ocVersion = $_['ocVersion'];
+$cfgClass = $ocVersion >= 7 ? 'section' : 'personalblock';
+
+?>
+
+
+<form id="sqlForm" action="#" method="post" class="<?php echo $cfgClass; ?>">
+
+    <div id="sql" class="<?php echo $cfgClass; ?>">
+        <legend><strong><?php echo $l->t('SQL'); ?></strong></legend>
+	<ul>
+	  <li><a id="sqlBasicSettings" href="#sql-1"><?php echo $l -> t('Database Settings'); ?></a></li>
+          <li><a id="sqlAdvSettings" href="#sql-2"><?php echo $l->t('Advanced Settings'); ?></a></li>
+        </ul>
+
+        <fieldset id="sql-1">
+           <table>
+           <tr><td><label for="sql_type"><?php echo $l->t('SQL Driver');?></label></td>
                 <?php $db_driver = array('mysql' => 'MySQL', 'pgsql' => 'PostgreSQL');?>
-                <select id="sql_type" name="sql_type">
+                <td><select id="sql_type" name="sql_type">
                     <?php 
                         foreach ($db_driver as $driver => $name):
                             echo $_['sql_type'];
@@ -13,20 +28,24 @@
                                 <option value="<?php echo $driver; ?>"><?php echo $name; ?></option>
                             <?php endif;
                         endforeach; ?>
-                </select>
-            </p>
+                </select></td>
+            </tr>
 
-            <p><label for="sql_host"><?php echo $l->t('Host');?></label><input type="text" id="sql_host" name="sql_host" value="<?php echo $_['sql_host']; ?>"></p>
-            <p><label for="sql_user"><?php echo $l->t('Username');?></label><input type="text" id="sql_user" name="sql_user" value="<?php echo $_['sql_user']; ?>" /></p>
-            <p><label for="sql_database"><?php echo $l->t('Database');?></label><input type="text" id="sql_database" name="sql_database" value="<?php echo $_['sql_database']; ?>" /></p>
-            <p><label for="sql_password"><?php echo $l->t('Password');?></label><input type="password" id="sql_password" name="sql_password" value="<?php echo $_['sql_password']; ?>" /></p>
-            <p><label for="sql_table"><?php echo $l->t('Table');?></label><input type="text" id="sql_table" name="sql_table" value="<?php echo $_['sql_table']; ?>" /></p>
-            <p><label for="sql_column_username"><?php echo $l->t('Username Column');?></label><input type="text" id="sql_column_username" name="sql_column_username" value="<?php echo $_['sql_column_username']; ?>" /></p>
-            <p><label for="sql_column_password"><?php echo $l->t('Password Column');?></label><input type="text" id="sql_column_password" name="sql_column_password" value="<?php echo $_['sql_column_password']; ?>" /></p>
-            <p><label for="sql_column_displayname"><?php echo $l->t('Real Name Column');?></label><input type="text" id="sql_column_displayname" name="sql_column_displayname" value="<?php echo $_['sql_column_displayname']; ?>" /></p>
-            <p><label for="crypt_type"><?php echo $l->t('Encryption Type');?></label>
+            <tr><td><label for="sql_host"><?php echo $l->t('Host');?></label></td><td><input type="text" id="sql_host" name="sql_host" value="<?php echo $_['sql_host']; ?>"></td></tr>
+            <tr><td><label for="sql_user"><?php echo $l->t('Username');?></label></td><td><input type="text" id="sql_user" name="sql_user" value="<?php echo $_['sql_user']; ?>" /></td></tr>
+            <tr><td><label for="sql_database"><?php echo $l->t('Database');?></label></td><td><input type="text" id="sql_database" name="sql_database" value="<?php echo $_['sql_database']; ?>" /></td></tr>
+            <tr><td><label for="sql_password"><?php echo $l->t('Password');?></label></td><td><input type="password" id="sql_password" name="sql_password" value="<?php echo $_['sql_password']; ?>" /></td></tr>
+            <tr><td><label for="sql_table"><?php echo $l->t('Table');?></label></td><td><input type="text" id="sql_table" name="sql_table" value="<?php echo $_['sql_table']; ?>" /></td></tr>
+        </table>
+        </fieldset>
+        <fieldset id="sql-2">
+        <table>
+            <tr><td><label for="sql_column_username"><?php echo $l->t('Username Column');?></label></td><td><input type="text" id="sql_column_username" name="sql_column_username" value="<?php echo $_['sql_column_username']; ?>" /></td></tr>
+            <tr><td><label for="sql_column_password"><?php echo $l->t('Password Column');?></label></td><td><input type="text" id="sql_column_password" name="sql_column_password" value="<?php echo $_['sql_column_password']; ?>" /></td></tr>
+            <tr><td><label for="sql_column_displayname"><?php echo $l->t('Real Name Column');?></label></td><td><input type="text" id="sql_column_displayname" name="sql_column_displayname" value="<?php echo $_['sql_column_displayname']; ?>" /></td></tr>
+            <tr><td><label for="crypt_type"><?php echo $l->t('Encryption Type');?></label></td>
                 <?php $crypt_types = array('md5' => 'MD5', 'md5crypt' => 'MD5 Crypt', 'cleartext' => 'Cleartext', 'mysql_encrypt' => 'mySQL ENCRYPT()', 'system' => 'System (crypt)', 'mysql_password' => 'mySQL PASSWORD()', 'joomla' => 'Joomla MD5 Encryption');?>
-                <select id="crypt_type" name="crypt_type">
+                <td><select id="crypt_type" name="crypt_type">
                     <?php 
                         foreach ($crypt_types as $driver => $name):
                             echo $_['crypt_type'];
@@ -36,12 +55,18 @@
                                 <option value="<?php echo $driver; ?>"><?php echo $name; ?></option>
                             <?php endif;
                         endforeach; ?>
-                </select>
-            </p>            
-            <p><label for="sql_column_active"><?php echo $l->t('User Active Column');?></label><input type="text" id="sql_column_active" name="sql_column_active" value="<?php echo $_['sql_column_active']; ?>" /></p>
-            <p><label for="strip_domain"><?php echo $l->t('Strip Domain Part from Username');?></label><input type="checkbox" id="strip_domain" name="strip_domain" value="1"<?php if($_['strip_domain']) echo ' checked'; ?> title="Strip Domain Part from Username when logging in and retrieving username lists"></p>
-            <p><label for="default_domain"><?php echo $l->t('Add default domain to Usernames');?></label><input type="text" id="default_domain" name="default_domain" value="<?php echo $_['default_domain']; ?>" /></p>
+                </select></td>
+            </tr>
+            <tr><td><label for="sql_column_active"><?php echo $l->t('User Active Column');?></label></td><td><input type="text" id="sql_column_active" name="sql_column_active" value="<?php echo $_['sql_column_active']; ?>" /></td></tr>
+            <tr><td><label for="strip_domain"><?php echo $l->t('Strip Domain Part from Username');?></label></td><td><input type="checkbox" id="strip_domain" name="strip_domain" value="1"<?php if($_['strip_domain']) echo ' checked'; ?> title="Strip Domain Part from Username when logging in and retrieving username lists"></td></tr>
+            <tr><td><label for="default_domain"><?php echo $l->t('Add default domain to Usernames');?></label></td><td><input type="text" id="default_domain" name="default_domain" value="<?php echo $_['default_domain']; ?>" /></td></tr>
+        </table>
+        </fieldset>
         <input type="hidden" name="requesttoken" value="<?php echo $_['requesttoken'] ?>" id="requesttoken" />
-        <input type="submit" value="<?php echo $l->t('Save'); ?>" />
-    </fieldset>
+	<input type="hidden" name="appname" value="user_sql" />
+        <input id="sqlSubmit" type="submit" value="<?php echo $l->t('Save'); ?>" />
+        <div id="sql_update_message" class="statusmessage"><?php echo $l->t('Saving...'); ?></div>
+        <div id="sql_error_message" class="errormessage"></div>
+        <div id="sql_success_message" class="successmessage"></div>
+    </div>
 </form>