Commit Graph

6998 Commits

Author SHA1 Message Date
Andreas Beeker
891e684eb7 #60427 - Creating pictures in PowerPoint slides requires scratchpad-jar for adding WMF images
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771812 13f79535-47bb-0310-9956-ffa450edef68
2016-11-28 20:51:02 +00:00
Andreas Beeker
19842d1e58 javadocs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771672 13f79535-47bb-0310-9956-ffa450edef68
2016-11-28 01:18:48 +00:00
Andreas Beeker
6ea58e94bc #60331 - Remove deprecated classes - deprecate Mutable* property classes
sonarcube fix - make protected attributes private

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771640 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 20:19:18 +00:00
Andreas Beeker
8968b6d6b6 SonarCube fixes - visibility of member attributes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771583 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 13:12:00 +00:00
Dominik Stadler
aba5d21295 Fix newly introduced Sonar issues and allow text to be null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771563 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 11:06:57 +00:00
Dominik Stadler
be1aa45b25 Bug 60370: Encode some special characters when setting title/text for validation text-boxes, for now all characters below 32, more can be added if necessary.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771396 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:59 +00:00
Dominik Stadler
055630de2d Revert deprecating a class that we still use ourselves and update error text slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771395 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:52 +00:00
Dominik Stadler
ed975b0efa Include actual entries when we do not find a Document-entry
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771394 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:45 +00:00
Dominik Stadler
e2b22e51f7 Bug 59200: Check for actual Excel limits on data validation title/text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771254 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 08:55:52 +00:00
Dominik Stadler
90ce8cb096 Remove unnecessary cast and reformat some code a bit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771247 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 05:34:58 +00:00
Javen O'Neal
52dcd75c66 bug 60416: prefer CellReference ref over String ref
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771232 13f79535-47bb-0310-9956-ffa450edef68
2016-11-24 21:25:43 +00:00
Javen O'Neal
d2f6e5c24e bug 60416: Reduce Hyperlink memory consumption in SXSSF; patch from Dmitry Katsubo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771231 13f79535-47bb-0310-9956-ffa450edef68
2016-11-24 21:14:35 +00:00
Tim Allison
52c449c65a bug 60343, return null if index is out of bounds in StylesTable's getStyleAt(idx)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1770848 13f79535-47bb-0310-9956-ffa450edef68
2016-11-22 14:47:45 +00:00
Andreas Beeker
ea63780926 Bug 60373 - TableCell.getTextHeight() returns Null pointer Exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1770447 13f79535-47bb-0310-9956-ffa450edef68
2016-11-18 23:29:53 +00:00
Dominik Stadler
5ec38746a1 Fix missing directory 'maven' in source release packages, adjust the related test-Ant-script to call 'assemble' instead of 'jar' to catch something like this in the future.
Also exclude some more intermediate files/directories from the source package.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769684 13f79535-47bb-0310-9956-ffa450edef68
2016-11-14 19:50:39 +00:00
Andreas Beeker
c0dbef286b #60331 - Remove deprecated classes (POI 3.16) - remove StylesTable.getNumberFormatAt(int)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769431 13f79535-47bb-0310-9956-ffa450edef68
2016-11-12 21:54:22 +00:00
Andreas Beeker
44ca7f04ba SonarCube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769399 13f79535-47bb-0310-9956-ffa450edef68
2016-11-12 18:35:39 +00:00
Andreas Beeker
a6f005de81 SonarCube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769366 13f79535-47bb-0310-9956-ffa450edef68
2016-11-12 00:52:10 +00:00
Andreas Beeker
fc86b15f13 - SonarCube fixes
- moved SecureTempFile classes to OOXML, because of duplicated code in test and examples packages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769363 13f79535-47bb-0310-9956-ffa450edef68
2016-11-11 23:22:43 +00:00
Andreas Beeker
3820215393 Bug 60345 - Handle corrupt PICT streams
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769226 13f79535-47bb-0310-9956-ffa450edef68
2016-11-10 23:04:25 +00:00
Andreas Beeker
ead2cdd696 Bug 59273 - Unable to create pptx file by potx file using Apache POI
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769220 13f79535-47bb-0310-9956-ffa450edef68
2016-11-10 22:54:07 +00:00
Javen O'Neal
7b8bc917ac bug 60321: add examples with encrypted temp data. Patch from PJ Fanning.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768744 13f79535-47bb-0310-9956-ffa450edef68
2016-11-08 17:32:38 +00:00
Dominik Stadler
57fa4c1869 Pull up one more test into BaseTestConditionalFormatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768590 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 21:32:18 +00:00
Dominik Stadler
64a6fb354a Adjust imports, fix some Javadoc issues and ignore deprecation warnings in tests
Exclude some more non-tests in OOXMLLite

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768589 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 21:32:12 +00:00
Dominik Stadler
76a0c6378e Add setFormattingRanges() to interface ConditionalFormatting, closes #42
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768588 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 21:32:04 +00:00
Dominik Stadler
8d083d8c64 Example AligningCells: Use int instead of short for column-index, closes Github #35
Also use more of the base classes where possible

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768584 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 20:50:10 +00:00
Tim Allison
0232c71e33 POI-60341, add test document (ugh, mea culpa), turn on test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768505 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 12:10:46 +00:00
Mark Murphy
e65baf7fc8 Move XWPF examples to new package to clean up code coverage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768437 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 05:35:18 +00:00
Mark Murphy
70724609b1 60337: XWPFTableRow.isRepeatHeader throws NullPointerException, setRepeatHeader does not overwrite old value
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=60337


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768153 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 06:12:24 +00:00
Tim Allison
abe0740d3a POI-60342: handle missing sdtcontentcell in an sdtcell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768054 13f79535-47bb-0310-9956-ffa450edef68
2016-11-04 15:21:51 +00:00
Tim Allison
d769a03fda POI-60341: handle missing sdtpr in an sdtbody
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768048 13f79535-47bb-0310-9956-ffa450edef68
2016-11-04 15:06:17 +00:00
Nick Burch
7c9754a08d As requested on StackOverflow, expose on CellStyle QuotePrefix/123Prefix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768012 13f79535-47bb-0310-9956-ffa450edef68
2016-11-04 11:11:09 +00:00
Nick Burch
6f5a44c139 More unit testing for XWPF list numbering complex cases, and some TODOs on improving it, inspired by users@ discussions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768005 13f79535-47bb-0310-9956-ffa450edef68
2016-11-04 10:55:31 +00:00
Javen O'Neal
a3f001b7ae bug 60331: remove deprecated FormulaShifter.createForRowShift(). Require SpreadsheetVersion.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767728 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 16:37:12 +00:00
Javen O'Neal
cbc3f8599d bug 60331: remove deprecated EntryUtils.copyNodes( DirectoryEntry, DirectoryEntry, List<String> excepts). Use EntryUtils.copyNodes( FilteringDirectoryEntry, FilteringDirectoryEntry ) instead.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767716 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 16:25:18 +00:00
Javen O'Neal
6966eebb38 show example of equivalent EntryUtils.copyNodes using FilteringDirectoryNode instead of DirectoryNode with excepts list
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767715 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 16:22:04 +00:00
Andreas Beeker
9d3094f11f Handle null returns of coerceValueToBoolean
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767474 13f79535-47bb-0310-9956-ffa450edef68
2016-11-01 10:52:20 +00:00
Andreas Beeker
af2d473d00 findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767473 13f79535-47bb-0310-9956-ffa450edef68
2016-11-01 10:29:02 +00:00
Andreas Beeker
e620194a20 findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767457 13f79535-47bb-0310-9956-ffa450edef68
2016-11-01 09:24:50 +00:00
Andreas Beeker
6f3bb20b2e JCE policy assumption fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767456 13f79535-47bb-0310-9956-ffa450edef68
2016-11-01 09:18:55 +00:00
Andreas Beeker
457100c358 Bug 60320 - issue opening password protected xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767399 13f79535-47bb-0310-9956-ffa450edef68
2016-11-01 01:30:48 +00:00
Tim Allison
ce826bc967 remove println
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767354 13f79535-47bb-0310-9956-ffa450edef68
2016-10-31 19:03:06 +00:00
Tim Allison
2633894b39 60293 -- Handle illegal "Odd" header/footer in XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767353 13f79535-47bb-0310-9956-ffa450edef68
2016-10-31 19:02:06 +00:00
Mark Murphy
14babbb970 57366: XWPFTable to Header / Footer
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=57366

This update contains a breaking change

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767175 13f79535-47bb-0310-9956-ffa450edef68
2016-10-30 18:49:16 +00:00
Dominik Stadler
ca4a7d2f27 Bug 53611: populate dimension of XSSF Worksheet when writing the document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767096 13f79535-47bb-0310-9956-ffa450edef68
2016-10-29 07:38:46 +00:00
Dominik Stadler
d47fff6e1c Bug 59026: Add two null-checks to make exporting XLSX to XML work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767057 13f79535-47bb-0310-9956-ffa450edef68
2016-10-28 18:24:04 +00:00
Tim Allison
1cdf883548 60315 -- allow 'yyyy-MM-dd' as a valid date format in metadata in OPCParser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767026 13f79535-47bb-0310-9956-ffa450edef68
2016-10-28 14:11:52 +00:00
Tim Allison
ca8d888f83 60305 -- gracefully handle truncated images while reading pictstream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767023 13f79535-47bb-0310-9956-ffa450edef68
2016-10-28 13:39:40 +00:00
Tim Allison
591785e2d2 whitespace clean up before fix for BUG-60305
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767021 13f79535-47bb-0310-9956-ffa450edef68
2016-10-28 13:26:49 +00:00
Tim Allison
1c2f768b8c whitespace clean up before fix for BUG-60305
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767020 13f79535-47bb-0310-9956-ffa450edef68
2016-10-28 13:25:14 +00:00
Andreas Beeker
51b4f2a365 fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766747 13f79535-47bb-0310-9956-ffa450edef68
2016-10-26 22:37:34 +00:00
Andreas Beeker
2c086c590e Bug 60059 - Deprecate xslf.usermodel.Drawing* - was: Can't change text of DrawingParagraph
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766746 13f79535-47bb-0310-9956-ffa450edef68
2016-10-26 22:32:46 +00:00
Nick Burch
9ee2e06f4c Fix close warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766503 13f79535-47bb-0310-9956-ffa450edef68
2016-10-25 10:24:48 +00:00
Nick Burch
6bbdb9c8a5 Whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766501 13f79535-47bb-0310-9956-ffa450edef68
2016-10-25 10:23:15 +00:00
Nick Burch
3e01fe6f68 v5 text extraction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766497 13f79535-47bb-0310-9956-ffa450edef68
2016-10-25 10:21:16 +00:00
Nick Burch
cc4e525e27 Inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766493 13f79535-47bb-0310-9956-ffa450edef68
2016-10-25 09:35:28 +00:00
Nick Burch
6816899106 Refactor child pointer logic to the factory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766492 13f79535-47bb-0310-9956-ffa450edef68
2016-10-25 09:33:37 +00:00
Nick Burch
3f1965ea27 Work in progress - v5 pointer containers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766487 13f79535-47bb-0310-9956-ffa450edef68
2016-10-25 09:15:02 +00:00
Nick Burch
747f5e0f40 Partial Visio v5 pointer support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766480 13f79535-47bb-0310-9956-ffa450edef68
2016-10-25 07:37:00 +00:00
Mark Murphy
ae589d08d3 Adds an example for building headers and footers in XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766459 13f79535-47bb-0310-9956-ffa450edef68
2016-10-24 23:56:21 +00:00
Dominik Stadler
a350f399f5 Allow more time for a unit-test when running on slow Gump VM
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766397 13f79535-47bb-0310-9956-ffa450edef68
2016-10-24 12:07:15 +00:00
Andreas Beeker
423a49cbab Bug 60294 - Add "unknown" ShapeType for 4095
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766227 13f79535-47bb-0310-9956-ffa450edef68
2016-10-22 19:34:47 +00:00
Dominik Stadler
3f91e44380 Bug 60289: Fix handling of unicode escapes with lowercase hex-chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766065 13f79535-47bb-0310-9956-ffa450edef68
2016-10-21 16:31:51 +00:00
Dominik Stadler
04184527b4 Correctly handle all types of old files, not just word
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766064 13f79535-47bb-0310-9956-ffa450edef68
2016-10-21 16:31:43 +00:00
Dominik Stadler
0610a20d87 Fix some IDE warnings, JavaDoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766063 13f79535-47bb-0310-9956-ffa450edef68
2016-10-21 16:31:37 +00:00
Javen O'Neal
359820ba80 bug 60288: remove defensive copy for internal relationships. Patch from Tim Helmstedt. This closes #38.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765935 13f79535-47bb-0310-9956-ffa450edef68
2016-10-21 07:29:40 +00:00
Andreas Beeker
f648c23daa fix integration-tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765900 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 22:31:50 +00:00
Dominik Stadler
d0d5334386 Exclude new BIFF5 file in some unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765876 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 20:31:57 +00:00
Dominik Stadler
f2c9dbec3f Add some missing close() calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765875 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 20:31:50 +00:00
Tim Allison
e9b4a17d77 BUG-60286 avoid NPE XWPFRun. Didn't add unit test or document...didn't seem to be worth it.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765863 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 18:58:47 +00:00
Tim Allison
9c455cb5c9 BUG-60285 avoid NPE if missing relationship id
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765861 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 18:45:03 +00:00
Tim Allison
9fd46e3174 BUG-60284 -- need to update dev tests <face_palm/>
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765859 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 18:39:47 +00:00
Tim Allison
d233f7c348 BUG-60284 -- throw EncryptedDocumentException for password protected OldExcel files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765829 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 15:13:16 +00:00
Javen O'Neal
0821c1e4b2 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765741 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 02:24:50 +00:00
Javen O'Neal
ab6dd76f6a upgrade to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765740 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 02:24:17 +00:00
Javen O'Neal
a1ec4334cf Eclipse automated refactor/cleanup: add final modifier to private fields to unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765739 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 02:21:14 +00:00
Javen O'Neal
107d44c48e close resource
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765737 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 02:05:42 +00:00
Javen O'Neal
96d35e0b8e Eclipse automated refactor/cleanup: convert for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765736 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 01:54:56 +00:00
Andreas Beeker
54122c2233 remove *_dump directory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765734 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:43:42 +00:00
Andreas Beeker
3ac60f4bcc Bug 55714 - Background image ignored on slide copy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765733 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:25:51 +00:00
Javen O'Neal
eeff9989ee StringUtil.count was renamed to StringUtil.countMatches
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765732 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:06:35 +00:00
Javen O'Neal
2554a46eaf Eclipse automated refactor/cleanup: convert for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765731 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:04:39 +00:00
Javen O'Neal
5d3d50b9d1 add StringUtil.count, inspired by Apache Commons Lang StringUtils#countMatches and Python's str.count(substr)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765730 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:04:16 +00:00
Javen O'Neal
4b01accdb3 Eclipse automated refactor/cleanup: convert for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765728 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 22:28:07 +00:00
Javen O'Neal
c5dddf7fac Eclipse automated refactor/cleanup: add missing @Override and @Deprecated annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765726 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 21:52:31 +00:00
Tim Allison
5958cb4840 BUG-59302 --add minimal support for VBAMacro extraction to HSLF; credit to Andreas Beeker for this patch. Problems are mine.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765696 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 18:44:46 +00:00
Javen O'Neal
c0a5f568da close pkg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765561 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 09:04:01 +00:00
Javen O'Neal
425e04b4a4 add @Override decorators to SheetIterator, move code outside of for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765556 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 08:38:19 +00:00
Javen O'Neal
9cad5aff09 reenable unit test for bug 58648 that passes now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765548 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 08:03:57 +00:00
Javen O'Neal
3ac3f37cbe bug 60255: use actual number of package parts rather than hard-coding an upper-bound
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765546 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:47:07 +00:00
Javen O'Neal
a73df78070 remove @deprecated annotation from Enum-returning getters. These will be deprecated after the int-returning getters are removed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765545 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:43:18 +00:00
Javen O'Neal
e1734cd542 disabled unit tests are now passing for bug 48703
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765544 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:37:47 +00:00
Dominik Stadler
ec7607e398 Fix some IDE warnings/javadoc/...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765538 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 06:52:44 +00:00
Javen O'Neal
eada340cbd make code more similar between default case and indexed case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765536 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 06:44:09 +00:00
Javen O'Neal
09c13eeefa on Windows, a directory cannot contain a file and a directory with the same name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765531 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:18:48 +00:00
Javen O'Neal
55252a9fe9 findbugs: Switch statement found in org.apache.poi.sl.draw.DrawShape.applyTransform(Graphics2D) where default case is missing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765530 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:07:30 +00:00
Javen O'Neal
669e32e551 add data type to UTF_16LE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765529 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:06:49 +00:00
Javen O'Neal
fec5613aff remove java.nio.charset.StandardCharsets which is not available until Java 7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765528 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:00:07 +00:00
Tim Allison
17d4d76f4f BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 18:24:39 +00:00
Tim Allison
ef7bbb8fe4 BUG 59858 -- avoid npe when there's a collision of record names...doh. Fix unit test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765482 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 16:54:12 +00:00
Tim Allison
92eb3bbade BUG 59858 -- avoid npe when there's a collision of record names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765479 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 16:43:20 +00:00
Tim Allison
c878e39b55 BUG 59830 -- incorrect reading of unicode stream name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765468 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 15:47:38 +00:00
Tim Allison
db79501e9f BUG 60158 -- AIOOBE in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765433 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 12:55:34 +00:00
Andreas Beeker
bf95861693 Bug 53191 - Problems with line style when converting ppt to png
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765196 13f79535-47bb-0310-9956-ffa450edef68
2016-10-16 22:48:25 +00:00
Dominik Stadler
e3633daac5 Bug 60259: Add missing dispose() call
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765100 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 19:07:04 +00:00
Dominik Stadler
90ef824079 Close temp-file in test to not leak file-handles and fail deleting the file on Windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765019 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 06:54:26 +00:00
Dominik Stadler
37116e84e5 Bug 60029: apply suggested fix and fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765018 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 06:54:20 +00:00
Tim Allison
7f9f8e9afa add length sanity check for length of embedded OLE10Native (BUG 60256)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764927 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 14:57:29 +00:00
Tim Allison
442815fcc5 add ignored test and triggering document for BUG 60256
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764890 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 13:22:23 +00:00
Nick Burch
b79defb983 Exclude broken hand-crafted test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764887 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 13:03:53 +00:00
Nick Burch
bff698c938 #60255 When creating a XSSF drawing, find the next available document part, even if another type has pinched the next number
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764863 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:44:03 +00:00
Javen O'Neal
1e5dc11721 bug 56781,60246: fix named range validation to match valid name rules per Excel docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764854 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:11:23 +00:00
Javen O'Neal
999c6499ec bug 60253: add helper functions to make the constructor formula1-overloading code simpler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764831 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 08:09:39 +00:00
Javen O'Neal
ee6b1e741d bug 60253: remove repeated check for ValidationType.ANY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764823 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 07:07:15 +00:00
Javen O'Neal
489f632288 bug 60253: revert XSSFDataValidationConstraint#prettyPrint QUOTE change in r1749129
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764822 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 07:04:27 +00:00
Javen O'Neal
cdd3a4f0df make cached fields transient
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764809 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 05:13:47 +00:00
Mark Murphy
f25343e18f Add Apache license to example file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764807 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 02:42:50 +00:00
Mark Murphy
37f9122633 53009: Problem creating header and footer
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=53009

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764563 13f79535-47bb-0310-9956-ffa450edef68
2016-10-13 01:13:45 +00:00
Andreas Beeker
83bd292fff Bug 60230 - Roundtrip test that encrypts XSSFWorkbook and then decrypts it fails with latest code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764008 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 20:34:35 +00:00
Javen O'Neal
95e8c4b4a2 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763999 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 19:09:26 +00:00
Javen O'Neal
d5c20ccb0d bug 60230: add disabled unit test from PJ Fanning for a roundtrip write/read of an encrypted XSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763998 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 19:03:49 +00:00
Javen O'Neal
c0b2d60d28 bug 60153: java.nio.charset.StandardCharsets is not available until Java 7. Use Charset.forName for Java 6 compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763997 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 18:06:46 +00:00
Javen O'Neal
02b3019f6c bug 60153: patch from PJ Fanning to demonstrate that SXSSFWorkbook SheetDataWriter can write encrypted temporary files to disk and the workbook can be AES encrypted when written to disk for a fully secure disk environment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763969 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 12:58:46 +00:00
Javen O'Neal
db53120ab3 fix findbugs warning BC_VACUOUS_INSTANCEOF from bug 55075
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763965 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 12:15:39 +00:00
Javen O'Neal
370aa27bf2 bug 60228: getCellTypeEnum should not be deprecated until after getCellType returns a CellType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763960 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:59:34 +00:00
Javen O'Neal
63da9f8d19 bug 60153: findbugs OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE close opened streams if an exception is raised while decorating the stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763959 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:51:13 +00:00
Javen O'Neal
45d18d5c45 bug 55075: add missing import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763955 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:26:49 +00:00
Javen O'Neal
6426f4d19e bug 55075: remove wildcard import; previous commit contributed by Frank Ploessel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763951 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:13:06 +00:00
Javen O'Neal
61f00a509f bug 55075,51233: create drawings with correct height when rows are custom height
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763950 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:02:36 +00:00
Javen O'Neal
e0fd36dfb4 bug 60021: add note that EncryptionInfo may require poi-ooxml.jar to run EncryptionModes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763944 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 05:40:38 +00:00
Javen O'Neal
3e4da0cd75 bug 60153: encrypt SXSSF temporary files; patch from PJ Fanning
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763943 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 04:43:14 +00:00
Javen O'Neal
dd1ed5b840 bug 60197: Workbook#setSheetOrder should update named range sheet indices
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 03:02:13 +00:00
Javen O'Neal
13a08a408b bug 60219: add disabled unit test for parsing formulas containing external workbook references with a quoted sheet name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763937 13f79535-47bb-0310-9956-ffa450edef68
2016-10-08 23:41:08 +00:00
Andreas Beeker
1d38f5c329 Bug 60003 - Regression: HSLF Powerpoint text extractor from footer of master slide
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763927 13f79535-47bb-0310-9956-ffa450edef68
2016-10-08 18:08:25 +00:00
Andreas Beeker
cb03495d36 Bug 60226 - ClassLoader workaround for OSGI when processing OOXML files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763922 13f79535-47bb-0310-9956-ffa450edef68
2016-10-08 17:07:15 +00:00
Dominik Stadler
9b908a1994 Add initial compile steps with a simple multi-project setup to build.gradle
Adjust some tests to make them run fine in the Gradle build as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763816 13f79535-47bb-0310-9956-ffa450edef68
2016-10-07 19:33:11 +00:00
Javen O'Neal
5b8cbb0143 bug 60216: javadocx fix for Comment#isVisible and Comment#setVisible; patch from Daniel Kueppers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763757 13f79535-47bb-0310-9956-ffa450edef68
2016-10-07 12:39:15 +00:00
Dominik Stadler
94859c032c Bug 59958: Add simple test-case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763487 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 20:13:38 +00:00
Dominik Stadler
cdef5dc16c Use IOUtils.closeQuietly() in more places
Avoid two possible file-handle leaks when opening files fails with an exception
Make tests close resources properly to not spam the output when running with file-leak-detector

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763485 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 20:00:07 +00:00
Dominik Stadler
89f68a6a47 Bug 53028: Broken auto fit row height in the cells with word wrap
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763484 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 19:59:56 +00:00
Dominik Stadler
2bfa5a50de Print out size of extracted text in CommandLineExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763483 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 19:59:50 +00:00
Dominik Stadler
86eafd3c44 Some IDE warning fixes and unit test adjustments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763482 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 19:59:44 +00:00
Nick Burch
4ffc48f7f7 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763399 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 10:39:03 +00:00
Mark Murphy
d106d31934 Add PropertyTemplate for drawing Borders (58787)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763338 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 02:23:52 +00:00
Nick Burch
48e338e828 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762875 13f79535-47bb-0310-9956-ffa450edef68
2016-09-30 10:22:27 +00:00
Javen O'Neal
c1a11dc0b8 bug 60187: set BorderStyle directly instead of through short code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762859 13f79535-47bb-0310-9956-ffa450edef68
2016-09-30 07:02:02 +00:00
Javen O'Neal
d169bdc2f9 bug 60187: replace methods operating on BorderStyle codes with BorderStyle enums
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762856 13f79535-47bb-0310-9956-ffa450edef68
2016-09-30 06:39:29 +00:00
Andreas Beeker
d8767e1c70 Bug 59857 - Password protected files with "Microsoft Enhanced Cryptographic Provider v1.0"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762726 13f79535-47bb-0310-9956-ffa450edef68
2016-09-28 23:36:09 +00:00
Andreas Beeker
0a7cd3b68b merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68
2016-09-28 21:01:40 +00:00
Dominik Stadler
db79fe043c Adjust some JavaDoc and remove some unnecessary String.valueOf() calls and fix some other compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762617 13f79535-47bb-0310-9956-ffa450edef68
2016-09-28 08:44:14 +00:00
Javen O'Neal
12ca2205b0 bug 57843: add failing unit test: Word 6.0 (1993) fails with ArrayIndexOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761873 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 09:24:48 +00:00
Javen O'Neal
596bba0962 bug 59687: correctly delete comments from rows when removing a row and the workbook contains empty rows above the deleted row; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761861 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 07:50:33 +00:00
Javen O'Neal
551d46f3c1 bug 59687: add failing unit test showing that comments when the row that contains the comment is deleted; patch and file contributed by Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761860 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 07:36:52 +00:00
Javen O'Neal
839870a49d check column outline level for bug 55076
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761847 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 04:37:04 +00:00
Javen O'Neal
257e6197ca add failing unit test for bug 55076: collapsing column groups only hides the first column
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761846 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 04:24:22 +00:00
Javen O'Neal
e9a16f2c5e fix NPE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761844 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 04:02:56 +00:00
Javen O'Neal
43f7d5bfdc use equalsIgnoreCase for case-insensitive string comparisons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761843 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:48:49 +00:00
Javen O'Neal
8455e01772 add comment for purpose of test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761842 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:37:09 +00:00
Javen O'Neal
a09fe683dd bug 45565: add failing unit test for bug 45565
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761841 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:29:00 +00:00
Dominik Stadler
7e9cc96c46 Compiler/IDE warnings, unnecessary keywords,
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761675 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:45:57 +00:00
Javen O'Neal
f1c4407766 replace @Ignore with POITestCase.skipTest/testPassesNow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761674 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:32:26 +00:00
Javen O'Neal
cbeddd0d11 bug 59983: add failing unit test demonstrating formula shifting is apply twice to shared formulas; patch from Luca Martini
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761673 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:20:36 +00:00
Javen O'Neal
eedc13f5ce add fixturing for notifying us when a previously failing unit test passes (better than @Ignore)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761672 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:03:57 +00:00
Javen O'Neal
7e3f2ca8d1 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761669 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 03:57:22 +00:00
Javen O'Neal
4e864476c6 bug 60153: move flushSheets out to its own method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761668 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 03:31:15 +00:00
Javen O'Neal
deed3aa8d6 bug 57200,59788: be more specific why a temporary directory could not be created
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761667 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 03:19:31 +00:00
Javen O'Neal
2be1834545 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761665 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:45:39 +00:00
Javen O'Neal
29128d019d javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761664 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:43:55 +00:00
Javen O'Neal
ad8506b7f5 bug 59933: demote accessibility of NullLogger methods to the same level as POILogger
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761662 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:12:54 +00:00
Javen O'Neal
b44d6ec062 make POILogFactory _loggers cache final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761660 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:05:58 +00:00
Javen O'Neal
92d0f35c84 bug 59933: override POILogger#log(int, Object...) in NullLogger
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761657 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:41:54 +00:00
Javen O'Neal
0558c3a085 fix copy-paste error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761655 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:15:39 +00:00
Javen O'Neal
9a36aa3a37 include class of caught exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761654 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:14:26 +00:00
Javen O'Neal
3adf725ba4 bug 60158: add failing test cases for AIOOBE on VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761652 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 01:03:12 +00:00
Dominik Stadler
c669e2ef67 Adjust handling of ByteBuffer some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761636 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 20:24:54 +00:00
Javen O'Neal
a4c3ce29ea bug 59853: exclude BaseTestXSSFPivotTable from ooxml-lite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761545 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 09:59:01 +00:00
Javen O'Neal
676ca76fd9 bug 59853: support PivotTables with named structured references; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761537 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 07:55:13 +00:00
Andreas Beeker
cda4f20482 merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68
2016-09-19 00:20:44 +00:00
Javen O'Neal
008a26d1bf bug 59705: consolidate bounds checking of column index into a helper method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760986 13f79535-47bb-0310-9956-ffa450edef68
2016-09-16 00:32:40 +00:00
Tim Allison
0784ab530a POI 60140 Prevent unnecessary memory usage -- no need to cache HeapByteBuffer in FileBackedDataSource, thanks to Luis Filipe Nassif for diagnosing this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760816 13f79535-47bb-0310-9956-ffa450edef68
2016-09-15 00:19:52 +00:00
Javen O'Neal
5b79b4da90 sheet names are case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760814 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 22:43:08 +00:00
Javen O'Neal
39752a5643 make sure workbook can be written out and read back for all TestXSSFPivotTable tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760811 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 22:11:14 +00:00
Javen O'Neal
16acf81b9e convert TestXSSFPivotTable to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760806 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 22:01:11 +00:00
Javen O'Neal
1de973e2a7 declare methods throw runtime exceptions for IDE hints
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760798 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 21:44:06 +00:00
Javen O'Neal
91f2d5680e declare methods throw runtime exceptions for IDE hints
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760784 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 21:32:34 +00:00
Javen O'Neal
03b5dc68eb bug 60128: remove forbidden-api Exception.printStackTrace()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760744 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 19:24:49 +00:00
Javen O'Neal
3959260c6a bug 60128: exclude openxml4j/invalid.xlsx from additional integration (stress) tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760743 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 18:41:21 +00:00
Javen O'Neal
9ac461596f bug 60128: add test-data/openxml4j/invalid.xlsx to expected failures for integration test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760735 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:48:00 +00:00
Javen O'Neal
97b94f5dcd javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760733 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:25:03 +00:00
Javen O'Neal
753ca9b811 bug 60128: make code Java 6 compatible. Throwable#addSuppressed not available until Java 7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760732 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:21:31 +00:00
Nick Burch
41b0462f50 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760719 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 15:01:57 +00:00
Nick Burch
5fc5680d15 Patches from Patrick Zimmermann from bugs #60130 and #60131 - DGET fix for empty cells and D* coding improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760717 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 14:59:00 +00:00
Javen O'Neal
6ed8aaada6 make logger final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760711 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:56:03 +00:00
Javen O'Neal
2104b1d585 bug 60128: close opened resources to avoid leaks; add exception as cause where available for more context for raised exceptions.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760710 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:55:39 +00:00
Javen O'Neal
d34b6a995b give more helpful exceptions rather than returning null when zip file cannot be opened
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760708 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:28:27 +00:00
Javen O'Neal
ed5cd06fb7 bug 60128: close open file descriptors when exceptions are thrown from OPCPackage.open
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760702 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:57:39 +00:00
Nick Burch
6219cc6664 Unit test for bug #60128, showing that calling close on a broken package cleans up file or stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760693 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:35:34 +00:00
Javen O'Neal
ed7258906f move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:53:58 +00:00
Javen O'Neal
8842d7bffd move BaseXSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) and HSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) up to BaseFormulaEvaluator class to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760647 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:33:20 +00:00
Javen O'Neal
f71ae8036d bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760641 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 06:42:20 +00:00
Javen O'Neal
b0f814f83f bug 59791: add deprecation warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760639 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 06:22:38 +00:00
Javen O'Neal
9a11b0ffd5 bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760634 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:51:52 +00:00
Javen O'Neal
430ea9abfd bug 58190: add @since annotations to SlideShow.addPicture and findPicture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760633 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:41:40 +00:00
Javen O'Neal
ca78ec2878 bug 58671: add @Removal annotation to deprecated fields
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760632 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:31:48 +00:00
Javen O'Neal
38cd94d676 bug 59264: revert CellStyle#getBorder[Top|Bottom|Left|Right]() to return short and add getBorder[Top|Bottom|Left|Right]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760630 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:22:23 +00:00
Javen O'Neal
292d7ec27c bug 59264: revert getBorder[Top|Bottom|Left|Right|Diagonal]() to return short and add getBorder[Top|Bottom|Left|Right|Diagonal]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760627 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 04:35:45 +00:00
Javen O'Neal
2644cae418 bug 59790: add @Removal annotations to deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760624 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:51:45 +00:00
Javen O'Neal
5d1ae2cbae bug 59833: add @Removal annotation to deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760623 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:33:52 +00:00
Javen O'Neal
6839a52aa3 bug 59837,59833,59264: add @Removal annotations to CellStyle constants for which enums now exist
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760622 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:24:15 +00:00
Javen O'Neal
808996a683 bug 59873: add @Removal annotations for deprecated CreationHelper#createHyperlink(int) and Hyperlink static aliases to HyperlinkType enum values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760621 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:17:51 +00:00
Javen O'Neal
b91b5c5715 bug 59907: add @Removal annotations to AnchorType static aliases in ClientAnchor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760620 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:06:51 +00:00
Javen O'Neal
9ea5915313 bug 59907: add @Removal annotations to deprecated ClientAnchor#setAnchorType(int)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760619 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 02:55:52 +00:00
Javen O'Neal
0977e51818 bug 59907: restore ClientAnchor#setAnchorType(int) that was removed in POI 3.14 beta 1 and broke backwards compatibility without a 2 release deprecation notice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760617 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 02:41:01 +00:00
Javen O'Neal
3c97d9700a change CellValue#getCellType() to return an int instead of an enum for backwards compatibility (source and binary) with POI 3.14. This reverts the behavior introduced in POI 3.15 beta 3 in r1751237.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760607 13f79535-47bb-0310-9956-ffa450edef68
2016-09-13 23:24:56 +00:00
Nick Burch
494b54161a Disabled unit test for #60010
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760458 13f79535-47bb-0310-9956-ffa450edef68
2016-09-12 23:10:27 +00:00
Javen O'Neal
abe46f40ed bug 52425: Error adding Comments into cloned Sheets; patch from Daniel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760221 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 04:05:42 +00:00
Javen O'Neal
adfd0d7f6c bug 60025: DataFormatter should print booleans as TRUE/FALSE, not true/false
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760219 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 03:37:56 +00:00
Javen O'Neal
5409095923 bug 58191: Support merge cells within a table row; patch from Mark Olesen
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760217 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 03:21:33 +00:00
Javen O'Neal
050010094f add unit test class for XSLFTableRow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760216 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 02:52:29 +00:00
Javen O'Neal
6146860a5e bug 59958: Add cells on the fly to the evaluation sheet cache on cache miss; patch from Tomasz Stanczak
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760213 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 02:02:56 +00:00
Javen O'Neal
d9cfcbdd18 bug 60102: throw IOException when writing a closed document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760206 13f79535-47bb-0310-9956-ffa450edef68
2016-09-10 19:33:32 +00:00
Javen O'Neal
7dabe1b101 move duplicated NullOutputStream classes to test suite utilities
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760203 13f79535-47bb-0310-9956-ffa450edef68
2016-09-10 18:47:00 +00:00
Javen O'Neal
e1b5ed4c14 Add comments describing purpose of each unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760130 13f79535-47bb-0310-9956-ffa450edef68
2016-09-10 05:22:58 +00:00
Tim Allison
5747e871a1 poi-60044 small typo in last update to BuiltinFormats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760102 13f79535-47bb-0310-9956-ffa450edef68
2016-09-09 18:41:37 +00:00
Javen O'Neal
cd7b5359f8 make CreatePivotTable self-explaining with better variable names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757459 13f79535-47bb-0310-9956-ffa450edef68
2016-08-24 04:03:26 +00:00
Javen O'Neal
7f7eba3d04 Update CreatePivotTable with non-deprecated constructor. This closes #36 on github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757458 13f79535-47bb-0310-9956-ffa450edef68
2016-08-24 03:54:55 +00:00
Javen O'Neal
bc1f9dfb27 Remove unnecessary short cast. This closes #37 on github
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757457 13f79535-47bb-0310-9956-ffa450edef68
2016-08-24 03:47:21 +00:00
Javen O'Neal
9665b9859a bug 59791: add @Removal tags to Cell.CELL_TYPE_* constants, deprecated by CellType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757239 13f79535-47bb-0310-9956-ffa450edef68
2016-08-22 18:25:45 +00:00
Javen O'Neal
75b943d69c bug 59791: make sure hard-coded int literals work for cell type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757237 13f79535-47bb-0310-9956-ffa450edef68
2016-08-22 18:14:46 +00:00
Javen O'Neal
3f4612ffcb bug 59791: improve Cell.CELL_TYPE_* backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757235 13f79535-47bb-0310-9956-ffa450edef68
2016-08-22 17:57:45 +00:00
Andreas Beeker
71db60b890 merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1756967 13f79535-47bb-0310-9956-ffa450edef68
2016-08-19 20:57:56 +00:00
Andreas Beeker
9521546156 add encryption support
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1756964 13f79535-47bb-0310-9956-ffa450edef68
2016-08-19 20:23:16 +00:00
Javen O'Neal
f7bf415085 revert r1753048 due to AIOOB regression
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756552 13f79535-47bb-0310-9956-ffa450edef68
2016-08-16 21:43:31 +00:00
Javen O'Neal
403db2b866 decrease TestSXSSFSheetAutoSizeColumn COLUMN_WIDTH_THRESHOLD_BETWEEN_SHORT_AND_LONG so that poi-ooxml-schemas can be built on 'Java: 1.8.0_101/1.8.0_101-b13/25.101-b13/OpenJDK 64-Bit Server VM from Oracle Corporation on Linux: 4.7.0-1-default'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756402 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 17:17:06 +00:00
Javen O'Neal
139319ac73 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756398 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 16:08:11 +00:00
Javen O'Neal
779c0e527a bug 60005: fix NPE in XSLFTextParagraph.getDefaultFontSize()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756397 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 16:05:32 +00:00
Javen O'Neal
4f49414473 make member variables final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756361 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 08:09:32 +00:00
Javen O'Neal
7c4e332b61 extract string constant out of code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756358 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 07:36:22 +00:00
Javen O'Neal
16be8e597b simplify unit test using assertContainsIgnoreCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756357 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 07:31:43 +00:00
Javen O'Neal
8d38e8e674 add (meta) unit test for POITestCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756356 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 07:27:03 +00:00
Javen O'Neal
f3ba3ffe5f whitespace, remove unused variable, expose Set interface for seenNotes, append \n character instead of String
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756348 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 05:23:34 +00:00
Javen O'Neal
e97b333ea0 bug 59773: move loop invariants out of for-loop for performance, use for-each instead of for loop when possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756345 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 04:42:31 +00:00
Nick Burch
34a6732b01 Slightly simplify HWPF writing code, and add in-place write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756003 13f79535-47bb-0310-9956-ffa450edef68
2016-08-11 15:27:33 +00:00
Nick Burch
8c7c45ecca HWPF in-place write support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756001 13f79535-47bb-0310-9956-ffa450edef68
2016-08-11 15:14:04 +00:00
Andreas Beeker
5a486ec7c8 forgot cryptoapi encryption flags
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755541 13f79535-47bb-0310-9956-ffa450edef68
2016-08-08 21:00:10 +00:00
Andreas Beeker
680683cf77 merge down trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755463 13f79535-47bb-0310-9956-ffa450edef68
2016-08-08 01:14:36 +00:00
Andreas Beeker
0bfefdfc04 HSSF CryptoAPI decryption support
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755461 13f79535-47bb-0310-9956-ffa450edef68
2016-08-08 00:10:44 +00:00
Nick Burch
f8bc502028 Whitespace, javadocs and @Overrides for the Logger classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755192 13f79535-47bb-0310-9956-ffa450edef68
2016-08-04 14:23:54 +00:00
Andreas Beeker
c4ac2e7758 Preparations for hssf_cryptoapi:
- Add cloneable
- Change existing hslf cryptoapi to streaming


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755127 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 23:54:01 +00:00
Nick Burch
a1f6d9c832 Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:53:43 +00:00
Nick Burch
60b2586c3f Refactor out some of the common FormulaEvaluator logic from HSSF to a base class (XSSF coming shortly)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755070 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:42:04 +00:00
Nick Burch
560ff4004e Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755068 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:15:13 +00:00
Nick Burch
1570d79529 Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755066 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:12:50 +00:00
Javen O'Neal
fcb22a8a5e bug 59922: rename XSSFPaswordHelper to XSSFPasswordHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754786 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:20:43 +00:00
Javen O'Neal
ca31684a27 bug 59922: make XSSFPasswordHelper internal because it works on XmlObject objects, which are generally an internal implementation detail of POI-OOXML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754785 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:03:36 +00:00
Javen O'Neal
66d7d4ddaa whitespace; +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754784 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:01:24 +00:00
Javen O'Neal
3c77adf9e8 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754782 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 17:36:06 +00:00
David North
984683ab4b Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59920

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 12:51:24 +00:00
Dominik Stadler
b8f1906f2a Rename and add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754705 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 06:23:36 +00:00
Javen O'Neal
5ddd038640 javadoc fix: incorrect deprecated replacement
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754702 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 05:32:41 +00:00
Mark Murphy
20907fc5b4 revert changes made in r1754691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754700 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 04:21:14 +00:00
Mark Murphy
8c0adfe55f correction to junit bugs in r1754691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 02:53:55 +00:00
Nick Burch
0fe7cd5299 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 00:17:33 +00:00
Mark Murphy
504a26b844 Add new class Cell Style Template and supporting enum for drawing borders
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 23:59:02 +00:00
Dominik Stadler
b23e85c852 Add coverage of function WEEKDAY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754689 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 21:24:13 +00:00
Dominik Stadler
98401573ed Test a few more cases of function INDIRECT()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754675 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:33 +00:00
Dominik Stadler
bbfb783a57 Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:27 +00:00
Dominik Stadler
5e0612eabd IDE warnings and fix a few places where we do not close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:17 +00:00
Nick Burch
dfcf57bfbf Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754530 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 14:03:28 +00:00
David North
e5877bd8e0 Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 13:24:00 +00:00
Dominik Stadler
fa24949520 Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68
2016-07-27 18:15:54 +00:00
Nick Burch
2beb904e86 HWPFDocument.write(File) support and tests #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754108 13f79535-47bb-0310-9956-ffa450edef68
2016-07-26 10:58:08 +00:00
Dominik Stadler
a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
2016-07-24 11:38:50 +00:00
Nick Burch
5a1ff54cf3 In-place write for HSLF #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753741 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 23:25:02 +00:00
Nick Burch
13a7be6cd2 Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 23:09:07 +00:00
Nick Burch
50519d3c73 Javadoc updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 10:27:27 +00:00
Javen O'Neal
327a4aa091 test Cell.setCellValue(false)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753634 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 02:17:37 +00:00
Nick Burch
92a146e4b5 If doing an in-place write, update the properties too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:31:57 +00:00
Nick Burch
af36e63bff #57919 HSLF writing to new File
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753622 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:20:02 +00:00
Nick Burch
d240667115 #57919 HPSF writing better error handling, and start prep for HSLF more write methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:09:33 +00:00
Nick Burch
b15c2b1c53 Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753620 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:39:12 +00:00
Nick Burch
3fa0449747 #57919 Add in-place and new-File write methods to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:35:51 +00:00
Nick Burch
1ccced289d Mark some more scratchpad document types as currently being read-only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753618 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:18:25 +00:00
Nick Burch
9830fd3dca Helper class for implementing extra write methods (#57919) for Scratchpad classes which are read-only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753617 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:13:03 +00:00
Nick Burch
8e50c77100 Prepare for pushing write() and write(File) to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 18:41:27 +00:00
Nick Burch
4dee08213a Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 12:01:36 +00:00
Nick Burch
dfd3bbee21 Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:14:05 +00:00
Nick Burch
d84df31b50 #57919 Start on support for writing to a new File (faster than OutputStream)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:07:29 +00:00
Javen O'Neal
93a53a1da3 add test case for bug 53564
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753359 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 10:08:50 +00:00
Javen O'Neal
50d1788d3d bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 08:02:41 +00:00
Javen O'Neal
ebbcd10034 bug 59881: fix spelling; patch from Patrick Zimmermann
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 18:25:28 +00:00
Dominik Stadler
abc3072df2 52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 10:32:55 +00:00
Dominik Stadler
35173d9e30 Some warnings/improvements suggested by IntelliJ
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 09:34:59 +00:00
Dominik Stadler
0bf845e0cc 59106: WorkdayFunction does not read the area with holidays correctly to calculate work days
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:27 +00:00
Dominik Stadler
29b21a82f7 Adjust unused local variables to also make FindBugs happy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753124 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:19 +00:00
Dominik Stadler
da9cd94e76 Fix one more place where stream were left open when an exception is thrown
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:12 +00:00
Dominik Stadler
da595c2343 Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:07 +00:00
Dominik Stadler
412ae950c2 Enable reproducer test for bug 56880 after it was fixed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753121 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:17:51 +00:00
Dominik Stadler
a118ec77d4 Add commented reproducer for bug 57603
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753120 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:17:45 +00:00
Javen O'Neal
f7021f3788 only calculate getTextHeight if it will be used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:33:32 +00:00