Commit Graph

821 Commits

Author SHA1 Message Date
Nick Burch
fdd0d249ca CFRule12 tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690778 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 17:54:28 +00:00
David North
24612d3e82 Add Sheet.getMergedRegions to obtain them all as a list. Implement this for XSSF using "deprecated" methods in XMLBeans which allow the operation to be linear in the number of regions rather than n-squared.
Fixes #57893

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690661 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 13:00:35 +00:00
David North
2f8aa558b3 Patch from Chris Boyle to add basic support for .xlsm (macro-enabled) workbooks. The binary blob containing the VBA macros may be copied from one such workbook into another.
Fixes #58036

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690593 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 09:05:17 +00:00
Dominik Stadler
efc96e1d8e Open file read-only in test to avoid making it dirty during running unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688045 13f79535-47bb-0310-9956-ffa450edef68
2015-06-28 19:55:56 +00:00
Dominik Stadler
bde247f61a Fix test to find the exception-text in all cases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687212 13f79535-47bb-0310-9956-ffa450edef68
2015-06-24 08:53:25 +00:00
Dominik Stadler
5103ea7c0c show full exception stack-trace if zip-bomb detection test fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687197 13f79535-47bb-0310-9956-ffa450edef68
2015-06-24 08:33:06 +00:00
Andreas Beeker
c0cb680292 Bug 56865 - Limit number of bytes (by counting them) while opening office docs
Bug 50090 - 'zip' bomb prevention

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687148 13f79535-47bb-0310-9956-ffa450edef68
2015-06-23 23:39:07 +00:00
Dominik Stadler
e4f5df42f6 Bug 56655: Fix Sumifs for cases where the criteria is in error.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686610 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 13:10:28 +00:00
Dominik Stadler
cb5588c4a1 Bug 56420: Fix possible NullPointerException when empty cell is included in Sumif calculation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686564 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 11:29:14 +00:00
Dominik Stadler
13eb52f12f Move more tests into base class and add a TestSXSSFBugs class to verify some things that are supported against SXSSFWorkbook as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686035 13f79535-47bb-0310-9956-ffa450edef68
2015-06-17 14:53:38 +00:00
Dominik Stadler
e7d33e4ccb Make setLandscape(false) and setLeftToRight(false) do what one would expect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686019 13f79535-47bb-0310-9956-ffa450edef68
2015-06-17 14:26:31 +00:00
Dominik Stadler
f77cdd40b4 add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685506 13f79535-47bb-0310-9956-ffa450edef68
2015-06-15 08:17:08 +00:00
David North
16a9eca7c8 My own patch to fix #56328
Add tests for initial patch applied by Nick in r1582892

Fix and test AreaReference#isWholeColumnReference to take account of the prevailing spreadsheet version. Fixing all users of this is a big undertaking, so for now I've left a fallback on the original behaviour for some cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685101 13f79535-47bb-0310-9956-ffa450edef68
2015-06-12 15:20:10 +00:00
David North
c580758b2c Use a different arbitrary value for the ID of the comment shape type. This appears to prevent Excel >= 2010 from turning POI-written comments into the wrong shape (giant curved arrow).
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=55410

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1683315 13f79535-47bb-0310-9956-ffa450edef68
2015-06-03 12:50:10 +00:00
Tim Allison
ca17056096 POI-57975: clean up white spaces and other style issues in XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682473 13f79535-47bb-0310-9956-ffa450edef68
2015-05-29 14:01:31 +00:00
Tim Allison
b8f9c0cad1 POI-57889 -- actually trigger inclusion of CTNumLvl with document contributed by Moritz Dorka on TIKA-1315
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682310 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 19:08:24 +00:00
Nick Burch
a727593a41 Correct package
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682210 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:15:07 +00:00
Nick Burch
c5c70d3ce4 Pull out the parts of TextPainter needed by XSLF from HSLF to common-SL in core #57963
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682209 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:13:23 +00:00
Dominik Stadler
03805d9e20 Add WorkbookFactory.create() with a flag to allow to open files read-only, keep the current way of opening read/write as default to not break existing code.
Also adjust Javadoc somewhat.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681823 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 19:30:21 +00:00
Dominik Stadler
9017803980 Make POIXMLDocument implement Closeable as it holds an OCPPackage with open resources and thus should be closed after usage. Until now only XSSFWorkbook did this, but it makes sense for all derived classes.
Also make close() in POIXMLDocument public to not have to re-implement it in all sub-classes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681822 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 19:30:04 +00:00
Dominik Stadler
589b189151 Prevent problems reported in Bug 56574 by ensuring that Cells are properly removed when a row is overwritten by calling createRow() with it's rownum.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680280 13f79535-47bb-0310-9956-ffa450edef68
2015-05-19 13:13:09 +00:00
Nick Burch
120608b1f9 Start exposing the default paragraph and run styles from XWPFStyles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678193 13f79535-47bb-0310-9956-ffa450edef68
2015-05-07 13:25:47 +00:00
Nick Burch
9fd1832753 Start on XWPFStyles support for document default styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678187 13f79535-47bb-0310-9956-ffa450edef68
2015-05-07 13:07:00 +00:00
Nick Burch
9a755850e9 Begin on test for going from xwpf text to style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678179 13f79535-47bb-0310-9956-ffa450edef68
2015-05-07 12:37:43 +00:00
Dominik Stadler
ea27ddf601 Try to fix flaky test by waiting for a switch of the second to ensure that we have the same timestamps in the two workbooks that we compare byte-wise in this test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677950 13f79535-47bb-0310-9956-ffa450edef68
2015-05-06 08:42:28 +00:00
Andreas Beeker
02bbe3b566 OOM fix for gump run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677913 13f79535-47bb-0310-9956-ffa450edef68
2015-05-05 23:51:10 +00:00
Tim Allison
8bfc6056c8 POI-57889 prevent NPE with on some documents with XWPFParagraph's getNumFmt() and add some other classes to enable calculation of paragraph numbers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677723 13f79535-47bb-0310-9956-ffa450edef68
2015-05-05 01:39:16 +00:00
Nick Burch
e9340cc1ba If an empty stream or file is given to WorkbookFactory.create, give a more informative exception - EmptyFileException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677562 13f79535-47bb-0310-9956-ffa450edef68
2015-05-04 09:15:48 +00:00
Nick Burch
c8f8cde62d Patch from Mark Olesen from bug #57552: Sort PackagePart returns from OPCPackage by name considering numbers in filenames, so Image10.png comes after Image9.png, fixing problems with XSLF adding 10+ images to a slide
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677373 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 08:47:50 +00:00
Nick Burch
3543d1a553 Avoid short wrapping on cell styles and formats > 32,767 in XSSF - format supports up to 64,000 of them #57880
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677371 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 08:10:07 +00:00
Dominik Stadler
31adc2f269 Add verifying testcase for Bug 57423 and Bug 55752, both are still not solved, though.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676965 13f79535-47bb-0310-9956-ffa450edef68
2015-04-30 11:54:13 +00:00
Dominik Stadler
3275263c2b Remove Eclipse warnings in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676903 13f79535-47bb-0310-9956-ffa450edef68
2015-04-30 05:58:15 +00:00
Nick Burch
925d32e2c1 Allow WorkbookFactory.create to open xlsx files protected with the default password
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676853 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:36:13 +00:00
Nick Burch
9f196708d4 #57593 Complete create overloading in WorkbookFactory to take passwords
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676847 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:19:38 +00:00
Nick Burch
73aa2c9ee3 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676845 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:13:42 +00:00
Nick Burch
2889cabaed #57593 Begin adding overloaded WorkbookFactory.create methods which take the spreadsheet password
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676843 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:12:18 +00:00
Nick Burch
fb4bf25259 Use a constant for the name of the OOXML encrypted package node
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676838 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 19:47:35 +00:00
Nick Burch
b2a1862f19 Patch from Jon Scharff from bug #57826 - If a XSSF shape has a buFont but no bullet character, mirror Excel and treat as un-bulleted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676831 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 19:21:37 +00:00
Nick Burch
c029154424 Add a (disabled) unit test showing the incorrect ordering problem of parts - bug #57552
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676810 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 18:31:12 +00:00
Dominik Stadler
4c96affb9a Add unit-test which verifies that fill and alignment styles are applied and read back in correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676276 13f79535-47bb-0310-9956-ffa450edef68
2015-04-27 14:29:59 +00:00
Nick Burch
3c1d9756ba Fix some inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675748 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 02:20:57 +00:00
Nick Burch
b681f4fb3a #57642 Fix setSheetName with ISERROR on XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675745 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 02:13:07 +00:00
Nick Burch
a5846f0f66 #57829 Avoid XmlValueDisconnectedException when removing a XWPFRun from a XWPFParagraph by removing from IRuns as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675738 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 01:29:10 +00:00
Dominik Stadler
f5c3a2a62c Print out slightly more on test-failure for a unit tests which fails intermittently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675266 13f79535-47bb-0310-9956-ffa450edef68
2015-04-22 06:49:38 +00:00
Dominik Stadler
d1385bbe1b Fix bug 57828, shifting more than one commit per row did not work.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674975 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 20:13:33 +00:00
Dominik Stadler
570819e4f6 Bug 56579: Throw exception if max string length of 32767 chars is exceeded in XSSF and SXSSF.
Add verification testcase for bug 57008.
Move some unit tests to the Bsae-Test-Class to verify things for all SS-implementations.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1671096 13f79535-47bb-0310-9956-ffa450edef68
2015-04-03 15:55:21 +00:00
Dominik Stadler
0216a881f7 Bug 56017: fix shifting comments with shifted rows and move some more tests into the base classes to run them against XSSF, SXSSF and HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666843 13f79535-47bb-0310-9956-ffa450edef68
2015-03-15 20:52:55 +00:00
Dominik Stadler
30d20582af Bug 56295: Fix cloning of styles across workbooks and handling of default value of attribute applyFill
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666736 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 19:32:28 +00:00
Nick Burch
ff737c5df4 Detect OOXML-strict, and give more helpful exceptions for them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666525 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:39:47 +00:00
Nick Burch
ace2354d6c Stub unit tests for #57699
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666510 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 16:46:15 +00:00