Commit Graph

3159 Commits

Author SHA1 Message Date
Tim Allison
fd125b9e4e bug 62624 -- ensure streams are closed...thanks to LGTM, and PJ!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845300 13f79535-47bb-0310-9956-ffa450edef68
2018-10-31 00:59:16 +00:00
Tim Allison
c257dd71f9 bug 62624 -- fix loop identified as dodgy by FindBugs; add a other sanity checks.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845299 13f79535-47bb-0310-9956-ffa450edef68
2018-10-31 00:47:51 +00:00
Tim Allison
9229cab9bc bug 62624 -- fix recursion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845284 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 21:30:57 +00:00
Tim Allison
9ab4318ade bug 62625 -- clean up imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845246 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 15:45:00 +00:00
Tim Allison
1db334a6fd bug 62625 -- add special handling for REFERENCE_NAME record that may only
contain an ascii string, against the spec in VBAMacroReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845238 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 13:25:20 +00:00
Tim Allison
0fd3027a67 bug 62624 -- fix npe by adding processing of module name mapping in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845138 13f79535-47bb-0310-9956-ffa450edef68
2018-10-29 15:48:44 +00:00
Dominik Stadler
232616f44d Adjust sample for creating comments to also create a .xlsx file
Enhance workbook factory to allow to create new empty workbooks as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844881 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:57 +00:00
Dominik Stadler
2148b7f278 Typos and IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844879 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:43 +00:00
Greg Woolsey
d24b4492f0 #62834 FormulaEvaluator.evaluateInCell() throws Exception
added cell type = formula check when looping through the shared formula range, to ignore any non-formula cells.

Also refactored a bit to enable passing in the evaluation context, as getCellFormula() uses it behind the scenes when evaluating a shared formula cell (has to shift the formula references based on the master cell).  Review of these changes is welcome, as always.

Checked all other code referencing the "SHARED" enum, and didn't see anything else that dealt with formula cell values and thus would need to notice non-formula cells.

Added unit test based on the failing file from Bugzilla.  Test failed until the fixed code was in place.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844295 13f79535-47bb-0310-9956-ffa450edef68
2018-10-19 01:11:47 +00:00
Yegor Kozlov
c7111f562c Bug 62373: Support for FREQUENCY function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844238 13f79535-47bb-0310-9956-ffa450edef68
2018-10-18 13:46:04 +00:00
Nick Burch
290e9c4087 #62831 Fix WorkbookFactory.create with a subclass of File, eg from JFileChooser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844116 13f79535-47bb-0310-9956-ffa450edef68
2018-10-17 14:24:59 +00:00
PJ Fanning
9f106fe8ec add stax entries to forbidden apis due to android issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843009 13f79535-47bb-0310-9956-ffa450edef68
2018-10-06 09:38:58 +00:00
PJ Fanning
6b4094650f change method to get XMLEventFactory due to issues seen on Android SDK
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842683 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 07:36:12 +00:00
PJ Fanning
4833c25d32 lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842302 13f79535-47bb-0310-9956-ffa450edef68
2018-09-29 09:33:52 +00:00
PJ Fanning
74c07d5307 [bug-62738] make int cast a long cast in randbetween
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1841321 13f79535-47bb-0310-9956-ffa450edef68
2018-09-19 12:18:56 +00:00
Andreas Beeker
3c3f2a3fe3 sonar fixes - blocker
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839745 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 11:56:18 +00:00
Andreas Beeker
2044779351 #62649 - Remove OPOIFS* / rename NPOIFS* to POIFS*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839709 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 00:25:50 +00:00
Andreas Beeker
e4bd5e838f #62649 - Remove OPOIFS
Fix HPSF UTF-8 encoding error with Bug52311.doc while refactoring CopyCompare/EntryUtils

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839201 13f79535-47bb-0310-9956-ffa450edef68
2018-08-26 11:55:00 +00:00
Dominik Stadler
522c33358b Ensure that file handles are closed for encrypted files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839197 13f79535-47bb-0310-9956-ffa450edef68
2018-08-26 11:41:20 +00:00
Dominik Stadler
71002b2491 Adjust test for JDK 9, 10 and 11
fix some IDE/Javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839195 13f79535-47bb-0310-9956-ffa450edef68
2018-08-26 11:41:09 +00:00
PJ Fanning
a611b66fd1 [bug-62639] make private constructor on DateFormatter public
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1838420 13f79535-47bb-0310-9956-ffa450edef68
2018-08-20 10:03:49 +00:00
Andreas Beeker
1407ace4f7 #61589 - Importing content does not copy hyperlink address
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837909 13f79535-47bb-0310-9956-ffa450edef68
2018-08-12 22:35:02 +00:00
Tim Allison
2bb839edd7 bug 62608 -- avoid ioobe in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837664 13f79535-47bb-0310-9956-ffa450edef68
2018-08-08 17:30:02 +00:00
PJ Fanning
83b60f4777 [bug-62275] in vlooup function, treat optional 4th param as true if the value is not provided
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1836857 13f79535-47bb-0310-9956-ffa450edef68
2018-07-27 21:26:31 +00:00
Andreas Beeker
d3b5a0141e #62564 - replace Thread.currentThread().getContextClassLoader() with getClass().getClassLoader()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1836590 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 22:57:18 +00:00
Dominik Stadler
a4251b706b Adjust comments and IDE warnings, duplicate code reduction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835183 13f79535-47bb-0310-9956-ffa450edef68
2018-07-05 19:53:52 +00:00
Dominik Stadler
d2c3c7e004 Add a test with a threaded TempFileCreationStrategy, remove duplicated constant.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835182 13f79535-47bb-0310-9956-ffa450edef68
2018-07-05 19:53:44 +00:00
Andreas Beeker
0a999d8cd3 #62451 - Document last printed in the year 27321
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833668 13f79535-47bb-0310-9956-ffa450edef68
2018-06-17 16:59:48 +00:00
PJ Fanning
e2195c505f use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833096 13f79535-47bb-0310-9956-ffa450edef68
2018-06-07 06:03:35 +00:00
Andreas Beeker
611c15f412 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832748 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 21:28:06 +00:00
Andreas Beeker
7088a68f1d sonar fixes and
disable closing of outputstream in ZipPackage.saveImpl() - see https://stackoverflow.com/questions/50646538/stream-close-exception-occures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832746 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 20:29:35 +00:00
Andreas Beeker
d09cb8f9d8 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832735 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 13:01:14 +00:00
Andreas Beeker
09fa9890a6 #62355 - unsplit packages - 4 - open HPSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832361 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:15:59 +00:00
Andreas Beeker
e2ec4ebe95 #62355 - unsplit packages - 3 - only imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832360 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:13:31 +00:00
Andreas Beeker
1c0834c436 #62355 - unsplit packages - 2 - modified classes (not only imports)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832359 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:01:33 +00:00
Andreas Beeker
54f191b613 #62355 - unsplit packages - 1 - moved classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832358 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 21:59:18 +00:00
Andreas Beeker
b144ace936 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832067 13f79535-47bb-0310-9956-ffa450edef68
2018-05-22 22:39:22 +00:00
Andreas Beeker
1d6a1c4072 sonar fixes - null dereference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831992 13f79535-47bb-0310-9956-ffa450edef68
2018-05-21 23:17:57 +00:00
Andreas Beeker
5c71e10c46 #62051 - Two shapes have the same shapeId within the same slide.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831947 13f79535-47bb-0310-9956-ffa450edef68
2018-05-20 22:00:14 +00:00
Andreas Beeker
508e6da4e5 remove test code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831754 13f79535-47bb-0310-9956-ffa450edef68
2018-05-17 05:35:58 +00:00
Andreas Beeker
f35e818fa2 #62037 - SlideNames should not be null but have a default as if accessed by VBA
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831745 13f79535-47bb-0310-9956-ffa450edef68
2018-05-16 21:57:49 +00:00
Andreas Beeker
0e8736dcda #62381 - Fix rendering of AutoShapes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831743 13f79535-47bb-0310-9956-ffa450edef68
2018-05-16 20:30:53 +00:00
Nick Burch
c079795f4e List a few more missing functions as inline-comments, based on definitions from functionMetadata.txt
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831572 13f79535-47bb-0310-9956-ffa450edef68
2018-05-14 14:25:00 +00:00
Greg Woolsey
bf17600457 A few more places I should never have introduced Cell as a parameter, sine CellReference is all that is needed, faster, and allows for undefined cells.
Backward compatible for the few people using it so far, with comments to point to the faster methods.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831203 13f79535-47bb-0310-9956-ffa450edef68
2018-05-08 19:03:52 +00:00
Andreas Beeker
5961b640a5 add convenience method for files to FileMagic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830782 13f79535-47bb-0310-9956-ffa450edef68
2018-05-02 18:33:23 +00:00
Andreas Beeker
17fdb3188c add additional exception info to failing IOUtils.toByteArray
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830779 13f79535-47bb-0310-9956-ffa450edef68
2018-05-02 17:29:24 +00:00
Andreas Beeker
066a8a0b42 add license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830725 13f79535-47bb-0310-9956-ffa450edef68
2018-05-02 05:36:15 +00:00
PJ Fanning
32b370fb67 [githib-107] add areas function support. Thanks to Inji Hanbin. This closes #107
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830685 13f79535-47bb-0310-9956-ffa450edef68
2018-05-01 14:47:29 +00:00
Andreas Beeker
e0f7014503 #59893 - Forbid calls to InputStream.available
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830400 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 21:38:19 +00:00
Dominik Stadler
ad92fcca9e Fix setting active cell in .xls by populating field_6_refs whenever row/column changes, this fixes bug 61905
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830115 13f79535-47bb-0310-9956-ffa450edef68
2018-04-25 20:14:07 +00:00