Dominik Stadler
1496e83eaa
Adjust to make forbidden-api-check succeed again
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808930 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 19:02:31 +00:00
Dominik Stadler
985af5304a
Bug 61148: Fix calculating formula value, unfortunately we currently need to set the value twice
...
Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808929 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 19:02:22 +00:00
Dominik Stadler
d1d01bb632
IntelliJ warnings, deprecation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808928 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 19:02:06 +00:00
Dominik Stadler
c31d6686db
Fix some IntelliJ warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808908 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 16:23:37 +00:00
Tim Allison
a59402a37f
60805 (partial) -- remove/suppress println in tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808903 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 15:52:21 +00:00
Dominik Stadler
d1765d7e76
While working on bug 61148 I found that getCellType() and setCellErrorValue() in SXSSFCell are doing different things than the ones in XSSFCell, tried to fix this by mimicking functionality of XSSF in SXSSF as well.
...
Reformating some small things as well.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808874 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 12:47:13 +00:00
Javen O'Neal
4835636fed
bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808817 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 03:27:40 +00:00
Javen O'Neal
7a52b8c93b
bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808816 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 03:26:20 +00:00
Dominik Stadler
357816942a
Bug 61520: Add JavaDoc about name-references in Excel
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808763 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 18:55:07 +00:00
PJ Fanning
51305b6260
use non-deprecated versions of getCellType
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 16:31:55 +00:00
PJ Fanning
e0ee55e75f
change CellFormat.ultimateType to return CellType
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808739 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 16:06:54 +00:00
PJ Fanning
318fe3e597
change HyperLink getType to return HyperlinkType
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 15:55:48 +00:00
PJ Fanning
aaad224db9
fix compiler warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808722 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 14:15:15 +00:00
PJ Fanning
7dad60e9d4
update getCellType to return CellType enum instead of int
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:58:55 +00:00
PJ Fanning
4a4c428b6b
update getCellType to return CellType enum instead of int
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:38:07 +00:00
PJ Fanning
d4486af6de
update getCellType to return CellType enum instead of int
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:26:16 +00:00
PJ Fanning
d9b63eb569
remove some deprecated code slated for removal in 3.18
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808687 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 12:27:36 +00:00
PJ Fanning
16d262d0b4
Change getCachedFormulaResultType to return CellType
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808678 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 10:50:50 +00:00
Andreas Beeker
a51bac65b7
#60499 - Deleting a picture that is used twice on a slide corrupt the slide
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808661 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 22:45:03 +00:00
Dominik Stadler
71cfb659a1
Remove deprecated methods from NPOIFSFileSystem/OPOIFSFileSystem
...
IntelliJ warnings/suggestions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808622 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:45 +00:00
Dominik Stadler
2917583bd2
Fix some warnings in OOXMLLite and move copyFile to IOUtils
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808621 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:31 +00:00
Dominik Stadler
b644047b70
Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:23 +00:00
Dominik Stadler
75c63b6bbe
Some more code cleanup
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808619 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:07:48 +00:00
PJ Fanning
0b7774a452
remove some deprecated code slated for removal in 3.18
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808535 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 12:16:29 +00:00
Dominik Stadler
1f4344a048
Fix some compiler warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808523 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:28 +00:00
Dominik Stadler
2600c60fb5
Use Integer.compare() where possible
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808522 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:20 +00:00
Dominik Stadler
8b564f1185
Fix some warnings in unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808521 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:06 +00:00
Dominik Stadler
b7547a01f6
Use Collections.singleton() where applicable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808520 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:56 +00:00
Dominik Stadler
356d4a77cb
Fix some warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808519 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:50 +00:00
Dominik Stadler
5341a131de
Remove unnecessary local variables
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:38 +00:00
Dominik Stadler
7937da6a10
Remove unnecessary type arguments (Java 8)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:27:23 +00:00
Dominik Stadler
d4070f05e7
Remove unnecessary type arguments
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808515 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:24:05 +00:00
Dominik Stadler
50beafbb47
Suppress some warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808514 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:57 +00:00
Dominik Stadler
87f5a0c7cd
Remove unused imports
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808513 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:48 +00:00
Dominik Stadler
8ca329e08b
Remove unnecessary casts and toString() calls
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808512 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:30 +00:00
Dominik Stadler
0ce7fff0be
Remove unnecessary semicolons
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808511 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:15 +00:00
Dominik Stadler
f27cb3354d
Remove unnecessary initialization of members
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808510 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:22:59 +00:00
Dominik Stadler
ba5f686a06
Fix typos and warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808509 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:21:35 +00:00
Dominik Stadler
e57e73fe38
Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary casts
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808508 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:21:28 +00:00
Dominik Stadler
51944a4e82
Detect some HTML files as separate invalid filetype
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808507 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:56 +00:00
Dominik Stadler
92ae9ce5e0
Allow to produce a jar for the integration-test-code so we can use it directly in the mass-regression tests without having to copy it for every run.
...
Enable some forbidden-api-checks for integration-test code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808506 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:50 +00:00
Dominik Stadler
6044d4629c
Adjust local test in integration-test file-handler
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808505 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:44 +00:00
Dominik Stadler
ee35ccda7f
Add .git as excluded dir for integration-tests and add a local test for XSSFBFileHandler to be able to manually test single files quickly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808504 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:38 +00:00
Dominik Stadler
23c2850586
Add additional check as mentioned in bug 50060
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808503 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:32 +00:00
Dominik Stadler
445852e773
Tried to reproduce bug 61300, but could not.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808502 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:25 +00:00
Dominik Stadler
f839090fe6
At least print out correct offset information for PtrRefN if it has offset values set
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808501 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:17 +00:00
Dominik Stadler
c9151662e8
Add test for question on the mailing-list
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808500 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:06 +00:00
PJ Fanning
6998fe1ea6
remove some deprecated code slated for removal in 3.18
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808483 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 20:17:21 +00:00
Dominik Stadler
f947ab760d
Java 8: Deprecate some methods in IOUtils
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808475 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 18:39:43 +00:00
Dominik Stadler
6592bf6fbe
Adjust some more places for the new versions of some third party libraries
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808473 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 18:39:29 +00:00
Dominik Stadler
276c8c89de
Update third party libs to latest versions
...
Start updating build to Java 8
Set version to 4.0-beta1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808472 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 18:39:18 +00:00
PJ Fanning
8f53bd94a6
remove some deprecated code slated for removal in 3.18
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808455 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 12:29:35 +00:00
Nick Burch
e4fc7ff5a7
Remove javadoc references to removed classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808436 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 09:03:56 +00:00
PJ Fanning
7863d0b312
remove deprecated inner classes from HSFColor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808432 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 08:29:31 +00:00
PJ Fanning
19d58f3657
remove some deprecated code slated for removal in 3.18
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808403 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 23:44:47 +00:00
PJ Fanning
4d1907b447
remove some deprecated code slated for removal in 3.18
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808402 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 23:09:08 +00:00
PJ Fanning
320d9735ca
remove some deprecated code slated for removal in 3.18
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808400 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 22:19:16 +00:00
PJ Fanning
18e53b3bef
add missing licenses on test classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808315 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 07:21:33 +00:00
Tim Allison
4852228f3f
60279 -- back off to brute-force search for macro content if offset information is not correct
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808301 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 02:22:55 +00:00
PJ Fanning
5ef2f1636c
Numeric Array Formula and Matrix Function [from Bob95132] This closes #69
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808297 13f79535-47bb-0310-9956-ffa450edef68
2017-09-13 23:54:36 +00:00
PJ Fanning
e726dd68de
[bug-61515] fix xlsf issue with relationships [from Alain Bearez] This closes #70
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808294 13f79535-47bb-0310-9956-ffa450edef68
2017-09-13 23:10:44 +00:00
Nick Burch
526dc01a50
Copy over and tweak PicturesSource from Apache Tika
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1807651 13f79535-47bb-0310-9956-ffa450edef68
2017-09-07 21:36:15 +00:00
Andreas Beeker
d17deb6185
#61478 - POI OOXML-Schema lookup uses wrong classloader
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1807418 13f79535-47bb-0310-9956-ffa450edef68
2017-09-05 21:30:29 +00:00
Tim Allison
60176900fc
While working on 61475, need to add a new line after picture text...not worth separate ticket.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806843 13f79535-47bb-0310-9956-ffa450edef68
2017-08-31 20:20:24 +00:00
Tim Allison
235d102f26
61475 -- append text from pictures only once...bug from my work on 61470.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806839 13f79535-47bb-0310-9956-ffa450edef68
2017-08-31 19:14:43 +00:00
Tim Allison
3b32a00aa7
61470 -- add extraction of content within ruby elements; allow users to concatenate or not concatenate phonetic strings. Default is to concatenate.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806712 13f79535-47bb-0310-9956-ffa450edef68
2017-08-30 16:29:52 +00:00
Greg Woolsey
914ae602b1
Fixes bug #61468 , caused by a confusing OOXML spec design as noted in JavaDocs added in r1795648.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806623 13f79535-47bb-0310-9956-ffa450edef68
2017-08-29 17:14:52 +00:00
Dominik Stadler
20fa8328f4
Verify that bug 61294 is fixed now, add some more coverage for IOUtils in general
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806162 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 11:51:18 +00:00
Dominik Stadler
34f35b2d0e
Revert performance tuning done via Bug 61350 as it lead to problems when running multi-threaded large regression tests.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806077 13f79535-47bb-0310-9956-ffa450edef68
2017-08-24 19:46:39 +00:00
Dominik Stadler
2108f82449
Fix 60384 and 60709: When shifting with merged regions we should correctly check if the region is moved along or needs to be removed because it is not fully kept via the shifting. This was broken by the fix for bug 59740, now additional unit tests ensure that it works better.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805518 13f79535-47bb-0310-9956-ffa450edef68
2017-08-19 16:31:45 +00:00
Dominik Stadler
b233345510
Add more non-test classes in OOXMLLite and add another font-metric that appears
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805516 13f79535-47bb-0310-9956-ffa450edef68
2017-08-19 16:31:28 +00:00
Greg Woolsey
5e5adc70e5
Bug 61431 - Conditional formatting evaluation ignores undefined cells
...
now evaluating based on cell references instead, and watching out for undefined cells in rules that require a cell.
Added unit test based on previously failing file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805245 13f79535-47bb-0310-9956-ffa450edef68
2017-08-16 23:52:27 +00:00
Andreas Beeker
6f341568b6
#61381 - PushbackInputStreams passed to ZipHelper may not hold 8 bytes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804854 13f79535-47bb-0310-9956-ffa450edef68
2017-08-11 20:47:48 +00:00
Nick Burch
9ae6952845
Add an example of trying multiple passwords against an OOXML file. More a demo than anything, GPU enabled tools are much faster!
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804667 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 12:43:16 +00:00
PJ Fanning
9fa3e36e9a
[Bug-61048] SXSSF module writes wrong escape sequence for carriage returns
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804596 13f79535-47bb-0310-9956-ffa450edef68
2017-08-09 18:37:14 +00:00
Dominik Stadler
b3ad734de1
Assert on the contents of the byte-array to see if the problem happens during writing the data or reading it back in
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803614 13f79535-47bb-0310-9956-ffa450edef68
2017-08-01 06:26:44 +00:00
Dominik Stadler
c7e1fabf1c
Reformat code slightly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803612 13f79535-47bb-0310-9956-ffa450edef68
2017-08-01 06:26:27 +00:00
Andreas Beeker
97f90ca839
Fix further Windows JVM 6 font rendering errors - OOM and EXCEPTION_ACCESS_VIOLATION
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803528 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 12:25:23 +00:00
Andreas Beeker
27fd9e4cbb
remove invalid javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803493 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 08:42:48 +00:00
Nick Burch
e34e286850
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803488 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 06:36:10 +00:00
Andreas Beeker
ff2bcdf62d
#61363 - Unify escher shape id allocation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803483 13f79535-47bb-0310-9956-ffa450edef68
2017-07-30 23:11:36 +00:00
Andreas Beeker
b3c111a283
Add handling of alternate content elements
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803397 13f79535-47bb-0310-9956-ffa450edef68
2017-07-29 23:08:15 +00:00
Greg Woolsey
f9b9c0d18b
Deleting a sheet did not delete table parts and relations. Deleting a table needs to also delete any queryTable relations and parts.
...
Previous behavior didn't result in documents Excel complained about, but left dead entries in the ZIP structure, which made it bigger and bugged me.
This change does not attempt to delete query connection definitions, as those aren't referenced as relations, and don't have a usage counter to ensure we only delete them if there are no other references. In my samples I had query tables on multiple sheets using the same connection definition, and wanted to delete only one sheet/table but leave others.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803317 13f79535-47bb-0310-9956-ffa450edef68
2017-07-28 18:01:36 +00:00
PJ Fanning
9f28e36438
[Bug-61354] fix issue with extracting text from Word docs. This closes #66
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803250 13f79535-47bb-0310-9956-ffa450edef68
2017-07-28 07:42:23 +00:00
Greg Woolsey
e1f37388fc
Fix data validation value list evaluation
...
One of my users found that my initial implementation was lacking a core distinction - most evaluations expect a single result, and "unwrap" 2/3D ValueEval results to a single value based on the input row/column.
However, data validation list formulas explicitly are expected to return a 2D ValueEval. This worked when the formula was simple and evaluated to a single Ptg, but only returned one value when the formula was more complex, or referenced a named range defined as a complex formula.
This change teaches WorkbookEvaluator about the distinction, by way of a new attribute for FormulaType.
There is room for discussion over how it is implemented, but this works for me.
Includes the failing workbook we had as a new unit test.
While I was in FormulaType I went ahead and removed the deprecated, unused, and redundant code marked for removal in 3.17.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803121 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 22:19:58 +00:00
Andreas Beeker
49a222ecbc
#61350 - Use unsynchronized xmlbeans
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803120 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 22:15:27 +00:00
Greg Woolsey
9e896b17ea
Another font size variation. I suspect it is my Windows 10 scaling factor, set to 100% instead of the Windows 10 default 125%.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803117 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 22:00:23 +00:00
Tim Allison
16f331054f
61337 -- try to convert assertions to exceptions. I left in the assertions for the binary search components.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803092 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 18:43:27 +00:00
Tim Allison
21cbf101bc
61346 add more sanity checks before allocating byte arrays in emf/wmf
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803041 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 12:46:24 +00:00
Andreas Beeker
4ca2ad85b9
remove test leftover
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803024 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 08:13:16 +00:00
Andreas Beeker
d345faa025
Bug 61182 - Invalid signature created for streamed xlsx file
...
- add hashes for other linebreaks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803011 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 22:42:22 +00:00
Tim Allison
a07ed9e864
61338 -- avoid infinite loop triggered by fuzzed wmf file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802997 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 20:26:57 +00:00
Tim Allison
df3910135f
61295 -- prevent potential oom in HPSF triggered by fuzzed file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802879 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 01:38:35 +00:00
Tim Allison
67719a8d4f
augment expected sizes in TestFonts
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802855 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 19:29:29 +00:00
Dominik Stadler
cc0294d58b
Refactor test somewhat to make it easier to see what it actually verifies
...
Check some more to see why it fails sometimes in CI, e.g. on node qnode1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802817 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 14:16:34 +00:00
Andreas Beeker
08b03d9547
Fonts bugfix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802751 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 05:39:33 +00:00
Andreas Beeker
2325cdb9e6
Bug 61331 - Font group handling / common font interface
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802741 13f79535-47bb-0310-9956-ffa450edef68
2017-07-23 22:45:47 +00:00
Dominik Stadler
8a95a71a48
My version of Java 6 chokes on Generics here
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802633 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:29 +00:00
Dominik Stadler
f28bbb750c
Adjust TestFonts for my version of Ubuntu
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802632 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:22 +00:00
Dominik Stadler
c76672b8aa
ExtractorFactory: Try to close resources also on Errors to avoid keeping files open too long
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802630 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:11 +00:00