Javen O'Neal
|
fc2bcfae9a
|
cleanup for r1812476: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:08:43 +00:00 |
|
Javen O'Neal
|
5fb4887907
|
replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:41:42 +00:00 |
|
Javen O'Neal
|
cfac692a6a
|
string.equals("") -> string.isEmpty() or "".equals(string)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 07:45:53 +00:00 |
|
Javen O'Neal
|
bcbadce32e
|
IntelliJ: simplify boolean logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812363 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-17 07:43:41 +00:00 |
|
PJ Fanning
|
16125ab3cc
|
Make public static members final [thanks to Kui Liu]. This close #78.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-15 20:50:58 +00:00 |
|
Dominik Stadler
|
bc7d79a613
|
Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-13 09:40:22 +00:00 |
|
Dominik Stadler
|
c05e07b55c
|
adjust tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-11 18:31:34 +00:00 |
|
Dominik Stadler
|
673b223f61
|
Remove "filling" in IntList as this has no effect whatsoever as far as I could see
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-11 05:32:05 +00:00 |
|
Dominik Stadler
|
566789e983
|
Apply patch from bug 61096: Add support for modules in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811383 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-07 06:11:12 +00:00 |
|
Dominik Stadler
|
48613ee271
|
Bug 61064: Support behavior of function CEILING in newer versions of Microsoft Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1810007 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-28 14:36:53 +00:00 |
|
Dominik Stadler
|
6450f1cc42
|
Bug 61082: Adjust JavaDoc for getFirst/LastRow/Cell to explain that there might be empty rows/cells included in the counts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809988 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-28 13:12:32 +00:00 |
|
Dominik Stadler
|
688d5072d1
|
Fix bug 61516: when copying cells with formulas we should properly check for references that are invalid afterwards.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809967 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-28 09:56:45 +00:00 |
|
Dominik Stadler
|
a751880c11
|
Replace "getEntry() plus catch" by "hasEntry()" in HSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809738 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 12:33:08 +00:00 |
|
Dominik Stadler
|
991fba37a2
|
Fixup change for CellReference to keep the behavior the same as before
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809737 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 12:31:51 +00:00 |
|
Dominik Stadler
|
af1b1d619c
|
Replace deprecated CellReference class and some other warnings fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809714 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 08:26:05 +00:00 |
|
Tim Allison
|
7a2ce09761
|
Bug 61349 -- bump limits on classes that caused regressions in Dominik's regression corpus. Many thanks to Dominik Stadler for running the regression tests!!!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809623 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-25 12:53:10 +00:00 |
|
PJ Fanning
|
3a622169d3
|
Remove more deprecated classes and methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809428 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-23 14:03:25 +00:00 |
|
Dominik Stadler
|
4a6bb031a0
|
Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809371 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-23 07:41:27 +00:00 |
|
Dominik Stadler
|
79a039ec8d
|
Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809349 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-22 20:07:56 +00:00 |
|
Nick Burch
|
dc9416ec4d
|
Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809171 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-21 15:09:50 +00:00 |
|
Tim Allison
|
9cade10fa4
|
Bug 61349 -- add more sanity checks when allocating byte[]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-21 14:52:59 +00:00 |
|
Dominik Stadler
|
985af5304a
|
Bug 61148: Fix calculating formula value, unfortunately we currently need to set the value twice
Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808929 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-19 19:02:22 +00:00 |
|
Dominik Stadler
|
d1d01bb632
|
IntelliJ warnings, deprecation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808928 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-19 19:02:06 +00:00 |
|
Dominik Stadler
|
357816942a
|
Bug 61520: Add JavaDoc about name-references in Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808763 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 18:55:07 +00:00 |
|
PJ Fanning
|
51305b6260
|
use non-deprecated versions of getCellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 16:31:55 +00:00 |
|
PJ Fanning
|
e0ee55e75f
|
change CellFormat.ultimateType to return CellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808739 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 16:06:54 +00:00 |
|
PJ Fanning
|
318fe3e597
|
change HyperLink getType to return HyperlinkType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 15:55:48 +00:00 |
|
PJ Fanning
|
7dad60e9d4
|
update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 13:58:55 +00:00 |
|
PJ Fanning
|
4a4c428b6b
|
update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 13:38:07 +00:00 |
|
PJ Fanning
|
d4486af6de
|
update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 13:26:16 +00:00 |
|
PJ Fanning
|
d9b63eb569
|
remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808687 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 12:27:36 +00:00 |
|
PJ Fanning
|
16d262d0b4
|
Change getCachedFormulaResultType to return CellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808678 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-18 10:50:50 +00:00 |
|
Dominik Stadler
|
71cfb659a1
|
Remove deprecated methods from NPOIFSFileSystem/OPOIFSFileSystem
IntelliJ warnings/suggestions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808622 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-17 11:08:45 +00:00 |
|
Dominik Stadler
|
2917583bd2
|
Fix some warnings in OOXMLLite and move copyFile to IOUtils
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808621 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-17 11:08:31 +00:00 |
|
Dominik Stadler
|
b644047b70
|
Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-17 11:08:23 +00:00 |
|
Dominik Stadler
|
75c63b6bbe
|
Some more code cleanup
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808619 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-17 11:07:48 +00:00 |
|
PJ Fanning
|
0b7774a452
|
remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808535 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 12:16:29 +00:00 |
|
Dominik Stadler
|
2600c60fb5
|
Use Integer.compare() where possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808522 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:29:20 +00:00 |
|
Dominik Stadler
|
8b564f1185
|
Fix some warnings in unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808521 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:29:06 +00:00 |
|
Dominik Stadler
|
356d4a77cb
|
Fix some warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808519 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:28:50 +00:00 |
|
Dominik Stadler
|
5341a131de
|
Remove unnecessary local variables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:28:38 +00:00 |
|
Dominik Stadler
|
7937da6a10
|
Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:27:23 +00:00 |
|
Dominik Stadler
|
50beafbb47
|
Suppress some warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808514 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:23:57 +00:00 |
|
Dominik Stadler
|
87f5a0c7cd
|
Remove unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808513 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:23:48 +00:00 |
|
Dominik Stadler
|
8ca329e08b
|
Remove unnecessary casts and toString() calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808512 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:23:30 +00:00 |
|
Dominik Stadler
|
0ce7fff0be
|
Remove unnecessary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808511 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:23:15 +00:00 |
|
Dominik Stadler
|
f27cb3354d
|
Remove unnecessary initialization of members
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808510 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:22:59 +00:00 |
|
Dominik Stadler
|
ba5f686a06
|
Fix typos and warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808509 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:21:35 +00:00 |
|
Dominik Stadler
|
e57e73fe38
|
Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808508 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:21:28 +00:00 |
|
Dominik Stadler
|
51944a4e82
|
Detect some HTML files as separate invalid filetype
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808507 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-16 08:20:56 +00:00 |
|