Commit Graph

8459 Commits

Author SHA1 Message Date
Javen O'Neal
f458a9ac41 convert TestColumnHelper from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777038 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 23:23:16 +00:00
Javen O'Neal
18fd1b522d assertEquals(false, ...) -> assertFalse(...)
assertEquals(true, ...) -> assertTrue(...)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777037 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 23:14:53 +00:00
Javen O'Neal
ca0154a793 use case-insensitive string startsWith/endsWith utility function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777031 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 22:23:56 +00:00
Andreas Beeker
b919ad9989 Sonarqube fixes
- replace RuntimeException with application specific runtime exception
- clean-up sources - add braces to if statements and add override annotations
- fix a few hslf blockers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776896 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 00:55:49 +00:00
Andreas Beeker
f2052fe278 Sonarqube fixes - Cast one of the operands of this multiplication operation to a ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776894 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 22:59:35 +00:00
Javen O'Neal
4ed96136ec md5hash should not fail silently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776828 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 06:58:01 +00:00
Javen O'Neal
11c8858f6e use last file extension if multiple extensions; close opened stream; extract String constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776827 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 06:57:42 +00:00
Andreas Beeker
a4a0c1e91a fix content-type handling in *SSF-EmbeddedExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776823 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 00:56:51 +00:00
Andreas Beeker
254b42ff26 #60521 - Enable nested XSSF GroupShapes and fix calculation of Client-/ChildAnchor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776820 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:54:32 +00:00
Andreas Beeker
1d9c74b1bf #60519 - Extractor for *SSF embeddings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776819 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:50:47 +00:00
Andreas Beeker
db4bdaf29a #60520 - Provide *SSF functionality via Common SS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776818 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:47:23 +00:00
Andreas Beeker
820c8f8fd3 fix forbidden-apis-check error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776817 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:37:14 +00:00
Dominik Stadler
8f1eed63cc Fix missing license-headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776806 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 17:55:52 +00:00
Dominik Stadler
13e4ff4553 Cover some dev-tools with a few simple tests, close resources correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776798 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 16:53:33 +00:00
Dominik Stadler
c2022f7c3a Allow to pass --add-modules to javadoc as well as we get lots of missing code reported otherwise, we cannot use the existing property java9addmods as we need to use a different default-value for non-JDK9 builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776797 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 16:53:20 +00:00
Dominik Stadler
102c0d2173 Bug 60219: FormulaParser can't parse external references when sheet name is quoted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776796 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 16:53:16 +00:00
Dominik Stadler
1350ad3eb3 Coverage:
* Exclude "examples" from coverage in Jenkins, add some comments
* Fix warning in newer Gradle versions
* Adjust coverage-excludes in build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776715 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 09:43:13 +00:00
Dominik Stadler
b2a4c75665 Fix some Findbugs reports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776714 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 09:43:08 +00:00
Dominik Stadler
8e1a75912e Jenkins DSL: IBM JDK should not use noScratchpad, set coverage-flag for no-scratchpad-job
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776650 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:19:12 +00:00
Dominik Stadler
e66d78a388 Jenkins DLS: Remove support for multiple JDKs, it was not used and did not work anyway due to name-clashes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776649 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:12:14 +00:00
Dominik Stadler
a30315de20 Send emails for builds with JDK 9 to dev@ now after it ran green for the first time
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776648 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:12:10 +00:00
Dominik Stadler
36406ad3a1 Ensure streams are closed always, reformat code somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776647 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:12:06 +00:00
Dominik Stadler
6f616d0a51 Bug 60369: Adjust pattern to better handle non-ASCII characters in Month-names which can appear since Java 8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776646 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:11:55 +00:00
Dominik Stadler
da2b7c0969 Fix some compilation warnings
Update Javadoc
Reformat code somewhat
Supress IntelliJ warnings in findbugs-filters.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776645 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:11:48 +00:00
Dominik Stadler
06eaa174d7 Set --add-modules as environment-variable as well as we need to enable it in Ant itself for the forbidden-api-checks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776634 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 20:35:13 +00:00
Dominik Stadler
4d83cc8ac2 Fix an api-violations introduced in a test-case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776633 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 20:35:08 +00:00
Dominik Stadler
de83b46caa Update JaCoCo to 0.7.8 to allow to run it when using JDK 9
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776623 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 19:03:44 +00:00
Dominik Stadler
800866450b Add test provided via bug 60536 for bug 60526, remove some warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776622 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 18:54:47 +00:00
Dominik Stadler
a6f5bcc970 Add full support for using file-leak-detector, will be added to CI to report missing close() calls in test-runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776617 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 18:37:24 +00:00
Dominik Stadler
7b5a7e32df Allow to set the new --add-opens argument for JDK 9, scratchpad tests require slightly more memory on JDK 9 now, also adjust the Jenkins DSL accordingly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776608 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 17:00:13 +00:00
Dominik Stadler
12e2fa39fa Bug 60512: Add missing XSSFRelation.CUSTOM_PROPERTY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776606 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 16:55:19 +00:00
Dominik Stadler
8def7307d9 Bug 60452: WorkdayCalculator calculateWorkdays does return wrong value for same day input
deprecate unused method isNonWorkday

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776588 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 15:05:14 +00:00
Dominik Stadler
b573615cd0 bug 60526: Make loggers final and make throttled log actually work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776555 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 13:09:28 +00:00
centic
a977e9eaf2 Disable Sonar in Gradle build for now, it requires Java 8, but we should still be able to compile with Java 7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776317 13f79535-47bb-0310-9956-ffa450edef68
2016-12-28 19:47:40 +00:00
centic
b49a16e7cc Add sonar-plugin to Gradle build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776072 13f79535-47bb-0310-9956-ffa450edef68
2016-12-26 20:47:29 +00:00
centic
06b9fb5999 Maven: Add jacoco plugin and adjust to apply argLine correctly when calling "mvn jacoco:prepare-agent package jacoco:report jacoco:report-aggregate", however report-aggregate does not seem to work yet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776068 13f79535-47bb-0310-9956-ffa450edef68
2016-12-26 19:51:47 +00:00
centic
25b22afebf Add some throttling to the log for failed SAXHelper features to not spam the log on JDK 9 with restricted reflection
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776067 13f79535-47bb-0310-9956-ffa450edef68
2016-12-26 19:51:42 +00:00
centic
0b17d4def9 Use one redirection less when downloading findbugs jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776066 13f79535-47bb-0310-9956-ffa450edef68
2016-12-26 19:51:37 +00:00
centic
a150527574 Add mising @Override and other warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776065 13f79535-47bb-0310-9956-ffa450edef68
2016-12-26 19:51:32 +00:00
kiwiwings
b4728919b9 report size of entries for POIFSViewer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775992 13f79535-47bb-0310-9956-ffa450edef68
2016-12-25 00:06:13 +00:00
kiwiwings
3ff9eb5f0d Fix 0-pointer on unset document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775565 13f79535-47bb-0310-9956-ffa450edef68
2016-12-21 22:03:54 +00:00
centic
c44cf6ab38 Sonar issues: Mark two places where we catch Error/Throwable as "On purpose"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775122 13f79535-47bb-0310-9956-ffa450edef68
2016-12-19 15:25:20 +00:00
centic
9a04e2dd07 Comments, Javadoc and make close() only log instead of throw an exception to not have catch inside catch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775118 13f79535-47bb-0310-9956-ffa450edef68
2016-12-19 15:03:58 +00:00
kiwiwings
503a63c0d4 fix eclipse warnings - close resources
add getter for HSLF slideshows implementation class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774974 13f79535-47bb-0310-9956-ffa450edef68
2016-12-19 01:34:24 +00:00
kiwiwings
c200faedec SonarQube fixes - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774969 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 22:03:31 +00:00
kiwiwings
4f94969a41 sonarqube fixes - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774845 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 03:47:08 +00:00
kiwiwings
c4b37f0723 Fix Bugzilla link
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774843 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 03:33:57 +00:00
kiwiwings
0ff9cbb0f9 #60331 - Remove deprecated classes (POI 3.16)
- remove orphaned classes immediately, which are quite likely not used anymore
- deprecated the rest

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774842 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 03:26:13 +00:00
kiwiwings
43c8f44c2c switch sonarqube to 1.8 and activate it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774825 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 00:01:45 +00:00
kiwiwings
245e1745fe add sonarqube job
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774820 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 23:52:48 +00:00