Commit Graph

4144 Commits

Author SHA1 Message Date
Nick Burch
e2dd40f66c Patch from Josh from bug #43901 - Correctly update the internal last cell number when adding and removing cells (previously sometimes off-by-one)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634617 13f79535-47bb-0310-9956-ffa450edef68
2008-03-07 11:18:02 +00:00
Nick Burch
ba4e8c0a9f Add broken test for bug #43901
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634372 13f79535-47bb-0310-9956-ffa450edef68
2008-03-06 18:13:47 +00:00
Nick Burch
f8915deeb5 Embeded files from bug #44524
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634371 13f79535-47bb-0310-9956-ffa450edef68
2008-03-06 18:06:48 +00:00
Nick Burch
924975f0e9 Change the behaviour on short last blocks to be a warning not an exception, as some people seem to have "real" valid files that trigger this. Fixed bug #28231
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634318 13f79535-47bb-0310-9956-ffa450edef68
2008-03-06 15:54:06 +00:00
Nick Burch
6f0aafadac Changelog update for last patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633548 13f79535-47bb-0310-9956-ffa450edef68
2008-03-04 16:59:02 +00:00
Nick Burch
e685873465 Big patch from Josh from bug #44504 - lots of formula parser improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633547 13f79535-47bb-0310-9956-ffa450edef68
2008-03-04 16:53:32 +00:00
Nick Burch
900f3999f0 Problem files from bug #44501
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633505 13f79535-47bb-0310-9956-ffa450edef68
2008-03-04 15:06:29 +00:00
Nick Burch
058d1e7d15 Fix indent, add more documentation, and make the error message more helpful
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633205 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 17:47:36 +00:00
Nick Burch
c5e82b7bae Patch from Josh from bug #44508 - Fix formula evaluation with evaluateInCell on boolean formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633169 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 16:55:00 +00:00
Nick Burch
a16fa738f0 Patch from Josh from bug #44510 - Fix how DVALRecord works with dropdowns
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633151 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 16:09:02 +00:00
Nick Burch
0102c66498 Patch from Josh from bug #44495 - Handle named cell ranges in formulas that have lower case parts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633126 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 15:26:38 +00:00
Nick Burch
0ecbec584e Fix from Yegor from bug #44491 - don't have the new style handy POIDocument property stuff break old style hpsf+hssf use
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633118 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 15:10:46 +00:00
Nick Burch
0677bb2cff Patch from Paolo from bug #44481 - getVerticallyCenter shouldn't take a parameter, but leave the old version in as deprecated for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633114 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 15:01:18 +00:00
Ugo Cei
88aa367ec3 Applied patches for #44480, thanks to Paolo Mottadelli <p.mottadelli@sourcesense.com>, <paolo.moz@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@632325 13f79535-47bb-0310-9956-ffa450edef68
2008-02-29 14:18:06 +00:00
Nick Burch
d601a0b4b7 Bug #44471 - Crystal Reports generates files with short StyleRecords, which isn't allowed in the spec. Work around this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@630164 13f79535-47bb-0310-9956-ffa450edef68
2008-02-22 11:40:00 +00:00
Nick Burch
7cdfaaa61d Patch from Josh from bug #44450 - VLookup and HLookup support, and improvements to Lookup and Offset
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@630160 13f79535-47bb-0310-9956-ffa450edef68
2008-02-22 11:23:50 +00:00
Nick Burch
08a1a952b8 At the request of legal-discuss, shuffle the ooxml xsd licence details into LICENSE from NOTICE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629865 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 16:44:46 +00:00
Nick Burch
e0b06b3510 Add a disabled test for a file with whacky StyleRecords that trigger an AIOOB
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629849 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 16:22:18 +00:00
Nick Burch
1a6fcd5024 Patch from Josh from bug #44449 - Handle SharedFormulas better, for where there are formulas for the same area on two sheets, and when the shared formula flag is set incorrectly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629837 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:48:52 +00:00
Nick Burch
598e5e1ba8 Patch from Josh from bug #44437 - improved unit test for poifs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629832 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:42:06 +00:00
Nick Burch
1030ecb726 Patch from Josh from bug #44437 - improved unit test for poifs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629831 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:40:34 +00:00
Nick Burch
38421b7650 Patch from Josh from bug #44366 - InputStreams passed to POIFSFileSystem are now automatically closed. A warning is generated for people who might've relied on them not being closed before, and a wrapper to restore the old behaviour is supplied
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629829 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:35:59 +00:00
Nick Burch
173f63cd0a Patch from Josh from bug #44371 - support for OFFSET function, and various tweaks to the formula evaluator to support this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629821 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:08:44 +00:00
Nick Burch
acd787dcb8 Fix bug 38921, where HSSFPalette.findSimilar() wasn't working properly, and add tests for it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629755 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 11:34:25 +00:00
Nick Burch
8862ef22aa Use the right way to figure out how many rows on a sheet, so we display the row number for all of them on the left hand side. Also, tidy up some imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629742 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 10:49:25 +00:00
Nick Burch
528bda2729 Fix from Josh from bug #44456 - Update contrib SViewer to not fail if a HSSFRow is null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629738 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 10:36:08 +00:00
Nick Burch
08c14adf33 Patch from Josh from bug #44403 - Further support for unusual, but valid, arguments to the Mid function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629552 13f79535-47bb-0310-9956-ffa450edef68
2008-02-20 18:14:30 +00:00
Ugo Cei
8191f45e44 Return a list of all pictures for a workbook. This shows a discrepancy between the way pictures are stored in OLE2 files and the way they are stored in OOXML files. In the former case, pictures are associated with the workbook, in the latter they are referred to in "drawings" which are, in turn, referred to in sheets.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@629170 13f79535-47bb-0310-9956-ffa450edef68
2008-02-19 17:34:39 +00:00
Ugo Cei
c278230bb6 Moved test data file to own package.
Start writing some tests for parsing cell styles.

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@629092 13f79535-47bb-0310-9956-ffa450edef68
2008-02-19 12:56:51 +00:00
Nick Burch
f251bc201c Update notice for latest guidance on ooxml xsd licence, and update getting involved to link to the newly released binary file format docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628714 13f79535-47bb-0310-9956-ffa450edef68
2008-02-18 13:08:16 +00:00
Nick Burch
818880bf7f Further support for whole-column references, including formula strings and the evaluator. Also has some new tests for it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628065 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 13:50:38 +00:00
Nick Burch
720b6bdf3d Partial fix for bug #44410 - support whole column ranges such as C:C in the formula evaluator (so SUM(D:D) will now work). However, the formula string will still be displayed wrong
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628044 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 12:59:40 +00:00
Nick Burch
8bbaecfd84 Fix from Josh from bug #44421 - Update Match function to properly support Area references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628035 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 12:13:25 +00:00
Nick Burch
e113d12d34 Fix from Josh from bug #44417 - Improved handling of references for the need to quote the sheet name for some formulas, but not when fetching a sheet by name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628033 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 12:04:42 +00:00
Nick Burch
8827c07cdb Fix for bug #44413 from Josh - Fix for circular references in INDEX, OFFSET, VLOOKUP formulas, where a cell is actually allowed to reference itself
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628029 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 11:53:25 +00:00
Nick Burch
7992e8e0f0 Fix for bug #44403 - Have mid use the third argument properly, and test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628027 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 11:45:13 +00:00
Nick Burch
28b1858b3e To avoid confusion and repeated changes in svn, update the TestDataValidation test to output its file (that needs opening in excel to check to output) into the system tmp directory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@627999 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 10:30:10 +00:00
Nick Burch
4a7276e4ee Big formula update from Josh from bug #44364 - support for Match, NA and SumProduct functions, and initial error support in functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@627788 13f79535-47bb-0310-9956-ffa450edef68
2008-02-14 16:01:10 +00:00
Nick Burch
3acc95e057 In the interests of sanity, stop having hssf test data files in scratchpad and main, go to just having them in main
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@627779 13f79535-47bb-0310-9956-ffa450edef68
2008-02-14 15:32:49 +00:00
Ugo Cei
8ec2aaafd6 Merged revisions 618680-620582 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r618680 | nick | 2008-02-05 16:51:29 +0100 (Tue, 05 Feb 2008) | 1 line
  
  Add java.lang.Iterable style methods for iterating over rows and cells, but don't actually implement that, as it wasn't in jdk 1.3 or jdk 1.4, with is rather tedious
........
  r618690 | nick | 2008-02-05 17:21:21 +0100 (Tue, 05 Feb 2008) | 1 line
  
  Tweaks to the iterator use guides for hssf
........
  r618692 | nick | 2008-02-05 17:32:45 +0100 (Tue, 05 Feb 2008) | 1 line
  
  Few tweaks to the patching guide
........
  r618940 | yegor | 2008-02-06 10:47:13 +0100 (Wed, 06 Feb 2008) | 1 line
  
  3.0.2-FINAL released
........
  r619001 | nick | 2008-02-06 15:35:05 +0100 (Wed, 06 Feb 2008) | 1 line
  
  Implement hashCode and equals for HSSFFont and HSSFCellStyle
........
  r619310 | yegor | 2008-02-07 09:56:59 +0100 (Thu, 07 Feb 2008) | 1 line
  
  support for excel hypelrinks
........
  r619382 | nick | 2008-02-07 13:39:12 +0100 (Thu, 07 Feb 2008) | 1 line
  
  Patch from bug #44373 - Have HSSFDateUtil.isADateFormat support more date formats
........
  r619502 | nick | 2008-02-07 17:53:23 +0100 (Thu, 07 Feb 2008) | 1 line
  
  Handle timezones better with cell.setCellValue(Calendar), so now 20:00-03:00, 20:00+00:00 and 20:00+03:00 will all be recorded as 20:00, and not 17:00 / 20:00 / 23:00 (pass a Date not a Calendar for old behaviour) - patch from bug #38641
........
  r619509 | nick | 2008-02-07 18:12:09 +0100 (Thu, 07 Feb 2008) | 1 line
  
  Add (disabled) failing testcase for bug #44375
........
  r619848 | klute | 2008-02-08 12:55:43 +0100 (Fri, 08 Feb 2008) | 1 line
  
  - Fixed bug 44375 - HPSF now copes with a broken dictionary in Document Summary Information stream. RuntimeExceptions that occured when trying to read bogus data are now caught. Dictionary entries up to but not including the bogus one are preserved, the rest is ignored.
........
  r619849 | klute | 2008-02-08 12:56:11 +0100 (Fri, 08 Feb 2008) | 1 line
  
  - Fixed bug 44375 - HPSF now copes with a broken dictionary in Document Summary Information stream. RuntimeExceptions that occured when trying to read bogus data are now caught. Dictionary entries up to but not including the bogus one are preserved, the rest is ignored.
........
  r619851 | nick | 2008-02-08 13:02:10 +0100 (Fri, 08 Feb 2008) | 1 line
  
  Copy Rainer's change note from changes.xml to status.xml, as it's needed in both
........
  r619968 | nick | 2008-02-08 19:17:29 +0100 (Fri, 08 Feb 2008) | 1 line
  
  Tweak layout
........
  r620341 | nick | 2008-02-10 22:54:13 +0100 (Sun, 10 Feb 2008) | 1 line
  
  Test for bug #42564 - appears to already be fixed
........
  r620557 | nick | 2008-02-11 18:55:09 +0100 (Mon, 11 Feb 2008) | 1 line
  
  Another test relating to bug #42564 - this one is still failing
........
  r620582 | nick | 2008-02-11 20:14:04 +0100 (Mon, 11 Feb 2008) | 1 line
  
  If we have a document with a hpsf stream that exists, but is of the wrong type, then log a warning but continue
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@627544 13f79535-47bb-0310-9956-ffa450edef68
2008-02-13 17:34:43 +00:00
Ugo Cei
7d48f4d18e Load shared strings table when loading workbook.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@627407 13f79535-47bb-0310-9956-ffa450edef68
2008-02-13 13:43:42 +00:00
Nick Burch
d92520eac2 If we have a document with a hpsf stream that exists, but is of the wrong type, then log a warning but continue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@620582 13f79535-47bb-0310-9956-ffa450edef68
2008-02-11 19:14:04 +00:00
Nick Burch
600dd45507 Another test relating to bug #42564 - this one is still failing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@620557 13f79535-47bb-0310-9956-ffa450edef68
2008-02-11 17:55:09 +00:00
Nick Burch
45473533cf Test for bug #42564 - appears to already be fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@620341 13f79535-47bb-0310-9956-ffa450edef68
2008-02-10 21:54:13 +00:00
Nick Burch
655fac8420 Tweak layout
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619968 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 18:17:29 +00:00
Nick Burch
f45385e77d Copy Rainer's change note from changes.xml to status.xml, as it's needed in both
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619851 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 12:02:10 +00:00
Rainer Klute
b6751af998 - Fixed bug 44375 - HPSF now copes with a broken dictionary in Document Summary Information stream. RuntimeExceptions that occured when trying to read bogus data are now caught. Dictionary entries up to but not including the bogus one are preserved, the rest is ignored.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619849 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 11:56:11 +00:00
Rainer Klute
c3340f823b - Fixed bug 44375 - HPSF now copes with a broken dictionary in Document Summary Information stream. RuntimeExceptions that occured when trying to read bogus data are now caught. Dictionary entries up to but not including the bogus one are preserved, the rest is ignored.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619848 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 11:55:43 +00:00
Nick Burch
9e43771b7e Add (disabled) failing testcase for bug #44375
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619509 13f79535-47bb-0310-9956-ffa450edef68
2008-02-07 17:12:09 +00:00
Nick Burch
57d32bcc7e Handle timezones better with cell.setCellValue(Calendar), so now 20:00-03:00, 20:00+00:00 and 20:00+03:00 will all be recorded as 20:00, and not 17:00 / 20:00 / 23:00 (pass a Date not a Calendar for old behaviour) - patch from bug #38641
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619502 13f79535-47bb-0310-9956-ffa450edef68
2008-02-07 16:53:23 +00:00