moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
6,228 Commits 29 Branches 84 Tags 722 MiB
e4f5df42f6
Commit Graph

1986 Commits

Author SHA1 Message Date
Nick Burch
3300ac2a56 FilePassRecord type of 4 is now documented as the same as 2 & 3, see bug #35897 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636776 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 23:22:50 +00:00
Nick Burch
4923afc9f8 Fix bug #57185 - Should be Series not Serie, latter is incorrect English / a Typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636755 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 22:11:07 +00:00
Nick Burch
0fdd7a1dbc Partial HSSF support for adding new external workbook formula references for #57184 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636742 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 21:35:01 +00:00
Nick Burch
4b479d98c4 Improve BiffViewer output for SupBookRecord 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636725 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 20:11:35 +00:00
Nick Burch
8616a88a86 Add missing HSSFWorkbook constructor javadocs #57166 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635533 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-30 16:19:54 +00:00
Dominik Stadler
8a82d32ae8 Apply patch for bug 57151: Document CellRangeAddress and add some validation to prevent invalid row/column combinations. 
Cover class CellRangeAddress fully in unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635389 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-30 05:53:06 +00:00
Cédric Walter
d59c8f47be Bug 57150: Added EOMONTH function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634515 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-27 12:29:32 +00:00
Andreas Beeker
8dcdbe9c1a Bug 57143 - Javadocs and throws clause for WorkbookUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634412 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-27 00:36:13 +00:00
Andreas Beeker
f818d1fdb7 house keeping - fixes for sonarqube blockers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634255 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-25 21:32:03 +00:00
Dominik Stadler
5706aab18c Bug 57010: Add implementation of function PROPER 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633215 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 19:57:11 +00:00
Nick Burch
508f36d702 SheetUtil helper for finding the main cell of a merged region, if in one 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632833 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 19:58:05 +00:00
Nick Burch
8137193852 Add a note on how this is not the right way to make a string of your cell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632438 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-16 21:41:11 +00:00
Andreas Beeker
daa7d17531 Bug 57080 - IndexOutOfBoundsException in poi decryptor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631600 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-13 23:42:33 +00:00
Dominik Stadler
2d04f98cd1 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629656 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:43:37 +00:00
Dominik Stadler
8dde4b0ae4 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629653 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:39:35 +00:00
Dominik Stadler
d254ec8ec1 Print out current version of java before building to allow to see in build output if we use a supported Java VM version 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629644 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:20:12 +00:00
Andreas Beeker
da4201c2cd more tests, some refactoring 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628107 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 22:30:02 +00:00
Andreas Beeker
b410e72196 merge with trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625828 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-17 21:12:36 +00:00
Andreas Beeker
777fd47d71 some changes because of test errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618254 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 18:19:28 +00:00
Andreas Beeker
63f8c1dcf0 Xml signature support - version 1 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617141 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 18:25:10 +00:00
Andreas Beeker
3cd1cd6e70 Another test for NPOIFS in-place writing support - probably the deletion of an entry causes the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615273 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-02 00:51:56 +00:00
Nick Burch
0e44d8da73 Fix bug #56800 - Provide a helpful exception, XLSBUnsupportedException, if XSSFWorkbook is passed a .xlsb file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615118 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-01 14:33:17 +00:00
Nick Burch
2ee05730bd Fix bug #55050 - If the start+end row and cell are the same on an AreaPtg, avoid inverting the relative flag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614928 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 16:06:43 +00:00
Nick Burch
de0d2a0935 Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614886 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 13:37:33 +00:00
Nick Burch
65e23c7ea9 Fix bug #53984 - Support the ColInfoRecord coming after the cells, rather than before as is normal, and also handle things so that if an unsupported BofRecord is found for a sheet, warn and skip rather than breaking 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614884 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 13:31:01 +00:00
Nick Burch
f16296111b Correct logic for the start-of-sheet missing rows, for event user model, and add tests for this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614789 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 23:06:46 +00:00
Nick Burch
bdb9bbccc1 Start on details tests for bug #53433 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614786 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 22:43:31 +00:00
Nick Burch
64187356aa #56132 Allow XSSF formula evaluation to also skip missing external workbook references, if requested 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614729 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 18:08:28 +00:00
Nick Burch
797f3368d6 Patch from Sofia Larsson and Martin Andersson from bug #56020 - XSSF support for creating Pivot tables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614684 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 15:27:09 +00:00
Dominik Stadler
51649dbdfa Add/Fix some Javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613826 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-27 18:32:24 +00:00
Nick Burch
59861b7836 Complete evaluation support for multi-sheet references for bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613467 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 16:42:31 +00:00
Nick Burch
2438213bd8 Begin required interface + base-class support for multi-sheet area references for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613460 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 16:15:47 +00:00
Nick Burch
97c4bbc9b8 Allow XSSF to evaluate multi-sheet references too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613455 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:55:49 +00:00
Nick Burch
3872e620a7 Update the RefEval method signature to cope with multi-sheet references, and have appropriate functions take advantage of this. For bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613453 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:46:05 +00:00
Nick Burch
d97867e5be Start preparing LazyAreaEval and LazyRefEval to handle sheet ranges, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613443 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:50:44 +00:00
Nick Burch
3e2e01c149 Update the XSSF getExternalSheet method signature, to start to prepare for sheet ranges 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613439 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:23:21 +00:00
Nick Burch
4c8f3ab160 More tests for #55906, and provide a new eval that lets you get at evals for many sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613438 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:15:56 +00:00
Nick Burch
96386e2e0a Areas can have multi-sheet references too, so add FormulaParser support to these as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613437 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 13:59:07 +00:00
Nick Burch
8f4fac46ee Update Ref3DPxg to support multi-sheet ranges too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613376 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:22:21 +00:00
Nick Burch
0dde805ec7 Refactor to reduce clutter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613374 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:10:52 +00:00
Nick Burch
29e5928c42 More progress towards #55906 - Have the ExternSheet references set up for multi-sheet references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613373 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:05:57 +00:00
Nick Burch
1161077a6b More progress towards #55906 - FormulaParser is able to identify and parse multi-sheet references, but not yet fully round-trip them. (No evaluation support yet either) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613317 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 22:44:51 +00:00
Nick Burch
e27a6e5466 More internal method signature updates, for HSSF external sheets being possible ranges, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613307 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:35:47 +00:00
Nick Burch
7f6ba5513c Rename some of the internal HSSF sheet lookup methods which deal with external sheet indicies, to make it clear when they return the first sheet name/index, and add support for getting the last one too (will be the same as the first if not a range) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613305 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:25:45 +00:00
Nick Burch
1fc5397a59 #55906 Extern Sheet References can have a last as well as a first sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613302 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:10:13 +00:00
Nick Burch
a41a4fd118 Patch from thaichat04 from bug #56194 - HPSF thumbnail format tags are int not unit 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613256 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 19:34:19 +00:00
Nick Burch
4c98f1db45 Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 18:58:27 +00:00
Nick Burch
70b21ffe56 Fix javadoc warning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613176 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:26:34 +00:00
Nick Burch
0c8112b84a Correct HSSFOptimiser logic for the case where the to-keep style wasn't previously in use. Fixes #54443 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613175 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:25:58 +00:00
Nick Burch
f91eee5846 Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613174 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:22:28 +00:00
Nick Burch
fec4eb7a12 When evaluating a name in another workbook, need to use an OperationEvaluationContext tied to that Workbook, and do so such that XSSF references work too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613154 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 14:56:23 +00:00
Nick Burch
f06915e95d Don't fetch the name, convert to a ptg, then convert back again, instead simply return the name directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613153 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 14:37:09 +00:00
Dominik Stadler
b6dd3bca34 Bug 56688: Fix border cases in EDATE function: handle RefEval and BlankEval and also return #VALUE, not #REF if case of error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612557 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-22 12:31:56 +00:00
Dominik Stadler
3f9c701688 Fix formatting of trailing comma in HexDumps, cover class fully with tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612496 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-22 07:47:14 +00:00
Nick Burch
12e87a1900 Generalise the CollaboratingWorkbooksEnvironment setup, so that XSSF can use it too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612254 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 12:23:54 +00:00
Nick Burch
79f3f4bb06 Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612219 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 09:45:44 +00:00
Nick Burch
3db4f0b82c Allow creating a CollaboratingWorkbooksEnvironment from a Map too, not only a pair of arrays 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612218 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 09:44:21 +00:00
Nick Burch
d43121661c Correct non-sheet-based NameXPxg formula rendering, and add tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612203 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 07:35:09 +00:00
Nick Burch
05dc1ec70c Change how we update sheet names in XSSF formulas and names, when renaming sheets, to take advantage of the simpler structure that Pxg now offers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612151 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:56:35 +00:00
Nick Burch
a550397ac2 XSSF Pxgs must escape sheet names where required when generating the formula string 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612150 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:53:27 +00:00
Nick Burch
44a6aef699 Common interface across the XSSF Ptg / Pxg classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612149 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:48:48 +00:00
Nick Burch
4345b06cab Rename missing from previous commit 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612140 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:14:47 +00:00
Nick Burch
42cd819573 Update the formula evaluator to support XSSF style external named ranges too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612133 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 17:51:51 +00:00
Nick Burch
0b1dee9913 Better reporting on why a test is failing, and partial NameXPxg eval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611969 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 21:27:28 +00:00
Nick Burch
ed7140b3d8 Move towards supporting same workbook named ranges in external style for xssf 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611961 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:51:23 +00:00
Nick Burch
58096a6862 Start to add XSSF specific handling for NameX (named ranges or functions from another file) #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611958 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:30:31 +00:00
Nick Burch
86ca81d22f Provide XSSF-style external sheet support for areas, similar to the recent cell reference support. #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611950 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:42:07 +00:00
Nick Burch
84b50e845e Fix inconsistent indents/whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611949 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:23:13 +00:00
Nick Burch
2cd4290460 Start to update how the formula parser looks up sheets from formula ptgs, to account for the differences in how HSSF and XSSF store references to external sheets. For #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611948 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:19:06 +00:00
Nick Burch
0986f32d46 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611947 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:11:54 +00:00
Nick Burch
c392b4fa72 The Event User Model fake-workbook for formula evaluations needs to know about the sheet names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611946 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:10:47 +00:00
Nick Burch
fbcf64087d Fix Generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611944 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:00:09 +00:00
Nick Burch
7c382f9f37 The way that HSSF and XSSF stores references to external sheets are rather different, so begin to reflect that in how we parse their formulas into Ptgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611906 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 12:49:41 +00:00
Nick Burch
4c362590d8 Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 18:30:16 +00:00
Nick Burch
6e37f73018 Have WorkbookEvaluator process NameXPtgs, rather than returning a NameXEval which later places didn't handle. Largely allows us to process the .xls version of the test file for #56737 (but filenames aren't quite the same as in Excel) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611711 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 16:58:38 +00:00
Nick Burch
d4a1239efa #56737 Sometimes Excel writes an internal reference to a local name in an odd way, without an ExternalNameRecord, try to detect and work around those 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611681 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 15:59:55 +00:00
Nick Burch
dd6819aa13 When throwing an exception during formula evaluation, if this is due to an unimplemented function, have a more specific exception type 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607588 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 11:20:32 +00:00
Dominik Stadler
e34e77b12d Bug 56537: Update javadoc to reflect the addition of Closeable to Workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607390 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-02 15:05:05 +00:00
Dominik Stadler
9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly, 
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 20:36:30 +00:00
Nick Burch
47a8f6cf48 Partial fix for #56537 - Have Workbook offer a close() method, which in turn closes the NPOIFS or OPC resource from which it was loaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601901 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 13:48:54 +00:00
Nick Burch
11a095bb3d HSSFCell should follow XSSF, and allow setting a null-style to return to the default style, fixes bug #56572 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1598258 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-29 11:39:50 +00:00
Dominik Stadler
8c6e7e06aa Fix for 56563 - Multithreading bug when reading 2 similar files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597637 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-26 20:03:08 +00:00
Nick Burch
834973efe0 If a NoteRecord has no author tag, it seems it can sometimes be double padded. Fixes #47251 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597098 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-23 14:07:20 +00:00
Nick Burch
6cc94cdae8 Handle date format strings in an iso8601 style format, with a T in them. Fixes bug #54034 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597038 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-23 09:18:16 +00:00
Dominik Stadler
47ea1aa486 Bug 53691: Fix a copy/paste error in CFRuleRecord.clone() 
also make CFRuleRecord.toString() print out more information which caused the bug to be much harder to find
Add unit tests to verify/reproduce this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596251 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-20 14:01:22 +00:00
Dominik Stadler
8e6c459d83 Bug 56325: fix Exception when removing sheets with named ranges in the workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595048 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 21:14:52 +00:00
Nick Burch
4d2a90d3ec Add a HSSF print paper size constant for "printer default" for bug #56509 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594848 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 10:15:04 +00:00
Andreas Beeker
00e2e55338 Bug 56486 - Add XOR obfuscation/decryption support to HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592636 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-05 21:41:31 +00:00
Andreas Beeker
337f775807 Bug 56269 - DateFormat - Rounding of fractionals 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592419 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 21:17:18 +00:00
Andreas Beeker
234ad7f85e The NPOIFS-classes result currently in left-over memory mapped buffers. 
These are actually hard to workaround, so for Windows the test is ignored, if this error happens.
http://stackoverflow.com/questions/3602783/file-access-synchronized-on-java-object 

Apart of that, the RandomFileAccess instance is saved in the FileBackedDataSource as it needs to
be closed instead of the Channel.
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4796385

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592418 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 20:58:42 +00:00
Dominik Stadler
4112a8441e File leak detector: Close streams in some tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592315 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 08:05:32 +00:00
Nick Burch
ee0cddaf9a Excel 2007 and later allows for more than 3 Conditional Formatting rules per sheet, so change our hard limit to logging a compatibility warning. Test file from Pau Coma Ramirez from bug #56482 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591959 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-02 15:49:23 +00:00
Nick Burch
305ce3123b Generics warnings fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591838 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-02 09:15:23 +00:00
Nick Burch
ba4225395f Provide a convenience method for creating a PropertySet from a Directory + Entry 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590650 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 14:19:13 +00:00
Nick Burch
52c6fd587c Fix generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590642 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 14:03:18 +00:00
Nick Burch
3a5825c43f Update the HPSF change properties example to use NPOIFS + in-place writes, and have NPOIFS give a helpful error if you try to in-place write on a read only open 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590577 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 09:22:58 +00:00
Nick Burch
a57e1f1fa6 Get NPOIFS in-place-write working! 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590556 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 06:35:39 +00:00
Nick Burch
3e6cb71fb9 More on the HPFS in-place NPOIFS write tests, and a note about what is still to do for them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590319 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 22:50:00 +00:00
Nick Burch
f649abdbe9 Fix javadoc layout 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590317 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 22:43:23 +00:00
Nick Burch
0496d8f330 Convert the HPSF test to JUnit 4, and add a bit more testing for NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590309 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 21:51:28 +00:00
Nick Burch
73bc57db74 NDocumentOutputStream write logic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590191 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:34:09 +00:00
Nick Burch
b77ce4fede Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590190 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:33:16 +00:00
Nick Burch
c3769b5da0 Begin to support and test in-place changes to documents within a NPOIFS stream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590185 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:07:00 +00:00
Nick Burch
868a108fe3 Support for replacing the contents of a Document in a NPOIFSFileSytem, in place 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590177 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 22:40:51 +00:00
Nick Burch
0bdc025279 When deleting a document in NPOIFS, free the underlying blocks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590160 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 22:00:30 +00:00
Nick Burch
b1dd6b403f Add a getEntryNames() method to POIFS/NPOIFS directory entries, to make listing easier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590148 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 21:10:52 +00:00
Nick Burch
6a89a9afbf More NPOIFS mini stream improvements, and more tests for it all 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590098 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 18:39:31 +00:00
Nick Burch
e4e0e93ff5 Correct mini stream initialisation, and enable more npoifs write tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590088 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 18:14:28 +00:00
Nick Burch
4b6ae05a04 More NPOIFS tests, and a partial mini-stream fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590083 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 17:06:10 +00:00
Nick Burch
1fc66d1f71 Correct NPOIFS mini stream first write bug, and add more NPOIFS stream write tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589881 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 21:08:34 +00:00
Nick Burch
a94f150450 More NPOIFS write testing, and fix a problem with writing xbat details out 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589806 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 17:44:10 +00:00
Nick Burch
b2a35bb494 More unit tests for NPOIFS writing, and correct a bug in how bats get allocated in xbats. (Some issues still remain) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589800 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 17:25:10 +00:00
Nick Burch
fbd86d5084 More int/long sizing fixes for >2gb NPOIFS files, see bug #56447 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589783 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 16:15:21 +00:00
Nick Burch
e7dff43065 Fix bug #56450 - Avoid a NPE if a comment has no associated NoteRecord (but we still don't know where it belongs) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589770 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 15:42:53 +00:00
Andreas Beeker
14a7ae6316 Bug 56437 - [PATCH] Streaming write support in NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588887 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-21 14:37:33 +00:00
Andreas Beeker
821d3ca5bd Some encryption fixes: 
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-21 12:16:54 +00:00
Dominik Stadler
0974acc778 Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-18 18:20:15 +00:00
Nick Burch
d2d289b90f Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-15 21:59:52 +00:00
Cédric Walter
730deb782b performance issue: call toString() on a String object. This is entirely redundant. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583358 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-31 16:01:39 +00:00
Cédric Walter
a0d1ab5add performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-31 15:54:52 +00:00
Nick Burch
f52fe377ae Patch from bug #56328 from David North - the maximum row number in a formula depends on HSSF vs XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582892 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-28 21:54:30 +00:00
Nick Burch
2a7cebf8c0 Patch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix the equals(Object) logic, and fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575683 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-09 09:49:06 +00:00
Dominik Stadler
7e21a14172 Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 16:46:59 +00:00
Dominik Stadler
8c5115aeb1 Fix Sonar issues about finalize() usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 08:41:25 +00:00
Andreas Beeker
3fe86eca24 Added MD4-option and some cleanups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-06 00:53:09 +00:00
Nick Burch
f6a5959788 POI is now on JDK 1.6, so remove 1.5 workaround 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574049 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-04 11:57:44 +00:00
Andreas Beeker
833ae007f8 Bug 56076 - Add document protection with password support to XWPF 
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-21 23:19:57 +00:00
Andreas Beeker
2cfc8dbf17 FindBugs fix 
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 23:36:32 +00:00
Nick Burch
c144310a15 Patch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero length 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568813 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 19:35:55 +00:00
Andreas Beeker
2a14920cdd FindBugs fix 
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 16:30:24 +00:00
Dominik Stadler
023fa18794 Instead of using initCause() when re-throwing exceptions, it leads to better stacktraces if a simple constructor-argument is used 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568614 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 10:43:58 +00:00
Dominik Stadler
9b4121cb45 Update Javadoc somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568555 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:19:32 +00:00
Andreas Beeker
92a488a28b FindBugs fix 
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix 
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-13 23:34:11 +00:00
Andreas Beeker
413e76aed0 FindBugs fix 
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-09 21:19:20 +00:00
Nick Burch
d07ce077f5 Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563660 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:44:30 +00:00
Nick Burch
e023d34c9a Add setIncludeHeadersFooters(boolean) to the ExcelExtractor common interface, as all implementations now have the method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563658 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:41:27 +00:00
Nick Burch
720b4a3aad Have the Excel text extractors all implement the same interface, as best as they can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563650 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:23:26 +00:00
Andreas Beeker
5d0f69097c Bug 51891 - Fix StringIndexOutOfBoundsException : Ole10Native.<init> (parsing word file) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563483 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 21:45:48 +00:00
Andreas Beeker
474c4eec6a jdk 5 compiler doesn't support overwrite for interfaces ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561406 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-25 21:56:08 +00:00
Nick Burch
d2687261e3 Patch from Detlef Brendle from bug #55873 - Support for COUNTIFS function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1560736 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-23 16:43:59 +00:00
Andreas Beeker
439ad29071 Added license headers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-18 00:38:04 +00:00
Andreas Beeker
1eba8faedb Bug 35897 - Password protected files 
+ Junit4 modifications, needed for expected exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557281 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-10 23:14:03 +00:00
Nick Burch
0e5300538f Ensure our package html files have consistent line endings, and the right svn properties set on them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557156 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-10 15:39:39 +00:00
Dominik Stadler
d714d0da65 Bug 55723: Make HSSFSheet.setAutoFilter() behave equal to XSSF, also make XSSF work when setAutoFilter is called multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554688 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-01 22:15:44 +00:00
Dominik Stadler
5e77641784 remove some unused imports and some useless TODOs, slightly more 
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:12:30 +00:00
Dominik Stadler
dcc34ec845 Don't unnecessarily convert from ArrayList to array, use the ArrayList directly instead, this speeds up BiffViewer and related unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554534 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:11:59 +00:00
Dominik Stadler
d83461c3fb Print out which actual value was out of range 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554533 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:11:44 +00:00
Andreas Beeker
f32e87957c obsoleted by TestEscherBlipRecord and EscherMetafileBlip 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554104 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-30 00:00:54 +00:00
Nick Burch
e961fe6e94 Fix whitespace - reformat to consistent spaces, instead of a mix of tabs and spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553625 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-27 04:26:18 +00:00