Commit Graph

1220 Commits

Author SHA1 Message Date
Nick Burch db0e58b4b6 Start on unit tests for the problem reported in stackoverflow post 26437323
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632841 13f79535-47bb-0310-9956-ffa450edef68
2014-10-18 20:37:56 +00:00
Nick Burch 14fb9a55ee Move non-HSSF specific bug tests into BaseTestBugzillaIssues from HSSF TestBugs, so they can be tested automatically on XSSF too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632837 13f79535-47bb-0310-9956-ffa450edef68
2014-10-18 20:10:31 +00:00
Nick Burch 508f36d702 SheetUtil helper for finding the main cell of a merged region, if in one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632833 13f79535-47bb-0310-9956-ffa450edef68
2014-10-18 19:58:05 +00:00
Dominik Stadler 5c40484b1f Enhance test and coverge for class TempFile
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631250 13f79535-47bb-0310-9956-ffa450edef68
2014-10-12 20:07:24 +00:00
Dominik Stadler 8dde4b0ae4 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629653 13f79535-47bb-0310-9956-ffa450edef68
2014-10-06 13:39:35 +00:00
Dominik Stadler d254ec8ec1 Print out current version of java before building to allow to see in build output if we use a supported Java VM version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629644 13f79535-47bb-0310-9956-ffa450edef68
2014-10-06 13:20:12 +00:00
Andreas Beeker b410e72196 merge with trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625828 13f79535-47bb-0310-9956-ffa450edef68
2014-09-17 21:12:36 +00:00
Andreas Beeker 63f8c1dcf0 Xml signature support - version 1
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617141 13f79535-47bb-0310-9956-ffa450edef68
2014-08-10 18:25:10 +00:00
Nick Burch 2ee05730bd Fix bug #55050 - If the start+end row and cell are the same on an AreaPtg, avoid inverting the relative flag
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614928 13f79535-47bb-0310-9956-ffa450edef68
2014-07-31 16:06:43 +00:00
Nick Burch 65e23c7ea9 Fix bug #53984 - Support the ColInfoRecord coming after the cells, rather than before as is normal, and also handle things so that if an unsupported BofRecord is found for a sheet, warn and skip rather than breaking
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614884 13f79535-47bb-0310-9956-ffa450edef68
2014-07-31 13:31:01 +00:00
Nick Burch f16296111b Correct logic for the start-of-sheet missing rows, for event user model, and add tests for this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614789 13f79535-47bb-0310-9956-ffa450edef68
2014-07-30 23:06:46 +00:00
Nick Burch bdb9bbccc1 Start on details tests for bug #53433
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614786 13f79535-47bb-0310-9956-ffa450edef68
2014-07-30 22:43:31 +00:00
Nick Burch 78c4a8168a Unit test to show that bug #53494 has already been fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614741 13f79535-47bb-0310-9956-ffa450edef68
2014-07-30 19:02:09 +00:00
Nick Burch 64187356aa #56132 Allow XSSF formula evaluation to also skip missing external workbook references, if requested
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614729 13f79535-47bb-0310-9956-ffa450edef68
2014-07-30 18:08:28 +00:00
Nick Burch c62aa2d74b Convert the test to using interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614715 13f79535-47bb-0310-9956-ffa450edef68
2014-07-30 16:56:31 +00:00
Dominik Stadler a9f946ef70 Add simple unit test to verify that Bug 42016 was fixed already by some other fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614135 13f79535-47bb-0310-9956-ffa450edef68
2014-07-28 19:10:54 +00:00
Nick Burch a4e73e3dc8 Unit test to show that bug #52111 (intersect formulas) was already solved
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613737 13f79535-47bb-0310-9956-ffa450edef68
2014-07-26 22:39:16 +00:00
Nick Burch 5d9f8945c9 HSSF and XSSF Multi-Sheet formula reference tests from Radoslav from bug #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613654 13f79535-47bb-0310-9956-ffa450edef68
2014-07-26 15:20:06 +00:00
Nick Burch 59861b7836 Complete evaluation support for multi-sheet references for bug #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613467 13f79535-47bb-0310-9956-ffa450edef68
2014-07-25 16:42:31 +00:00
Nick Burch 3872e620a7 Update the RefEval method signature to cope with multi-sheet references, and have appropriate functions take advantage of this. For bug #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613453 13f79535-47bb-0310-9956-ffa450edef68
2014-07-25 15:46:05 +00:00
Nick Burch 96386e2e0a Areas can have multi-sheet references too, so add FormulaParser support to these as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613437 13f79535-47bb-0310-9956-ffa450edef68
2014-07-25 13:59:07 +00:00
Nick Burch 29e5928c42 More progress towards #55906 - Have the ExternSheet references set up for multi-sheet references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613373 13f79535-47bb-0310-9956-ffa450edef68
2014-07-25 10:05:57 +00:00
Nick Burch 1161077a6b More progress towards #55906 - FormulaParser is able to identify and parse multi-sheet references, but not yet fully round-trip them. (No evaluation support yet either)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613317 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 22:44:51 +00:00
Nick Burch 7f6ba5513c Rename some of the internal HSSF sheet lookup methods which deal with external sheet indicies, to make it clear when they return the first sheet name/index, and add support for getting the last one too (will be the same as the first if not a range)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613305 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 21:25:45 +00:00
Nick Burch a41a4fd118 Patch from thaichat04 from bug #56194 - HPSF thumbnail format tags are int not unit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613256 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 19:34:19 +00:00
Nick Burch 4c98f1db45 Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 18:58:27 +00:00
Nick Burch 0c8112b84a Correct HSSFOptimiser logic for the case where the to-keep style wasn't previously in use. Fixes #54443
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613175 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 16:25:58 +00:00
Dominik Stadler b6dd3bca34 Bug 56688: Fix border cases in EDATE function: handle RefEval and BlankEval and also return #VALUE, not #REF if case of error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612557 13f79535-47bb-0310-9956-ffa450edef68
2014-07-22 12:31:56 +00:00
Dominik Stadler 3f9c701688 Fix formatting of trailing comma in HexDumps, cover class fully with tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612496 13f79535-47bb-0310-9956-ffa450edef68
2014-07-22 07:47:14 +00:00
Nick Burch 42cd819573 Update the formula evaluator to support XSSF style external named ranges too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612133 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 17:51:51 +00:00
Nick Burch 0986f32d46 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611947 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:11:54 +00:00
Nick Burch c392b4fa72 The Event User Model fake-workbook for formula evaluations needs to know about the sheet names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611946 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:10:47 +00:00
Nick Burch 551573dd95 Bit more towards XSSF name support for #56737, will need some deeper changes though to fully implement
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611830 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 22:50:54 +00:00
Nick Burch d0db408a2f Leave part disabled for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611755 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 18:30:54 +00:00
Nick Burch 4c362590d8 Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 18:30:16 +00:00
Nick Burch 3fd7c0d258 Update bug reference numbers, and bring over part of a test from unfixed that is now working (rest remains broken)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611728 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 17:27:37 +00:00
Nick Burch 6e37f73018 Have WorkbookEvaluator process NameXPtgs, rather than returning a NameXEval which later places didn't handle. Largely allows us to process the .xls version of the test file for #56737 (but filenames aren't quite the same as in Excel)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611711 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 16:58:38 +00:00
Nick Burch d4a1239efa #56737 Sometimes Excel writes an internal reference to a local name in an odd way, without an ExternalNameRecord, try to detect and work around those
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611681 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 15:59:55 +00:00
Nick Burch c9d90732e5 Add disabled unit tests for bug #56737, which currently fails (differently) for HSSF and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611400 13f79535-47bb-0310-9956-ffa450edef68
2014-07-17 16:18:39 +00:00
Dominik Stadler 9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly,
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 20:36:30 +00:00
Nick Burch 11a095bb3d HSSFCell should follow XSSF, and allow setting a null-style to return to the default style, fixes bug #56572
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1598258 13f79535-47bb-0310-9956-ffa450edef68
2014-05-29 11:39:50 +00:00
Dominik Stadler f928ce1d34 Increase the font-inaccuracy for one unit test as some machines have fonts that lead to lower values, e.g. we get only 770 instead of 980 for Jenkins build on IBM JDK and on some local Windows machines
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597873 13f79535-47bb-0310-9956-ffa450edef68
2014-05-27 20:45:25 +00:00
Dominik Stadler 8c6e7e06aa Fix for 56563 - Multithreading bug when reading 2 similar files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597637 13f79535-47bb-0310-9956-ffa450edef68
2014-05-26 20:03:08 +00:00
Nick Burch 834973efe0 If a NoteRecord has no author tag, it seems it can sometimes be double padded. Fixes #47251
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597098 13f79535-47bb-0310-9956-ffa450edef68
2014-05-23 14:07:20 +00:00
Dominik Stadler 47ea1aa486 Bug 53691: Fix a copy/paste error in CFRuleRecord.clone()
also make CFRuleRecord.toString() print out more information which caused the bug to be much harder to find
Add unit tests to verify/reproduce this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596251 13f79535-47bb-0310-9956-ffa450edef68
2014-05-20 14:01:22 +00:00
Dominik Stadler 927e62f662 Apache POI - Use assertArrayEquals() instead of assertTrue(Arrays.equals()), this way we get better information on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595190 13f79535-47bb-0310-9956-ffa450edef68
2014-05-16 13:25:45 +00:00
Dominik Stadler 8e6c459d83 Bug 56325: fix Exception when removing sheets with named ranges in the workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595048 13f79535-47bb-0310-9956-ffa450edef68
2014-05-15 21:14:52 +00:00
Dominik Stadler 599489e6fa fix some Eclipse warnings, unnecessary null-check and missing close() in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594201 13f79535-47bb-0310-9956-ffa450edef68
2014-05-13 11:31:18 +00:00
Andreas Beeker 00e2e55338 Bug 56486 - Add XOR obfuscation/decryption support to HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592636 13f79535-47bb-0310-9956-ffa450edef68
2014-05-05 21:41:31 +00:00
Andreas Beeker 337f775807 Bug 56269 - DateFormat - Rounding of fractionals
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592419 13f79535-47bb-0310-9956-ffa450edef68
2014-05-04 21:17:18 +00:00