Commit Graph

9168 Commits

Author SHA1 Message Date
Andreas Beeker
2c2028ede6 #61881 - handle invalid font names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 11:44:19 +00:00
Greg Woolsey
41981a4ac9 #61841
Add @Override annotations, clean up imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817331 13f79535-47bb-0310-9956-ffa450edef68
2017-12-07 01:54:21 +00:00
Greg Woolsey
cbd17b9320 #61841 fix typo in method name
Fixing the typo pointed out by PJ Fanning, thanks for the proof read!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817325 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 23:53:25 +00:00
Greg Woolsey
94c2b64692 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
always with the missing license...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817254 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:46:42 +00:00
Greg Woolsey
6390202491 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:15:51 +00:00
PJ Fanning
5f4f1b5846 use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 22:31:59 +00:00
PJ Fanning
89a788ea5b use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817238 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 21:23:44 +00:00
Javen O'Neal
58114c6d8c bug 61840: close workbook to prevent resource leak in unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816893 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 17:51:19 +00:00
Javen O'Neal
79250e916f bug 61840: add unit test showing that shiftRows does not produce #REF! formula errors if cells are not shifted above the first row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816892 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 17:47:29 +00:00
Nick Burch
e8234fd032 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816453 13f79535-47bb-0310-9956-ffa450edef68
2017-11-27 14:05:17 +00:00
Nick Burch
b967299429 Bump library version to match Ant defined version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816445 13f79535-47bb-0310-9956-ffa450edef68
2017-11-27 12:42:47 +00:00
Alain Béarez
c795f2e793 XDDF usermodel for Charts closes #68 on GitHub
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 14:03:01 +00:00
Andreas Beeker
2cda98a4aa #61809 - Infinite loop in SectionIDMap.get() and .put()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816205 13f79535-47bb-0310-9956-ffa450edef68
2017-11-24 01:02:20 +00:00
PJ Fanning
76a16ba175 use try with resources in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816189 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 20:03:25 +00:00
PJ Fanning
3e4e43b28b use try with resources in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816187 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 19:28:36 +00:00
Dominik Stadler
7367d2f1a3 Don't try to collect junit results for Maven when we only run Sonar-tasks and thus skip unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816186 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:54:17 +00:00
Dominik Stadler
d77e980e44 Change order of handling shape-types in copy() as FreeFormShape derives from AutoShape and thus would have not been copied correctly currently
Fix some Javadoc, some warnings and code duplications

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816185 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:54:11 +00:00
Dominik Stadler
d6f97af799 Ensure that the tempdir exists when we use ImageIO in one of the tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816046 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 12:25:11 +00:00
PJ Fanning
e22d67682f add TestStringCodepointsIterable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816020 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 09:57:45 +00:00
PJ Fanning
d695f8ad68 use codepoint iterator in a few places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815998 13f79535-47bb-0310-9956-ffa450edef68
2017-11-22 01:07:24 +00:00
PJ Fanning
268bcdbc2d add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 22:10:48 +00:00
PJ Fanning
0675acb64a add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 21:33:51 +00:00
PJ Fanning
2b02a97d6a remove more uses of Character.toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815988 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 21:11:07 +00:00
Dominik Stadler
5bf0a46aec Try to set java.io.tmpdir for tests to avoid the strange permission errors that we see in CI-builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815963 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 17:32:48 +00:00
Dominik Stadler
90e72ea9fc Ensure that no old version of commons-codec is lingering around and causes hard to find build errors locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815952 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 16:29:01 +00:00
Dominik Stadler
2f755d8d9b Try if using a local temporary directory avoids the permission errors in unit tests in the Maven runs:
* Collect JUnit results
* Set java.io.tmpdir in Maven unit test runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815951 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 16:28:07 +00:00
PJ Fanning
c1ae77c8ce [bug-61792] basic test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815873 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 23:58:13 +00:00
PJ Fanning
d4f15fafa9 [bug-61792] some changes to avoid iterating over chars of Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 23:35:36 +00:00
PJ Fanning
d99e4ea649 upgrade to commons-codec 1.11
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815852 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 20:46:16 +00:00
Dominik Stadler
9a7358e348 Handle case where the JaCoCo zip file is available, but the extracted files are missing, not sure how that happens, but we see it on some CI machines...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815755 13f79535-47bb-0310-9956-ffa450edef68
2017-11-19 19:53:44 +00:00
Mark Murphy
c37a85d974 javadocs and Quick page improvements for XSSF Header/Footer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815706 13f79535-47bb-0310-9956-ffa450edef68
2017-11-19 01:35:07 +00:00
Greg Woolsey
9d11d1c3ea add Locale awareness to case insensitive conditional comparisons in formatting rule logic. Needed anyway, and removes forbidden API issues.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815404 13f79535-47bb-0310-9956-ffa450edef68
2017-11-16 01:22:52 +00:00
Greg Woolsey
963a8fedae ignore a unit test that snuck in. It was created to investigate an open bug report. It fails, as expected, which broke the build.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815336 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 16:34:14 +00:00
Greg Woolsey
ff034f6a20 Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types

fixed, with unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 08:35:17 +00:00
Dominik Stadler
3e70d22cbc Fix setting a font-color if no previous color is defined for the font
Add unit-test to verify this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815086 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 11:46:04 +00:00
Dominik Stadler
1b9d599882 Fix tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815085 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 11:44:50 +00:00
Javen O'Neal
f062e7f1c2 bug 61745: remove String#toString() usage found by forbidden apis check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815048 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 00:51:41 +00:00
Javen O'Neal
a1b8f3ff14 bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 21:48:41 +00:00
Javen O'Neal
bac484ba37 +svn:eol-style native *.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815002 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 06:52:38 +00:00
Javen O'Neal
fbccf3066c github #81: sheet names are case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815001 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 06:14:43 +00:00
Javen O'Neal
1bc1bdb58b XWPFTable#getRows() should return an unmodifiable list unless the method can correctly update xmlbeans in response to modifying the list
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814999 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:34:52 +00:00
Javen O'Neal
fd29e87402 make tableRows final; initialize where defined rather than in constructor.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814998 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:32:43 +00:00
Javen O'Neal
c1e6c2eef7 deprecate XWPFTable#addNewRowBetween(int,int), which has not been implemented since 2008 when this class was first authored. (Unrelated: This closes #82 on github).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814997 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:30:42 +00:00
Mark Murphy
70fdcdf848 Surface XSSF Header/Footer Attributes (60887)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814950 13f79535-47bb-0310-9956-ffa450edef68
2017-11-11 14:18:24 +00:00
Dominik Stadler
2d5b6457c6 Some JavaDoc adjustments, typos, IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68
2017-11-08 14:59:08 +00:00
Javen O'Neal
8b0145c6e0 bug 61730: remove asSet function from unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 07:26:48 +00:00
Javen O'Neal
163673a7aa bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is safer, less likely to cause an OOM/DoS.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 07:21:24 +00:00
Javen O'Neal
841cc75ee4 bug 61730: add javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 01:54:25 +00:00
Javen O'Neal
fb321255e8 bug 61730: add iterator interface to CellRangeAddressBase for iterating over CellAddresses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 00:29:09 +00:00
Javen O'Neal
baec676cd0 bug 61727: make TestCellRangeUtil unit tests more explicit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814444 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 22:19:06 +00:00