moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
7,698 Commits 29 Branches 84 Tags 722 MiB
d3eae0ccd8
Commit Graph

6368 Commits

Author SHA1 Message Date
Andreas Beeker
eb111ce81f findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744332 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 23:34:52 +00:00
Dominik Stadler
0c78005743 Bug 59427: Add a check to better report cases when a document is already closed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744306 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:34 +00:00
Dominik Stadler
df72dbfbed Revert expected failure as it seems to be fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744305 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:27 +00:00
Dominik Stadler
6a223ec11e BiffViewer: Close resources always 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744212 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:21 +00:00
Dominik Stadler
ff055532c1 Exclude newly added corrupt file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744211 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:16 +00:00
Andreas Beeker
e28fff0423 ignore external relations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744196 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 07:23:34 +00:00
Andreas Beeker
7b282db0e2 Move reflection-equals to POITestCase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744169 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 23:28:25 +00:00
Andreas Beeker
61321b4b37 #54570 - InvalidFormatException because of Absolute URI forbidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744137 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 21:04:00 +00:00
Andreas Beeker
33241e821f add asl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744021 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:54:02 +00:00
Andreas Beeker
73108582a0 deprecation fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744008 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:52 +00:00
Andreas Beeker
1f862981e2 Close resources in Common SL rendering classes and minimize memory consumption by using the image anchor dimensions instead of the WMF-included dimensions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744007 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:22 +00:00
Andreas Beeker
306edb91e5 sonar fix - reduce complexity by using constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744006 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:04:46 +00:00
Andreas Beeker
fa00834766 Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744005 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:02:13 +00:00
Andreas Beeker
20fe8a5e0f Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744004 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:01:36 +00:00
Andreas Beeker
2e5f0132c5 Sonar fixes - array is stored directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744003 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:57:19 +00:00
Andreas Beeker
84be4acea9 Dispose XmlCursor 
Replacing a method argument (XmlCursor) with a local instance and then updating it, doesn't make sense

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744002 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:54:01 +00:00
Andreas Beeker
12425ac107 added commons-logging to integration test to make profiling easier - just match the timestamps of the log with the timestamps of the profiling monitor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744001 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:49:17 +00:00
Andreas Beeker
dde2a25283 #59170 - Remove deprecated classes (POI 3.15) - use FormulaError instead of ErrorConstants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744000 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:38:42 +00:00
Andreas Beeker
401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-13 23:50:39 +00:00
Javen O'Neal
4a3acf4de0 add @since to javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742882 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:47:49 +00:00
Javen O'Neal
730641576a bug 59443: exit early on setAddress if address is the same 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:46:14 +00:00
Javen O'Neal
191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:25:29 +00:00
Javen O'Neal
70459401a3 bug 59443: add get/setAddress methods on cell comment class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:09:41 +00:00
Javen O'Neal
fe04abd31d fix BasteTestCellComment#attemptToSave2CommentsWithSameCoordinates to work with different behaviors of HSSFWorkbook and XSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742871 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 04:29:17 +00:00
Javen O'Neal
e9bfa9da87 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:53:55 +00:00
Javen O'Neal
a92163e9b6 add disabled unit test for bug 59393 from stone 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742868 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:49:16 +00:00
Javen O'Neal
88d0eee64b move TestHSSFComment#attemptToSave2CommentsWithSameCoordinates down to BaseTestCellComment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742866 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:35:45 +00:00
Javen O'Neal
94e4eb5276 merge TestComment into TestHSSFComment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742865 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:27:32 +00:00
Javen O'Neal
25552a1453 add test case from Anders Åberg for bug 59442 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742862 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:27:31 +00:00
Javen O'Neal
3920d0660c Test CellUtil with XSSFWorkbook and SXSSFWorkbook instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742860 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:12:25 +00:00
Javen O'Neal
9fba427794 convert TestCellUtil to BaseTestCellUtil so that it can be tested with different workbook instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742859 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:09:36 +00:00
Andreas Beeker
f850d93b68 #59434 - Cannot add a picture on a slide that already have an image with an hyperlink on it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742816 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-08 13:28:11 +00:00
Dominik Stadler
61f84af565 Try to print out more information if the timestamp-operation fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742425 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:44 +00:00
Dominik Stadler
d158ef23bd Close file-handles in tests as well to avoid noise when running file-leak-detection 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742424 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:37 +00:00
Dominik Stadler
8908412e3a Some general code-fixes found while trying out Java 9 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742423 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:31 +00:00
Dominik Stadler
56c5bd05e1 Try to catch more network-unavailable cases in TestSignatureInfo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742422 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:23 +00:00
Dominik Stadler
26de463419 Refactor SSPerformanceTest into a few methods to make it easier to use a profiler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742420 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:16 +00:00
Andreas Beeker
f688ed96c6 #59327 - Setting text direction on a table cell has no effect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742338 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-04 22:09:10 +00:00
Javen O'Neal
808254af89 bug 59383: getFormat should cache data formatter (fix from Nick C), accidentally deleted in bug 58532 r1710407. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1741114 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-26 22:48:02 +00:00
Javen O'Neal
20b11d54b1 remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739689 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-18 04:47:06 +00:00
Javen O'Neal
480ec67d81 add unit test for SXSSFSheet#changeRowNum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739688 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-18 04:46:05 +00:00
Javen O'Neal
1e07b01af3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739661 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 21:51:16 +00:00
Javen O'Neal
ba64b65412 add unit test for StringUtil#join 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739660 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 21:28:49 +00:00
Javen O'Neal
556f1e78a1 restore r1739550 and r1739552 (by reverting r1739580). Exclude BaseTestXWorkbook, BaseTestXSheet, BaseTestXRow, and BaseTestXCell from the OOXML-Lite target 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739644 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 20:17:04 +00:00
Javen O'Neal
dca380f057 reformat exclude classes regular expression for OOXMLLite 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739643 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 20:02:17 +00:00
Javen O'Neal
ae5b894886 upgrade TestPaletteRecord to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739587 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:40:18 +00:00
Javen O'Neal
e66fc6b289 bug 58896: write autoSizeColumn timing to POILogger instead of standard output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739584 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:36:50 +00:00
Javen O'Neal
e678eeb582 revert r1739548 and r1739550. I could not figure out how to add BaseTestXWorkbook|Sheet|Row.java without causing junit to complain about 'Test class should have exactly one public constructor' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739580 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:25:35 +00:00
Javen O'Neal
0b9fea928e add comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739554 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:42:26 +00:00
Javen O'Neal
da6d61f83b consolidate duplicates between TestXSSF* and TestSXSSF* 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739552 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:40:27 +00:00
Javen O'Neal
144758da98 add junit test classes for combined testing of XML-specific functionality of (S)XSSF Workbook, Sheet, and Row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739550 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:06:30 +00:00
Javen O'Neal
ec84916a9f bug 59342: add sheet tab color getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739548 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 07:39:36 +00:00
Javen O'Neal
4d4b54b7c8 bug 59342: add sheet tab color getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739547 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 07:38:15 +00:00
Javen O'Neal
3ba74f8319 bug 59340: lookup IndexedColors by index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739539 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 03:39:21 +00:00
Javen O'Neal
48bba39dcf move unit test for XSSFSheet.setTabColor from TestXSSFWorkbook to TestXSSFSheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739538 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 03:35:58 +00:00
Javen O'Neal
4e33c06871 bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 01:29:19 +00:00
Javen O'Neal
f3af2a116b bug 59336: patch from Mark Murphy: replace deprecated usage of functions in CellUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739533 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:32:32 +00:00
Javen O'Neal
6043813e67 bug 59338: patch from Mark Murphy to deprecate HSSFCellUtil class in favor of CellUtil. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739531 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:20:37 +00:00
Javen O'Neal
393ccc1873 fix Sonar warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738876 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 22:44:28 +00:00
Javen O'Neal
ecf7db3223 bug 59312: delete temporary files even when the output stream cannot be closed (such as out of disk space IOException) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738848 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 18:48:31 +00:00
Javen O'Neal
d94ff1aa8e javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738789 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:19:49 +00:00
Javen O'Neal
a4af4fc6c3 fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:03:24 +00:00
Javen O'Neal
9e389627cc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738773 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:28:25 +00:00
Javen O'Neal
cb5544ad9f fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738765 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:12:57 +00:00
Javen O'Neal
aa6083ce0a add LINK_TYPE_SECONDARY_CATEGORIES, which appears to be a valid type (0x03) based on HSSFChart.insertData 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738762 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:03:58 +00:00
Dominik Stadler
78a05ca7a0 Fix compiler warnings and ensure CTChartSheets stays included and is not refactored out by automated import reorganization 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738752 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 10:09:44 +00:00
Javen O'Neal
921c9b9e4b junit4 assert* improvements, add CTChartsheet to unit test so that it's compiled into poi-ooxml-schemas.jar (if it isn't already) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738742 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 09:22:48 +00:00
Javen O'Neal
db25900315 convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738738 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 08:51:45 +00:00
Dominik Stadler
4010992ac2 Exclude file that was modified and now fails with the known limitation of sheet-cloning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738704 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 06:56:06 +00:00
Javen O'Neal
68ac23176f convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738680 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:43:33 +00:00
Javen O'Neal
a4808bb56c whitespace: +svn:eol-style=native, tabs to 4 spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738679 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:21:01 +00:00
Javen O'Neal
4260aa76c2 javadoc typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738677 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:13:52 +00:00
Javen O'Neal
d59c08e954 fix javadocs and findbugs warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738674 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 01:30:20 +00:00
Javen O'Neal
5e51b9e89b bug 52949: add unit test for reading VBA Macros from a Visio OOXML (VSDM, 2013+) file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738651 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 21:35:22 +00:00
Javen O'Neal
bbf912dceb bug 52949: add VBAMacroReader unit tests for H/XSLF, H/XWPF, and HGDF; OLE directories as case-insensitive 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738513 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 05:54:17 +00:00
Javen O'Neal
d6252e00b1 bug 52949: fix forbidden apis 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738499 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 01:26:09 +00:00
Javen O'Neal
f49047e733 add @NotImplemented annotation to methods that are not implemented 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 21:28:41 +00:00
Javen O'Neal
f2e250d7e4 ignore VBA source files in integration test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738460 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 20:21:55 +00:00
Javen O'Neal
f49897de27 bug 52949: parameterize fromNPOIFS also 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738439 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:46:42 +00:00
Javen O'Neal
9f36d6c876 bug 52949: prepare for adding DOC/DOCM and PPT/PPTM test cases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738438 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:33:47 +00:00
Javen O'Neal
014d371a5f bug 52949: add junit test for RLEDecompressingInputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738436 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:09:02 +00:00
Javen O'Neal
8898db6b2e svn propset svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738435 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:05:33 +00:00
Nick Burch
d7981342e0 Javadoc tweaks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738431 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 13:02:36 +00:00
Nick Burch
e8e1a294e6 Make the extractor exactly that, powered by the reader #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738429 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:59:38 +00:00
Nick Burch
2185e91883 Unit test for VBA macro reading #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:45:53 +00:00
Nick Burch
82351e8fea Start to refactor VBAMacroExtractor into a more general class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738423 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:54:09 +00:00
Nick Burch
4abcc6626a VBA extraction support from bug #52949 from Barry Lagerweij 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738418 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:16:49 +00:00
Dominik Stadler
2a0ed81538 Bug 57844: Add some javadoc for unimplemented features in SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 09:40:40 +00:00
Tim Allison
a060c664a1 close fileinputstream on second exception in ZipPackage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-08 14:36:05 +00:00
Dominik Stadler
3718d45538 In Example FromHowTo, open the OPCPacakge read-only to not try to write it back on close() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738097 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-07 07:25:02 +00:00
Dominik Stadler
5c1780aa72 Close two more file-handles in Example FromHowTo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738035 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:20 +00:00
Dominik Stadler
8b10d4d71b Tried to evaluate all formulas in worksheets as part of the integration tests, but some documents fail and it probably increases runtime of tests considerably, so left commented out for now. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738034 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:14 +00:00
Dominik Stadler
b9e7c32ffe Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:08 +00:00
Dominik Stadler
ec6bb2a066 Slightly improve error message 
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:59 +00:00
Dominik Stadler
62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:47 +00:00
Dominik Stadler
2c4a66ee49 Add missing license header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737963 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 10:52:36 +00:00
Dominik Stadler
5dc647da61 Bug 56911: Fix IndexOutOfBoundsException in PlfLfo.add() and add minimal test, however these classes look quite untested and thus require more test-coverage to make them more robust 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737947 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 09:00:05 +00:00
Nick Burch
a456ad5d77 Fix javadoc warning - As per http://bugs.java.com/bugdatabase/view_bug.do;jsessionid=d014dfa686594180be40ca5872f5?bug_id=4907024 an @see is only allowed a single link with nothing after it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737924 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 06:28:14 +00:00
Javen O'Neal
7fd89e0e39 add test coverage for TestSXSSFCell.toString() on blank and date cells 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737923 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 06:01:26 +00:00
Javen O'Neal
f9c74888e3 add test coverage for WorkbookFactory.create(File file, String password, Boolean readOnly) when file does not exists 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737917 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 05:15:15 +00:00
Javen O'Neal
bed6a46d10 bug 59264: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737914 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 04:32:36 +00:00
Javen O'Neal
b8dcd4df42 bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 00:06:53 +00:00
Javen O'Neal
c95f6a4b35 whitespace (tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:47:41 +00:00
Javen O'Neal
fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:30:37 +00:00
Javen O'Neal
e2399abbe9 bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:38:55 +00:00
Javen O'Neal
5752c4bb7e bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:36:11 +00:00
Javen O'Neal
f7939c4c95 bug 59264: add link to BorderStyle on deprecated BORDER_* constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:34:24 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 20:28:46 +00:00
Javen O'Neal
739196e5b3 bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:27:20 +00:00
Javen O'Neal
8e1b343761 rearrange BORDER_DOTTED and BORDER_HAIR 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:26:44 +00:00
Dominik Stadler
b46a57926c Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-03 18:32:22 +00:00
Dominik Stadler
e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:56 +00:00
Dominik Stadler
205055b83c Prevent us from changing the file with every test-run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737488 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:49 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor 
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:43 +00:00
Dominik Stadler
1985e23f59 Regression: Add unit-test which triggers more code deep inside XSLF to have some missing pieces included in the reduced ooxml-schema-jar 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737466 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 06:38:39 +00:00
Nick Burch
29c2e05b58 Javadoc fix - Generics are type-erased so not included in the javadoc links 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737317 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 07:17:04 +00:00
Dominik Stadler
88e9ff08db Enhance integration tests to call some of the common examples/devtools to also trigger these with all sample files, currently XLSX2CSV, BiffViewer, FromHowTo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737308 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 06:25:49 +00:00
Tim Allison
26af28bbdb POI 59257 upgrade Bouncy Castle to 1.54 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737298 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 00:57:56 +00:00
Dominik Stadler
316c1fe307 Bug 57930: Add support for inlineString in FromHowTo 
Also do not require an Apache Xerces Parser, let the JDK choose an available one instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737247 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 14:39:11 +00:00
Dominik Stadler
12f99cc9d5 Adjust integration tests, fix compilation warnings, make the check on "EXPECTED_EXTRACTOR_FAILURES" actually work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737242 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 13:56:27 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets. 
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 13:32:05 +00:00
Dominik Stadler
33cf4c310b DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:44:11 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:30:55 +00:00
Dominik Stadler
ff68b433b8 Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:27:20 +00:00
Dominik Stadler
00e6abb6bc Try to reproduce bug 58922, convert to JUnit 4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737018 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 16:11:29 +00:00
Dominik Stadler
0888ad4de5 Fix some compiler warnings, improve error message, cover some more code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 15:45:04 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 14:53:44 +00:00
Andreas Beeker
4eeffd0532 XSLF: do not display Master Slide objects by default 
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:52:01 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory 
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:49:45 +00:00
Andreas Beeker
ceda10fa32 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:46:53 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:22:08 +00:00
Dominik Stadler
8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:20:29 +00:00
Javen O'Neal
4f4531c67e assertCloseDoesNotModifyFile method was adapted from method with the same name in TestWorkbookFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736744 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:09:50 +00:00
Javen O'Neal
6b6b6a668e add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:04:37 +00:00
Javen O'Neal
01b20a6567 make OPCPackage logger final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 05:01:02 +00:00
Javen O'Neal
f0e824587b bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 17:29:00 +00:00
Javen O'Neal
4fe9f0bcab make private member variable ctColor final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 06:37:34 +00:00
Javen O'Neal
784b07e424 bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-23 16:42:04 +00:00
Javen O'Neal
1128818a70 bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736165 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:22:03 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily 
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:51:39 +00:00
Javen O'Neal
dd308cd87e return unmodifiable shared strings to guarentee parallel data structures stay in sync 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736144 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:04:51 +00:00
Javen O'Neal
a61e242e86 bug 59208: correctly understand val="1" for isBold, isItalic, etc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 04:20:45 +00:00
Javen O'Neal
e89f19bef3 fix inconsistent newlines (remove carriage returns), set svnprop eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736121 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 02:31:16 +00:00
Andreas Beeker
197aef5420 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:42:56 +00:00
Andreas Beeker
762864d0f2 findbugs fixes - RR_NOT_CHECKED 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:29:06 +00:00
Andreas Beeker
e9f333827d fix eclipse warnings 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 00:14:21 +00:00
Andreas Beeker
8be67e1910 fix eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735881 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-20 13:36:56 +00:00
Andreas Beeker
b09c85ff04 eclipse warning fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735706 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 23:12:28 +00:00
Andreas Beeker
87f4e8fa63 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 22:21:12 +00:00
Andreas Beeker
488ce5fec3 #59195 - POIXMLTypeLoader depends on XMLBeans 2.6.0 - remove piccolo classes from xmlbeans jars and disable xmloption in type loader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735685 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 21:34:03 +00:00
Andreas Beeker
33991bfd98 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:39:20 +00:00
Andreas Beeker
492e51b15f findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:36:11 +00:00
Andreas Beeker
3e6de40c64 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 21:52:53 +00:00
Andreas Beeker
4187b04edb forgot another contains call ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:40:00 +00:00
Andreas Beeker
61388344ba findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:36:17 +00:00
Andreas Beeker
56ceb000f1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:30:19 +00:00
Andreas Beeker
7652be2ed1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735323 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:34:26 +00:00
Andreas Beeker
d749785d1f sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735321 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:27:56 +00:00
Andreas Beeker
d6d47e0bca findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:10:27 +00:00
Andreas Beeker
4c4d718f52 forbidden-apis-fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735316 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:59:40 +00:00
Andreas Beeker
a7c073ada9 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735312 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:46:28 +00:00
Andreas Beeker
ac6a01898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735301 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:20:15 +00:00
Andreas Beeker
80e4d8b879 First try of uncluttering CellNumberFormatter. 
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:18:58 +00:00
Andreas Beeker
52fe2e4571 Fix for Softmaker Office files, which set encryption settings invalidly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735298 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:05:37 +00:00
Tim Allison
81e49eff0f 59183 - handle timezones (even with colons) in date parsing metadata in ooxml opc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735270 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 17:52:42 +00:00
Nick Burch
560ce3ee0b Ignore ODS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735079 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 14:17:47 +00:00
Nick Burch
197458b30c One final invalid file type check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:37:01 +00:00
Nick Burch
7112835d90 Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:30:45 +00:00
Nick Burch
700fe05e34 Push all the zip opening logic into ZipHelper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735064 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:03:30 +00:00
Nick Burch
0fab07ccfc Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735063 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:56:28 +00:00
Nick Burch
5f2f0adfae Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735061 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:54:16 +00:00
Nick Burch
4d7955d6b5 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:50:57 +00:00
Dominik Stadler
4a98bd4c27 Remove some useless lines of code, the initialAllocationSize is ignored in SXSSFRow() anyway 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734925 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 12:00:27 +00:00
Dominik Stadler
d853210049 Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 11:58:15 +00:00
Andreas Beeker
3f4f58829d HSLF: Add support for system colors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 00:42:59 +00:00
Dominik Stadler
4bd9afde4f Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:38 +00:00
Dominik Stadler
3c1052e375 Bug 55791: Avoid using an existing file-name when creating a new slide, it could still be left over from previous partial removal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734862 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:27 +00:00
Dominik Stadler
0a5dcbec1b Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:18 +00:00
Nick Burch
2718aa2f51 Escape spaces in the URL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:19:46 +00:00
Andreas Beeker
653403e956 #59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 19:31:32 +00:00
Andreas Beeker
045123e198 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734809 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 14:12:43 +00:00
Dominik Stadler
9bf1bf60b2 Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:33 +00:00
Dominik Stadler
f1a476d83a Fix bug 56549: correctly calculate char index ranges for HWPF in the TextPieceTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734718 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:26 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class 
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:32 +00:00
Dominik Stadler
6d97ae7083 Fix some cases where POI itself or the tests leaked file-handles 
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:22 +00:00
Dominik Stadler
128a991f9c Findbugs fixes 
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:56 +00:00
Dominik Stadler
b989e4f5a8 Enable some tests that are ignored, actually run green and did not have any comment why they were ignored in the first place 
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734687 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:50 +00:00
Dominik Stadler
8c508d89b0 Add test for bug 59098 which shows that this is fixed in 3.14. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734686 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:43 +00:00
Andreas Beeker
7d6be0ff54 #59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-11 23:14:09 +00:00
Andreas Beeker
630bdd0f15 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734339 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:32:33 +00:00
Andreas Beeker
1b9523898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6 Remove a superfluous/bloated log function, which String.format can do better and is only used once ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 20:57:26 +00:00
Nick Burch
9090741226 More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 10:57:52 +00:00
Andreas Beeker
9f47700711 #59058 - OOM when parsing docx after OPCPackage.open with File but not with InputStream (TIKA-1866) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734184 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 01:25:02 +00:00
Andreas Beeker
3a328aa220 #57031 - Out of Memory when extracting text from attached files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 00:41:02 +00:00
Dominik Stadler
e444b4b01a Fix source rebuilding verification after resulting binaries in dist-folder changed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733878 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-07 08:32:11 +00:00
Nick Burch
ea9169b3c4 Comment and Javadoc updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733119 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-01 18:11:14 +00:00
Andreas Beeker
261ef4934c #59056 - Render individual slideshow shapes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25 Fix NPE of regression tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:36:58 +00:00
Dominik Stadler
4ad3d7b35a Exclude file for bug 59074 for some more tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732783 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 19:40:25 +00:00
Andreas Beeker
a7ca3d19ae find bugs fix - WMF_HEADER_MAGIC isn't final but should be 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732753 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 15:24:14 +00:00
Dominik Stadler
2fa065d96c Also mark the file for bug 59074 as expected-failure for integration testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732620 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:53 +00:00
Dominik Stadler
da1879c1b2 Bug 57914: Provide a better error message for OOXML strict format which we do not support yet. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:46 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0 Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:43:59 +00:00
Nick Burch
1cbcfbe026 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732580 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:32:54 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:32:17 +00:00
Andreas Beeker
41d693fe15 Regression fixes for H/XSLF and HWMF 
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:43:51 +00:00
Dominik Stadler
161ef55132 Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:39:11 +00:00
Nick Burch
d35942ca52 #59021 Namespace aware processing fix for ReadOnlySharedStringsTable, to match the one recently added to XSSFSheetXMLHandler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731986 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:24:09 +00:00
Nick Burch
194fdfe162 Pull out two more XSSF namespace definitions as re-usable constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731980 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:16:54 +00:00
Nick Burch
094e3f68e6 Pull out http://schemas.openxmlformats.org/spreadsheetml/2006/main to a re-used constant 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731975 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:10:20 +00:00
Nick Burch
c58e4fe96c Patch from Jim King from bug #57989 - XSSFChart support for setting chart titles, plus get+set unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731566 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 21:17:23 +00:00
Dominik Stadler
0f10be0ca4 One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 20:42:05 +00:00
Dominik Stadler
10f46da1ae Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 20:41:56 +00:00
Tim Allison
bc716a2796 POI 59030 fix NPE in XWPFTableCell's getVerticalAlignment via Prasad Babu 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731257 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-19 15:46:26 +00:00
Javen O'Neal
2cab09db04 bug 58896: comment out time-dependent test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 17:53:13 +00:00
Nick Burch
20777db2e7 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731047 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 11:16:11 +00:00
Javen O'Neal
7bb1a1bb22 move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 04:05:45 +00:00
Javen O'Neal
57ebf6b133 bug 58896: add unit test to time Sheet.autoSizeColumn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 03:33:25 +00:00
Javen O'Neal
5e52b6f4e9 avoid redundant null check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730994 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 02:03:11 +00:00
Tim Allison
9e46ee937c 59021 -- fix content extraction from namespaced elements in XSSFEventBasedExcelExtractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730992 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 01:49:59 +00:00
Javen O'Neal
c80fa0c870 bug 56345: reject single-cell merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 01:33:14 +00:00
Dominik Stadler
5093542774 Add test which verifies that bug 52684 is not a problem (any more) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-17 21:35:22 +00:00
Javen O'Neal
3cb72bfa7b bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 20:27:59 +00:00
Dominik Stadler
4aeff3f0ac Tried to reproduce bug 55476, but could not, added unit test anyway 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730598 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 19:16:45 +00:00
Nick Burch
86153c0ea6 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:58:16 +00:00
Nick Burch
0982d9dee5 Start generalising the IgnoredErrorType code for later HSSF use too #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:40:24 +00:00
Dominik Stadler
63a7f89342 No need to wrap OpenXML4JRuntimeException in another instance of itself and fix some compilation/javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730482 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 10:08:26 +00:00
Dominik Stadler
677b19afbd GitHub PR 27: Add method to check for any protection in XWPFDocument, closes #27 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730471 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 09:26:51 +00:00
Dominik Stadler
98da5af350 Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 08:33:12 +00:00
Dominik Stadler
528a64dc76 Improve error messages to state which bounds are exceeded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 07:41:47 +00:00
Dominik Stadler
b01efb6855 Regression analysis: Cloning sheets failed on ctrlProps, i.e. checkboxes 
and other GUI elements, add minimal support for these to allow clone to
succeed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730275 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:30:10 +00:00
Dominik Stadler
c68a9e4c02 Regression analysis: the additional testing of cloning sheets showed a 
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:46 +00:00
Dominik Stadler
eeee511f71 Ignore a failure during cloning if we exceed file-format limits 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730273 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:23 +00:00
Dominik Stadler
b6de146895 bug 58996: Don't try to unset fill color if it is not set to avoid invalid access inside the Xml structures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729964 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-12 09:44:47 +00:00
Nick Burch
118b728156 Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:40 +00:00
Nick Burch
a3966df033 Allow common tests to do auto-sizing even on SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729848 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:01 +00:00
Andreas Beeker
2aa39f5bdb Add example for adding videos 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728888 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-06 22:23:47 +00:00
Andreas Beeker
ce22cc44c4 XSLF - fixed NPE when adding pictures with existing non-picture media files (e.g. movies) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728737 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 22:03:44 +00:00
Dominik Stadler
fb07d95b55 Remove file from expected failures after changes for bug 56880 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728612 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 07:51:35 +00:00
Tim Allison
827c3f562b Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-04 19:54:15 +00:00
Javen O'Neal
95e95dfabb remove deprecated (2009) HSSFComment#setColumn(short). int version is available. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:52:32 +00:00
Javen O'Neal
80c9b356c2 HSSFComment: note a final field 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:33:00 +00:00
Javen O'Neal
dc860a6f93 fix O(n^2) runtime unnecessarily recreating an array inside a for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:14:55 +00:00
Javen O'Neal
6c89d062bf bug 58885: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727777 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 04:04:56 +00:00
Javen O'Neal
e365e9cbac bug 58885: performance regression on XSSFSheet.addMergedRegion(CellRangeAddress). Add an unsafe version of addMergedRegion that doesn't check for overlapping merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727776 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 03:27:35 +00:00
Dominik Stadler
a79dfd18e4 Adjust test to pass forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727693 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-30 11:02:54 +00:00
Dominik Stadler
68997de5f0 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called 
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-29 22:09:03 +00:00
Dominik Stadler
f94bb63332 add an ignored test for bug 58804 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726681 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-25 20:21:30 +00:00
Andreas Beeker
5fad9af36f #41047 - Support hyperlinks in HSLF shapes and textruns 
#47291 - Cannot open link correctly which insert in ppt

HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-24 00:12:10 +00:00
Dominik Stadler
2ac89a2dc9 Rename test-source file to actual class name to avoid constant recompilations on 'compile-main' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725336 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:38 +00:00
Dominik Stadler
a369daa432 Fix possible NPE found with msg-file from CommonCrawl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725334 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:23 +00:00
Dominik Stadler
fe359afec3 Fix possible NullPointerException with invalid/unsupported image types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725332 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 19:56:30 +00:00
Javen O'Neal
0173f22787 make SXSSFWorkbook member variables private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725047 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:58:25 +00:00
Javen O'Neal
14beee1cfd whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725043 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:31 +00:00
Javen O'Neal
18c5045d5b fix questionable List.remove(int) in SXSSFITestDataProvider 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725042 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:05 +00:00
Andreas Beeker
94fdd517aa BugFix: wrong hyperlink record added - used child instead of parent record 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725041 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:19:34 +00:00
Javen O'Neal
51e4b32498 add @Override annotations to ITestDataProviders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725040 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:03:58 +00:00
Javen O'Neal
276e95e43f bug 58879: add SpreadsheetVersion to Workbook interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:01:33 +00:00
Andreas Beeker
79920b06eb Fix NPE when calling HSLFTextRun.setHorizontalCentered() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725022 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 19:27:58 +00:00
Andreas Beeker
c1263423cf #56004 - Support for WMF rendering 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724897 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 00:11:01 +00:00
Dominik Stadler
bdef6e1c52 Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:46:17 +00:00
Dominik Stadler
50d09bf36c Fix a NullPointerException that occurs with some PPTs now but did not in POI 3.13 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724487 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:49 +00:00
Dominik Stadler
e91e15ab10 Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:05 +00:00
David North
a08539ef02 Generalised API for adding ignored errors, e.g. number stored as text. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724469 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 17:54:24 +00:00
Dominik Stadler
8793846bc6 Bug 58829: Remove some useages of printStackTrace() and some other minor cleanups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724445 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 15:59:38 +00:00
Dominik Stadler
8cf781c31b Rework test to not catch exception, junit does a good job of handling unexpected exceptions itself, StringBuffer replacing, code duplication 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724368 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 08:16:15 +00:00
Nick Burch
c86a4af85e Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724364 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:33:03 +00:00
Nick Burch
ed9a070491 #58847 Getters/setters/removers for the additional well-known document summary information properties from Office 12 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724363 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:26:26 +00:00
Andreas Beeker
0ded035dda Javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724343 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 01:09:43 +00:00
Andreas Beeker
b0c16b8261 #57796 - Support hyperlink extraction when rendering slides 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724338 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-12 23:20:48 +00:00
Nick Burch
ef61211207 More Office 12 DSI property IDs, getters/setters to follow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724110 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:43:33 +00:00
Nick Burch
5e32d8c805 Bump up the max DSI property ID, and list a few Office 12 well known IDs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724104 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:26:24 +00:00
Andreas Beeker
f56b918b16 #54916 - POI does not always read all the slides in pptx files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723966 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 20:44:17 +00:00
Andreas Beeker
b3b4ed6564 add other printStackTrace methods to forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 19:52:16 +00:00
Andreas Beeker
8d033e235c replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 02:20:35 +00:00
Andreas Beeker
22a9bade84 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723898 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 01:12:16 +00:00
Tim Allison
f065bf6e00 POI-58822 switch printStackTrace for actual log msg. Should probably open separate ticket to handle handful of other instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723765 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-08 17:06:39 +00:00
Javen O'Neal
1e9fd97f78 bug 58815: javadoc spelling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723445 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-07 01:53:05 +00:00
Andreas Beeker
afb36678f5 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723198 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-05 23:40:47 +00:00
Andreas Beeker
6ec54a0177 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722771 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 22:46:57 +00:00
Dominik Stadler
0fe35af294 Undo changes to file in assertCloseDoesNotModifyFile to not have dirty files after running tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722756 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 21:37:52 +00:00
Dominik Stadler
f54452a0e7 Try to reproduce bug 52258 and add more checks to integration tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722755 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 21:23:09 +00:00
Dominik Stadler
c4c9ac0ccf bug 58043: provide some compatibility between HSSF and XSSF in regards to values for CellStyle.setRotation(). Also adjust JavaDoc to mention the remaining things to note 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722716 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 13:28:17 +00:00
Dominik Stadler
ff8592b190 Fix bug 58067: XWPF: don't return deleted text when document is in review-mode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722715 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 13:28:01 +00:00
Javen O'Neal
bc6a4a20d4 re-throw errors we aren't looking for 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722708 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 09:48:05 +00:00
Javen O'Neal
4f6a75b701 bug 58779: check if SlideShowFactory.create() modifies the file being read when the slideshow is closed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722707 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 09:16:59 +00:00
Javen O'Neal
2cf06902d5 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722696 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 01:34:33 +00:00
Javen O'Neal
87ec46ff34 test XSLF SlideShowFactory creation methods individually for more granular unit test results 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722695 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 01:26:29 +00:00
Javen O'Neal
d747590977 rearrange unit tests into more, smaller functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722667 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:20:43 +00:00
Dominik Stadler
67d7b4a231 Move test for bug 57236 as it seems to be fixed since some time 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722666 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:11:41 +00:00
Dominik Stadler
b037995fdd Add test which reproduces bug 58325, seems the file uses AlternateContent which POI does not support (yet) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722665 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:11:28 +00:00
Javen O'Neal
347881ef1e bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 11:11:33 +00:00
Javen O'Neal
4a47ec3d39 fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 06:23:05 +00:00
asf-sync-process
de7807c8a7 bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 04:29:34 +00:00
Javen O'Neal
85bb833ea1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722605 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 03:40:22 +00:00
Andreas Beeker
f5a24203b8 remove test debug stuff 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722556 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 19:45:30 +00:00
Andreas Beeker
9072855208 preparation for #54916 - commit unrelated changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722538 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 19:05:50 +00:00
Dominik Stadler
4803a0c355 bug 58618: XWPFParagraph insertNewRun and removeRun work incorrectly for 
runs after hyperlink/field runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722503 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:28:01 +00:00
Dominik Stadler
bbd6e63c60 Include full nested exception, not just localized message 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722502 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:50 +00:00
Dominik Stadler
a6957b5c91 Some more unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722501 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:35 +00:00
Dominik Stadler
39551f8e01 Combine common functionality in POIXMLTypeLoader into helper method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722500 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:27 +00:00
Andreas Beeker
006595947d add ignored testcase for multiple signatures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722497 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 15:04:06 +00:00
Andreas Beeker
318f0b35b8 remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas) 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722482 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 02:22:31 +00:00
Andreas Beeker
8ed770dfe3 remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722480 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 00:45:05 +00:00
Andreas Beeker
e7d60982c7 #55030 - RichTextRun getFontName can not get Chinese font name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722479 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 23:49:34 +00:00
Andreas Beeker
f317f5e288 #56570 - RecordType has repeat by code type 3009 
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722476 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 22:10:17 +00:00
Andreas Beeker
ee6966dae9 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722465 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 20:23:20 +00:00
David North
069d7c6141 Fix example. If you don't call super for the non-ignored sheets, everything breaks because you end up with an empty workbook. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722457 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 18:15:35 +00:00
Dominik Stadler
7f105042ba Fix bug 58760: non-standard namespace-key breaks parsing XLSX files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722433 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 09:56:33 +00:00
Dominik Stadler
c7baa89709 Revert changes to integration-test-framework to not make tests fail with strange errors about entity expansion limits 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722425 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 08:23:04 +00:00
Dominik Stadler
5344aa12cd Use parameter in unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722412 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:56 +00:00
Dominik Stadler
902830cf14 Adjust test for extracting some more 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:50 +00:00
Dominik Stadler
8589924b22 Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:44 +00:00
Dominik Stadler
e4b168d27f Add null-handler in integration-tests for two Visio files which are not handled (yet) and adjust memory handling somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722408 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:30 +00:00
Dominik Stadler
8ae2972f3d Bug 58616: Try to initialize with empty password if not done before 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:23 +00:00
Dominik Stadler
b4ac21a810 Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722406 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:13 +00:00
Dominik Stadler
b06eaa0d3e Exclude file from integration-tests until bug 58760 is fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722405 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:04 +00:00
Andreas Beeker
5a8442a16a WMF - remove test output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722249 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 23:53:52 +00:00
Nick Burch
a3d4d2571f Disabled unit test for #58760 (problem remains) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722244 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 22:42:17 +00:00
Javen O'Neal
434ebbbdef remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722095 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:41 +00:00
Javen O'Neal
8be029b0c6 add comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722094 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:57 +00:00
Javen O'Neal
b96af85631 move comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722093 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:43:40 +00:00
Javen O'Neal
900d21a59c javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722092 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:41:50 +00:00
Javen O'Neal
44c5423be4 add unit test for bug 58779 when the problem gets fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722091 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:40:20 +00:00
Javen O'Neal
dba7fcdd4e junit3 -> junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722081 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:54:59 +00:00
Javen O'Neal
5310fc4b6d revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722079 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:28:32 +00:00
Javen O'Neal
6bc5c33c10 revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722078 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:21:17 +00:00
Javen O'Neal
5ab2c61a3f make spreadsheet file names static final rather than initializing them with setUp() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722073 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 08:53:46 +00:00
Javen O'Neal
7980a6b457 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722070 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 07:38:31 +00:00
Javen O'Neal
eb5bca1612 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722057 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 06:55:22 +00:00
Javen O'Neal
ef26a1d15c bug 58775: set an upper limit on number of data formats, default 250. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722054 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 05:46:20 +00:00
Javen O'Neal
70f08e1fc5 fix javadocs warnings for r1721930 (bug 58775) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 02:57:58 +00:00
Javen O'Neal
22b03ba71b convert junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722048 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:26:55 +00:00
Javen O'Neal
1dd49eff7c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722047 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:18:16 +00:00
Andreas Beeker
a89d5210c3 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722046 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 00:45:59 +00:00
Javen O'Neal
ae1020ac35 bug 58778: override a built-in number format, such as using £ instead of $ for currency 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722043 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 00:12:04 +00:00
Javen O'Neal
bf5e95d37a bug 58740: javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721942 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 16:04:47 +00:00
Javen O'Neal
a50f45e4c2 bug 58775: use short for data format index, int for cell style index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:50:54 +00:00
Javen O'Neal
0404c61acc bug 58775: consolidate HashMap and array numberFormats data structures to one SortedMap data structure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721928 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:37:23 +00:00
Javen O'Neal
8f47967d55 write for loop for performance and readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721924 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:20:30 +00:00
Javen O'Neal
0849d8c34a bug 58775: fix a>b which should be a>=b; use shorts instead of ints to hold number format index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:19:50 +00:00
Javen O'Neal
f3c14d82a6 simplify bug 57880 test case: 
remove unrelated DataFormat code (not worried about wrap-around here since Excel supports up to 250 data formats and we're using the short data type)
replace complex write-out, close, read-back, delete code with new better test apparatus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721922 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:03:52 +00:00
Javen O'Neal
934effd443 add convenience methods for writing and reading back XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 13:44:08 +00:00
Javen O'Neal
3204cedf28 bug 58775: use assertNotBuiltInFormat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:13:17 +00:00
Javen O'Neal
0ef05fcdab java docs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721901 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:11:13 +00:00
Javen O'Neal
9bdfcc4be6 bug 58775: add unit test to test for non-built-in data formats 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:10:12 +00:00
Javen O'Neal
8a7cd6308e bug 58775: add Override annotations, Javadocs, and comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721880 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 07:56:54 +00:00
Javen O'Neal
a94df00797 make HSSFCellStyle attributes final, add Override decorators on all methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 05:43:11 +00:00
Javen O'Neal
ec4732a034 bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 00:52:47 +00:00
Javen O'Neal
19e5db9602 bug 58740: return unmodifiable list/map when exposing internal data structures 
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-27 23:17:33 +00:00
Dominik Stadler
d89168fa51 Fix compiling unit-test after previous changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721471 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:48:31 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:43 +00:00
Dominik Stadler
c9dee45744 fix commandline option in PPTX2PNG from quite to quiet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721469 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:33 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:35:59 +00:00
Andreas Beeker
b333ed457d #56004 - Support for WMF rendering (parsing the WMF records) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721078 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-21 01:26:39 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-20 20:39:01 +00:00
Nick Burch
355810fb9f Unit test for non-reproducable #58747 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720588 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 15:05:06 +00:00
Dominik Stadler
ffe36ac2fe Fix unit test for bug 58731 to actually run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720534 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 12:39:01 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-14 22:49:04 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-13 09:51:22 +00:00
Andreas Beeker
ad89fdcaf5 #58718 - Master styles not initialized when running multithreaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719758 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-13 01:50:24 +00:00
Javen O'Neal
4f8057e56f bug 57450: javadoc fixes from Stefan Thurnherr 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718226 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:43:26 +00:00
Javen O'Neal
5da709336c supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:11:38 +00:00
Javen O'Neal
dedb924183 bug 56454: shiftRows incorrectly handle merged regions that do not contain column 0. Add failing unit test from Jörg Selbach. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718217 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 20:51:54 +00:00
Javen O'Neal
37622ec57e make test easier to understand using A1 addresses instead of row+col numbers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718216 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 20:43:27 +00:00
Dominik Stadler
96cb8c18fe Bug 58084: Fix cloning Cell Styles with Borders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717973 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:39:07 +00:00
Dominik Stadler
387fb86d68 Eclipse warnings, code formatting, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717972 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:38:14 +00:00
Javen O'Neal
4aa6108c0d add hashCode for corresponding equals function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717940 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:59:26 +00:00
Javen O'Neal
abced24fe4 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717938 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:56:59 +00:00
Javen O'Neal
eca89530d3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717931 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:12:27 +00:00
Javen O'Neal
26abacebaf FindBugs warning: ExcelStyleDateFormatter doesn't override java.text.SimpleDAtaFormat.equals(Object) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:54:21 +00:00
Javen O'Neal
3b24eaacd3 make fields static 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717929 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:51:03 +00:00
Javen O'Neal
ebbf3d0ddb whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717928 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:47:31 +00:00
Javen O'Neal
6d17f8ddef whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717927 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:46:58 +00:00
Javen O'Neal
17a4680cee findbugs: check return value of File.mkdir(s), and don't accidentally catch RuntimeException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:33:28 +00:00
Javen O'Neal
93497e5b0e add comments for names of missing functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:01:58 +00:00
Javen O'Neal
b6e5801a1c fix javadocs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717907 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:20:36 +00:00
Javen O'Neal
83a2f13494 fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717903 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:10:26 +00:00
Javen O'Neal
44c9afd31d fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:05:52 +00:00
Javen O'Neal
9c19c23291 bug 58570: add get/setActiveCell to Sheet interface, add Cell.getAddress, 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:36:27 +00:00
Javen O'Neal
293ef9fe17 remove deprecated functions (since 2008) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717899 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:30:34 +00:00
Dominik Stadler
5a8aceec32 Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-02 21:47:52 +00:00
Andreas Beeker
cc77b04a94 Sonar fixes, direct array parameter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717359 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-01 00:23:21 +00:00
Andreas Beeker
f0ed3cbbab - #47904 - Update text styles in HSLF MasterSlide 
- common sl unification for TextParagraph.setTextAlign

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717351 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 23:34:30 +00:00
Javen O'Neal
89fbd66262 bug 58670: cleanup from r1717192 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717194 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 07:03:09 +00:00
Javen O'Neal
8410c84ad6 bug 58670: replace SXSSFRow's storage of SXSSFCells[] with a TreeMap<Int, SXSSFCell> 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717192 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 06:07:49 +00:00
Javen O'Neal
b5ad3a9327 add @Override annotations to SXSSFRow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:28:57 +00:00
Javen O'Neal
24e5a0a458 add @Override annotation. Explicitly specify workbook type returned by SXSSFITestDataProvider.writeOutAndReadBack 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717179 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:22:14 +00:00
Javen O'Neal
5650b03ea0 testBool/testErr: check values before writeOutAndReadBack 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717178 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:21:01 +00:00
Javen O'Neal
7fc9df615f fix testErr: createRow(1) -> createRow(0); replace assumeTrue with assertEquals for more informative test results 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717171 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:00:24 +00:00
Javen O'Neal
dcba12a0ce whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717167 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:50:18 +00:00