Commit Graph

9095 Commits

Author SHA1 Message Date
Javen O'Neal
2554a46eaf Eclipse automated refactor/cleanup: convert for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765731 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:04:39 +00:00
Javen O'Neal
5d3d50b9d1 add StringUtil.count, inspired by Apache Commons Lang StringUtils#countMatches and Python's str.count(substr)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765730 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:04:16 +00:00
Javen O'Neal
4b01accdb3 Eclipse automated refactor/cleanup: convert for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765728 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 22:28:07 +00:00
Javen O'Neal
c5dddf7fac Eclipse automated refactor/cleanup: add missing @Override and @Deprecated annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765726 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 21:52:31 +00:00
Tim Allison
5958cb4840 BUG-59302 --add minimal support for VBAMacro extraction to HSLF; credit to Andreas Beeker for this patch. Problems are mine.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765696 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 18:44:46 +00:00
Javen O'Neal
c0a5f568da close pkg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765561 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 09:04:01 +00:00
Javen O'Neal
425e04b4a4 add @Override decorators to SheetIterator, move code outside of for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765556 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 08:38:19 +00:00
Javen O'Neal
9cad5aff09 reenable unit test for bug 58648 that passes now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765548 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 08:03:57 +00:00
Javen O'Neal
3ac3f37cbe bug 60255: use actual number of package parts rather than hard-coding an upper-bound
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765546 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:47:07 +00:00
Javen O'Neal
a73df78070 remove @deprecated annotation from Enum-returning getters. These will be deprecated after the int-returning getters are removed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765545 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:43:18 +00:00
Javen O'Neal
e1734cd542 disabled unit tests are now passing for bug 48703
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765544 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:37:47 +00:00
Dominik Stadler
ec7607e398 Fix some IDE warnings/javadoc/...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765538 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 06:52:44 +00:00
Javen O'Neal
eada340cbd make code more similar between default case and indexed case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765536 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 06:44:09 +00:00
Javen O'Neal
09c13eeefa on Windows, a directory cannot contain a file and a directory with the same name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765531 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:18:48 +00:00
Javen O'Neal
55252a9fe9 findbugs: Switch statement found in org.apache.poi.sl.draw.DrawShape.applyTransform(Graphics2D) where default case is missing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765530 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:07:30 +00:00
Javen O'Neal
669e32e551 add data type to UTF_16LE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765529 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:06:49 +00:00
Javen O'Neal
fec5613aff remove java.nio.charset.StandardCharsets which is not available until Java 7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765528 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 05:00:07 +00:00
Tim Allison
17d4d76f4f BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 18:24:39 +00:00
Tim Allison
ef7bbb8fe4 BUG 59858 -- avoid npe when there's a collision of record names...doh. Fix unit test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765482 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 16:54:12 +00:00
Tim Allison
92eb3bbade BUG 59858 -- avoid npe when there's a collision of record names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765479 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 16:43:20 +00:00
Tim Allison
c878e39b55 BUG 59830 -- incorrect reading of unicode stream name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765468 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 15:47:38 +00:00
Tim Allison
db79501e9f BUG 60158 -- AIOOBE in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765433 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 12:55:34 +00:00
Andreas Beeker
bf95861693 Bug 53191 - Problems with line style when converting ppt to png
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765196 13f79535-47bb-0310-9956-ffa450edef68
2016-10-16 22:48:25 +00:00
Dominik Stadler
e3633daac5 Bug 60259: Add missing dispose() call
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765100 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 19:07:04 +00:00
Dominik Stadler
3f5e3d638c Update to japicmp-gradle-plugin:0.1.2 and enable newly added properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765020 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 07:09:13 +00:00
Dominik Stadler
90ef824079 Close temp-file in test to not leak file-handles and fail deleting the file on Windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765019 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 06:54:26 +00:00
Dominik Stadler
37116e84e5 Bug 60029: apply suggested fix and fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765018 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 06:54:20 +00:00
Dominik Stadler
b51eb49e58 Bug 60134: Add initial tasks for running japicmp to the Gradle build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764960 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 20:46:30 +00:00
Tim Allison
7f9f8e9afa add length sanity check for length of embedded OLE10Native (BUG 60256)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764927 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 14:57:29 +00:00
Tim Allison
442815fcc5 add ignored test and triggering document for BUG 60256
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764890 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 13:22:23 +00:00
Nick Burch
b79defb983 Exclude broken hand-crafted test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764887 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 13:03:53 +00:00
Nick Burch
bff698c938 #60255 When creating a XSSF drawing, find the next available document part, even if another type has pinched the next number
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764863 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:44:03 +00:00
Nick Burch
a1800650d9 Test file for #60255
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764859 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:39:16 +00:00
Javen O'Neal
1e5dc11721 bug 56781,60246: fix named range validation to match valid name rules per Excel docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764854 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:11:23 +00:00
Javen O'Neal
999c6499ec bug 60253: add helper functions to make the constructor formula1-overloading code simpler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764831 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 08:09:39 +00:00
Javen O'Neal
ee6b1e741d bug 60253: remove repeated check for ValidationType.ANY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764823 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 07:07:15 +00:00
Javen O'Neal
489f632288 bug 60253: revert XSSFDataValidationConstraint#prettyPrint QUOTE change in r1749129
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764822 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 07:04:27 +00:00
Javen O'Neal
cdd3a4f0df make cached fields transient
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764809 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 05:13:47 +00:00
Mark Murphy
f25343e18f Add Apache license to example file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764807 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 02:42:50 +00:00
Mark Murphy
37f9122633 53009: Problem creating header and footer
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=53009

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764563 13f79535-47bb-0310-9956-ffa450edef68
2016-10-13 01:13:45 +00:00
Andreas Beeker
83bd292fff Bug 60230 - Roundtrip test that encrypts XSSFWorkbook and then decrypts it fails with latest code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764008 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 20:34:35 +00:00
Javen O'Neal
95e8c4b4a2 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763999 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 19:09:26 +00:00
Javen O'Neal
d5c20ccb0d bug 60230: add disabled unit test from PJ Fanning for a roundtrip write/read of an encrypted XSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763998 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 19:03:49 +00:00
Javen O'Neal
c0b2d60d28 bug 60153: java.nio.charset.StandardCharsets is not available until Java 7. Use Charset.forName for Java 6 compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763997 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 18:06:46 +00:00
Javen O'Neal
02b3019f6c bug 60153: patch from PJ Fanning to demonstrate that SXSSFWorkbook SheetDataWriter can write encrypted temporary files to disk and the workbook can be AES encrypted when written to disk for a fully secure disk environment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763969 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 12:58:46 +00:00
Javen O'Neal
db53120ab3 fix findbugs warning BC_VACUOUS_INSTANCEOF from bug 55075
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763965 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 12:15:39 +00:00
Javen O'Neal
370aa27bf2 bug 60228: getCellTypeEnum should not be deprecated until after getCellType returns a CellType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763960 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:59:34 +00:00
Javen O'Neal
63da9f8d19 bug 60153: findbugs OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE close opened streams if an exception is raised while decorating the stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763959 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:51:13 +00:00
Javen O'Neal
45d18d5c45 bug 55075: add missing import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763955 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:26:49 +00:00
Javen O'Neal
6426f4d19e bug 55075: remove wildcard import; previous commit contributed by Frank Ploessel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763951 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:13:06 +00:00