Commit Graph

2698 Commits

Author SHA1 Message Date
Dominik Stadler
c669e2ef67 Adjust handling of ByteBuffer some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761636 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 20:24:54 +00:00
Javen O'Neal
008a26d1bf bug 59705: consolidate bounds checking of column index into a helper method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760986 13f79535-47bb-0310-9956-ffa450edef68
2016-09-16 00:32:40 +00:00
Tim Allison
0784ab530a POI 60140 Prevent unnecessary memory usage -- no need to cache HeapByteBuffer in FileBackedDataSource, thanks to Luis Filipe Nassif for diagnosing this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760816 13f79535-47bb-0310-9956-ffa450edef68
2016-09-15 00:19:52 +00:00
Javen O'Neal
91f2d5680e declare methods throw runtime exceptions for IDE hints
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760784 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 21:32:34 +00:00
Nick Burch
41b0462f50 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760719 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 15:01:57 +00:00
Nick Burch
5fc5680d15 Patches from Patrick Zimmermann from bugs #60130 and #60131 - DGET fix for empty cells and D* coding improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760717 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 14:59:00 +00:00
Javen O'Neal
ed7258906f move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:53:58 +00:00
Javen O'Neal
8842d7bffd move BaseXSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) and HSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) up to BaseFormulaEvaluator class to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760647 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:33:20 +00:00
Javen O'Neal
f71ae8036d bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760641 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 06:42:20 +00:00
Javen O'Neal
b0f814f83f bug 59791: add deprecation warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760639 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 06:22:38 +00:00
Javen O'Neal
9a11b0ffd5 bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760634 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:51:52 +00:00
Javen O'Neal
430ea9abfd bug 58190: add @since annotations to SlideShow.addPicture and findPicture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760633 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:41:40 +00:00
Javen O'Neal
ca78ec2878 bug 58671: add @Removal annotation to deprecated fields
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760632 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:31:48 +00:00
Javen O'Neal
38cd94d676 bug 59264: revert CellStyle#getBorder[Top|Bottom|Left|Right]() to return short and add getBorder[Top|Bottom|Left|Right]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760630 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:22:23 +00:00
Javen O'Neal
292d7ec27c bug 59264: revert getBorder[Top|Bottom|Left|Right|Diagonal]() to return short and add getBorder[Top|Bottom|Left|Right|Diagonal]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760627 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 04:35:45 +00:00
Javen O'Neal
2644cae418 bug 59790: add @Removal annotations to deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760624 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:51:45 +00:00
Javen O'Neal
5d1ae2cbae bug 59833: add @Removal annotation to deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760623 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:33:52 +00:00
Javen O'Neal
6839a52aa3 bug 59837,59833,59264: add @Removal annotations to CellStyle constants for which enums now exist
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760622 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:24:15 +00:00
Javen O'Neal
808996a683 bug 59873: add @Removal annotations for deprecated CreationHelper#createHyperlink(int) and Hyperlink static aliases to HyperlinkType enum values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760621 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:17:51 +00:00
Javen O'Neal
b91b5c5715 bug 59907: add @Removal annotations to AnchorType static aliases in ClientAnchor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760620 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:06:51 +00:00
Javen O'Neal
9ea5915313 bug 59907: add @Removal annotations to deprecated ClientAnchor#setAnchorType(int)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760619 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 02:55:52 +00:00
Javen O'Neal
0977e51818 bug 59907: restore ClientAnchor#setAnchorType(int) that was removed in POI 3.14 beta 1 and broke backwards compatibility without a 2 release deprecation notice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760617 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 02:41:01 +00:00
Javen O'Neal
3c97d9700a change CellValue#getCellType() to return an int instead of an enum for backwards compatibility (source and binary) with POI 3.14. This reverts the behavior introduced in POI 3.15 beta 3 in r1751237.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760607 13f79535-47bb-0310-9956-ffa450edef68
2016-09-13 23:24:56 +00:00
Javen O'Neal
adfd0d7f6c bug 60025: DataFormatter should print booleans as TRUE/FALSE, not true/false
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760219 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 03:37:56 +00:00
Tim Allison
5747e871a1 poi-60044 small typo in last update to BuiltinFormats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760102 13f79535-47bb-0310-9956-ffa450edef68
2016-09-09 18:41:37 +00:00
Javen O'Neal
9665b9859a bug 59791: add @Removal tags to Cell.CELL_TYPE_* constants, deprecated by CellType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757239 13f79535-47bb-0310-9956-ffa450edef68
2016-08-22 18:25:45 +00:00
Javen O'Neal
3f4612ffcb bug 59791: improve Cell.CELL_TYPE_* backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757235 13f79535-47bb-0310-9956-ffa450edef68
2016-08-22 17:57:45 +00:00
Nick Burch
f8bc502028 Whitespace, javadocs and @Overrides for the Logger classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755192 13f79535-47bb-0310-9956-ffa450edef68
2016-08-04 14:23:54 +00:00
Nick Burch
a1f6d9c832 Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:53:43 +00:00
Nick Burch
60b2586c3f Refactor out some of the common FormulaEvaluator logic from HSSF to a base class (XSSF coming shortly)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755070 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:42:04 +00:00
Nick Burch
560ff4004e Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755068 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:15:13 +00:00
Nick Burch
1570d79529 Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755066 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:12:50 +00:00
Javen O'Neal
3c77adf9e8 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754782 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 17:36:06 +00:00
David North
984683ab4b Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59920

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 12:51:24 +00:00
Javen O'Neal
5ddd038640 javadoc fix: incorrect deprecated replacement
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754702 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 05:32:41 +00:00
Mark Murphy
20907fc5b4 revert changes made in r1754691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754700 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 04:21:14 +00:00
Mark Murphy
8c0adfe55f correction to junit bugs in r1754691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 02:53:55 +00:00
Nick Burch
0fe7cd5299 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 00:17:33 +00:00
Mark Murphy
504a26b844 Add new class Cell Style Template and supporting enum for drawing borders
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 23:59:02 +00:00
Dominik Stadler
bbfb783a57 Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:27 +00:00
David North
e5877bd8e0 Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 13:24:00 +00:00
Dominik Stadler
a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
2016-07-24 11:38:50 +00:00
Nick Burch
13a7be6cd2 Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 23:09:07 +00:00
Nick Burch
50519d3c73 Javadoc updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 10:27:27 +00:00
Nick Burch
92a146e4b5 If doing an in-place write, update the properties too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:31:57 +00:00
Nick Burch
d240667115 #57919 HPSF writing better error handling, and start prep for HSLF more write methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:09:33 +00:00
Nick Burch
3fa0449747 #57919 Add in-place and new-File write methods to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:35:51 +00:00
Nick Burch
8e50c77100 Prepare for pushing write() and write(File) to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 18:41:27 +00:00
Nick Burch
4dee08213a Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 12:01:36 +00:00
Nick Burch
dfd3bbee21 Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:14:05 +00:00