Commit Graph

7749 Commits

Author SHA1 Message Date
PJ Fanning
75d1771f49 [bug-62522] include partName in exception message
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835276 13f79535-47bb-0310-9956-ffa450edef68
2018-07-06 19:07:22 +00:00
Dominik Stadler
8e9ccfaacd Regression tests: Add test which triggers reading header/footer of PPTX files so that we include the related CT classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835184 13f79535-47bb-0310-9956-ffa450edef68
2018-07-05 19:54:24 +00:00
Dominik Stadler
a4251b706b Adjust comments and IDE warnings, duplicate code reduction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835183 13f79535-47bb-0310-9956-ffa450edef68
2018-07-05 19:53:52 +00:00
Dominik Stadler
d2c3c7e004 Add a test with a threaded TempFileCreationStrategy, remove duplicated constant.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835182 13f79535-47bb-0310-9956-ffa450edef68
2018-07-05 19:53:44 +00:00
PJ Fanning
4c97e2daa5 try to get CTPhonetic included in poi-ooxml-schemas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835048 13f79535-47bb-0310-9956-ffa450edef68
2018-07-04 11:38:32 +00:00
PJ Fanning
f68e8e2c07 mark constructor as public
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834879 13f79535-47bb-0310-9956-ffa450edef68
2018-07-02 20:01:11 +00:00
PJ Fanning
31674ea13b try to get CTPhoneticRun added to poi-ooxml-schemas jar (referenced in excel-streaming-reader codebase)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834745 13f79535-47bb-0310-9956-ffa450edef68
2018-06-30 14:49:31 +00:00
Andreas Beeker
9b50601458 #62513 - Don't try to parse embedded package relationships
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834729 13f79535-47bb-0310-9956-ffa450edef68
2018-06-30 11:20:23 +00:00
Dominik Stadler
e6157c5b13 Slightly adjust afew tests some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834654 13f79535-47bb-0310-9956-ffa450edef68
2018-06-29 08:13:22 +00:00
Dominik Stadler
88de42971d Somehow the WordToHtml converter now produces slightly more than 6000 chars before the <table element for me
As there is no description why this substring was in the test in the first place I removed it to make
the test less flaky.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834621 13f79535-47bb-0310-9956-ffa450edef68
2018-06-28 15:47:16 +00:00
Dominik Stadler
602b6d451e Gracefully close resources in test if first line in setup causes a problem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834412 13f79535-47bb-0310-9956-ffa450edef68
2018-06-26 10:12:52 +00:00
Andreas Beeker
eb03fc42be #59268 - remove duplicated typeloader in POI and use fixed XmlBeans implementation instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834229 13f79535-47bb-0310-9956-ffa450edef68
2018-06-23 22:56:34 +00:00
Andreas Beeker
e87f0cb68d #59268 - add license header / escape unicode string
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834168 13f79535-47bb-0310-9956-ffa450edef68
2018-06-22 22:24:27 +00:00
Andreas Beeker
18db483a72 #59268 - Work on providing an updated version of XMLBeans
(imported from https://github.com/apache/poi/pull/113)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834165 13f79535-47bb-0310-9956-ffa450edef68
2018-06-22 21:25:00 +00:00
Andreas Beeker
0a999d8cd3 #62451 - Document last printed in the year 27321
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833668 13f79535-47bb-0310-9956-ffa450edef68
2018-06-17 16:59:48 +00:00
Andreas Beeker
de9b2e0481 #60713 - (S)XSSFWorkbook/POIXMLDocument.write(OutputStream) closes the OutputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833566 13f79535-47bb-0310-9956-ffa450edef68
2018-06-14 22:25:26 +00:00
Andreas Beeker
5169036f66 #62452 - Extract configuration while verifying XML signatures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833477 13f79535-47bb-0310-9956-ffa450edef68
2018-06-13 20:06:08 +00:00
PJ Fanning
d101d9100c [bug-62438] remove nullable class (and use java.util.Optional). This closes #111
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833459 13f79535-47bb-0310-9956-ffa450edef68
2018-06-13 12:18:32 +00:00
Dominik Stadler
4c6b940223 Fix some IDE warnings, Javadoc, useless asserts, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833293 13f79535-47bb-0310-9956-ffa450edef68
2018-06-10 18:55:33 +00:00
PJ Fanning
e908117b0b fix some deprecation warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833218 13f79535-47bb-0310-9956-ffa450edef68
2018-06-08 23:15:46 +00:00
Andreas Beeker
3245d7c809 remove obsolete dev classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833217 13f79535-47bb-0310-9956-ffa450edef68
2018-06-08 22:31:39 +00:00
PJ Fanning
74ff20d363 fix some deprecation warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833116 13f79535-47bb-0310-9956-ffa450edef68
2018-06-07 12:01:49 +00:00
PJ Fanning
232bf3a776 fix some javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833106 13f79535-47bb-0310-9956-ffa450edef68
2018-06-07 08:37:28 +00:00
PJ Fanning
726c7b3245 fix some javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833101 13f79535-47bb-0310-9956-ffa450edef68
2018-06-07 07:40:09 +00:00
PJ Fanning
e2195c505f use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833096 13f79535-47bb-0310-9956-ffa450edef68
2018-06-07 06:03:35 +00:00
PJ Fanning
e59255c99d [bug-62435] Rename getAllEmbedds method to getAllEmbeddedParts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833090 13f79535-47bb-0310-9956-ffa450edef68
2018-06-06 22:30:57 +00:00
PJ Fanning
53bb443e64 [bug-62435] Rename getAllEmbedds method to getAllEmbeddedParts (getAllEmbedds is retained but deprecated)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833059 13f79535-47bb-0310-9956-ffa450edef68
2018-06-06 16:51:13 +00:00
PJ Fanning
fd90cb4ea7 fix test class name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833056 13f79535-47bb-0310-9956-ffa450edef68
2018-06-06 16:27:02 +00:00
Andreas Beeker
fc2998c82e javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832978 13f79535-47bb-0310-9956-ffa450edef68
2018-06-05 22:44:18 +00:00
Andreas Beeker
2fb04cf51d #62187 - missing lib reference on integration build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832974 13f79535-47bb-0310-9956-ffa450edef68
2018-06-05 21:22:33 +00:00
Andreas Beeker
d8d076b73a #62187 - Compiling with Java 10 fails with ClassCastException / use commons-compress for zipbomb detection
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832789 13f79535-47bb-0310-9956-ffa450edef68
2018-06-03 22:09:11 +00:00
Andreas Beeker
611c15f412 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832748 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 21:28:06 +00:00
Andreas Beeker
7088a68f1d sonar fixes and
disable closing of outputstream in ZipPackage.saveImpl() - see https://stackoverflow.com/questions/50646538/stream-close-exception-occures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832746 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 20:29:35 +00:00
Andreas Beeker
d09cb8f9d8 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832735 13f79535-47bb-0310-9956-ffa450edef68
2018-06-02 13:01:14 +00:00
Andreas Beeker
6ecad91893 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832719 13f79535-47bb-0310-9956-ffa450edef68
2018-06-01 23:54:19 +00:00
Andreas Beeker
09fa9890a6 #62355 - unsplit packages - 4 - open HPSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832361 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:15:59 +00:00
Andreas Beeker
e2ec4ebe95 #62355 - unsplit packages - 3 - only imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832360 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:13:31 +00:00
Andreas Beeker
1c0834c436 #62355 - unsplit packages - 2 - modified classes (not only imports)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832359 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 22:01:33 +00:00
Andreas Beeker
54f191b613 #62355 - unsplit packages - 1 - moved classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832358 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 21:59:18 +00:00
PJ Fanning
748c8f2583 fix spelling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832357 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 21:34:42 +00:00
PJ Fanning
54c4c5829a [githib-110] rename text segment class. This closes #110
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832354 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 20:59:52 +00:00
PJ Fanning
917dace980 [githib-110] rename text segment class. This closes #110
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832352 13f79535-47bb-0310-9956-ffa450edef68
2018-05-27 20:58:21 +00:00
Andreas Beeker
8c06c5f51a sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832229 13f79535-47bb-0310-9956-ffa450edef68
2018-05-25 10:20:44 +00:00
Andreas Beeker
24020f66af sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832131 13f79535-47bb-0310-9956-ffa450edef68
2018-05-23 22:29:40 +00:00
Andreas Beeker
b144ace936 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832067 13f79535-47bb-0310-9956-ffa450edef68
2018-05-22 22:39:22 +00:00
Andreas Beeker
1d6a1c4072 sonar fixes - null dereference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831992 13f79535-47bb-0310-9956-ffa450edef68
2018-05-21 23:17:57 +00:00
Andreas Beeker
e268b16754 #62393 - Inconsistent slide import behavior depending on Mac OS X Version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831974 13f79535-47bb-0310-9956-ffa450edef68
2018-05-21 14:20:11 +00:00
Andreas Beeker
04bbc80292 #62041 - TestFonts fails on Mac
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831948 13f79535-47bb-0310-9956-ffa450edef68
2018-05-20 22:22:58 +00:00
Andreas Beeker
5c71e10c46 #62051 - Two shapes have the same shapeId within the same slide.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831947 13f79535-47bb-0310-9956-ffa450edef68
2018-05-20 22:00:14 +00:00
Andreas Beeker
0be1b75834 #61633 - Zero width shapes aren't rendered
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831923 13f79535-47bb-0310-9956-ffa450edef68
2018-05-19 21:05:10 +00:00
Andreas Beeker
508e6da4e5 remove test code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831754 13f79535-47bb-0310-9956-ffa450edef68
2018-05-17 05:35:58 +00:00
Andreas Beeker
f35e818fa2 #62037 - SlideNames should not be null but have a default as if accessed by VBA
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831745 13f79535-47bb-0310-9956-ffa450edef68
2018-05-16 21:57:49 +00:00
Andreas Beeker
0e8736dcda #62381 - Fix rendering of AutoShapes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831743 13f79535-47bb-0310-9956-ffa450edef68
2018-05-16 20:30:53 +00:00
Nick Burch
c079795f4e List a few more missing functions as inline-comments, based on definitions from functionMetadata.txt
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831572 13f79535-47bb-0310-9956-ffa450edef68
2018-05-14 14:25:00 +00:00
Greg Woolsey
bf17600457 A few more places I should never have introduced Cell as a parameter, sine CellReference is all that is needed, faster, and allows for undefined cells.
Backward compatible for the few people using it so far, with comments to point to the faster methods.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831203 13f79535-47bb-0310-9956-ffa450edef68
2018-05-08 19:03:52 +00:00
Andreas Beeker
02178bac2b Random test value/file length resulted in occasionally failures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831127 13f79535-47bb-0310-9956-ffa450edef68
2018-05-07 20:50:32 +00:00
Andreas Beeker
5961b640a5 add convenience method for files to FileMagic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830782 13f79535-47bb-0310-9956-ffa450edef68
2018-05-02 18:33:23 +00:00
Andreas Beeker
17fdb3188c add additional exception info to failing IOUtils.toByteArray
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830779 13f79535-47bb-0310-9956-ffa450edef68
2018-05-02 17:29:24 +00:00
Andreas Beeker
066a8a0b42 add license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830725 13f79535-47bb-0310-9956-ffa450edef68
2018-05-02 05:36:15 +00:00
Andreas Beeker
83eb0ca821 Cleanup Biff8EncryptionKey usage and use HPSF constants instead of duplicated strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830705 13f79535-47bb-0310-9956-ffa450edef68
2018-05-01 18:22:00 +00:00
PJ Fanning
32b370fb67 [githib-107] add areas function support. Thanks to Inji Hanbin. This closes #107
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830685 13f79535-47bb-0310-9956-ffa450edef68
2018-05-01 14:47:29 +00:00
Dominik Stadler
8fc6199641 Allow one more add-opens to silence one more warning seen in Java 9/Java 10 currently
Use latest JDK 10 versions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830551 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 11:21:31 +00:00
Andreas Beeker
34c9cffe5d disable ImageIO cache - probably need to set it in every test class or disable it in the beginning of all tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830520 13f79535-47bb-0310-9956-ffa450edef68
2018-04-29 21:12:06 +00:00
Andreas Beeker
e0f7014503 #59893 - Forbid calls to InputStream.available
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830400 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 21:38:19 +00:00
Dominik Stadler
2574fd2d3d Streamline assertion-usage in some tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830296 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 06:15:05 +00:00
Dominik Stadler
ad92fcca9e Fix setting active cell in .xls by populating field_6_refs whenever row/column changes, this fixes bug 61905
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830115 13f79535-47bb-0310-9956-ffa450edef68
2018-04-25 20:14:07 +00:00
Andreas Beeker
2d6380833a Bug 62187 - commit Commons Compress unrelated changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830061 13f79535-47bb-0310-9956-ffa450edef68
2018-04-25 10:03:39 +00:00
Andreas Beeker
6dc8c3034e #61459 - handle slide layouts in extractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829677 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 20:00:46 +00:00
Andreas Beeker
5189313eb4 #61459 - HSLFShape.getShapeName() returns name of shapeType and not the shape name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829656 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 13:45:18 +00:00
Andreas Beeker
ab390ce170 #62319 - Decommission XSLF-/PowerPointExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829653 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 12:52:59 +00:00
Dominik Stadler
bc436fcc3d OOXMLLite: improve progress output: count test-classes, not single test-methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829641 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 09:46:47 +00:00
Dominik Stadler
2d7fdbc4bc Fix unit test broken with previous check-in
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829640 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 09:45:28 +00:00
Andreas Beeker
15de4bf7a9 Nullpointer fix for slideshow extractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829538 13f79535-47bb-0310-9956-ffa450edef68
2018-04-19 13:34:52 +00:00
Dominik Stadler
8632f0c47e Add some unit-tests for setActiveCell(), although bug 61905 reports that Excel still does not read this correctly for HSSF workbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829518 13f79535-47bb-0310-9956-ffa450edef68
2018-04-19 08:37:17 +00:00
Greg Woolsey
edd87f05b7 add some javadoc to warn that stale cached formula cell values may result in incorrect evaluations, and what to do about it (evaluate formula cells before asking the rule if it applies).
Doing it for the user turns out to not be that easy, as the FormulaEvaluator instance in use is not known in this context.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829471 13f79535-47bb-0310-9956-ffa450edef68
2018-04-18 18:25:08 +00:00
Andreas Beeker
4ba2d64a50 Bug 62092 - Text not extracted from grouped text shapes in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829453 13f79535-47bb-0310-9956-ffa450edef68
2018-04-18 15:02:02 +00:00
Dominik Stadler
6829dbd447 Close resources correctly when opening encrypted documents in the TextExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828378 13f79535-47bb-0310-9956-ffa450edef68
2018-04-04 19:41:16 +00:00
Dominik Stadler
e9121036cc Bug 62165: Do not close stream when opening succeeds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828377 13f79535-47bb-0310-9956-ffa450edef68
2018-04-04 19:41:10 +00:00
Dominik Stadler
eb4e20cd69 Try to avoid one NPE that popped up in commoncrawl-corpus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828375 13f79535-47bb-0310-9956-ffa450edef68
2018-04-04 19:40:54 +00:00
PJ Fanning
af19295590 fix error message
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828364 13f79535-47bb-0310-9956-ffa450edef68
2018-04-04 16:55:46 +00:00
PJ Fanning
16d25b62af [bug-62254] update offset function to support optional offset values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828288 13f79535-47bb-0310-9956-ffa450edef68
2018-04-03 21:51:30 +00:00
Dominik Stadler
2ce07693c5 Add unit tests to include more required classes in poi-ooxml-schemas, add test for bug 62174 so additional schema-classes are included
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828180 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:16:16 +00:00
Dominik Stadler
9af2dd7824 OOXMLLite: IDE warnings and add an additional listener to print out progress during running tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828179 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:16:07 +00:00
Dominik Stadler
f440933277 Close resources in tests and in case of Exceptions and use try-with-resources. Close the socket-connection during encrpyting/decrypting as soon as it is not needed any more.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828178 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:16:01 +00:00
Dominik Stadler
48c8b9af81 Update excludes in OOXMLLite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828177 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:15:49 +00:00
Dominik Stadler
2be766f267 Bug 61267: detect Word v2 files and report that they are not supported in Apache POI
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828176 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:15:42 +00:00
PJ Fanning
35fd4f85aa [bug-62216] add test case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828174 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 15:59:21 +00:00
PJ Fanning
0ec274d46e [bug-62216] Fix issue with SXSSF error cells
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828144 13f79535-47bb-0310-9956-ffa450edef68
2018-04-01 16:16:37 +00:00
PJ Fanning
54e533889a [bug-62121] Fixed Power function of negative numbers. Thanks to Bob van den Berge. This closes #104
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828143 13f79535-47bb-0310-9956-ffa450edef68
2018-04-01 15:52:13 +00:00
PJ Fanning
3f19729834 [github-103] take latest changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828142 13f79535-47bb-0310-9956-ffa450edef68
2018-04-01 15:37:14 +00:00
PJ Fanning
6ca71f0bb9 add missing license
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1827177 13f79535-47bb-0310-9956-ffa450edef68
2018-03-19 09:22:46 +00:00
PJ Fanning
aea347d94a [github-103] hsmf: support writing properties. Thanks to Dominik Hölzl. This closes #103
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1827173 13f79535-47bb-0310-9956-ffa450edef68
2018-03-19 09:10:38 +00:00
PJ Fanning
47fb3691f7 [bug-62176] synchronize temp dir creation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1826655 13f79535-47bb-0310-9956-ffa450edef68
2018-03-13 15:12:00 +00:00
Dominik Stadler
fd39985247 Add test for setters/getters of XWPFRun to include morre generated classes in poi-ooxml-schemas.
See also https://github.com/centic9/poi-on-android/issues/31

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1826464 13f79535-47bb-0310-9956-ffa450edef68
2018-03-11 21:11:11 +00:00
Andreas Beeker
58a0a100f5 #62159 - Support XML signature over windows certificate store
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825948 13f79535-47bb-0310-9956-ffa450edef68
2018-03-06 00:07:20 +00:00
Dominik Stadler
ff96f4c64d Reduce testcase some more, add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825851 13f79535-47bb-0310-9956-ffa450edef68
2018-03-05 05:14:56 +00:00
Dominik Stadler
feace0e745 Add unit test which verifies that ThresholdInputStream can be used. This currently fails with Java 10 because the reflection relies on internals of class ZipFile that were changed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825818 13f79535-47bb-0310-9956-ffa450edef68
2018-03-04 13:33:38 +00:00
Dominik Stadler
fb2f23678f Some IntelliJ and Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825817 13f79535-47bb-0310-9956-ffa450edef68
2018-03-04 13:33:31 +00:00
Dominik Stadler
f3addac5e0 Fix compiling with current JDK 10 RC build, OOXML-Tests are still failing due to ThresholdInputStream, though.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825816 13f79535-47bb-0310-9956-ffa450edef68
2018-03-04 13:33:20 +00:00
PJ Fanning
aee50698a4 use xmlunit for xml diffs in unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825810 13f79535-47bb-0310-9956-ffa450edef68
2018-03-04 12:24:44 +00:00
PJ Fanning
3716f4a556 remove some deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825807 13f79535-47bb-0310-9956-ffa450edef68
2018-03-04 11:47:21 +00:00
PJ Fanning
8d4f3fde68 remove some casts to short
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825749 13f79535-47bb-0310-9956-ffa450edef68
2018-03-03 01:48:46 +00:00
PJ Fanning
2688ce9d82 fix license check failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825547 13f79535-47bb-0310-9956-ffa450edef68
2018-02-28 10:30:05 +00:00
PJ Fanning
b7aafa03fb fix problematic javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825542 13f79535-47bb-0310-9956-ffa450edef68
2018-02-28 10:01:52 +00:00
PJ Fanning
dcbe14abd0 remove XDDFChart workaround that saved workbook to temp file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825541 13f79535-47bb-0310-9956-ffa450edef68
2018-02-28 09:54:58 +00:00
PJ Fanning
590f27e86d [github-98] write data in respective Column in case of XDDFChart. Thanks to Sandeep Tiwari. This closes #98
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825521 13f79535-47bb-0310-9956-ffa450edef68
2018-02-27 23:12:53 +00:00
PJ Fanning
daeea27e14 use Integer.toString to convert ints to strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825457 13f79535-47bb-0310-9956-ffa450edef68
2018-02-27 14:24:50 +00:00
PJ Fanning
fef8c69085 tidy up API for font index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825409 13f79535-47bb-0310-9956-ffa450edef68
2018-02-26 20:26:48 +00:00
PJ Fanning
4221ccebda [bug-62055] Fix XSSFImportFromXML table resize. Thanks to Leonard Kappe. This closes #99
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825315 13f79535-47bb-0310-9956-ffa450edef68
2018-02-25 17:06:19 +00:00
Greg Woolsey
d144f09d2f Fix for bug #62130. Turns out there were cases when a workbook with multiple edit/save cycles on the same instance would save stale cell data, resulting in incorrect copies.
Includes new unit test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825277 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 21:30:47 +00:00
Greg Woolsey
9dff7e2f09 The table auto-filter range should not include table footer rows, while the table range does. POI was using the same for both regardless of footers.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825182 13f79535-47bb-0310-9956-ffa450edef68
2018-02-23 23:37:04 +00:00
PJ Fanning
753f6f9dc6 further uptake of int methods for font lookups
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825103 13f79535-47bb-0310-9956-ffa450edef68
2018-02-22 22:32:25 +00:00
PJ Fanning
104d4dac06 [bug-62018] use ints to index fonts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824826 13f79535-47bb-0310-9956-ffa450edef68
2018-02-20 00:25:43 +00:00
PJ Fanning
47c1695a08 add apache license to new examples due to rat check failures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824489 13f79535-47bb-0310-9956-ffa450edef68
2018-02-16 14:08:28 +00:00
Nick Burch
24120f228b Unit test to try to reproduce bug #62108 (currenly works though...)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824451 13f79535-47bb-0310-9956-ffa450edef68
2018-02-16 11:47:24 +00:00
Nick Burch
269ea2617f Add some write/change code as well for Groovy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824378 13f79535-47bb-0310-9956-ffa450edef68
2018-02-15 22:16:07 +00:00
Nick Burch
8417d99ee6 Commit examples from the JVM Languages page
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824371 13f79535-47bb-0310-9956-ffa450edef68
2018-02-15 21:45:47 +00:00
PJ Fanning
51f99aa616 [github-94] Add Range Copier. Thanks to Dragan Jovanović. This closes #94
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824266 13f79535-47bb-0310-9956-ffa450edef68
2018-02-14 20:30:01 +00:00
Dominik Stadler
afc3085684 Fix some IntelliJ warnings in XDGF area
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823988 13f79535-47bb-0310-9956-ffa450edef68
2018-02-12 15:34:11 +00:00
Alain Béarez
2603eccc96 [bug-57369] support for major and minor unit on XDDFChart axes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823963 13f79535-47bb-0310-9956-ffa450edef68
2018-02-12 12:59:38 +00:00
Mark Murphy
0f4c54023e #55953 Added methods to position a table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823920 13f79535-47bb-0310-9956-ffa450edef68
2018-02-12 04:12:06 +00:00
Andreas Beeker
b6fc14300b Update JAXB classes with fixed javadocs for java 8 doclint
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823910 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 22:09:58 +00:00
Mark Murphy
ac7311994a Added missing table border types to XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823904 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 21:31:32 +00:00
Andreas Beeker
11522974cf #61947 - Remove deprecated classes (POI 4.0.0)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823894 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 20:45:38 +00:00
Andreas Beeker
22659beef2 #62096 - Add support for tabstops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823893 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 20:39:18 +00:00
Andreas Beeker
ae65b5cb4a FindBugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823892 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 20:35:11 +00:00
Mark Murphy
32f3b22d08 Add ability to set get and remove outer borders for tables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823873 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 18:43:20 +00:00
Dominik Stadler
316041521c Bug 62042: Adjust gradle build to properly set the locale
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823596 13f79535-47bb-0310-9956-ffa450edef68
2018-02-08 19:34:22 +00:00
Dominik Stadler
d0adab9aee Various smaller adjustments: Remove filename in test, remove unused parameters, fix a few simple typos in JavaDoc and add more JavaDoc and some more tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823595 13f79535-47bb-0310-9956-ffa450edef68
2018-02-08 19:34:16 +00:00
PJ Fanning
ac763a24ad fix further typo in exception message
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822948 13f79535-47bb-0310-9956-ffa450edef68
2018-02-02 11:59:58 +00:00
Dominik Stadler
a487bee768 Fix small typo, closes PR #97 on Github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822937 13f79535-47bb-0310-9956-ffa450edef68
2018-02-02 10:35:48 +00:00
PJ Fanning
940f438eaf fix findbug issues introduced recently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822758 13f79535-47bb-0310-9956-ffa450edef68
2018-01-31 05:52:46 +00:00
PJ Fanning
3f2ae2ee4b fix use of forbidden apis in row shift code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822743 13f79535-47bb-0310-9956-ffa450edef68
2018-01-31 05:31:31 +00:00
PJ Fanning
5afe7c20ab use spaces for indents in some files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822720 13f79535-47bb-0310-9956-ffa450edef68
2018-01-31 00:09:51 +00:00
PJ Fanning
bf20eafa7d [bug-55713] Wrong ErrorStyle for DataValidations. Thanks to Philemon Schucker. This closes #95
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822719 13f79535-47bb-0310-9956-ffa450edef68
2018-01-31 00:00:17 +00:00
PJ Fanning
de2b6ba095 add missing licenses to source code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822641 13f79535-47bb-0310-9956-ffa450edef68
2018-01-30 13:31:16 +00:00
PJ Fanning
25634cf55f [github-81] Formula adjusting in context of column shifting. Thanks to Dragan Jovanović. This closes #81
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822639 13f79535-47bb-0310-9956-ffa450edef68
2018-01-30 13:16:49 +00:00
PJ Fanning
4637ffcbca [bug-62038] add mockito based unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822517 13f79535-47bb-0310-9956-ffa450edef68
2018-01-29 15:21:59 +00:00
PJ Fanning
6dc0f74269 ignore broken test temporarily
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822409 13f79535-47bb-0310-9956-ffa450edef68
2018-01-27 14:18:05 +00:00
PJ Fanning
ee8dc42e36 some changes to allow shared string table to be subclassed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822404 13f79535-47bb-0310-9956-ffa450edef68
2018-01-27 13:30:52 +00:00
PJ Fanning
a6faf34d92 [github-90] change default DSIG algorithm to SHA256. Thanks to Jörn Franke. This closes #90
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822293 13f79535-47bb-0310-9956-ffa450edef68
2018-01-26 13:30:32 +00:00
PJ Fanning
aca52d2a51 bouncycastle 1.59
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822285 13f79535-47bb-0310-9956-ffa450edef68
2018-01-26 12:38:49 +00:00
PJ Fanning
7e434aa155 [bug-62038] handle null font size in XSLFTextRun copy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822253 13f79535-47bb-0310-9956-ffa450edef68
2018-01-26 07:51:57 +00:00
Alain Béarez
a5d2574538 code cleaning according to code review recommendations (closes #93)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822224 13f79535-47bb-0310-9956-ffa450edef68
2018-01-25 19:59:52 +00:00
Tim Allison
db3e8697f7 related to Bug 61991 -- include docx in test suite to trigger inclusion of CTPictureBase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822033 13f79535-47bb-0310-9956-ffa450edef68
2018-01-23 18:05:23 +00:00
PJ Fanning
48a5e63ad7 [Bug 61972] Adding chart in Document of MS-Word File without reading Temp MS-Word File. Thanks to Sandeep Tiwari. This closes #91
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1821764 13f79535-47bb-0310-9956-ffa450edef68
2018-01-20 23:01:18 +00:00
PJ Fanning
d12d1afa23 remove unnecessary test override
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820652 13f79535-47bb-0310-9956-ffa450edef68
2018-01-09 12:23:37 +00:00
Alain Béarez
5f0072983b introduce XDDFShapeProperties as user model API (closes #72 from GitHub)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820369 13f79535-47bb-0310-9956-ffa450edef68
2018-01-06 02:51:53 +00:00
PJ Fanning
d4df69570c [github-86] expose language for Text Runs. Thanks to Geoff Baskwill. This closes #86
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820242 13f79535-47bb-0310-9956-ffa450edef68
2018-01-04 23:32:14 +00:00
Dominik Stadler
859ce548a4 Deprecate methods with typos and provide new ones.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819776 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:39:48 +00:00
Dominik Stadler
6ac8433953 Bug 61937: Add more javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819774 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:39:38 +00:00
Dominik Stadler
214695e09c Bug 61543: do not fail with "part already exists" when tables are created/removed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819773 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:39:33 +00:00
Dominik Stadler
e05a94e8ee Bug 61550: Add more information to exception text and verify that it is thrown
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819772 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:39:26 +00:00
Dominik Stadler
33d5bf0961 Bug 61648: Test Sheet.setArrayFormula for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819770 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:39:15 +00:00
Dominik Stadler
bc4eb140c5 Add test which verifies that bug 61652 is not appearing any more on latest trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819769 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:39:08 +00:00
Dominik Stadler
d4e89724c7 Update some tests and IntelliJ warnings
Ignore disabled test instead of not listing it in the test-report at all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819768 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:38:58 +00:00
PJ Fanning
d10ec59751 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819766 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 13:05:31 +00:00
PJ Fanning
272e33e4a8 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819763 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 12:23:06 +00:00
PJ Fanning
822608f1a6 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819762 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 12:13:53 +00:00
PJ Fanning
ef89809723 Bug-61947 add back deprecated methods (removed by accident)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819761 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:54:01 +00:00
PJ Fanning
0f390dab17 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819759 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:47:53 +00:00
PJ Fanning
186736ce11 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819758 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:42:43 +00:00
Andreas Beeker
95bbbe5678 #61797 - Embed Excel / Ole objects into powerpoint
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819710 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 01:14:08 +00:00
Andreas Beeker
45c73e1741 #61943 - SL Common: narrow generics definition because of tighter java9 checks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819709 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 01:05:59 +00:00
Andreas Beeker
2a18d2d4db #61942 - Refactor PackagePartName handling and add getUnusedPartIndex method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819708 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:56:07 +00:00
Andreas Beeker
2dc2933f9a #61941 - Move Ole marker generation to Ole10Native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819706 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:22:43 +00:00
Andreas Beeker
7d3876cf12 #61940 - Replace ClassID statics with enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819705 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:13:38 +00:00
Andreas Beeker
e262b250d7 #61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819690 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 22:17:55 +00:00
Yegor Kozlov
ca7549131b Bug 58106: when a cell with a 'master' shared formula is removed, the next cell in the range becomes the master
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819623 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 16:34:57 +00:00
Yegor Kozlov
ff6f06cc27 Bugzilla 61116: Formula evaluation fails when using matrix addition within index function call
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819596 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 13:11:56 +00:00
Dominik Stadler
24c2b4fabe Disable test which currently breaks with every little change to the resulting XML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819424 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 13:46:00 +00:00
Dominik Stadler
7a50340cbf Bug 61665: Enhance SSPerformanceTest some more to add a warmup run and allow to run with unsynchronized XmlBeans
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819417 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 10:53:40 +00:00
Dominik Stadler
9eb8fedf5d Fix bug 61787, which was introduced by bug 58067: Change how deleted content is detected to not incorrectly see too much text as deleted.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819405 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:51 +00:00
Dominik Stadler
451c26874a Bug 61798: Fix usage of getLastCellNum(), unfortunately this is a bit misleading compared to getFirstCellNum()...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819404 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:43 +00:00
Dominik Stadler
eb8fac4f77 Bug 61911: Avoid IndexOutOfBounds access when reading pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819403 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:36 +00:00
Dominik Stadler
822188c49a Fix IntelliJ warnings and code formatting, generalize ExcelToHtmlUtils, use try-with-resources, update/enhance JavaDoc somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819402 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:26 +00:00
Greg Woolsey
31ae97e748 Added a couple missing null checks.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819398 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:17:33 +00:00
Greg Woolsey
a7a3293fb9 Implement DMAX and DSUM functions, following the pattern from DMIN.
Refactored the D* function enum to have instances return the function implementation instances rather than using a case construct, now that Java 8 is required.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819376 13f79535-47bb-0310-9956-ffa450edef68
2017-12-27 22:33:03 +00:00
PJ Fanning
50c0ba01c6 Remove misleading SXSSF logging
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819282 13f79535-47bb-0310-9956-ffa450edef68
2017-12-26 11:02:45 +00:00
Yegor Kozlov
64d98e7872 Bug 61869: updating a cell with shared formula produces an unreadable file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818818 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 16:30:13 +00:00
PJ Fanning
12f82dd617 use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818786 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 12:15:35 +00:00
PJ Fanning
7cdaeba856 use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818781 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 11:47:52 +00:00
PJ Fanning
57dcaedde7 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818629 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:33:16 +00:00
PJ Fanning
bfff3c7bd8 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:23:52 +00:00
PJ Fanning
af11cb1023 use non deprecated method for adding string to shared strings table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818623 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 20:54:39 +00:00
Yegor Kozlov
1ccc7bfd46 Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 15:54:50 +00:00
PJ Fanning
9ab4245730 Bug-61906 fix javadoc issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818248 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 09:13:16 +00:00
PJ Fanning
e34387b2cf Bug-61906 add API for working with RichStringText and deprecate API methods that use CTRst
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 09:09:50 +00:00
PJ Fanning
b3e2c19784 Bug-61792 simplify sxssf code that writes chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818223 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 00:54:52 +00:00
Javen O'Neal
525952b625 delete commented out code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817976 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 06:39:01 +00:00
Javen O'Neal
5530f8a831 bug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are not in ascending order in the CTWorksheet; unit test adapted from Luca
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817975 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 06:21:19 +00:00
Nick Burch
8498e4d88c #61765 Another HSSF Workbook name found from (unknown) third party software produced files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817812 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 19:52:53 +00:00
Greg Woolsey
11e60eb77e Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Protect against this in the future by introducing a factory method to create XSSFColor instances from a CTColor instance and the associated workbook style indexed color map.

If the CTColor instance is null, the factory returns null.  All callers already are prepared for a null instance, but many had their own null check on the CTColor object.  This centralizes that.

This also further forces the requirement for the indexed color map.  Any time a color is created, the workbook or styleTable is available in the same context, so passing this is extra parameter is trivial and allows XSSFColor to properly reference custom/themed indexed colors.

Did not remove any methods yet, only deprecated them.  Changed the signature to one internal test-only constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817796 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 17:30:04 +00:00
Andreas Beeker
185a66aed5 remove package name to ease the output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817600 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 12:06:59 +00:00
Andreas Beeker
2c2028ede6 #61881 - handle invalid font names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 11:44:19 +00:00
Greg Woolsey
41981a4ac9 #61841
Add @Override annotations, clean up imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817331 13f79535-47bb-0310-9956-ffa450edef68
2017-12-07 01:54:21 +00:00
Greg Woolsey
cbd17b9320 #61841 fix typo in method name
Fixing the typo pointed out by PJ Fanning, thanks for the proof read!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817325 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 23:53:25 +00:00
Greg Woolsey
94c2b64692 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
always with the missing license...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817254 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:46:42 +00:00
Greg Woolsey
6390202491 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:15:51 +00:00
PJ Fanning
5f4f1b5846 use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 22:31:59 +00:00