Commit Graph

61 Commits

Author SHA1 Message Date
Dominik Stadler
da2b7c0969 Fix some compilation warnings
Update Javadoc
Reformat code somewhat
Supress IntelliJ warnings in findbugs-filters.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776645 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:11:48 +00:00
Javen O'Neal
e7eef4d75a bug 59781: ignore duplicate HSSF PaneInformation, which now shadows the Common SS version. The HSSF version has been deprecated and will be deleted after 2 releases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751081 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 16:29:05 +00:00
Javen O'Neal
84113f3c63 findbugs: fix SF_SWITCH_FALLTHROUGH warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 06:12:35 +00:00
Javen O'Neal
6c5cd8e400 findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:34:02 +00:00
Javen O'Neal
b148307f0f findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:06:47 +00:00
Javen O'Neal
1853126f9b findbugs: fix URF_UNREAD_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:42:59 +00:00
Javen O'Neal
ddfb99fa47 consolidate findbugs filters using Or logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748081 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:09:41 +00:00
Javen O'Neal
55b675a384 fix findbugs issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 03:48:30 +00:00
Andreas Beeker
feead38601 ignore invalid performance issues - e.g. see #57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747947 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 01:18:12 +00:00
Javen O'Neal
249bdf8661 +props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 04:27:21 +00:00
Dominik Stadler
a7df6604a4 Upgrade to FindBugs 3.0.1 and add some findbugs-excludes
Update to forbiddenapi-checker 2.1, use the newly provided rule-sets and remove things that were applied upstream 


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745366 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 14:17:52 +00:00
Dominik Stadler
128a991f9c Findbugs fixes
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:12 +00:00
Andreas Beeker
b3b4ed6564 add other printStackTrace methods to forbidden-apis-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 19:52:16 +00:00
Andreas Beeker
8d033e235c replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 02:20:35 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 09:51:22 +00:00
Dominik Stadler
5a8aceec32 Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68
2015-12-02 21:47:52 +00:00
Andreas Beeker
ee0f9b84e1 close resources
fix a few eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717077 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 15:26:53 +00:00
Uwe Schindler
493a157e6a Fix remaining security manager problems. Forbiddenapis now passes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713915 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 19:11:35 +00:00
Dominik Stadler
db98ec0bd9 Tried to add excelant to forbidden-apis-check, but failed due to issue #82 in forbidden-api-checks tool. List more pathes that we still not include. Add description to custom forbidden-api-checks and add commented out checks for reflectoin as discussed in bug 58597
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713218 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 10:01:48 +00:00
Andreas Beeker
acb219fbe1 fixes sonar/findbugs issues
add Date.toString() to forbidden-apis and fix occurrences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 23:46:57 +00:00
Dustin Spicuzza
3bd2011924 Import poi-visio codebase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709354 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:52:35 +00:00
Andreas Beeker
aaafb0270d Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:19:50 +00:00
Andreas Beeker
f5e9adea84 merged common_sl branch to trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692593 13f79535-47bb-0310-9956-ffa450edef68
2015-07-24 21:47:55 +00:00
Andreas Beeker
652211b8d2 Snapshot commit - still lots of errors, xslf rendering works, started work on hslf
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1667902 13f79535-47bb-0310-9956-ffa450edef68
2015-03-19 23:44:23 +00:00
Andreas Beeker
996c9dd93c initial commit - still lots of errors, but I need to switch to a clean trunk for releasing and testing
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1661322 13f79535-47bb-0310-9956-ffa450edef68
2015-02-21 10:56:03 +00:00
Dominik Stadler
eb44db4d9c Bug 57003: Add implementation of function FIXED
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637361 13f79535-47bb-0310-9956-ffa450edef68
2014-11-07 12:29:05 +00:00
Andreas Beeker
1d84cd9828 Bug 55164 - Support for adding slide notes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635010 13f79535-47bb-0310-9956-ffa450edef68
2014-10-29 00:07:34 +00:00
Andreas Beeker
2cfc8dbf17 FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 23:34:11 +00:00
Andreas Beeker
276b477322 disable not applicable findbugs check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567815 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 00:07:36 +00:00
Yegor Kozlov
e80c3aabc1 Bugzilla 54436: Fixed metadata for GETPIVOTDATA function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1451875 13f79535-47bb-0310-9956-ffa450edef68
2013-03-02 11:38:09 +00:00
Yegor Kozlov
c8f9bde8ee removed svn:executable bit from project files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1212745 13f79535-47bb-0310-9956-ffa450edef68
2011-12-10 08:02:08 +00:00
Yegor Kozlov
8e6eff67fc more progress with XSLF: made some methods publis as suggested on poi-dev, more tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1205902 13f79535-47bb-0310-9956-ffa450edef68
2011-11-24 16:13:42 +00:00
Yegor Kozlov
66b79be517 added missing definition of the upArrow shape, moved support for line decorations to XSLFSimpleShape
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1204477 13f79535-47bb-0310-9956-ffa450edef68
2011-11-21 13:10:14 +00:00
Yegor Kozlov
21b4a0f948 more progress with xlsf: support for gradient and texture fills, backgrounds, improved drawing of preset shapes and many more updates ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1198658 13f79535-47bb-0310-9956-ffa450edef68
2011-11-07 09:12:16 +00:00
Yegor Kozlov
5badcee102 support for preset shape geometries in xslf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1189105 13f79535-47bb-0310-9956-ffa450edef68
2011-10-26 10:10:05 +00:00
Yegor Kozlov
3c6ce72dda initial support for rendering pptx slides into images with a PPTX2PNG command-line utility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1187328 13f79535-47bb-0310-9956-ffa450edef68
2011-10-21 13:17:33 +00:00
Yegor Kozlov
6bf42e8072 initial support for XSLF usermodel API
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1156539 13f79535-47bb-0310-9956-ffa450edef68
2011-08-11 08:38:19 +00:00
Yegor Kozlov
533f3a4f4a moved common formula-related code to org.apache.poi.ss.formula, eliminated dependencies on HSSF, reduced the number of eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1037431 13f79535-47bb-0310-9956-ffa450edef68
2010-11-21 11:52:32 +00:00
Yegor Kozlov
0b9ab8930e included poi-ooxml-schemas and poi-examples in the release cycle, also misc improvements in build.xml: merged scratchpad and main examples, improved cross-module classpath dependencies, removed obsolete targets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@882927 13f79535-47bb-0310-9956-ffa450edef68
2009-11-21 15:30:54 +00:00
Josh Micich
522d5c6892 Changed CRLF to LF in remaining trunk/src files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780878 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 23:21:13 +00:00
Nick Burch
4f047382c2 Resolve the licensing issue around chunks_parse_cmds.tbl, with the newly dual-licensed version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@730438 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 18:20:37 +00:00
Nick Burch
bae464ec10 Implement idea from bug #35583 - Include a version class, org.apache.poi.Version, to allow easy introspection of the POI version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@676221 13f79535-47bb-0310-9956-ffa450edef68
2008-07-12 19:37:17 +00:00
Nick Burch
a7c8dca597 Shuffle the HDGF chunks_parse_cmds.tbl off into resources where it more properly belongs, and correctly update the legal notice file to match
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@674348 13f79535-47bb-0310-9956-ffa450edef68
2008-07-06 21:16:05 +00:00
Josh Micich
a811443b4b Fix for 45060 (and 45041) - Improved token class transformation during formula parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@660828 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 06:19:31 +00:00
Josh Micich
30faafa87e Follow on from bug 44675 - regenerated functionMetadata.txt from new ooo excelfileformat.odt
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658986 13f79535-47bb-0310-9956-ffa450edef68
2008-05-22 03:26:25 +00:00
Josh Micich
609058dea5 Another attempt to fix unicode problems in functionMetadata.txt. Made that file pure ascii.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653892 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 19:48:55 +00:00
Nick Burch
3475425c5f Fix up the functionMetadata.txt stuff to be end-to-end UTF8. Was assuming it before, but breaking on some systems, while now it ought to work fine everywhere
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653831 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 16:38:34 +00:00
Josh Micich
e6fb5e7d7b Bug #44733 - DPRODUCT function should be index 189, not 191
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@643625 13f79535-47bb-0310-9956-ffa450edef68
2008-04-01 22:18:25 +00:00
Josh Micich
c6d7eb5387 patch 44675 - made POI capable of recognising var-args functions. Some related fixes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@641185 13f79535-47bb-0310-9956-ffa450edef68
2008-03-26 07:32:28 +00:00